[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

jasonmolenda added inline comments. Comment at: lldb/test/API/commands/platform/sdk/main.c:4-6 + for (int i = 0; i != 10; ++i) { +sleep(10); + } JDevlieghere wrote: > clayborg wrote: > > You can call pause() which will stop and wait for a signal to be deliv

[Lldb-commits] [PATCH] D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Bien. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92603/new/ https://reviews.llvm.org/D92603 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D92609: [lldb] Use the cpu sub type defines for llvm::MachO

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92609/new/ https://reviews.llvm.org/D92609 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. jasonmolenda requested review of this revision. The plist returned by a DBGShellCommands program (dsymForUUID etc) may include an

[Lldb-commits] [PATCH] D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs

jasonmolenda added a comment. Ah, I forgot to add. I added a test by having an existing corefile test (which loads an x86_64 binary) have a plist that claims it is i386. It's close to the same thing, and results in the same kind of erroring if lldb trusts the arch from the plist. Repository

[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah very cool, I didn't realize we had a new posix_spawn attr setter that could set the cpu subtype. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92712/new/ https://revie

[Lldb-commits] [PATCH] D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cedc44a9233: Ignore DBGArchitecture from dsymForUUID's plist (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92692/new/ https://r

[Lldb-commits] [PATCH] D94320: [debugserver] Various plist changes

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks Jonas, LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94320/new/ https://reviews.llvm.org/D94320 ___

[Lldb-commits] [PATCH] D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. It can be tricky to find the important error messages when debugserver tries to launch or attach to a process in the system console log.

[Lldb-commits] [PATCH] D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedde2eb1d209: Add unconditional logging to debugserver for launch/attach processes (authored by jasonmolenda). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda created this revision. jasonmolenda added a reviewer: labath. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. debugserver doesn't support the g packet. I don't understand how this test runs in the first pla

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda added a comment. Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94754/new/ https://reviews.llvm.org/D94754 ___

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda updated this revision to Diff 316880. jasonmolenda added a comment. Ah, Pavel's change was correct to run the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94754/new/ https://reviews.llvm.org/D94754 Files: lldb/test/API/

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG10ac9b29a4ca: Skip 'g' packet tests when running on darwin; debugserver doesn't impl (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D95110: [lldb] Upstream eCore_arm_arm64e enum value

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95110/new/ https://reviews.llvm.org/D95110 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. Are the bots all running macOS Big Sur (macOS 11)? The `-target` command line arguments in the Makefile might not work if the test is run on an older versio

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

jasonmolenda accepted this revision. jasonmolenda added a comment. Yep, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95922/new/ https://reviews.llvm.org/D95922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, labath. jasonmolenda added a project: LLDB. Herald added subscribers: danielkiss, kristof.beyls. I found this on an AAarch64 target, where we use a frame pointer register on Darwin. UnwindAssemblyInstEmulation iterates o

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda added a comment. In D78077#1980116 , @clayborg wrote: > If you test worked, then there is something wrong with this test? See inline > comment for copy and paste error Thanks for catching that. The test definitely fails without the patch,

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda updated this revision to Diff 257557. jasonmolenda added a comment. Update to address mistake Greg identified; also remove two unused variables that were in this method before my changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1cd92e480c12: Bug where insn-based unwind plans on arm64 could be wrong (authored by jasonmolenda). Repository: rG LLVM

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda created this revision. jasonmolenda added reviewers: labath, clayborg. jasonmolenda added a project: LLDB. I've been experimenting with returning richer error messages in debugserver recently, and I found a bug the other day where qLaunchSuccess returns its error code with an "E" fo

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. In D79614#2027861 , @clayborg wrote: > Why not just fix qLaunchSuccess by passing the string through a > "escape_string(...)" function? Any packet that can return a string with > unknown content should be escaped correctly.

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. In D79614#2027861 , @clayborg wrote: > Why not just fix qLaunchSuccess by passing the string through a > "escape_string(...)" function? Any packet that can return a string with > unknown content should be escaped correctly.

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. In D79614#2028295 , @clayborg wrote: > In D79614#2027869 , @jasonmolenda > wrote: > > > In D79614#2027861 , @clayborg > > wrote: > > > > > Why

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. Thanks for the feedback. In D79614#2029157 , @labath wrote: > I think that "piggy-backing" on the `qSupported` packet for communicating > protocol fixes is a good idea. However, I agree with Greg, that it does not > seem li

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8b783b1ab4: Quote error string from qLaunchSuccess (authored by jasonmolenda). Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jasonmolenda added a comment. I skimmed it, I guess the one question that comes to mind is how this will behave if we an operating system thread provider plugin active, where it may not actually list all of the threads that exist -- where we try to be tolerant of threads disappearing and then r

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

jasonmolenda added a comment. Nice cleanup of a long standing undefined behavior warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/ https://reviews.llvm.org/D80955 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jasonmolenda added a comment. Hi Jan, I noticed our sanitizer bot started getting failures in Failing Tests (3): lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63 lldb-shell :: SymbolFile/DWARF/D

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & P_TRANSLATED) as a boolean, but that's a style pref as much as anything. CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82493/new/ https://reviews.llvm.org/D82493 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jasonmolenda added a comment. Hi Pavel, sorry I've been doing a bunch of random things today and haven't really had a chance to look at this yet. eh_frame is so problematic for lldb, we never know what we're getting. I keep thinking we should take over a few augmentation string characters so t

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jasonmolenda accepted this revision. jasonmolenda added a comment. Sorry yes this patch is fine. To be honest, on x86_64 at least, as you've pointed out, maybe we should just live on eh_frame completely without going through any of these augmentation checks at all. AFAIK gdb is living off of

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay, this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82616/new/ https://reviews.llvm.org/D82616 ___

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. The rewrite of the ObjectFileMachO parts is very nice. LGTM. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:462 + +typedef unsigned char uuid_t[16]

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda updated this revision to Diff 230129. jasonmolenda added a reviewer: labath. jasonmolenda added a comment. Updated GDBRemoteRegisterContext::ReadRegisterBytes to only mark registers as valid if the full contents for the register are included in the g packet. Updated gdbclientutils.

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Thanks for looking this over Pavel. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215 +struct RegisterInfo *reginfo = m_reg_info.GetRegisterInfoAtIndex(i

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24ed3a05198: Handle the case where the 'g' packet doesn't get all regs. lldb would silently… (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D70417?vs=230129&id=230334#toc

[Lldb-commits] [PATCH] D70574: [lldb-server] Verify 'g' is supported before relying on them

jasonmolenda added a comment. Hi, sorry I haven't had time to get back to this one. I wanted to look into the m_avoid_g_packets ivar in GDBRemoteCommunicationClient and GDBRemoteCommunicationClient::AvoidGPackets. It looks like it was written to specifically avoid the g packet with arm64 devi

[Lldb-commits] [PATCH] D70906: [lldb] Move register info "augmentation" from gdb-remote into ABI

jasonmolenda accepted this revision. jasonmolenda added a comment. Good change, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70906/new/ https://reviews.llvm.org/D70906 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

jasonmolenda added a comment. I don't want to add noise to this, but there's a related change that I'd like to upstream soon -- ARMv8.3 pointer authentication bits in addresses. With the ARMv8.3 ISA, higher bits that aren't used for addressing can be used to sign & authenticate pointers that a

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jasonmolenda added a comment. In D63540#1766693 , @omjavaid wrote: > Hi Jan, > > I have done further investigation on this with new ampere arm server. This > problem manifests itself on all kind of Debian flavors and is not related to > underlying librar

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks for the ping, yes this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 ___

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9 +frame info +# CHECK: frame #0: {{.*}}_ZN1CC2Eiii +c Is this mangled name going to be the same on windows? Rep

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, jingham. Herald added a project: LLDB. On macOS lldb has an option that can be added to SBLaunchInfo to create a new Terminal window and run the inferior in that new window. lldb uses some AppleScript to open the new wi

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda marked 3 inline comments as done. jasonmolenda added a comment. Thanks for the review Greg. To really do this reliably, we probably either need to use a different kernel API, or push this down into debugserver where we can get the process' task port and inspect what its status is.

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda added a comment. In D72813#1825006 , @clayborg wrote: > ok if this works for now that is fine. Just close the socket_fd when we fail > to write the pid to the socket and this is good to go. I mark it as close-on-exec so we don't need to clo

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda abandoned this revision. jasonmolenda added a comment. Taking a different approach to fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72813/new/ https://reviews.llvm.org/D72813

[Lldb-commits] [PATCH] D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: mgorny. darwin-debug is used to launch a binary while setting the current working directory/env vars/architecture, exec'ing it stopped so lldb can attach to i

[Lldb-commits] [PATCH] D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep, looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72971/new/ https://reviews.llvm.org/D72971

[Lldb-commits] [PATCH] D69524: [debugserver] Delete macOS/PPC debug server implementation

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, sorry yes, the initial debugserver implementation was written back when macOS ppc was still a thing (although on its way out) - but the time the switch happened to lldb, we'd d

[Lldb-commits] [PATCH] D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG83a131b27642: Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions (authored by jasonmolenda). Change

[Lldb-commits] [PATCH] D72985: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay, looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72985/new/ https://reviews.llvm.org/D72985 __

[Lldb-commits] [PATCH] D72981: [debugserver] Unify the breakpoint/watchpoint interface (NFCI)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72981/new/ https://reviews.llvm.org/D72981 _

[Lldb-commits] [PATCH] D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks like a good change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73401/new/ https://reviews.llvm.org/D73401 ___

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

jasonmolenda added a comment. Looks good, for the --shlib option I would get rid of the "full path or base name" language and just say "name", my two cents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 _

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

jasonmolenda added a comment. I don't know about checking for NO_XPC_SERVICES for these -- they're LaunchServices/AppleScript related. As Vedant mentioned with the earlier check, I think `TARGET_OS_EMBEDDED` rather than an architecture check would be the most correct change; these services are

[Lldb-commits] [PATCH] D74001: Fix after c25938d

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks great to me, thanks! If it's easy to add on, could you remove the xfail from lldb/packages/Python/lldbsuite/test/commands/add-dsym/uuid/TestAddDsymCommand.py in the sa

<    5   6   7   8   9   10