jasonmolenda added a comment.

In D79614#2027861 <https://reviews.llvm.org/D79614#2027861>, @clayborg wrote:

> Why not just fix qLaunchSuccess by passing the string through a 
> "escape_string(...)" function? Any packet that can return a string with 
> unknown content should be escaped correctly. Adding a new packet doesn't 
> really fix the problem in older debugserver/lldb-server binaries anyway.


tbh I think the more interesting aspect of the patch - the part worth 
discussing - is using a keyword to qSupported to test for / enable fixes in 
debugserver/lldb-server implementation, so lldb can interoperate with both 
fixed & broken remote agents, until we can safely excise the support for the 
buggy behavior in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79614/new/

https://reviews.llvm.org/D79614



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to