[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6bac2cd81d: Fix off-by-one error in armv7 mach-o corefile register context (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149224

[Lldb-commits] [PATCH] D149284: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thank you for cleaning this one up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284/new/ https://reviews.llvm.org/D149284

[Lldb-commits] [PATCH] D149040: Refactor and generalize debugserver code for setting hardware watchpoints on AArch64

jasonmolenda added a comment. Thanks for all the helpful comments, I'll update the patch. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:833-835 +std::vector +DNBArchMachARM64::AlignRequestedWatchpoint(nub_addr_t user_addr, +

[Lldb-commits] [PATCH] D149040: Refactor and generalize debugserver code for setting hardware watchpoints on AArch64

jasonmolenda marked 7 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:833-835 +std::vector +DNBArchMachARM64::AlignRequestedWatchpoint(nub_addr_t user_addr, +

[Lldb-commits] [PATCH] D149040: Refactor and generalize debugserver code for setting hardware watchpoints on AArch64

jasonmolenda updated this revision to Diff 518101. jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Update patch to incorporate Jonas' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149040/new/ https://reviews.l

[Lldb-commits] [PATCH] D149040: Refactor and generalize debugserver code for setting hardware watchpoints on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG5679379cc7df: Refactor and generalize AArch64 watchpoint support in debugserver (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. AArch64 supp

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On an AArch

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fac08ff1dcd: Recognize `addressing_bits` kv in stop reply packet (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149803/new/ http

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

jasonmolenda updated this revision to Diff 519629. jasonmolenda added a comment. Update patch with Dan and Jonas' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149792/new/ https://reviews.llvm.org/D149792 Files: lldb/test/API/functiona

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e16e41b28b1: Add AArch64 MASK watchpoint support in debugserver (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. debugserver has a memory

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda added a comment. Thanks for the feedback. Testing now & will update the patch in a bit. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:930-931 +if (!image_infos[i].is_valid_mach_header) { + image_infos_array_sp->AddItem(image_info_dict_sp

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520545. jasonmolenda added a comment. Update to address Alex's comments, fix the testsuite failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520546. jasonmolenda added a comment. Update the patch to stop checking for the `mod_date` key in the JSON reply for each binary. This value is always zero with dyld for the past five+ years. It increases the size of the packet unnecessarily, but lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93f91148ae: Add a new report_load_commands option to jGetLoadedDynamicLibrariesInfos (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D150158?vs=520546&id=520578#toc Repo

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520580. jasonmolenda added a comment. Updating to reflect what I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb/docs/lldb-gdb-remote.tx

[Lldb-commits] [PATCH] D150239: ObjectFileMachO: Prioritize the TEXT segment as the mach header segment, regardless of the order the segments appear in the file

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. `ObjectFileMachO::GetMachHe

[Lldb-commits] [PATCH] D150239: ObjectFileMachO: Prioritize the TEXT segment as the mach header segment, regardless of the order the segments appear in the file

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9759d0cb6dc: Prioritize using a segment with the name TEXT instead off fileoff 0 (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The darwin kernel debuggi

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda added a comment. Ah, makes sense, will update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda updated this revision to Diff 522813. jasonmolenda added a comment. Update patch to use a std::once operation instead of hand-rolling it, as suggested by Jonas and Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https:

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3227e74e3bf: lldb PlatformDarwinKernel make local filesystem scan lazy (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I had two bugs wi

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. I spent some time trying to see if there was a clear reason for the duplicated code; it was added in `llvm-svn: 193380` in 2013 and they were very clearly i

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

jasonmolenda added a comment. Thanks for the review comments, really helpful. I've also added a new block to `DynamicLoader::LoadBinaryWithUUIDAndAddress` to make the binary search system: (1) `Target::GetOrCreateModule` (lldb already has it), (2) `Symbols::LocateExecutableObjectFile` / `Symbo

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

jasonmolenda created this revision. jasonmolenda added reviewers: DavidSpickett, JDevlieghere, jingham, omjavaid. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lld

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

jasonmolenda updated this revision to Diff 525910. jasonmolenda added a comment. Updating the patch to incorporate Alex's feedback, and a little further refinement with testing. I am still doing final testing now, and mostly interested in how to create a mach-o corefile that would trigger the f

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

jasonmolenda added a comment. In D151366#4375959 , @antmo wrote: > Hi @mib, > I think this broke lldb-arm-ubuntu bot (LocalVariableWatchpointDisabler.test > failure): https://lab.llvm.org/buildbot/#/builders/17/builds/38136 > Also visible on lldb-aarch64

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rG48a12ae8212c: Fix a few bugs with Mach-O corefile loading, plus perf (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150928/new/ h

[Lldb-commits] [PATCH] D151861: Don't emit a bunch of spurious "Unknown platform 0" warnings from debugserver

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Ah good catch, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151861/new/ https://re

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

jasonmolenda updated this revision to Diff 527251. jasonmolenda added a comment. Updated patch with Alex and Jonas' feedback incorporated. Most significantly, instead of making target.process.virtual-addressable-bits an array of uint values (between zero to two of them), I am leaving virtual-ad

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rG21dfaf60a763: Setting to control addressable bits in high memory (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151292/new/ https

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber:

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4419197 , @bulbazord wrote: > I noticed you're pulling a lot of raw pointers out of shared pointers. Is > there a particular reason you're doing that? `operator bool` on > `std::shared_ptr` returns true if the he

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Right now to clear un

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda updated this revision to Diff 531092. jasonmolenda added a comment. Address Alex's feedback of not extracting the ABI pointer out of the shared pointer; simply use the shared pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15286

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4420223 , @DavidSpickett wrote: > I'm curious how you would end up with a signed PC value, but given this is > unwind it could be a value from a previous frame that was signed when stored > to the stack. The da

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/include/lldb/Target/RegisterFlags.h:96 + /// Produce a text table showing the layout of all the fields. Unamed/padding + /// fields wil

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Putting this in `register info` is good, it's not too easily discoverable (to be honest I didn't know this command existed today), but as you say, the number of people who w

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/ https://reviews.llvm.org/D152916

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d9f88f19a1: Add Fix*Address methods to Process, call into ABI (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152863/new/ https:

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce7037b5edd: Clear non-addressable bits from pc/fp/sp in unwinds (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/ http

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah that's an unintended bottleneck. If you're debugging to debugserver on a darwin system, it will tell lldb it uses a 128k max packet size, so larger read requests are still be

[Lldb-commits] [PATCH] D153079: Add an llvm::report_fatal_error for when the darwin kernel says we've finished an insn-step but the thread doesn't think it was insn-stepping

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We have some failures on an arm6

[Lldb-commits] [PATCH] D153079: Add an llvm::report_fatal_error for when the darwin kernel says we've finished an insn-step but the thread doesn't think it was insn-stepping

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a8e2538afc1: Add a fatal error for debug builds when disagreement about stepping (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I can see why the existing code is written as it is, given the dwarf spec for DW_CFA_restore: "The DW_CFA_restore instruction takes a single operand (encoded with the opcode) that

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

jasonmolenda added a comment. It seems like this patch is really avoiding the sign extension of an int8_t to int32_t in the process of being passed to printf. By casting it to unsigned we've avoided the sign extension and getting the correct result, but it seems like you could have used a prin

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectSource.cpp:1208 + : CommandObjectParsed(interpreter, "source cache dump", +"Du

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. You might want to mention why it isn't sustainable -- because we must allocate memory in the inferior process, and some inferior processes have quite small memory limits.

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. EnumerateDirectory gets the vfs::Status of each file entry, to

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c1108f44342: FileSystem::EnumerateDirectory should skip entries w/o Status, not halt (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D153822?vs=534792&id=534800#toc Repos

[Lldb-commits] [PATCH] D154037: Recognize BSS-only DATA segments as sections that need to be slid/loaded at addresses

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. ObjectFileMachO::SetLoadAddress() takes a slide or base load ad

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, sorry for not getting back to this one! Nice job coming up with a test. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

jasonmolenda created this revision. jasonmolenda added a reviewer: mib. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When debugging possible issues

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

jasonmolenda added inline comments. Comment at: lldb/source/Target/SectionLoadList.cpp:265-266 ++pos) { -s.Printf("addr = 0x%16.16" PRIx64 ", section = %p: ", pos->first, - static_cast(pos->second.get())); pos->second->Dump(s.AsRawOstream(), s.GetInde

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

This revision was automatically updated to reflect the committed changes. Closed by commit rGad451146e8f5: Add 'target dump section-load-list' for lldb debugging (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D154169?vs=536049&id=536057#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D154037: Recognize BSS-only DATA segments as sections that need to be slid/loaded at addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rG623e8455919a: Recognize BSS-only DATA segments as sections that need to be slid (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

jasonmolenda added a comment. This looks like a good change to me. I don't have any comments over Alex's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/ https://reviews.llvm.org/D154268 __

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. this looks good to me. I'm a little overly paranoid about specifying when things are file addresses versus load addresses -- I'm sure that anyone working in this context would kno

[Lldb-commits] [PATCH] D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test

jasonmolenda added a comment. Interesting, libc.so must have stripped the names of non-externally-visible functions, and libc_start_main calls one of them which calls main in turn. This change to the test case looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

jasonmolenda added a comment. Interesting. I remember reading in the recent arm arm docs about how there may be false watchpoint notifications when a processor is in SVE Streaming Mode and a write happens near a watchpoint, but I didn't realize that could happen outside of that context. I'm w

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

jasonmolenda added a comment. I have to agree with David, I don't see how the old code could overflow if DW_OP_deref_size's maximum size is the pointer size in the target, and we are reading it in to an 8-byte buffer, unless the target had addresses larger than 8 bytes, or the dwarf was malform

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 536492. jasonmolenda added a comment. Update patch to address Jim and Jonas' feedback, most importantly report a warning if we can't read one of the mach-o binary addresses that dyld is telling us are being added/removed. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

This revision was automatically updated to reflect the committed changes. Closed by commit rG624813a4f41c: Change the dyld notification function that lldb puts a breakpoint in (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/ https://reviews.llvm.org/D154386 __

[Lldb-commits] [PATCH] D108888: Improve error messaging on process connect errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3472ad5c5f8: Add specific error messages around gdb RSP handshake

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added a comment. This is much more comprehensive than what I was thinking of, nicely done. The mapping of the Exception Class in the esr reg to a name is AArch64 specific, not Apple specific, isn't it? I haven't looked in the ARM ARM, but I suspect it's just the specific names yo

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp:112 + auto exception_class = + static_cast(esr_val >> 26); + if (exception_class != shafik wrote: > Does `26` have a meaning? I

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp:112 + auto exception_class = + static_cast(esr_val >> 26); + if (exception_class != vsk wrote: > jasonmolenda wrote: > > shafik

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added a comment. very nice. Comment at: lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py:19 +@skipUnlessDarwin +@skipIf(archs=['i386','x86_64']) # exception codes not yet supported for Intel macs +def test(self): -

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah, on macOS we'll always have a UUID so this is a good change. The only time an arch is really important is if we don't have a UUID and we have a universal binary (aka fat file

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

jasonmolenda added a comment. In D110013#3013733 , @aprantl wrote: > Without having dug into this deeper, do you think not specifying the arch > could cause any problems with universal binaries? I guess not, because we > still have the UUID, and the UUI

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jasonmolenda created this revision. jasonmolenda added a reviewer: tatyana-krasnukha. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, GorNishanov. jasonmolenda requested review of this revision. Part of Tatyana's patch in https://reviews.llvm.org/D92164 added a stack of

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jasonmolenda added a comment. Another possible approach would be to allow an ExecutionContext with a nullptr Target to push on to the stack, but then in CommandInterpeter::GetExecutionContext skip over those until we find one with a Target, or fall back to the Debugger::GetSelectedExecutionCont

[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

jasonmolenda added a comment. I'm fine with the change, it's true it's inconsistent but I also hate how we don't prefix base16 numbers in gdb RSP - so many bugs and mistakes are introduced because of it. So I'm always trying to sneak in some 0x prefixes when no one is looking. A fun one I saw

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay in looking at this one. Yes, we usually put a new debugserver on devices every year, and we don't need to support devices this old any more, this is fine to re

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep, looks good, we can't hardcode the OS in this triple, we might be getting iOS or macOS binaries and should accept any OS these days. CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice cleanup of this table that's been growing over the years. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113155/new/ https://reviews.llvm.org/D113155

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Ted, sorry for not getting back to you earlier on this, yes this looks unintentional to me and I think this change is good. Nice test case. Thanks for the ping. Repository:

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113598/new/ https://reviews.llvm.org/D113598 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. jasonmolenda requested review of this revision. The DynamicLoader plugin for macOS needs to identify which binary is the dynamic loader (dyld,

[Lldb-commits] [PATCH] D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos

This revision was automatically updated to reflect the committed changes. Closed by commit rGfddafa110d86: Simplify logic to identify dyld_sim in Simulator debugging on macos (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda added a comment. `Process::ReadModuleFromMemory()` takes a FileSpec and header address in memory (and a size to read, default 512 bytes). It calls through `Module::GetMemoryObjectFile`. That reads the 512 bytes of memory into a buffer and calls `ObjectFile::FindPlugin` class meth

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda accepted this revision. jasonmolenda added a comment. In D132433#3747948 , @jasonmolenda wrote: > `Process::ReadModuleFromMemory()` takes a FileSpec and header address in > memory (and a size to read, default 512 bytes). It calls through

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132710/new/ https://reviews.llvm.org/D132710 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132973/new/ https://reviews.llvm.org/D132973 ___ lldb-commits mai

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In an internal devel

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Thanks Jim! Really helpful feedback and questions. Comment at: lldb/source/Core/DynamicLoader.cpp:191 ModuleSP module_sp; PlatformSP platform_sp = process->GetTarget().GetPlatform(); Target &

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 458970. jasonmolenda added a comment. Update the patch to address Jim's comments/suggestions. Biggest change was to clean up how DynamicLoaderDarwinKernel filters out any kernels in the Target that don't match the UUID of the actually running kernel.

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459094. jasonmolenda added a comment. Update patch to include more surrounding context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/ https://reviews.llvm.org/D133534 Files: lldb/include/lld

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 8 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +lldb::addr_t addr

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459191. jasonmolenda marked 5 inline comments as done. jasonmolenda added a comment. Update patch to incorporate Jonas & Pavel's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/ https://

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 2 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 + addr_t input_addr) { + Status error; + WritableDataBufferSP header_data(ne

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

This revision was automatically updated to reflect the committed changes. jasonmolenda marked an inline comment as done. Closed by commit rG1a608cfb5ca8: Recognize a platform binary in ProcessGDBRemote which determines plugins (authored by jasonmolenda). Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset thakis wrote: > This causes a dependency cycle: > > //lld

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > thakis wrote: > > This causes a depend

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a reviewer: ributzka. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This builds on the w

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

jasonmolenda updated this revision to Diff 459400. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https://reviews.llvm.org/D133680 Files: lldb/include/lldb/Target/DynamicLoader.h lldb/source/Core/DynamicLoader.cpp lldb/source/Plugin

<    1   2   3   4   5   6   7   8   9   10   >