jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/source/Commands/CommandObjectSource.cpp:1208
+ : CommandObjectParsed(interpreter, "source cache dump",
+ "Dump the state of the source code cache.\n"
+ "Intended to be used for debugging LLDB itself.",
----------------
Do you want to split this across two lines? I don't think there should be a
newline here.
================
Comment at: lldb/source/Commands/CommandObjectSource.cpp:1227
+ : CommandObjectParsed(interpreter, "source cache clear",
+ "Clear the source code cache.\n", nullptr) {}
+
----------------
I don't think the newline is necessary/should be here.
================
Comment at: lldb/source/Commands/CommandObjectSource.cpp:1266
: CommandObjectMultiword(interpreter, "source",
"Commands for examining "
"source code described by "
----------------
Maybe we can make this less accurate and easier to understand. like "Commands
for examining source files in the current process".
================
Comment at: lldb/source/Core/SourceManager.cpp:738
+ FileSP file = entry.second;
+ stream.Format("{0:%Y-%m-%d %H:%M:%S} {1,8:d} {2}\n", file->GetTimestamp(),
+ file->GetNumLines(), entry.first.GetPath());
----------------
m/d/Y would be dope tho
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153685/new/
https://reviews.llvm.org/D153685
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
