[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil marked 5 inline comments as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf-sleb128.s:6 +# RUN: llvm-mc -g -dwarf-version=5 -triple x86_64-unknown-linux-gnu %s -filetype=obj > %t.o +# RUN: ld.lld -m elf_x86_64 %t.o -o %

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

This revision was automatically updated to reflect the committed changes. Closed by commit rG476f520a0bd2: [lldb] Fix SLEB128 decoding (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D81119?vs=268489&id=268535#toc Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil added a comment. In D81119#2074954 , @jasonmolenda wrote: > lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63 > lldb-shell :: SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s That should be fixed by rG846909e2a

[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc

jankratochvil created this revision. jankratochvil added reviewers: labath, dblaikie, vsk. jankratochvil added a project: LLDB. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. D80519 added support for `DW_TAG_GNU_call_site` but Bug 45886

[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc

jankratochvil planned changes to this revision. jankratochvil added a comment. It regressed other testcases, I have to check it more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81334/new/ https://reviews.llvm.org/D81334 __

[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc

jankratochvil updated this revision to Diff 269030. jankratochvil added a comment. The new -1 value for `GetAttributes` is a bit ugly. But otherwise either - `CollectCallEdges` would need to reimplement `GetAttributes`. or - trying to guess which attribute belongs to which DIE from `DIEOffsetAt

[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil updated this revision to Diff 269047. jankratochvil retitled this revision from "[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc" to "[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC". jankratochvil added a comment. # This tests that lldb is compatible with DWARF-4 en

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. jankratochvil added a child revision: D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC. There is Labath's comment

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil updated this revision to Diff 269328. jankratochvil retitled this revision from "[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC" to "2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h:113 - size_t GetAttributes(DWARFAttributes &attributes, uint32_t depth = 0) const; + size_t GetAttributes(DWARFAttributes &attr

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil marked 5 inline comments as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_GNU_call_site-DW_AT_low_pc.s:46 + callb +int3 + ret labath wrote: > This is formatted strangely. Tab

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG4515d35f5c9e: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:733 DWARFAttributes attributes; - GetAttributes(cu, attributes); + GetAttributes(cu, attributes, 0 /* curr_depth */);

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGfd31e60b8ded: [nfc] [lldb] Reduce GetAttributes's depth parameter usage (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D81

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. I would separate/remove all [nfc] changes from this patch as they complicate it a bit. Such cleaned up patch I have prepared for myself: https://people.redhat.com/jkratoch/D74136-cleanup.patch Then also did you notice there is a regression for (I do not know why):

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:732 +FileSpec cu_spec; +if (sym_ctx.comp_unit) { + cu_spec = sym_ctx.comp_unit->GetPrimaryFile(); kwk wrote: > jankrato

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. I do not like much this approach but it fixes this case. I would prefer checking `DW_AT_producer` together with `-grecord-gcc-switches`. I was trying GCC and clang and all the IMO relevant options and I can get either no `.eh_frame`/`.debug_frame` or an asynchronou

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. In D82378#2109330 , @labath wrote: > Now this situation is not actually handled by lldb's "augmenter", so the > example somewhat shaky, but it does show that there are gaps in clang/llvm > modelling of unwind info. Good t

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. I do not understand why the testcase has **two** epilogues. The `UnwindAssembly_x86::AugmentUnwindPlanFromCallSite()` code tests only beginning and end of CFI, it does not read anything in between. The simplified testcase works the same for me: https://people.red

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. In D82378#2111675 , @labath wrote: > It's not related, at least not directly. My goal was to prove `UnwindAssembly_x86::AugmentUnwindPla

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. Just some notes of mine to find out which functions get used in which breakpoint case: -o 'breakpoint set -f main.c -l 1' -o q -o 'b main.c:1' lldb/source/Commands/CommandObjectBreakpoint.cpp:578 = eSetTypeFileAndLine lldb/source/Target/Target.cpp:330

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:722 + return false; + } + jankratochvil wrote: > This `IsSourceImplementationFile()` should be checking the filename requested > by user, not filename found in DWARF. It sho

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:323 + // passing. + remove_it = false; + } Now `if (filter_by_function) {}` always overrides any result from `if (filter_by_cu)`. So it woul

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:829 + m_target_sp->GetInlineStrategy() == eInlineBreakpointsHeaders) +return flags | eSymbolContextCompUnit; + return flags; `filter_by_function` now fully overrides `fil

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. The filename should not be checked from `SymbolContext::function` but rather from `SymbolContext::line_entry`. As that is cheaper. And when one asks for breakpoint at `1a.h:1` then it is enough to check `.debug_line` (which needs to be checked anyway) and why to

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. In D74136#2119549 , @labath wrote: > At this point I'm getting very lost in this patch, Me too, as you stated: In D74136#2020245 , @labath wrote: > In D74136#1983467

[Lldb-commits] [PATCH] D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes()

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: shafik. This patchset is removing non-DWARF code from `DWARFUnit` as discussed with @labath. For removing the dependency o

[Lldb-commits] [PATCH] D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: shafik. jankratochvil added a parent revision: D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClass

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. jankratochvil added a parent revision: D70646: RFC 2/3: Move non-DWARF

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil updated this revision to Diff 231124. jankratochvil added a comment. Remove that dodgy new parameter `SymbolFileDWARF &dwarf`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70647/new/ https://reviews.llvm.org/D70647 Files: lldb/sou

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil planned changes to this revision. jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Symbol/TypeSystem.h:108-110 + virtual DWARFASTParser *GetDWARFParser(SymbolFileDWARF &dwarf) { +return nullptr;

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. FYI I am investigating it. I have found 2019-09-26-raspbian-buster.zip really can run in chroot on Fedora 31 armv7hl so I should be able to reproduce it. It is building LLDB now, that takes about 6 hours. Repo

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid FYI the JIT error happens for me on `2019-09-26-raspbian-buster` even without this my patch. I will try to debug that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D6354

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil created this revision. jankratochvil added reviewers: omjavaid, labath. jankratochvil added a project: LLDB. Herald added subscribers: kristof.beyls, aprantl. jankratochvil added a reviewer: jasonmolenda. echo -e '#include \nint main(void){\nsync();return 0;}'|./bin/clang -g -x c

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid Do you still see any regression of this patch after D71498 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540

[Lldb-commits] [PATCH] D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498

jankratochvil created this revision. jankratochvil added reviewers: omjavaid, labath, jasonmolenda. jankratochvil added a project: LLDB. Herald added a subscriber: emaste. jankratochvil added a parent revision: D71498: Fix ARM32 inferior calls. This is a similar fix as D71498

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1785486 , @omjavaid wrote: > error: Can't run the expression locally: Interpreter doesn't handle one of > the expression's opcodes OK, I see it is a different error. I will try to reproduce also that one. Repo

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. Could you check symtabs what symbols are located at: th1/fr0 with pc value of 0x102f0, symbol name is '_start' vs. th1/fr0 with pc value of 0xfe52, no symbol/function name is known. ? Or maybe just attached the main executable as `_start=0x102f0` is there I

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1786319 , @clayborg wrote: > For the printf style statement, we can't use just one cast to "uintptr_t" > because on 32 bit systems it won't be converted to 64 bit. That pointer-to-`uint64_t` is now used for `prin

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil updated this revision to Diff 234672. jankratochvil added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Changing the size of symbols turned out to be too invasive. Let's keep it intact. Rather choose the best symbols from those which have

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil planned changes to this revision. jankratochvil added a comment. In D63540#1791017 , @labath wrote: > then this for example means that the "less global" symbols will not be > reported through the Symtab::ForEachSymbolContainingFileAddress AP

[Lldb-commits] [PATCH] D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498

jankratochvil abandoned this revision. jankratochvil added a comment. I will merge this with D71498 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71514/new/ https://reviews.llvm.org/D71514 _

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil created this revision. jankratochvil added reviewers: jingham, labath, clayborg, mossberg. jankratochvil added a project: LLDB. Herald added a subscriber: kristof.beyls. D71372 introduced: `Unwind/thread-step-out-ret-addr-check.test` failing on Fedo

[Lldb-commits] [PATCH] D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. My testing matches the @labath's one. I have updated D71784 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil updated this revision to Diff 235009. jankratochvil added a comment. Herald added a subscriber: krytarowski. Addressed the review and D71789 and enabled it for Linux again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil added a comment. Thanks for the review but is it tested on Darwin? I do not have any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71784/new/ https://reviews.llvm.org/D71784 ___ lldb-com

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a60e8a07: [lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGdf6879ec0227: [lldb] Fix ARM32 inferior calls (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Host/common/HostInfoBase.cpp:250 + reinterpret_cast( + HostInfoBase::ComputeSharedLibraryDirectory))); labath wrote: > jankratochvil wrote

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1785458 , @labath wrote: > In other places you're replacing a reinterpret_cast with two c casts. `reinterpret_cast` and a `(c cast)` have the same behavior and as `c cast` is shorter I did prefer it. But I see `

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:577-586 if (lldb_private::Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS)) { LLDB_LOGF(log,

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil updated this revision to Diff 234935. jankratochvil marked an inline comment as done. Herald added a subscriber: emaste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71498/new/ https://reviews.llvm.org/D71498 Files: lldb/source/Core

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Core/PluginManager.cpp:89 template static FPtrTy CastToFPtr(void *VPtr) { - return reinterpret_cast(reinterpret_cast(VPtr)); + return reinterpret_cast(VPtr); } --

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/Unwind/Inputs/thread-step-out-ret-addr-check.s:22 -#ifdef __linux__ .section .note.GNU-stack,"",@progbits That was apparently a comment now

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil created this revision. jankratochvil added reviewers: stella.stamenova, mossberg, labath. jankratochvil added a project: LLDB. Herald added a subscriber: krytarowski. jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: ll

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil abandoned this revision. jankratochvil added a comment. This has been already fixed by @labath: https://github.com/llvm/llvm-project/commit/ce3ce9f46404688cc2d95f794799c8f834630905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71797/n

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil added a comment. The difference (with the previous size-non-setting patch) is: -lldb < 14> send packet: $Z0,102f0,2# +lldb < 14> send packet: $Z0,102f0,4# That is because `GetAddressClass` fails to recognized `0x102f0` as a code address: PASS: (l

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D63540#1791017 , @labath wrote: > Defining some sort of a preference based on symbol type seems like a good > idea, but I don't think this is a good way to implement it. If

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil updated this revision to Diff 235518. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 Files: lldb/include/lldb/Utility/RangeMap.h lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil planned changes to this revision. jankratochvil added a comment. In D63540#1805967 , @labath wrote: > Passing different sort objects to different sort invocations could cause > changes done by one Sort call to be undone by further Symtab add

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil updated this revision to Diff 236777. jankratochvil added a comment. Found some way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 Files: lldb/include/lldb/Symbol/Symtab.h lldb/include/l

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. jankratochvil marked an inline comment as done. jankratochvil added inline comments. jankratochvil added a child revision: D63540: Fix lookup of symbols with the same address range but

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:602 RangeData(B base, S size, DataType d) : Range(base, size), data(d) {} - - bool operator<(const RangeData &rhs) const { -if (this->base

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil added a comment. In D63540#1809725 , @labath wrote: > - make the RangeMap constructor take a `const Compare &` instead of a > template pack. The std containers do the same, and I don't see a reason to > diverge.. Done. I have mistaken it

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil updated this revision to Diff 237103. jankratochvil added a comment. This patch is now on top of D72460 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 Files

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f2f41e12c52: RangeDataVector: Support custom sorting for D63540 (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72460/new/ https

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:159-161 + else if (symbol.IsWeak()) +return 2; + else if (symbol.IsDebug()) labath wrote: > [[ http://llvm.org/doc

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGbf7225888a99: [lldb] Fix lookup of symbols with the same address range but different binding (authored by jankratochvil). Changed prior to commit: https:/

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

jankratochvil created this revision. jankratochvil added reviewers: labath, omjavaid. jankratochvil added a project: LLDB. Herald added a subscriber: kristof.beyls. jankratochvil planned changes to this revision. jankratochvil added a parent revision: D63540: Fix lookup of symbols with the same ad

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:898-900 +if (i == num_entries - 1 || +m_file_addr_to_index.GetMutableEntryAtIndex(i + 1) +->GetRangeBase() != cur

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil updated this revision to Diff 239571. jankratochvil retitled this revision from "RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`" to "Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`". jankratochvil edited the summary of this revision. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes()

jankratochvil abandoned this revision. jankratochvil added a comment. This refactorization is no longer needed as I am abandoning D70647 to choose a different way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7064

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil abandoned this revision. jankratochvil marked an inline comment as done. jankratochvil added a comment. I tried to use `DIERef` instead of `DWARFDIE` everywhere as @labath does not like to increase `DWARFDIE` size from 16 bytes to 24 bytes. But that is not really feasible. For `DI

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: shafik. I think this patch is not good. I wrote it to as a solution to @labath's request that `DWARFDIE` should n

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. In D73206 @labath said: //The test changes are cool, and I'd encourage you to split them off into a separate patch. // Repository: rG LLVM Github

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

jankratochvil added a comment. In D73206#1837138 , @clayborg wrote: > Is this something we can store in the DWARFUnit? Seems like it would be nice > to be able to ask the DWARFUnit for its DWZ Unit? Then no changes are needed > to DWARFDie since it could

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241545. jankratochvil added a comment. Herald added a subscriber: mgorny. By making the new `.cpp` file I get now this error: In file included from /home/jkratoch/redhat/llvm-monorepo/lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.cpp:9: In

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241630. jankratochvil added a comment. It needed to add the line: include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include) But then maybe it also needs: # Our current version of gtest does not properly recognize C++11 support

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil updated this revision to Diff 241634. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70646/new/ https://reviews.llvm.org/D70646 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4011 +void SymbolFileDWARF::GetDWARFDeclContext(const DWARFDIE &die, + DWARFDeclConte

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

This revision was automatically updated to reflect the committed changes. Closed by commit rG789beeeca3cd: [lldb] Move non-DWARF code: DWARFUnit -> SymbolFileDWARF (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D70646?vs=241634&id=241715#toc Repository: rG LLV

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. Checked in, thanks for the review. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008 + DWARFASTParser *dwarf_ast = GetDWARFParser(*die.GetCU()); + if (dwarf_ast) +r

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D73279#1851201 , @labath wrote: > That might explain the warnings I have seen when building with msvc the other > day. It might good to add those too. Added. ==

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241721. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 Files: lldb/unittests/Expression/DWARFExpressionTest.cpp lldb/unittests/SymbolFile/DWARF/DWARFASTParserC

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil marked an inline comment as done. jankratochvil added a comment. This commit broke: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/ Going to revert the return value refactorization. That `DWARFDebugInfoEntry::GetDWARFDeclContext()` refactorization for return value was

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil added a comment. Reverted the refactorization by: https://github.com/llvm/llvm-project/commit/6dd0163502ff8c48195643b2b08a123c495743a0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70646/new/ https://reviews.llvm.org/D70646 __

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: shafik. In D70646 I broke http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil updated this revision to Diff 241784. jankratochvil marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 Files: lldb/unittests/Expression/DWARFExpressionTest.cpp

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil marked 8 inline comments as done. jankratochvil added inline comments. Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h:24 +class YAMLModuleTester { + // SubsystemRAII subsystems; + SubsystemRAII subsystems; aprantl wrote: > ?

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

jankratochvil created this revision. jankratochvil added reviewers: labath, xiaobai. jankratochvil added a project: LLDB. Herald added subscribers: usaxena95, dmgreen, jfb, kadircet, dexonsmith, modocache, ilya-biryukov, aprantl, mehdi_amini, mgorny. Herald added a reviewer: jdoerfert. jankratochv

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

jankratochvil added a comment. Functions are defined in: `./lib/liblldbTarget.a` = `lldb/source/Target/CMakeLists.txt` Functions are needed in: `./lib/liblldbExpression.a` = `lldb/source/Expression/CMakeLists.txt` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

jankratochvil updated this revision to Diff 242030. jankratochvil added a comment. OK, `LINK_INTERFACE_MULTIPLICITY` also works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73847/new/ https://reviews.llvm.org/D73847 Files: lldb/source/Core/CMa

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

This revision was automatically updated to reflect the committed changes. Closed by commit rG2926a651ba73: [lldb] [testsuite] generalize `DWARFASTParserClangTests` based on… (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil added a comment. Fixed up by: rG104800084f6a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 __

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil updated this revision to Diff 242936. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73787/new/ https://reviews.llvm.org/D73787 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParse

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil added a comment. In D73787#1859754 , @labath wrote: > One way to this could be improved further is to change the recursion in > `GetDWARFDeclContext` into a loop (then you wouldn't need the extra wrapper). True, I am stupid. But then I fin

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d11d5f62422: [lldb] [NFC] Refactor GetDWARFDeclContext to return DWARFDeclContext (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

jankratochvil added a comment. Even with the latest variant (commit `7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2`) I am getting on Fedora 30 x86_64: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test:5:10: error: CHECK: expected string not found in input # CHECK: threa

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rG88cd49e941b9: [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73847/n

<    4   5   6   7   8   9