[Lldb-commits] [PATCH] D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs

jankratochvil updated this revision to Diff 158176. https://reviews.llvm.org/D49969 Files: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h source/Plugins/SymbolFile/DWARF/NameToDIE.cpp source/Plugins/SymbolFile/DWARF/NameToDIE.h Ind

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil added a comment. In https://reviews.llvm.org/D48782#1164786, @labath wrote: > For the purposes of integration testing I think it would be better to just > silently accept these so that all tests work "out of the box" with dwz. It > might be nice to hide these details in a wrapper

[Lldb-commits] [PATCH] D40475: DWZ 05/06: DWZ test mode

jankratochvil added a comment. There is no DWZ-tool wrapping script as discussed at: D48782 https://reviews.llvm.org/D40475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs

jankratochvil updated this revision to Diff 159192. Repository: rLLDB LLDB https://reviews.llvm.org/D49969 Files: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h source/Plugins/SymbolFile/DWARF/NameToDIE.cpp source/Plugins/SymbolF

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. Just a ping, that `ConcatenatingDataExtractor` is still not coded, even as some draft patch? Just checking to prevent duplicating some existing work. FYI providing a rebase with few simple conflicts resolved . I

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. Just to clarify - I guess `DWARFConcatenatingDataExtractor` should replace all uses of `DWARFDataExtractor` in the `DWARF/` subdirectory, whenever `lldb::offset_t offset` is used, right? As the other option would be to remap just `lldb::user_id_t` but that would no

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, davide. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl, mgorny. Tried to address Greg Clayton's performance concerns here: Rebased

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1215821, @clayborg wrote: > I have stalled on this due to performance. Anything I do will ruin the > performance of 99% of the DWARF consumers for .debug_types which is rarely > used by our clients. I have tried to implement it

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil updated this revision to Diff 163663. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFASTP

[Lldb-commits] [PATCH] D51874: Fix buildbot regression: NameError: global name 'test_directory' is not defined

jankratochvil created this revision. jankratochvil added a reviewer: vsk. jankratochvil added a project: LLDB. With buildbot slave under test - I get: http://lab.llvm.org:8014/builders/lldb-x86_64-fedora-28-cmake/builds/243/steps/test1/logs/stdio File "/home/buildbot/lldbroot/lldb-x86_64-fed

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. BTW I would welcome some direction forward (for our internal yearly team meeting) how to unblock this patch (and assuming DWZ https://reviews.llvm.org/D40474). I can code some other of the solutions described above by Pavel Labath

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil added a comment. In https://reviews.llvm.org/D51578#1233518, @clayborg wrote: > Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put > all functionality into DWARFDataExtractor? OK, I will try it that way. > Also is there a reason we need to pass the block

[Lldb-commits] [PATCH] D40474: DWZ 03/06: Main functionality

jankratochvil updated this revision to Diff 165347. Repository: rLLDB LLDB https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cp

[Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL318626: Add comments to DWARFCompileUnit length fields/methods (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40211?vs=123472&id=123498#toc Repository: rL LLVM https

[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers

jankratochvil added a comment. In https://reviews.llvm.org/D40212#929716, @clayborg wrote: > Good change in the header file. If you mean the in-class initializers they obviously cannot be used without the in-place construction+destruction as they would stay duplicate to the Clear() method. O

[Lldb-commits] [PATCH] D40214: performance: Prevent needless DWARFCompileUnit::Clear() on freshly ctor-ed object

jankratochvil added a comment. Thanks for the review but then it would become a performance regression, not the performance improvement I was trying to make. Withdrawing this patch. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:74

[Lldb-commits] [PATCH] D40216: #if 0 for DWARFDebugInfo::Find() as it is unused

This revision was automatically updated to reflect the committed changes. Closed by commit rL318631: Remove 2 unused methods DWARFDebugInfo::Find and their FindCallbackString (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40216?vs=123479&id=123505#toc Repositor

[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()

jankratochvil updated this revision to Diff 124103. jankratochvil retitled this revision from "refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers" to "refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()". jankratochvil edit

[Lldb-commits] [PATCH] D40458: DWARFDebugInfoEntry: Remove unused: Contains, Clear, SetOffset

jankratochvil created this revision. Herald added a subscriber: JDevlieghere. Due to changes for DWZ I would need to update those such as renaming it to SetFileOffset. Checking in as obvious for unused code. https://reviews.llvm.org/D40458 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugIn

[Lldb-commits] [PATCH] D40458: DWARFDebugInfoEntry: Remove unused: Contains, Clear, SetOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rL318981: Due to changes for DWZ I would need to update those such as renaming it to (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40458?vs=124261&id=124262#toc Reposito

[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()

jankratochvil updated this revision to Diff 124266. https://reviews.llvm.org/D40212 Files: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugI

[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()

jankratochvil updated this revision to Diff 124290. jankratochvil added a comment. refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract() It has no functionality effect but I find it much more simplified for further refactorizations and extensions in my pat

[Lldb-commits] [PATCH] D40467: DWZ: Separate Offset also into FileOffset

jankratochvil created this revision. Herald added a subscriber: JDevlieghere. Offset may represent virtual DW_TAG_partial_unit remapping while FileOffset always represents the file data. Units are ordered: | Offset 0| FileOffset 0 of DWZ file (if exists) | | Off

[Lldb-commits] [PATCH] D40468: DWZ 05/12: Support reading section ".gnu_debugaltlink"

jankratochvil created this revision. Herald added subscribers: JDevlieghere, arichardson, emaste. All DWZ patches are also applied in: git clone -b dwz git://git.jankratochvil.net/lldb https://reviews.llvm.org/D40468 Files: include/lldb/lldb-enumerations.h source/Core/Section.cpp source/

[Lldb-commits] [PATCH] D40469: DWZ 06/12: Mask DW_TAG_partial_unit as DW_TAG_compile_unit for Tag()

jankratochvil created this revision. Herald added a subscriber: JDevlieghere. Code commonly checks if the parent DIE is DW_TAG_compile_unit. But DW_TAG_partial_unit also acts as DW_TAG_compile_unit for DWZ as DWZ is using DW_TAG_imported_unit only at the top unit level. All DWZ patches are also

[Lldb-commits] [PATCH] D40470: DWZ 07/12: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil created this revision. Herald added subscribers: JDevlieghere, aprantl. Multiple DW_TAG_compile_unit being indexed in a multithreaded way can request reading of the same DW_TAG_partial_unit. Unfortunately one cannot detect DWZ file ahead of time to disable such locking overhead as

[Lldb-commits] [PATCH] D40471: DWZ 08/12: DWARFCompileUnit::ExtractDIEsIfNeeded can now expand AllDiesButCuDieOnlyForPartialUnits

jankratochvil created this revision. Herald added a subscriber: JDevlieghere. It does not make sense to extract whole DW_TAG_partial_unit only to find out it is a partial unit and so it cannot be indexed on its own. All DWZ patches are also applied in: git clone -b dwz git://git.jankratochvil.n

[Lldb-commits] [PATCH] D40472: DWZ 09/12: Protect DWARFDebugInfo::m_compile_units by a new mutex

jankratochvil created this revision. Herald added subscribers: JDevlieghere, aprantl. DW_TAG_partial_unit is remapped on each of its use, those remapped virtual units are added into DWARFDebugInfo::m_compile_units during multithreaded indexing. All DWZ patches are also applied in: git clone -b

[Lldb-commits] [PATCH] D40473: DWZ 10/12: Adjust existing code for the DWZ support.

jankratochvil created this revision. Herald added subscribers: JDevlieghere, aprantl. New DWARFCompileUnit::GetMainCU() and DWARFDIE::GetMainDWARF() need to locate original symbol file from DWZ common file for example for UID context; symbol file matching the DIE one still needs to be used for .

[Lldb-commits] [PATCH] D40474: DWZ 11/12: Main functionality

jankratochvil created this revision. Herald added subscribers: JDevlieghere, mgorny. This is the kitchen sink. It also covers separate DWZ common files. All DWZ patches are also applied in: git clone -b dwz git://git.jankratochvil.net/lldb https://reviews.llvm.org/D40474 Files: include/lld

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

jankratochvil created this revision. Herald added subscribers: eraman, aprantl. Many ERRORs are correct because for many *_dwz testcases DWZ cannot be applied. Otherwise their tests would be duplicating their *_dwarf counterparts. Using for regression comparison of *_dwz against *_dwarf: rm -

[Lldb-commits] [PATCH] D40474: DWZ 11/12: Main functionality

jankratochvil added a comment. Going to update the patch. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:92 // C++14: mutable std::shared_timed_mutex m_dwz_uniq_mutex; mutable std::recursive_mutex m_dwz_uniq_mutex; labath wrote: > Is `llvm

[Lldb-commits] [PATCH] D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:216 + DWARFCompileUnitData *m_data; + clayborg wrote: > Is there a reason this is a member variable that I am no

[Lldb-commits] [PATCH] D40467: DWZ 04/12: Separate Offset also into FileOffset

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:15 #include +#include clayborg wrote: > Why is this added here? Doesn't seem to be needed, or it should be moved

[Lldb-commits] [PATCH] D40467: DWZ 04/12: Separate Offset also into FileOffset

jankratochvil updated this revision to Diff 124803. jankratochvil marked an inline comment as done. jankratochvil added a comment. Removed excessive: #include: https://reviews.llvm.org/D40467 Files: include/lldb/Expression/DWARFExpression.h source/Expression/DWARFExpression.cpp source/Pl

[Lldb-commits] [PATCH] D40212: DWZ 02/12: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:248-249 -while (cu->Extract(dwarf2Data->get_debug_info_data(), &offset)) { +for (;;) { + DWARFCompileUnitSP cu = DWARFCompileUnit::Extract(dwarf2Data, &offset); +

[Lldb-commits] [PATCH] D40212: DWZ 02/12: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers + Extract()

This revision was automatically updated to reflect the committed changes. Closed by commit rL319359: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class… (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40212?vs=124290&id=124806#toc Repository:

[Lldb-commits] [PATCH] D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:216 + DWARFCompileUnitData *m_data; + clayborg wrote: > jankratochvil wrote: > > clayborg wrote: > > > Is there

[Lldb-commits] [PATCH] D40635: refactor: Simplify loop with DWARFCompileUnit::Extract

jankratochvil created this revision. Herald added a subscriber: JDevlieghere. Forgotten small simplification in https://reviews.llvm.org/D40212. https://reviews.llvm.org/D40635 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp Index: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cp

[Lldb-commits] [PATCH] D40635: refactor: Simplify loop with DWARFCompileUnit::Extract

This revision was automatically updated to reflect the committed changes. Closed by commit rL319402: refactor: Simplify loop with DWARFCompileUnit::Extract (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40635?vs=124871&id=124872#toc Repository: rL LLVM https

[Lldb-commits] [PATCH] D40467: DWZ 04/12: Separate Offset also into FileOffset

jankratochvil added a comment. > Please undo all renaming from offset to file_offset. I am preparing now a split of this patch for the renaming part + the "real" part, sorry I did not realize it is mostly about the renaming which is not worth your detailed review. There are two different types

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

jankratochvil added a comment. > you will probably be the only person who will be able to run these tests and > verify dwz functionality. OK; really nobody runs RHEL/CentOS/Fedora? :-) > If you don't setup a buildbot testing OK, I will try that. I was even running a test bot for GDB. > These

[Lldb-commits] [PATCH] D40474: DWZ 11/12: Main functionality

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:487 + public: +// C++14: Use heterogenous lookup. +DWZCommonFile(const lldb_private::FileSpec &filespec_ref); --

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

jankratochvil added a comment. In https://reviews.llvm.org/D40475#940462, @labath wrote: > It looks like it could be a fun project to reimplement `dwz` on top of llvm > dwarf library, but I understand that would be a considerable detour for you. I think it would be best to drop DWZ, IIRC its g

[Lldb-commits] [PATCH] D40717: Makefile.rules: compile all tests with -fno-limit-debug-info

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. On Fedora 27 x86_64 it has no regressions and these results turned Failure->Success: LibcxxIteratorDataFormatterTestCase-test_with_run_command_dwarf.log LibcxxIteratorDataFor

[Lldb-commits] [PATCH] D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:216 + DWARFCompileUnitData *m_data; + jankratochvil wrote: > clayborg wrote: > > jankratochvil wrote: > > > clayborg wrote: > > > > Is there a reason this is a

[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. Cleanup needless+missing `#include "DWARFCompileUnit.h"` for split of DWARFCompileUnit to DWARFUnit as discussed in https://reviews.llvm.org/D40466. https://rev

[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323069: Clean up #include "DWARFCompileUnit.h" (authored by jankratochvil, committed by ). Herald added a subscriber: llvm

[Lldb-commits] [PATCH] D42613: Remove unused class declarations

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. Simplification by removing excessive DWARFCompileUnit references for https://reviews.llvm.org/D40466 . https://reviews.llvm.org/D42613 Files: source/Plugins/

[Lldb-commits] [PATCH] D42613: Remove unused class declarations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323586: Remove unused class declarations (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commi

[Lldb-commits] [PATCH] D42852: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. I have found the lookup by build-id (when lookup by /usr/lib/debug/path/name/exec.debug failed) does not work as LLDB tries the build-id hex string in uppercase but Fedora uses lowercase. xubuntu-16.10 also use

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added a subscriber: aprantl. I have found LLDB cannot find separate debug info of Fedora /usr/bin/gdb. It is because: lrwxrwxrwx 1 root root 14 Jan 25 20:41 /usr/bin/gdb -> ../libexec/gdb* -rw

[Lldb-commits] [PATCH] D42852: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

jankratochvil updated this revision to Diff 132668. jankratochvil added a comment. Simplify the testcase using: lldbutil.run_to_name_breakpoint https://reviews.llvm.org/D42852 Files: packages/Python/lldbsuite/test/linux/buildidcase/Makefile packages/Python/lldbsuite/test/linux/buildidcase/

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

jankratochvil updated this revision to Diff 132670. jankratochvil marked an inline comment as done. jankratochvil added a comment. Simplify the testcase by: lldbutil.run_to_name_breakpoint https://reviews.llvm.org/D42853 Files: packages/Python/lldbsuite/test/linux/sepdebugsymlink/Makefile

[Lldb-commits] [PATCH] D42891: DWZ 01/12: refactor: DWARFCompileUnit::Producer -> DWARFProducer

jankratochvil created this revision. jankratochvil added a reviewer: clayborg. Herald added a subscriber: JDevlieghere. jankratochvil added a dependent revision: D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData. https://reviews.llvm.org/D40466#inline-354567 suggested to make Prod

[Lldb-commits] [PATCH] D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData

jankratochvil updated this revision to Diff 132769. jankratochvil added a comment. Herald added subscribers: hintonda, mgorny. DWARFCompileUnitData is no more, there is now DWARFUnit with virtual method Data() to reference its inherited DWARFCompileUnit. I think it will make it more mergeable w

[Lldb-commits] [PATCH] D42892: DWZ 03/12: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. jankratochvil added a dependency: D40466: DWZ 02/12: DWARFUnit split out of DWARFCompileUnit. Now the codebase can use the DWARFUnit superclass. It will make it

[Lldb-commits] [PATCH] D40466: DWZ 02/12: DWARFUnit split out of DWARFCompileUnit

jankratochvil added a comment. This patch only tries to move code without changing it in any way (except for some Data() references required for DWARFCompileUnit members access from DWARFUnit). https://reviews.llvm.org/D40466 ___ lldb-commits mail

[Lldb-commits] [PATCH] D42852: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

This revision was automatically updated to reflect the committed changes. Closed by commit rL324222: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

This revision was automatically updated to reflect the committed changes. Closed by commit rL324224: Resolve binary symlinks before finding its separate .debug file (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D42908: Fix Bug 36237 - TestTargetSymbolsSepDebugSymlink fails when run remotely

jankratochvil created this revision. jankratochvil added a reviewer: labath. (In reply to labath from Bug 36237 comment #0) > The root problem is in Platform::Install. When given a symlink, it will try > to create the same symlink on the target. However, Platform::CreateSymlink > function is n

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil added a comment. FYI it FAILs for me on Fedora 27 x86_64, it cannot find "main", debugging it. The .build-id/ separate debug info does work with GDB but not with LLDB. https://reviews.llvm.org/D42914 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil created this revision. jankratochvil added a reviewer: labath. Herald added subscribers: emaste, srhines. This is written for tha YAML testcase of https://reviews.llvm.org/D42914. Its unstripped.yaml contains: Start of section headers: 64 (bytes into file) Number o

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil added a comment. This testcase does work for me only with newly written https://reviews.llvm.org/D42931. https://reviews.llvm.org/D42914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D42891: DWZ 01/12: refactor: DWARFCompileUnit::Producer -> DWARFProducer

This revision was automatically updated to reflect the committed changes. Closed by commit rL324275: refactor: DWARFCompileUnit::Producer -> DWARFProducer (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4289

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil added a comment. I see now Pavel has solved it by: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers https://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180205/038992.html I am not sure if that is not a more general solution but t

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. It does work for me also with: `r324254 - Fix parsing of object files with "early" section headers` https://reviews.llvm.org/D42914 __

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil abandoned this revision. jankratochvil added a comment. I think this patch still makes sense but whatever. https://reviews.llvm.org/D42931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D40466: DWZ 02/12: DWARFUnit split out of DWARFCompileUnit

jankratochvil updated this revision to Diff 135047. https://reviews.llvm.org/D40466 Files: source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D42892: DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

jankratochvil updated this revision to Diff 135048. jankratochvil retitled this revision from "DWZ 03/12: Move the codebase to use: DWARFCompileUnit -> DWARFUnit" to "DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit". jankratochvil edited the summary of this revision. https://r

[Lldb-commits] [PATCH] D40467: DWZ 03/11: Separate Offset also into FileOffset

jankratochvil updated this revision to Diff 135049. jankratochvil retitled this revision from "DWZ 04/12: Separate Offset also into FileOffset" to "DWZ 03/11: Separate Offset also into FileOffset". https://reviews.llvm.org/D40467 Files: include/lldb/Expression/DWARFExpression.h source/Expres

[Lldb-commits] [PATCH] D40469: DWZ 06/12: Mask DW_TAG_partial_unit as DW_TAG_compile_unit for Tag()

jankratochvil added a comment. In https://reviews.llvm.org/D40469#936245, @clayborg wrote: > Seems like it would be cleaner to leave DWARFDebugInfoEntry and DWARFDie > alone and just make clients deal with accepting DW_TAG_partial_unit when and > where they need to. I don't like the idea of not

[Lldb-commits] [PATCH] D40468: DWZ 04/11: Support reading section ".gnu_debugaltlink"

jankratochvil updated this revision to Diff 135050. jankratochvil retitled this revision from "DWZ 05/12: Support reading section ".gnu_debugaltlink"" to "DWZ 04/11: Support reading section ".gnu_debugaltlink"". https://reviews.llvm.org/D40468 Files: include/lldb/lldb-enumerations.h source/

[Lldb-commits] [PATCH] D40469: DWZ 04/11: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched

jankratochvil updated this revision to Diff 135051. jankratochvil retitled this revision from "DWZ 06/12: Mask DW_TAG_partial_unit as DW_TAG_compile_unit for Tag()" to "DWZ 04/11: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched". https://reviews.llvm.org/D40469 Files: sourc

[Lldb-commits] [PATCH] D40470: DWZ 07/12: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:123 size_t DWARFCompileUnit::ExtractDIEsIfNeeded(bool cu_die_only) { - const size_t initial_die_array_size = m_data->m_die_array.size(); - if ((cu_die_only && initial_die_arra

[Lldb-commits] [PATCH] D40470: DWZ 06/11: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 135053. jankratochvil retitled this revision from "DWZ 07/12: Protect DWARFCompileUnit::m_die_array by a new mutex" to "DWZ 06/11: Protect DWARFCompileUnit::m_die_array by a new mutex". jankratochvil edited the summary of this revision. https://reviews

[Lldb-commits] [PATCH] D40472: DWZ 07/11: Protect DWARFDebugInfo::m_compile_units by a new mutex

jankratochvil updated this revision to Diff 135055. jankratochvil retitled this revision from "DWZ 09/12: Protect DWARFDebugInfo::m_compile_units by a new mutex" to "DWZ 07/11: Protect DWARFDebugInfo::m_compile_units by a new mutex". jankratochvil edited the summary of this revision. https://rev

[Lldb-commits] [PATCH] D40472: DWZ 07/11: Protect DWARFDebugInfo::m_compile_units by a new mutex

jankratochvil updated this revision to Diff 135058. https://reviews.llvm.org/D40472 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h Index: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h =

[Lldb-commits] [PATCH] D40473: DWZ 10/12: Adjust existing code for the DWZ support.

jankratochvil added a subscriber: alexshap. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:199-202 + if (die_ref.cu_offset == DW_INVALID_OFFSET + // FIXME: Workaround default cu_offset = 0 in DIERef ctor. + // Why do

[Lldb-commits] [PATCH] D40473: DWZ 08/11: Adjust existing code for the DWZ support.

jankratochvil updated this revision to Diff 135059. jankratochvil retitled this revision from "DWZ 10/12: Adjust existing code for the DWZ support." to "DWZ 08/11: Adjust existing code for the DWZ support.". https://reviews.llvm.org/D40473 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserC

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

jankratochvil updated this revision to Diff 135060. jankratochvil marked an inline comment as done. jankratochvil retitled this revision from "DWZ 11/12: Main functionality" to "DWZ 09/11: Main functionality". https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil updated this revision to Diff 135063. jankratochvil retitled this revision from "DWZ 12/12: DWZ test mode" to "DWZ 10/11: DWZ test mode". jankratochvil added a comment. Herald added subscribers: JDevlieghere, mgorny. It now includes also unittests/SymbolFile/DWZ/ which should PASS e

[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a dependency: D40475: DWZ 10/11: DWZ test mode. So far `/usr/lib/debug/.build-id/**.debug` files could be opened any way. But with DWZ they can contain relative filename reference to `/usr/

[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Host/common/Symbols.cpp:288-290 if (llvm::sys::fs::equivalent(file_spec.GetPath(), module_file_spec.GetPath())) conti

[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files

jankratochvil updated this revision to Diff 135817. jankratochvil marked an inline comment as done. https://reviews.llvm.org/D43512 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/linux/buildidsymlink/Makefile packages/Python/lldbsuite/test/linux/buildids

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil updated this revision to Diff 135847. jankratochvil added a comment. > The way we do these sorts of things is that we explicitly add the category to > the list of skipped categories (take a look at `checkLibcxxSupport` in > dotest.py). I have implemented `dwz` category like `gmodu

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1024546, @labath wrote: > I personally don't think having a new debug info flavour is a good idea. > Tests written specifically to test this functionality will be easier to > maintain and debug when they break. And keeping adding

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1026779, @davide wrote: > Do you have a way of reproducing? It just happens for me each time - on Fedora 27 x86_64 on 16-core (32HT) 2-node NUMA machine having env var `MAKEFLAGS=-j32` (and `tuned-adm throughput-performance` if

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1026781, @davide wrote: > Any chance you're interested in working on that? Yes, it is in the shortterm or rather midterm plan. https://reviews.llvm.org/D32167 ___ lldb-commits mail

[Lldb-commits] [PATCH] D44157: [elf] Remove one copy of the section merging code

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Yes, it should be the same I think; some notes of mine: Module::GetSectionList()->obj_file->CreateSections(*GetUnifiedSectionList()); Module::GetUnifiedSectionList()->

[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files

jankratochvil updated this revision to Diff 137622. https://reviews.llvm.org/D43512 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/linux/buildidsymlink/Makefile packages/Python/lldbsuite/test/linux/buildidsymlink/TestTargetSymbolsBuildidSymlink.py pack

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil added a comment. In https://reviews.llvm.org/D40475#1018951, @davide wrote: > fwiw, you don't need unit tests or python tests to implement this. > If I understand the feature correctly you can probably extend `lldb-test` > (which is run as part of `check-lldb-lit`). I do not und

[Lldb-commits] [PATCH] D40473: DWZ 08/11: Adjust existing code for the DWZ support.

jankratochvil updated this revision to Diff 137962. jankratochvil added a comment. bugfix https://reviews.llvm.org/D40473 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp sour

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

jankratochvil updated this revision to Diff 137961. jankratochvil added a comment. bugfix https://reviews.llvm.org/D40466 Files: source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil updated this revision to Diff 137963. jankratochvil added a comment. > I have implemented dwz category like gmodules but even when checkDWZSupport > makes configuration.skipCategories.append("dwz") the DWZ-variants of tests > are still being run. I will investigate it more. This i

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

jankratochvil added a comment. ping: Are there more comments how to make this whole patchset accepted upstream? Thanks. https://reviews.llvm.org/D40474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

jankratochvil added a comment. In https://reviews.llvm.org/D40466#1034875, @davide wrote: > This is No functional change, right (just code churn)? Right. https://reviews.llvm.org/D40466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil updated this revision to Diff 138813. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/lldbinline.py packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

jankratochvil updated this revision to Diff 138860. https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWA

[Lldb-commits] [PATCH] D42892: DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:34 class DWARFUnit { + friend class DWARFCompileUnit; + clayborg wrote: > DWARFCompileUnit inherits from this class. This isn't needed right? It is needed now as `DWARF

<    1   2   3   4   5   6   7   8   9   >