jankratochvil created this revision.
jankratochvil added a reviewer: labath.
(In reply to labath from Bug 36237 comment #0)
> The root problem is in Platform::Install. When given a symlink, it will try
> to create the same symlink on the target. However, Platform::CreateSymlink
> function is not implemented, but even if it was, the target is unlikely to
> contain anything at the place where the symlink points to. And even if it
> contain something, it would most likely be a different object than the
> debugger will obtain when it resolves the symlink locally.
`lldb-server platform` did create a symlink for me:
/tmp/lldbtest/1/linux/sepdebugsymlink:
lrwxrwxrwx 1 jkratoch jkratoch 23 Feb 5 15:59 stripped.symlink ->
../dirreal/stripped.out
But I haven't found how to transfer the binaries there, I tried a bit some
`AddModule`+`SetRemoteInstallFileSpec` but it did not work and I did not try
harder.
> I think that a more reasonable behavior here would be to copy the file
> contents instead.
The symlink is essential for this testcase otherwise it does not test the
bugfix. OK to just disable it for remote testing?
https://reviews.llvm.org/D42908
Files:
packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
Index:
packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
===================================================================
---
packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
+++
packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
@@ -15,6 +15,7 @@
@no_debug_info_test # Prevent the genaration of the dwarf version of this
test
@skipUnlessPlatform(['linux'])
@skipIf(hostoslist=["windows"])
+ @skipIfRemote
def test_target_symbols_sepdebug_symlink_case(self):
self.build(clean=True)
exe = self.getBuildArtifact("dirsymlink/stripped.symlink")
Index: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
===================================================================
--- packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
+++ packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
@@ -15,6 +15,7 @@
@no_debug_info_test # Prevent the genaration of the dwarf version of this test
@skipUnlessPlatform(['linux'])
@skipIf(hostoslist=["windows"])
+ @skipIfRemote
def test_target_symbols_sepdebug_symlink_case(self):
self.build(clean=True)
exe = self.getBuildArtifact("dirsymlink/stripped.symlink")
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
