[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp:167-170 + // A list of known threads for the given process. When co

[Lldb-commits] [PATCH] D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:83-85 + uint64_t ToNanos(uint64_t tsc) const; + uint64_t ToTSC(uint64_t nanos) const;

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. sending this back to you based on the one minor thing we discussed related to reloading. If this is addressed in one of the cleanup diffs, lmk

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. Looks great overall, thanks for making these improvements - just a couple minor things Comment at: lldb/include/lldb/Targe

[Lldb-commits] [PATCH] D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. looks great overall, just a couple minor things. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:205-217 if (da

[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.h:53 +/// +/// \param[in] decoded_thread +/// All decoded instructions, errors and events will be appende

[Lldb-commits] [PATCH] D127817: [trace][intelpt] Support system-wide tracing [20] - Rename some fields in the schema

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/lldb-gdb-remote.txt:566 // } -// -// INTEL PT why delete this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25 +json::Value toJSON(const JSONUINT64 &uint64, bool hex) { + if (hex) should ther

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:188 + + bool was_enabled = m_enabled; if (Error err = DisableWithIoctl()) wallace wrote: > j

[Lldb-commits] [PATCH] D128107: Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 created this revision. jj10306 added a reviewer: wallace. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add trace load functionality to SBDebugger via the `LoadTraceFromFile` method. Update int

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 updated this revision to Diff 438400. jj10306 marked 12 inline comments as done. jj10306 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128107/new/ https://reviews.llvm.org/D128107 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:403 + /// trace session. + SBTrace LoadTraceFromFile(SBError &error, const char *trace_file_path); + wallace wrote: > wallace wrote: > > JDevlieghere wrote: > > > Can this take a

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 updated this revision to Diff 438449. jj10306 marked 2 inline comments as done. jj10306 added a comment. rebase and use SBFileSpec constructor with that requires an explicit `resolve` flag before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath) +loadTraceError = lldb.SBError() --

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f936796072: Add LoadTraceFromFile to SBDebugger and SBTrace (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128107/new/ https://revie

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks great overall, just a couple minor comments! Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:46 /// state and granularity. class TraceInstru

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194 + OutputWriterJSON(Stream &s, const TraceInstructionDumperOptions &options) + : m_s(s), m_option

[Lldb-commits] [PATCH] D108050: [wip] [trace] Hierarchical Trace Representation (HTR) redesign and "call stack trace" visualization

jj10306 updated this revision to Diff 378464. jj10306 added a comment. Herald added a subscriber: dang. Pulling in the request stitching changes so I can see what modifications were made to the "call stack trace" visualization along the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. this is awesome - the tests do a great job documenting the code and weird edge cases so thanks for that. just some minor nits and questions, looks good overall C

[Lldb-commits] [PATCH] D136034: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. nice! using this in conjunction with trace cursor we'll be able to produce some nice visualizations - lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Occasionally the assertion that enforces increasing TSC values in `DecodedTh

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks good overall, mainly some questions and a few nits Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:123 /// of a DenseMap because DenseMa

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 updated this revision to Diff 470472. jj10306 marked 7 inline comments as done. jj10306 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136610/new/ https://reviews.llvm.org/D136610 Files: lldb/source/Plugi

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:299-307 + uint64_t offset; + int status = pt_insn_get_offset(m_decoder_up.get(), &offset); + if (!IsLibiptError(status)) { +err_msg = +

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6eb089734dd: [trace][intelpt] Fix multi CPU decoding TSC assertion error (authored by jj10306). Changed prior to commit: https://reviews.llvm.org/D136610?vs=470472&id=470887#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the Python tests (ie tests run via `lldb-dotest -p TestTrace`) to hand

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

This revision was automatically updated to reflect the committed changes. Closed by commit rG17c65e51b916: [intelpt] Update Python tests to account for new errrors (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136801/new/ http

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mention that the LLVM/clang triple must be provided if the trace will be cons

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 updated this revision to Diff 473515. jj10306 added a comment. Improve docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/ https://reviews.llvm.org/D137509 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 marked an inline comment as done. jj10306 added a comment. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/ https://reviews.llvm.org/D137509 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 updated this revision to Diff 473628. jj10306 marked an inline comment as done. jj10306 added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/ https://reviews.llvm.org/D137509 Files: lldb/source/Plugi

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be created not using the CLI or on a machine other than where the

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf766fb65cc9: [NFC][intelpt] Improve IntelPT trace bundle documentation (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/ htt

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/API/SBTraceCursor.cpp:131 + const auto &maybe_wall_clock_time = m_opaque_sp->GetWallClockTime(); + return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0; +} o

[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296 std::vector m_item_data; + std::vector m_insn_extra_info; /// The TraceItemKind for each trace item encoded as uint8_t. We don't include do we need to store

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 updated this revision to Diff 474092. jj10306 added a comment. update the way items with no timestamps are handled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137645/new/ https://reviews.llvm.org/D137645 Files: lldb/bindings/interface/

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

jj10306 created this revision. jj10306 added reviewers: wallace, clayborg. Herald added subscribers: dang, mgorny. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff enables visualization of Intel PT traces by converting a su

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

jj10306 marked 6 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:3 +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. clayborg wrote: > Maybe add a definition

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 359848. jj10306 retitled this revision from "[trace] Add `thread trace dump ctf -f ` command" to "[trace] Add `thread trace export` command for Intel PT trace visualization". jj10306 edited the summary of this revision. jj10306 added a comment. - Add HTR doc

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 19 inline comments as done. jj10306 added inline comments. Comment at: lldb/docs/htr.rst:1 +Hierarchical Trace Representation (HTR) +== @clayborg @wallace Is there a way to view the "rendered" rst to ensure the t

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added inline comments. Comment at: lldb/source/Target/TraceHTR.cpp:205-217 + // Why does using `IHTRLayer ¤t_layer = m_instruction_layer;` not work? + HTRInstructionLayer instruction_layer = m_instruction_layer; + HTRBlockLayer current_layer = BasicSuperBlockMerge(inst

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:136-140 + /// Updates block_id: block mapping and append `block_id` to the block id + /// trace + void AddNewBlock(size_t block_id, HTRBlock &block); + /// Append `block_id` to the block id trace +

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 39 inline comments as done. jj10306 added inline comments. Comment at: lldb/source/Target/TraceHTR.cpp:53-57 +std::vector const &TraceHTR::GetBlockLayers() const { + return m_block_layers; +} + +HTRInstructionLayer const &TraceHTR::GetInstructionLayer() const { --

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 360965. jj10306 marked 2 inline comments as done. jj10306 added a comment. Address comments: - use unique_ptr to prevent unnecessary copying - add support for trace decoding errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://r

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 2 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const &GetBlockDefs() const; + wallace wrote: > As this is const, th

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked an inline comment as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const &GetBlockDefs() const; + wallace wrote: > jj10306 wrote: > > w

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 29 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const &GetBlockDefs() const; + jj10306 wrote: > wallace wrote: > >

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 361460. jj10306 edited the summary of this revision. jj10306 added a comment. Rebase and address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 Files: lldb/docs/htr.rst lldb/docs/media/basic_

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added a comment. Looks like I pulled in some unwanted changes related to the traceinstruction dumper and tsc when I rebased - will resolve this issue before landing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 _

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 361916. jj10306 added a comment. Rebased (integrate with https://reviews.llvm.org/D106501#change-SoRRVpoqDNdx) and address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 Files: lldb/docs/htr.r

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

jj10306 added a comment. In D105741#2920588 , @vsk wrote: > Hey @jj10306, thanks for working on this. > > @wallace @clayborg -- It seems like there are a ton of logic changes > introduced in this patch that are tested at too coarse a level. I'm not > co

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add more comprehensive for `thread trace export ctf` command

jj10306 created this revision. jj10306 added a reviewer: wallace. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up on https://reviews.llvm.org/D105741 - Add new test that exhaustively checks the output file's content - Fix

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365341. jj10306 added a comment. - move documentation to plugin directory - remove unnecessary checks in tests and remove test that wasn't testing anything different than the others - nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ h

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365346. jj10306 added a comment. - fix comment style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ https://reviews.llvm.org/D107674 Files: lldb/docs/htr.rst lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp lldb/source/Plugins

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

jj10306 added a comment. A more comprehensive test for this logic was added in https://reviews.llvm.org/D107674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 ___

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365477. jj10306 added a comment. lint + comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ https://reviews.llvm.org/D107674 Files: lldb/docs/htr.rst lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp lldb/source/Plugins/Tra

[Lldb-commits] [PATCH] D108050: [wip] [trace] Hierarchical Trace Representation (HTR) redesign and "call stack trace" visualization

jj10306 created this revision. Herald added a subscriber: mgorny. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Creating this patch so all the work from my internship is public and so I can continue to work on HTR if I'm able to

<    1   2