[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

[Jakob Johnson via Phabricator via lldb-commits]

jj10306 accepted this revision.
jj10306 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194
+  OutputWriterJSON(Stream &s, const TraceInstructionDumperOptions &options)
+      : m_s(s), m_options(options), m_j(/*IndentSize=*/m_s.AsRawOstream(),
+                                        options.pretty_print_json ? 2 : 0) {
+    m_j.arrayBegin();
----------------
the inline comment should be next to the second parameter, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128316/new/

https://reviews.llvm.org/D128316

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits