[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

ki.stfu added a comment. 👍 Repository: rL LLVM https://reviews.llvm.org/D47410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Hi. LGTM. Just fix a few minor issues before committing. Thank you for your contribution to LLDB project! Comment at: packages/Python/lldbsuite/test/tools/lldb

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Would you like me to commit it? https://reviews.llvm.org/D31073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Thanks for catching this! Could you update this CL to let me commit it? Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:287-289 +

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

ki.stfu added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329 +# We need to get past these instructions with a step to reach call to s_MyFunction. +self.runCmd("-exec-step --thread 1")

[Lldb-commits] [PATCH] D37533: Fix lldb-mi test data_read_memory_bytes_global

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. 👍 https://reviews.llvm.org/D37533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D26124: [LLDB-MI] Escape MI output in a more consistent manner

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. @enlight , thanks for giving a chance to review it, and sorry that it took to long from my side. Most of these changes look good to me, especially removing of meaningless temporal

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

ki.stfu added a comment. lgtm Repository: rL LLVM https://reviews.llvm.org/D24711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. I don't know the point of this patch (probably it's something special for NetBSD? @emaste) but I'm okay with that. Repository: rL LLVM https://reviews.llvm.org/D29256

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

ki.stfu added a comment. In https://reviews.llvm.org/D29256#660159, @krytarowski wrote: > It's undefined (implementation defined) behavior. > > C++11 5.2.2/7: > > > > Passing a potentially-evaluated argument of class type having a > > non-trivial copy constructor, a non-trivial move contr

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

ki.stfu added a comment. In https://reviews.llvm.org/D29256#662167, @krytarowski wrote: > @ki.stfu do you still agree with this patch? Please follow my comments and then we can go ahead. Comment at: tools/lldb-mi/MIDriver.cpp:512 CMICmnThreadMgrStd::Instance().GetEr

[Lldb-commits] [PATCH] D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:350 lldb::SBDebugger &rDbgr = m_rLLDBDebugSessionInfo.GetDebugger(); - m_strValue = lldb::SBDebugger::GetInternalVar