ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed.
Hi. LGTM. Just fix a few minor issues before committing. Thank you for your contribution to LLDB project! ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lexical-scope/Makefile:1 +LEVEL = ../../../make + ---------------- Rename directory to lexical**_**scope. ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lexical-scope/TestLexicalScope.py:1 +# coding=utf8 +""" ---------------- Remove please. We don't specify encoding in other files. ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lexical-scope/TestLexicalScope.py:1 +# coding=utf8 +""" ---------------- ki.stfu wrote: > Remove please. We don't specify encoding in other files. Rename this to packages/Python/lldbsuite/test/tools/lldb-mi/lexical**_**scope/Test**Mi**LexicalScope.py. https://reviews.llvm.org/D31073 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
