[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-06 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/102263 There is no need to clone the content and set extraction properties because `m_auxv` is already in the required form. >From d3a72694e444cf19e62bceab3234b8a338aec7b1 Mon Sep 17 00:00:00 2001 From: Igor Kudrin

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-06 Thread Igor Kudrin via lldb-commits
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() { } DataExtractor ProcessElfCore::GetAuxvData() { - const uint8_t *start = m_auxv.GetDataStart(); - size_t len = m_auxv.GetByteSize(); - lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len)

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-06 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin edited https://github.com/llvm/llvm-project/pull/102263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-09 Thread Igor Kudrin via lldb-commits
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() { } DataExtractor ProcessElfCore::GetAuxvData() { - const uint8_t *start = m_auxv.GetDataStart(); - size_t len = m_auxv.GetByteSize(); - lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len)

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-13 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/102263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing (PR #106478)

2024-08-28 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/106478 [D156118](https://reviews.llvm.org/D156118) states that this note is always present, but it is better to check it explicitly, as otherwise `lldb` may crash when trying to read registers. >From e588c3c305323

[Lldb-commits] [lldb] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing (PR #106478)

2024-08-28 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/106478 >From 6854730d45a2c119d2b8f71df6e22ead1c7ad5a8 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 28 Aug 2024 17:57:38 -0700 Subject: [PATCH] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing [D156118

[Lldb-commits] [lldb] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing (PR #106478)

2024-08-29 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/106478 >From 6854730d45a2c119d2b8f71df6e22ead1c7ad5a8 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 28 Aug 2024 17:57:38 -0700 Subject: [PATCH 1/2] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing [D15

[Lldb-commits] [lld] [lldb] [flang] [libcxx] [compiler-rt] [clang-tools-extra] [llvm] [clang] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-01 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/70898 >From 113c03bbf773c71d329ab2afd063753365e4ac68 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 26 Oct 2023 13:19:08 -0700 Subject: [PATCH] [YAMLParser] Unfold multi-line scalar values Long scalar values

[Lldb-commits] [clang-tools-extra] [llvm] [clang] [compiler-rt] [flang] [lldb] [lld] [libcxx] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-01 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/70898 >From 113c03bbf773c71d329ab2afd063753365e4ac68 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 26 Oct 2023 13:19:08 -0700 Subject: [PATCH] [YAMLParser] Unfold multi-line scalar values Long scalar values

[Lldb-commits] [lldb] f13ce15 - [DebugInfo] Rename getOffset() to getContribution(). NFC.

2020-04-03 Thread Igor Kudrin via lldb-commits
Author: Igor Kudrin Date: 2020-04-03T14:15:53+07:00 New Revision: f13ce15d441095493030404ab31eddb0fc08ca42 URL: https://github.com/llvm/llvm-project/commit/f13ce15d441095493030404ab31eddb0fc08ca42 DIFF: https://github.com/llvm/llvm-project/commit/f13ce15d441095493030404ab31eddb0fc08ca42.diff L

[Lldb-commits] [lldb] a0249fe - [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.

2020-04-06 Thread Igor Kudrin via lldb-commits
Author: Igor Kudrin Date: 2020-04-06T13:28:06+07:00 New Revision: a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb URL: https://github.com/llvm/llvm-project/commit/a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb DIFF: https://github.com/llvm/llvm-project/commit/a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb.diff L

[Lldb-commits] [lldb] r368033 - Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)

2019-10-04 Thread Igor Kudrin via lldb-commits
Author: ikudrin Date: Tue Aug 6 06:38:27 2019 New Revision: 368033 URL: http://llvm.org/viewvc/llvm-project?rev=368033&view=rev Log: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5) Differential Revision: https://reviews.llvm.org/D65640 Modified: lldb/trunk/source/Plu

[Lldb-commits] [lldb] 9a952fd - [LLDB] Fix build failures after removing Version from DWARFExpression.

2020-01-27 Thread Igor Kudrin via lldb-commits
Author: Igor Kudrin Date: 2020-01-27T19:33:34+07:00 New Revision: 9a952fd462774e79d8dc514d71bf43ea0ca7f429 URL: https://github.com/llvm/llvm-project/commit/9a952fd462774e79d8dc514d71bf43ea0ca7f429 DIFF: https://github.com/llvm/llvm-project/commit/9a952fd462774e79d8dc514d71bf43ea0ca7f429.diff L

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-08 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > To make the test more representative, I suggeest replacing the `removeFile()` > method with the following: Thanks! I've updated the test as you suggested. https://github.com/llvm/llvm-project/pull/111237 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111237 >From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Oct 2024 23:27:04 -0700 Subject: [PATCH 1/2] [lldb] Fix and re-enable TestUseSourceCache.py The decorato

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111483 >From bb594335d05a4c8cb2949556f5b338242a9b5280 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Mon, 7 Oct 2024 22:07:02 -0700 Subject: [PATCH 1/2] [lldb] Fix TestGlobalModuleCache.py for remote debugging `S

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-08 Thread Igor Kudrin via lldb-commits
@@ -111,6 +111,8 @@ def do_test(self, one_target, one_debugger): else: if one_target: new_debugger = lldb.SBDebugger().Create() +if lldb.selected_platform is not None: +new_debugger.SetSelectedPlatform(lldb

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111483 >From bb594335d05a4c8cb2949556f5b338242a9b5280 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Mon, 7 Oct 2024 22:07:02 -0700 Subject: [PATCH 1/2] [lldb] Fix TestGlobalModuleCache.py for remote debugging `S

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111237 >From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Oct 2024 23:27:04 -0700 Subject: [PATCH] [lldb] Fix and re-enable TestUseSourceCache.py The decorators c

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-12 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111951 >From e027444340be4020002126da0d2c8a705c2c7e3f Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 10 Oct 2024 20:27:10 -0700 Subject: [PATCH 1/2] [lldb] Speed up FindInMemory tests A memory region can be

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111951 A memory region can be relatively large. Searching for a value in the entire region is time-consuming, especially when running tests against a remote target, because the memory data is transferred in small c

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: So the test basically shows that it makes sense to set `use-source-cache` to `false` on Windows, otherwise the source file will be locked for editing. Windows 11 seems to allow deleting mmaped files, so we need to try opening the file for writing to re-enable the test. Thanks

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin edited https://github.com/llvm/llvm-project/pull/111237 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111237 >From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Oct 2024 23:27:04 -0700 Subject: [PATCH 1/2] [lldb] Fix and re-enable TestUseSourceCache.py The decorato

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin edited https://github.com/llvm/llvm-project/pull/111951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111951 >From e027444340be4020002126da0d2c8a705c2c7e3f Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 10 Oct 2024 20:27:10 -0700 Subject: [PATCH] [lldb] Speed up FindInMemory tests A memory region can be rela

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111237 >From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Oct 2024 23:27:04 -0700 Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py The decorato

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111237 >From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Oct 2024 23:27:04 -0700 Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py The decorato

[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)

2024-10-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/111231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-11 Thread Igor Kudrin via lldb-commits
@@ -6,27 +6,30 @@ UNALIGNED_INSTANCE_PATTERN_HEAP = ALIGNED_INSTANCE_PATTERN_HEAP[1:] -def GetAlignedRange(test_base): +def GetAlignedRange(test_base, shrink=False): frame = test_base.thread.GetSelectedFrame() ex = frame.EvaluateExpression("aligned_string_ptr")

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-04 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111237 The decorators caused the main test, i.e. `test_set_use_source_cache_true()`, to be skipped in most scenarios. It was only run on a Windows host targeting a non-Windows remote platform, and it failed in this

[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)

2024-10-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > Looks good, I guess. Is that constructor even necessary, given that it just > forwards the argument to the base class, and we already have the forwarding > `using` declaration? The constructor looks redundant at the moment, perhaps it is just a legacy from the early stages

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > As I understand it, Android Studio was setting `use-source-cache:=false` so > that users can continue to edit files on windows while lldb has them open. > > Judging by this patch, that may no longer be necessary. Or does that only > apply for certain situations (certain win

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > I don't see any relevant changes on those files, so I don't know the where > `openNativeFileInternal()` comes into the picture. `getFileAux()` calls `openNativeFileForRead()` first and then passes the file descriptor to `getOpenFileImpl()`. `openNativeFileForRead()` eventu

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

2024-10-21 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin edited https://github.com/llvm/llvm-project/pull/113251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

2024-10-21 Thread Igor Kudrin via lldb-commits
@@ -6,3 +6,6 @@ include Makefile.rules # Copy file into the build folder to enable the test to modify it. main-copy.cpp: main.cpp cp -f $< $@ +ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows igorkudrin wrote: If I understand correctly, w

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-09 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/111483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-07 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111483 `SBDebugger().Create()` returns a debugger with only the host platform in its platform list. If the test suite is running for a remote platform, it should be explicitly added and selected in the new debugger

[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)

2024-10-04 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111231 This fixes a build error with msvc for code introduced in #106442: ``` ...\lldb\source\Expression\DiagnosticManager.cpp(37): error C2668: 'llvm::ErrorInfo::ErrorInfo': ambiguous call to overloaded function

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

2024-10-22 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/113251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-09-18 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: Hi @JDevlieghere, This change causes diagnostic messages to be duplicated on Windows. For example: ``` > yaml2obj.exe lldb\test\Shell\ObjectFile\ELF\minidebuginfo-no-lzma.yaml -o > t.obj > lldb-new.exe (lldb) target create t.obj (x86_64) C:\tmp\t.obj No LZMA support found for

[Lldb-commits] [lldb] [lldb/platform-gdb] Do not assume a persistent connection (PR #131736)

2025-03-18 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/131736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/platform-gdb] Do not assume a persistent connection (PR #131736)

2025-03-18 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/131736 After https://reviews.llvm.org/D116539, when `m_gdb_client_up` in `PlatformRemoteGDBServer` is not null, the connection to a server is expected to exist. However, `PlatformRemoteGDBServer::DisconnectRemote()

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-03-18 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/131979 An invalid RLE sequence in the received packet could result in an out-of-bounds reading that could cause a crash. >From 239aeaa5686350681dc79cad63d5aae5a5f2310a Mon Sep 17 00:00:00 2001 From: Igor Kudrin Da

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-03-19 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/131979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-12 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/139196 >From 499f723c3f974ff53deb8f354d879e0baaa7a9e8 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 7 May 2025 19:55:07 -0700 Subject: [PATCH 1/4] [lldb][core] Fix getting summary of a variable pointing to

[Lldb-commits] [lldb] [lldb][NFC] Avoid an assertion failure in dwim-print (PR #139197)

2025-05-09 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/139197 >From 3faf0c0a4a19d7e1d503c31a684d79295e414be4 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 8 May 2025 18:37:34 -0700 Subject: [PATCH 1/2] [lldb][NFC] Avoid an assertion failure in dwim-print In a D

[Lldb-commits] [lldb] [lldb][NFC] Avoid an assertion failure in dwim-print (PR #139197)

2025-05-09 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/139197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-09 Thread Igor Kudrin via lldb-commits
@@ -735,14 +735,25 @@ size_t ValueObject::GetPointeeData(DataExtractor &data, uint32_t item_idx, case eAddressTypeLoad: { ExecutionContext exe_ctx(GetExecutionContextRef()); Process *process = exe_ctx.GetProcessPtr(); - if (process) { + if (process &&

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-09 Thread Igor Kudrin via lldb-commits
@@ -735,14 +735,25 @@ size_t ValueObject::GetPointeeData(DataExtractor &data, uint32_t item_idx, case eAddressTypeLoad: { ExecutionContext exe_ctx(GetExecutionContextRef()); Process *process = exe_ctx.GetProcessPtr(); - if (process) { + if (process &&

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-09 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/139196 >From 499f723c3f974ff53deb8f354d879e0baaa7a9e8 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 7 May 2025 19:55:07 -0700 Subject: [PATCH 1/3] [lldb][core] Fix getting summary of a variable pointing to

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-09 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: Yes, the program file contains the debug information and the read-only section with the data, so both the core and program files are required. And there are no core files with the same properties already committed. The program is built from

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/139196 Motivation example: ``` > lldb -c altmain2.core ... (lldb) var F (const char *) F = 0x0804a000 "" ``` The variable `F` points to a read-only memory page not dumped to the core file, so `Process::ReadMemory(

[Lldb-commits] [lldb] [lldb][NFC] Avoid an assertion failure in dwim-print (PR #139197)

2025-05-08 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/139197 In a Debug build on Windows, printing inline diagnostics resulted in an error, for example: ``` > cd llvm-project\lldb\test\API\functionalities\postmortem\elf-core > lldb.exe -c altmain.core > p dummy LLDB d

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-20 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/139196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-19 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: Ping. https://github.com/llvm/llvm-project/pull/139196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits