https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/111231
This fixes a build error with msvc for code introduced in #106442:
```
...\lldb\source\Expression\DiagnosticManager.cpp(37): error C2668:
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo':
ambiguous call to overloaded function
...\llvm\include\llvm/Support/Error.h(357): note: could be
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo(std::error_code)',
which inherits
'lldb_private::CloneableECError::CloneableECError(std::error_code)' via base
class 'lldb_private::ExpressionErrorBase'
...\llvm\include\llvm/Support/Error.h(357): note: or
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo(std::error_code,std::string)',
which inherits
'lldb_private::ExpressionErrorBase::ExpressionErrorBase(std::error_code,std::string)'
via base class 'lldb_private::ExpressionErrorBase'
...\lldb\source\Expression\DiagnosticManager.cpp(37): note: while trying to
match the argument list '(std::error_code)'
```
>From 2a8ae2cdca39184cc862e3ceee13c1c1275953c9 Mon Sep 17 00:00:00 2001
From: Igor Kudrin <ikud...@accesssoftek.com>
Date: Fri, 4 Oct 2024 22:02:23 -0700
Subject: [PATCH] [lldb][NFC] Fix a build failure with MSVC
Building the original code failed with an error:
```
...\lldb\source\Expression\DiagnosticManager.cpp(37): error C2668:
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo':
ambiguous call to overloaded function
...\llvm\include\llvm/Support/Error.h(357): note: could be
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo(std::error_code)',
which inherits
'lldb_private::CloneableECError::CloneableECError(std::error_code)' via base
class 'lldb_private::ExpressionErrorBase'
...\llvm\include\llvm/Support/Error.h(357): note: or
'llvm::ErrorInfo<lldb_private::ExpressionError,lldb_private::ExpressionErrorBase>::ErrorInfo(std::error_code,std::string)',
which inherits
'lldb_private::ExpressionErrorBase::ExpressionErrorBase(std::error_code,std::string)'
via base class 'lldb_private::ExpressionErrorBase'
...\lldb\source\Expression\DiagnosticManager.cpp(37): note: while trying to
match the argument list '(std::error_code)'
```
---
lldb/include/lldb/Utility/Status.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lldb/include/lldb/Utility/Status.h
b/lldb/include/lldb/Utility/Status.h
index 3910c26d115a09..2911ffb804c6fb 100644
--- a/lldb/include/lldb/Utility/Status.h
+++ b/lldb/include/lldb/Utility/Status.h
@@ -83,8 +83,7 @@ class ExpressionErrorBase
: public llvm::ErrorInfo<ExpressionErrorBase, CloneableECError> {
public:
using llvm::ErrorInfo<ExpressionErrorBase, CloneableECError>::ErrorInfo;
- ExpressionErrorBase(std::error_code ec, std::string msg = {})
- : ErrorInfo(ec) {}
+ ExpressionErrorBase(std::error_code ec) : ErrorInfo(ec) {}
lldb::ErrorType GetErrorType() const override;
static char ID;
};
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
