[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb edited the summary of this revision. hhb added a reviewer: labath. This change allows a hard coded relative PYTHONHOME setting. So that python can easily be packaged together with lldb. T

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245206. hhb marked 5 inline comments as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245211. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Plugins/ScriptInterpre

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb added a comment. > Can we maybe rename it to something like that? LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy to rename it. But that may break people who already set this flag. Is there a standard procedure to do this? Maybe add the new one and remove the old one a year later? Or m

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:298 +llvm::sys::path::append(path, lldb_python_home); +llvm::sys::path::remove_dots(path, /* remove_dot_dots = */

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245499. hhb added a comment. Rename LLDB_RELOCATABLE_PYTHON to LLDB_EMBED_PYTHON_HOME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245750. hhb added a comment. Move option() into if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Plugins/Script

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245770. hhb added a comment. The code should check on LLDB_EMBED_PYTHON_HOME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb90628b5f7: Allow customized relative PYTHONHOME (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D747

[Lldb-commits] [PATCH] D74998: Allow customized relative PYTHONHOME (Attemp 1)

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This is another attempt of 0bb90628b5f7c170689d2d3f019af773772fc649 . The difference is that g_python_home is not declared

[Lldb-commits] [PATCH] D74998: Allow customized relative PYTHONHOME (Attemp 1)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec3f62f0a0b: Allow customized relative PYTHONHOME (Attemp 1) (authored by hhb). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

This revision was automatically updated to reflect the committed changes. Closed by commit rL373668: [lldb] Calculate relative path for symbol links (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

hhb updated this revision to Diff 223117. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67988/new/ https://reviews.llvm.org/D67988 Files: lldb/scripts/Python/finishSwigPythonLLDB.py lldb/scripts/finishSwigWrapp

[Lldb-commits] [PATCH] D68442: [lldb] Remove unused variables.

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Fixes the comment in https://reviews.llvm.org/D67993 [lldb] Unifying lldb python path There are 3 places where python site-package path is calculated independently: 1. finishSwigPythonLLDB.p

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223135. hhb added a comment. Fix description.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Pyt

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223346. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Python/finishS

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_PREFI

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked an inline comment as not done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_P

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked 3 inline comments as done and an inline comment as not done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223638. hhb marked an inline comment as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb added a comment. In D68442#1698053 , @mgorny wrote: > Cool work. I presume you've tested it. I can test it tomorrow if you need me > to. However, I can do that after the commit. I'm doing a final round of testing on linux/darwin/windows(mingw). I'll

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223689. hhb added a comment. Converts python output path to cmake format. This looks like a bug on windows exists before this change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223701. hhb added a comment. Reverts the change related to python dir for windows. FileSpec should always contain normalized path. I.e. using '/' even in windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb closed this revision. hhb added a comment. This is merged as 61f471a and 0016b45 . Closing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224159. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ==

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb created this revision. hhb added a reviewer: tatyana-krasnukha. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 224159. hhb added a comment. Fix format Fixes issue like D68719 Repository: rG

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

hhb added a comment. I think this is caused by D68442 . Can you check whether D68728 fixes it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68719/new/ https://reviews.llvm.org/D68719 __

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224166. hhb added a comment. Simplify the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1a509417714d: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR (authored by hhb). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > This command produces an inco

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) hhb wrote: > tatyana-krasnukha wrote: > > This command p

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Makes the indent consistent to other part of the file. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68842 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9900dff3c0: Clean up format in cmake file (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224545. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lldb/

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224544. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: l

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb created this revision. hhb added a project: LLDB. hhb updated this revision to Diff 224544. hhb added a comment. hhb updated this revision to Diff 224545. Fix format hhb added a comment. Rebase This is another attempt of D67993 . This change removed hard

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224546. hhb added a comment. Remove tailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLL

[Lldb-commits] [PATCH] D68878: [lldb] Fix python packages install path

hhb created this revision. hhb added a reviewer: mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68878 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68878: [lldb] Fix python packages install path

This revision was automatically updated to reflect the committed changes. Closed by commit rG6aacd9687543: [lldb] Fix python packages install path (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68878/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > tatyana-krasnukha wrote: > >

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224648. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224649. hhb added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lld

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224647. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224707. hhb added a comment. Adds VERBATIM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224954. hhb added a comment. Fix the build for multi-config generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/fi

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224955. hhb added a comment. Oops fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Inde

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked 3 inline comments as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:244 + else() +set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}") + endif() tatyana-krasnukha wrote: > This command still pr

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

hhb requested changes to this revision. hhb added a comment. This revision now requires changes to proceed. Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked an inline comment as done. hhb added a comment. In D68858#1709458 , @tatyana-krasnukha wrote: > Build and installation completed successfully! LGTM, though it would be good > if anyone tests this with Xcode. I just tested Xcode. For xcode LL

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb accepted this revision. hhb added a comment. In D68910#1710009 , @llunak wrote: > How about this one? This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the implementat

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> print(distutils.sysconfig.get_python_lib(True, False, '')) lib64/python3.6/site-packages >>> print

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. One additional statement in openSUSE comparing to standard python: libdir = plat_specific and get_config_var("platlibdir") or "lib" Hmmm basically what does platform dependent mean... Anyway this change looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D68858?vs=224955&id=225123#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Move the copy of six.py, lldb.py and macosx/heap Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69016 Files: lldb/CMakeLists.txt lldb/scri

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb created this revision. hhb added a project: LLDB. hhb planned changes to this revision. This is the last part. And we can remove the python script. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb added a comment. In D69016#1710466 , @mgorny wrote: > I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less > control than separate targets) but overall this seems a good change. > Replacing ~250 lines of reinventing the wheel with

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225268. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py lldb/scripts/Py

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225266. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py lldb/scripts/Py

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D69016?vs=225151&id=225270#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1721867 , @labath wrote: > I'm sorry, this dropped off my radar. The only question I have here is about > the createPythonInit.py script. If we're moving stuff to cmake, I am > wondering if we shouldn't move that thing too?

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1722063 , @labath wrote: > Right. I see what you mean. > > But... does this have to happen at build time? Since the list of files is > already known at configuration time, you should be able to generate the files > in the "

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 226781. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py lldb/scripts/Py

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG99046b873f7f: [lldb] move package generation from python to cmake (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://review

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This makes all dependencies correct. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index: lldb/scripts/CM

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb marked an inline comment as done. hhb added a comment. In D69589#1726812 , @labath wrote: > This looks reasonable to me. I'm just wondering, now that these are separate > targets, I guess that means they can be run in random order, right? Will that >

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This avoids config time dependencies on liblldb. And enables other refactoring. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69630 Files:

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227145. hhb added a comment. Update one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake lldb/cm

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227172. hhb added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227204. hhb added a comment. When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6958

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1731782 , @aadsm wrote: > I fixed this locally by doing this (this fix doesn't really feel good but not > sure what's the best way to do it): I found it confusing too. So finish_swig should depends on liblldb, because at

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. See D68370 . We probably need to do the same thing for darwin... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb created this revision. hhb added a reviewer: aadsm. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Similar to D68370 but for darwin framework build. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69834 Files

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Sent D69834 . Haven't get a chance to test but you can see the idea... Also please add lldb-python-scripts to your LLVM_DISTRIBUTION_COMPONENTS when testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a79e083a0d1: [lldb] Add a install target for lldb python on darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/ https://revi

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb updated this revision to Diff 227956. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/ https://reviews.llvm.org/D69834 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ==

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227958. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLis

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227974. hhb added a comment. Fix some naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index: lldb/scripts

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1733567 , @aadsm wrote: > @hhb fwiw, I still get the same error with this diff (after applying it on > top of D69834 ). But D69834 > by itself works great!

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1734818 , @aadsm wrote: > @hhb I just did, and get the same error as well :( > `ninja: error: 'bin/LLDB.framework/LLDB', needed by > 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known > rule to make

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

hhb added a comment. In D69931#1736607 , @labath wrote: > In principle, this looks pretty similar to D67942 > , and my opinion on it is the same -- I > don't think we should be in the business of trying to package the tra

[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The main CMake file don't have a project() call. In this case, cmake will run a dummy project(Project ) at the very beginning. Even before cmake_minimum_required. And a series of compiler det

[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

This revision was automatically updated to reflect the committed changes. Closed by commit rL367273: [CMake] Move project() call to main CMake file (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem.cpp lldb/source/Initializati

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the > `#define` instead of executing

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213448. hhb marked 4 inline comments as done. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/Pos

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213505. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL368069: Various build fixes for lldb on MinGW (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in Platform.h, or anywhere else in lldb. This change fixes that.

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb added a comment. I'm not really know how this works before, given no one includes Config.h. Or maybe sys/types.h is never needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 _

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213688. hhb added a comment. Remove test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Host/

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213687. hhb added a comment. Remove a test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Ho

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213689. hhb added a comment. Herald added a subscriber: mstorsjo. Add one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerat

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213726. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Host/Conf

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D65822?

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb created this revision. hhb added a reviewer: labath. hhb added a project: LLDB. Herald added a subscriber: lldb-commits. This test doesn't make sense. Change to be consistent with what we did in GDBRemoteCommunication.cpp. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6596

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb updated this revision to Diff 214212. hhb added a comment. And we should really include Config.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65965/new/ https://reviews.llvm.org/D65965 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemote

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

This revision was automatically updated to reflect the committed changes. Closed by commit rL368352: [lldb] Fix HAVE_LIBCOMPRESSION (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D65965?v

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

hhb created this revision. hhb added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. hhb added a subscriber: kongyi. This fixes lldb build on macOS SDK prior to 10.12. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66034 Files:

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368496: Detects whether RESOURCE_TYPE_IO is defined. (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

  1   2   >