hhb added inline comments.
================ Comment at: finishSwigPythonLLDB.py:380 - strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) - strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) ---------------- tatyana-krasnukha wrote: > tatyana-krasnukha wrote: > > hhb wrote: > > > hhb wrote: > > > > tatyana-krasnukha wrote: > > > > > This command produces an incorrect path for Visual Studio since it > > > > > concatenates the root build directory with 'bin/liblldb.dll' > > > > > bypassing configuration name. > > > > Hmm understood. The origin change is reverted in rG958091c209d0. So I > > > > don't think this is relevant any more. I'll redo the change. Can you > > > > help test that time? I don't have a visual studio... > > > Sorry rGc0da1282fc036908cc721ee74f574fbb99d5e506 > > Yes, now it works well > > Can you help test that time? I don't have a visual studio... > > Yes, of course! > > BTW, I suppose that '--cmakeBuildConfiguration' option can fix the issue for > XCode too. > > It does. But we have some other issue when LLDB_BUILD_FRAMEWORK is enabled. Sent D68858. Wish it goes well this me. 😊 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68719/new/ https://reviews.llvm.org/D68719 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
