0001-Fix-parsing-of-IPv6-host-port-inside-brackets.patch
Description: Binary data
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emrekultursay wrote:
> With this in mind, deleting the file is representative of an editor wanting
> to save the file using the deletion strategy,...
Yes. I had meant it is not representative of what Android Studio (or _some_
editors) does.
> think it's not our goal here to ensure the editor
emrekultursay wrote:
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/111237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emrekultursay wrote:
OK, I figured the problem. In the test, we call `os.removeFile()` which does
not actually represent the real end-user use-case (which is to edit the file
and save it).
Empirically, on Windows 11, I can verify that when LLDB mmaps these large
files, then:
1. I can appen
emrekultursay wrote:
> it failed in this case because the source file is opened with the
> `FILE_SHARE_DELETE` share mode, which allows the file to be removed, see
> `llvm::sys::fs::openNativeFileInternal()` in
> `llvm/lib/Support/Windows/Path.inc`.
Was there an LLDB change about how it open
emrekultursay wrote:
On the Android Studio side, we don't run tests on old API levels. We only run
automated on latest API levels (and some best-effort manual tests on recent-ish
API levels). Different features in Android Studio have different min-API
requirements. To me, it seems OK to add "A
https://github.com/emrekultursay created
https://github.com/llvm/llvm-project/pull/136466
Commits 82ee31f and 2e89312 added socket sharing, but only for unix domain
sockets. That broke Android, which uses unix-abstract sockets.
>From 950bafe1b6b900384b8d0f925f1cdab19a2c8e3d Mon Sep 17 00:00:00
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/2] Fix connecting via abstract socket
Commit 82ee31f an
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/2] Fix connecting via abstract socket
Commit 82ee31f an
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/4] Fix connecting via abstract socket
Commit 82ee31f an
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/3] Fix connecting via abstract socket
Commit 82ee31f an
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
emrekultursay wrote:
Done by
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
-
+ Log *log = GetLog(LLDBLog::Platform);
https://github.com/emrekultursay commented:
PTAL. I added unit tests for the method, but I'm open to suggestions on how to
improve that test.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
@@ -31,8 +31,11 @@ class DomainSocket : public Socket {
std::vector GetListeningConnectionURI() const override;
+ static Socket *Create(NativeSocket sockfd, bool should_close, Status &error);
emrekultursay wrote:
Done.
https://github.com/llvm/llvm-projec
@@ -182,3 +191,20 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+llvm::Expected>
+DomainSocket::FromBoundNativeSocket(NativeSocket sockfd, bool should_close) {
+#ifdef __linux__
+ // Check
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) {
}
#endif
+#if LLDB_ENABLE_POSIX
emrekultursay wrote:
Done.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) {
}
#endif
+#if LLDB_ENABLE_POSIX
+TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
+ // Generate a name for the domain socket.
+ llvm::SmallString<64> name;
+ std::error_code EC = llvm::sys::fs::createUniq
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) {
}
#endif
+#if LLDB_ENABLE_POSIX
+TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
+ // Generate a name for the domain socket.
+ llvm::SmallString<64> name;
+ std::error_code EC = llvm::sys::fs::createUniq
https://github.com/emrekultursay commented:
Thanks. PTAL.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) {
}
#endif
+#if LLDB_ENABLE_POSIX
+TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
+ // Generate a name for the domain socket.
+ llvm::SmallString<64> name;
+ std::error_code EC = llvm::sys::fs::createUniq
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/5] Fix connecting via abstract socket
Commit 82ee31f an
emrekultursay wrote:
Thanks folks:
1. Can you please squash-and-merge this PR? (I don't have write permissions)
2. Would you like me to create a cherry-pick into release/20.x branch, or is
there a separate process for cherry-picks (e.g., wait some time to validate,
submit a cherry-pick request
emrekultursay wrote:
We're getting `SetSockAddr` error which can only fail if the path is too long.
The path generated by `createUniqueDirectory` is an absolute path to a
temporary directory. I guess it can be longer than 107 bytes on the CI machines.
All the other DomainSocket related tests s
https://github.com/emrekultursay created
https://github.com/llvm/llvm-project/pull/137405
To fix the test failures introduced in Commit 488eeb3
>From d7ab4d2f439e63a6145d83f0017f6e56dd2e37f9 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri, 25 Apr 2025 22:04:28 +
Subject: [PATCH] Sk
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/137405
>From 65de31524033192d1c14af29b70b8f32bac3be55 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri, 25 Apr 2025 22:04:28 +
Subject: [PATCH] Skip tests if socket name is longer than 107 bytes
To fi
@@ -455,37 +455,33 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
-
+ Log *log = GetLog(LLDBLog::Platform);
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/137405
>From 65de31524033192d1c14af29b70b8f32bac3be55 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri, 25 Apr 2025 22:04:28 +
Subject: [PATCH 1/2] Skip tests if socket name is longer than 107 bytes
T
https://github.com/emrekultursay created
https://github.com/llvm/llvm-project/pull/137414
Windows doesn't have domain sockets, so we must properly #ifdef the code that
touches DomainSocket.
>From fb1ced0cd73fbd3844a887d064cf319b27d2a237 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri,
emrekultursay wrote:
Thanks. Are the following patches good enough, or do we prefer a revert?
- Test fix: https://github.com/llvm/llvm-project/pull/137405
- Windows fix: https://github.com/llvm/llvm-project/pull/137414
https://github.com/llvm/llvm-project/pull/136466
__
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/137414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From 2aedf974b8743b9291fbd333af2eaa6d4d5cadcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH] Fix connecting via abstract socket
Commits 82ee31f and 2
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH] Fix connecting via abstract socket
Commit 82ee31f and Co
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From fd514c43019e25f36e12166b7239f7882ea7eca4 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH] Fix connecting via abstract socket
Commit 82ee31f and Co
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emrekultursay wrote:
@slydiman Could you also take a look at this PR, as you are the author of the 2
commits mentioned in the description? Thanks.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
44 matches
Mail list logo
