https://github.com/emrekultursay created
https://github.com/llvm/llvm-project/pull/137414
Windows doesn't have domain sockets, so we must properly #ifdef the code that
touches DomainSocket.
>From fb1ced0cd73fbd3844a887d064cf319b27d2a237 Mon Sep 17 00:00:00 2001
From: Emre Kultursay <emrekultur...@google.com>
Date: Fri, 25 Apr 2025 23:04:27 +0000
Subject: [PATCH] Fix Windows build
Windows doesn't have domain sockets, so we must properly #ifdef
the code that touches DomainSocket.
---
lldb/tools/lldb-server/lldb-platform.cpp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lldb/tools/lldb-server/lldb-platform.cpp
b/lldb/tools/lldb-server/lldb-platform.cpp
index b9a85370d649c..10d79c63af994 100644
--- a/lldb/tools/lldb-server/lldb-platform.cpp
+++ b/lldb/tools/lldb-server/lldb-platform.cpp
@@ -469,6 +469,7 @@ int main_platform(int argc, char *argv[]) {
if (gdbserver_port) {
socket = std::make_unique<TCPSocket>(sockfd, /*should_close=*/true);
} else {
+#if LLDB_ENABLE_POSIX
llvm::Expected<std::unique_ptr<DomainSocket>> domain_socket =
DomainSocket::FromBoundNativeSocket(sockfd, /*should_close=*/true);
if (!domain_socket) {
@@ -477,6 +478,11 @@ int main_platform(int argc, char *argv[]) {
return socket_error;
}
socket = std::move(domain_socket.get());
+#else
+ WithColor::error() << "lldb-platform child: Unix domain sockets are not "
+ "supported on this platform.";
+ return socket_error;
+#endif
}
GDBRemoteCommunicationServerPlatform platform(socket->GetSocketProtocol(),
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
