Re: [Lldb-commits] [PATCH] D5867: Minimal API support for non-8-bit byte targets

2016-09-08 Thread Ed Maste via lldb-commits
emaste added a comment. This change will no longer apply. Is it still desired? If so, can you please rebase the patch. https://reviews.llvm.org/D5867 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-09-19 Thread Ed Maste via lldb-commits
emaste requested changes to this revision. emaste added a reviewer: emaste. emaste added a comment. This revision now requires changes to proceed. Two requested changes called out in comments above https://reviews.llvm.org/D23977 ___ lldb-commits ma

[Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

2016-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 21 16:08:30 2016 New Revision: 282111 URL: http://llvm.org/viewvc/llvm-project?rev=282111&view=rev Log: Fix -Wcovered-switch-default warning in StackFrame.cpp The switch coveres all possible values. If a new one is added in the future the compiler will start warning,

[Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

2016-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 21 16:14:31 2016 New Revision: 282112 URL: http://llvm.org/viewvc/llvm-project?rev=282112&view=rev Log: Fix integer sign warning from r282105 Modified: lldb/trunk/source/Core/SourceManager.cpp Modified: lldb/trunk/source/Core/SourceManager.cpp URL: http://llvm.o

Re: [Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

2016-09-21 Thread Ed Maste via lldb-commits
On 21 September 2016 at 17:08, Ed Maste via lldb-commits wrote: > Author: emaste > Date: Wed Sep 21 16:08:30 2016 > New Revision: 282111 > > URL: http://llvm.org/viewvc/llvm-project?rev=282111&view=rev > Log: > Fix -Wcovered-switch-default warning in StackFrame.cpp &

[Lldb-commits] [lldb] r282119 - Fix for loop sign fix in r282112 for column = 0

2016-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 21 17:36:51 2016 New Revision: 282119 URL: http://llvm.org/viewvc/llvm-project?rev=282119&view=rev Log: Fix for loop sign fix in r282112 for column = 0 Modified: lldb/trunk/source/Core/SourceManager.cpp Modified: lldb/trunk/source/Core/SourceManager.cpp URL: htt

Re: [Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

2016-09-21 Thread Ed Maste via lldb-commits
On 21 September 2016 at 21:38, Adrian McCarthy wrote: > That fix doesn't look complete: Thanks, I've applied your fix in r282119, and sorry for being hasty with the original change. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

2016-09-21 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282123: Fix typo in lldb --help (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D12158?vs=32567&id=72133#toc Repository: rL LLVM https://reviews.llvm.org/D12158 Files: lldb

[Lldb-commits] [lldb] r282123 - Fix typo in lldb --help

2016-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 21 18:30:36 2016 New Revision: 282123 URL: http://llvm.org/viewvc/llvm-project?rev=282123&view=rev Log: Fix typo in lldb --help Patch by Yacine Belkadi Differential Revision: https://reviews.llvm.org/D12158 Modified: lldb/trunk/tools/driver/Driver.cpp Modified

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6 @@ -5,2 +5,3 @@ FreeBSDSignals.cpp + NetBSDSignals.cpp GDBRemoteSignals.cpp Should keep these in alpha order Comment at: source/Target/UnixSignals.cp

[Lldb-commits] [lldb] r255769 - Man page whitespace/formatting change to appease igor(1)

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 08:59:48 2015 New Revision: 255769 URL: http://llvm.org/viewvc/llvm-project?rev=255769&view=rev Log: Man page whitespace/formatting change to appease igor(1) igor is a tool to detect common problems and style conformance issues in man pages and other documents. Th

[Lldb-commits] [lldb] r255771 - Include -c, -core in the lldb(1) man page

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 09:37:21 2015 New Revision: 255771 URL: http://llvm.org/viewvc/llvm-project?rev=255771&view=rev Log: Include -c, -core in the lldb(1) man page Modified: lldb/trunk/docs/lldb.1 Modified: lldb/trunk/docs/lldb.1 URL: http://llvm.org/viewvc/llvm-project/lldb/trun

[Lldb-commits] [lldb] r255774 - Wrap Notes in --help output to 80 columns

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 09:49:38 2015 New Revision: 255774 URL: http://llvm.org/viewvc/llvm-project?rev=255774&view=rev Log: Wrap Notes in --help output to 80 columns Modified: lldb/trunk/tools/driver/Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp URL: http://llvm.org/viewv

Re: [Lldb-commits] [PATCH] D15582: Improve error handling for `f s #`

2015-12-17 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. LGTM Or if you want show the set of arguments - e.g. ```expected frame-index, got 's 1'``` That might clarify the "too many arguments." http://reviews.llvm.org/D15582 _

[Lldb-commits] [lldb] r256248 - Remove PC -1 offset from FreeBSD arm64 UpdateAfterBreakpoint

2015-12-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 22 09:57:21 2015 New Revision: 256248 URL: http://llvm.org/viewvc/llvm-project?rev=256248&view=rev Log: Remove PC -1 offset from FreeBSD arm64 UpdateAfterBreakpoint It was a copy-and-paste leftover. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/RegisterCon

[Lldb-commits] [lldb] r256250 - Add expectedFailureFreeBSD to tests failing in the same way as on Linux

2015-12-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 22 10:47:04 2015 New Revision: 256250 URL: http://llvm.org/viewvc/llvm-project?rev=256250&view=rev Log: Add expectedFailureFreeBSD to tests failing in the same way as on Linux llvm.org/pr25819 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespac

[Lldb-commits] [lldb] r256268 - Add expectedFailureFreeBSD to an additional thread state test failing on FreeBSD

2015-12-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 22 13:08:46 2015 New Revision: 256268 URL: http://llvm.org/viewvc/llvm-project?rev=256268&view=rev Log: Add expectedFailureFreeBSD to an additional thread state test failing on FreeBSD This new failure has been noted in the existing PR, llvm.org/pr15824 Modified:

[Lldb-commits] [lldb] r256270 - XFAIL TestCppNsImport on FreeBSD

2015-12-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 22 13:10:09 2015 New Revision: 256270 URL: http://llvm.org/viewvc/llvm-project?rev=256270&view=rev Log: XFAIL TestCppNsImport on FreeBSD It has an existing XFAIL annotation for GCC >= 4.9 but it also fails on FreeBSD 10.x with Clang 3.4.1. llvm.org/pr25925 Modified:

[Lldb-commits] [lldb] r256723 - Strip trailing whitespace

2016-01-03 Thread Ed Maste via lldb-commits
Author: emaste Date: Sun Jan 3 19:43:47 2016 New Revision: 256723 URL: http://llvm.org/viewvc/llvm-project?rev=256723&view=rev Log: Strip trailing whitespace (There are changes in the copies of these four files in the FreeBSD base system, and I've changed these ones to reduce gratuitous diffs in

[Lldb-commits] [lldb] r256724 - Remove unused variable

2016-01-03 Thread Ed Maste via lldb-commits
Author: emaste Date: Sun Jan 3 20:10:22 2016 New Revision: 256724 URL: http://llvm.org/viewvc/llvm-project?rev=256724&view=rev Log: Remove unused variable Obtained from FreeBSD r292611 Modified: lldb/trunk/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp Modifie

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-02-02 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: lldb/trunk/source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:308-309 @@ +307,4 @@ + +static std::vector& +GetSharedRegisterInfoVector () +{ Unused function? Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r260330 - Remove FreeBSD failure decorator from TestCppIncompleteTypes

2016-02-09 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Feb 9 18:03:52 2016 New Revision: 260330 URL: http://llvm.org/viewvc/llvm-project?rev=260330&view=rev Log: Remove FreeBSD failure decorator from TestCppIncompleteTypes CFLAGS is now being set correctly to pass -flimit-debug-info or -fno-limit-debug-info on FreeBSD. I'm

[Lldb-commits] [lldb] r260589 - XFAIL TestCommandScriptImmediateOutput on FreeBSD also

2016-02-11 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Feb 11 15:15:49 2016 New Revision: 260589 URL: http://llvm.org/viewvc/llvm-project?rev=260589&view=rev Log: XFAIL TestCommandScriptImmediateOutput on FreeBSD also Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/Tes

[Lldb-commits] [PATCH] D17402: Shuffle an #undef to avoid a warning on FreeBSD

2016-02-18 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added a subscriber: lldb-commits. Herald added a subscriber: emaste. On FreeBSD _LIBCPP_EXTERN_TEMPLATE is being defined from something included by lldb/lldb-private.h. Undefine it later to avoid the redefinition warning. http://reviews.llvm.org/D17402 Files

[Lldb-commits] [lldb] r261266 - Remove expectedFlakeyFreeBSD decorator for prompt setting

2016-02-18 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Feb 18 15:38:24 2016 New Revision: 261266 URL: http://llvm.org/viewvc/llvm-project?rev=261266&view=rev Log: Remove expectedFlakeyFreeBSD decorator for prompt setting The race condition/use after free involved in setting long prompts appears to be fixed now (although I do

Re: [Lldb-commits] [PATCH] D17395: Refactor GetSoftwareBreakpointTrapOpcode

2016-02-18 Thread Ed Maste via lldb-commits
emaste added a comment. Nice work, happy to see this deduplication. Repository: rL LLVM http://reviews.llvm.org/D17395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r261333 - Remove XFAIL from test passing on FreeBSD

2016-02-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Feb 19 10:58:08 2016 New Revision: 261333 URL: http://llvm.org/viewvc/llvm-project?rev=261333&view=rev Log: Remove XFAIL from test passing on FreeBSD Both Linux and FreeBSD had a comment "This needs to be root-caused." It looks like the failure has been fixed on both, and

[Lldb-commits] [lldb] r261339 - Remove XFAIL from test passing on FreeBSD

2016-02-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Feb 19 11:31:05 2016 New Revision: 261339 URL: http://llvm.org/viewvc/llvm-project?rev=261339&view=rev Log: Remove XFAIL from test passing on FreeBSD This is passing for me consistently on FreeBSD 10 and FreeBSD 11. llvm.org/pr15989 Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r261340 - Remove XFAIL from test passing on FreeBSD

2016-02-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Feb 19 11:35:01 2016 New Revision: 261340 URL: http://llvm.org/viewvc/llvm-project?rev=261340&view=rev Log: Remove XFAIL from test passing on FreeBSD There is a report in the PR from several months ago that it failed intermittently, but it is passing consistently for me o

[Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

2016-02-19 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added a reviewer: zturner. emaste added a subscriber: lldb-commits. All invocations are updated to use the generic expectedFailureAll. http://reviews.llvm.org/D17455 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/expr

Re: [Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

2016-02-19 Thread Ed Maste via lldb-commits
emaste updated this revision to Diff 48529. emaste added a comment. Address zturner feedback http://reviews.llvm.org/D17455 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/expression_command/call-function/TestCallStdStringFunction.py packages/Python/lld

Re: [Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

2016-02-19 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27 @@ -25,5 +25,4 @@ @skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test runner -@expectedFailureFreeBSD('llvm.org/pr19011') # N

[Lldb-commits] [lldb] r261355 - Remove expectedFailureFreeBSD decorator

2016-02-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Feb 19 13:25:03 2016 New Revision: 261355 URL: http://llvm.org/viewvc/llvm-project?rev=261355&view=rev Log: Remove expectedFailureFreeBSD decorator All invocations are updated to use the generic expectedFailureAll. Differential Revision: http://reviews.llvm.org/D17455

Re: [Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

2016-02-19 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261355: Remove expectedFailureFreeBSD decorator (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D17455?vs=48529&id=48533#toc Repository: rL LLVM http://reviews.llvm.org/D17455

[Lldb-commits] [PATCH] D18096: accept any build-id length between 4 and 20 bytes inclusive

2016-03-11 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added a reviewer: lldb-commits. There's a proposed patch D18091 adding build-id support to lld that would produce a 64-bit ID. There's some concern as existing tools typically expect the build-id to be either 16 or 20 bytes. Prior to this change lldb would r

Re: [Lldb-commits] [PATCH] D18096: accept any build-id length between 4 and 20 bytes inclusive

2016-03-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263432: Allow any build-id length between 4 and 20 bytes inclusive (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D18096?vs=50464&id=50587#toc Repository: rL LLVM http://revi

[Lldb-commits] [lldb] r263432 - Allow any build-id length between 4 and 20 bytes inclusive

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 09:06:00 2016 New Revision: 263432 URL: http://llvm.org/viewvc/llvm-project?rev=263432&view=rev Log: Allow any build-id length between 4 and 20 bytes inclusive Build-id support is being added to lld and by default it may produce a 64-bit build-id. Prior to this ch

Re: [Lldb-commits] [PATCH] D17972: [TestRegisterVariables] Adjust compiler range in expected failure decorator.

2016-03-14 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. Now failing on FreeBSD: http://llvm.org/pr26937 Repository: rL LLVM http://reviews.llvm.org/D17972 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [Lldb-commits] [lldb] r262970 - [TestRegisterVariables] Adjust compiler range in expected failure decorator.

2016-03-14 Thread Ed Maste via lldb-commits
On 8 March 2016 at 19:02, Siva Chandra via lldb-commits wrote: > Author: sivachandra > Date: Tue Mar 8 18:02:00 2016 > New Revision: 262970 > > -@expectedFailureAll(compiler="clang", compiler_version=['<', '3.5']) > +@expectedFailureAll(compiler="clang", compiler_version=['>', '3.5']) Th

[Lldb-commits] [lldb] r263467 - Enable expectedFailure for all Clang versions in TestRegisterVariables

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 13:59:44 2016 New Revision: 263467 URL: http://llvm.org/viewvc/llvm-project?rev=263467&view=rev Log: Enable expectedFailure for all Clang versions in TestRegisterVariables In r262970 this was changed from xfail Clang < 3.5 to > 3.5, but it still fails on FreeBSD 10

[Lldb-commits] [lldb] r263486 - Shuffle an #undef to avoid a warning on FreeBSD

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 15:39:08 2016 New Revision: 263486 URL: http://llvm.org/viewvc/llvm-project?rev=263486&view=rev Log: Shuffle an #undef to avoid a warning on FreeBSD On FreeBSD _LIBCPP_EXTERN_TEMPLATE is being defined from something included by lldb/lldb-private.h. Undefine it afte

Re: [Lldb-commits] [PATCH] D17402: Shuffle an #undef to avoid a warning on FreeBSD

2016-03-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263486: Shuffle an #undef to avoid a warning on FreeBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D17402?vs=48364&id=50641#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [lldb] r266197 - Match types in for loop to fix signedness comparison warning

2016-04-13 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Apr 13 08:32:06 2016 New Revision: 266197 URL: http://llvm.org/viewvc/llvm-project?rev=266197&view=rev Log: Match types in for loop to fix signedness comparison warning Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL:

Re: [Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-07 Thread Ed Maste via lldb-commits
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits wrote: > Author: slthakur > Date: Fri Aug 7 01:39:38 2015 > New Revision: 244308 > > URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev > Log: > [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 > mode su

Re: [Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-10 Thread Ed Maste via lldb-commits
On 10 August 2015 at 05:13, wrote: > > > Hi Ed, > > We do not require to handle e_void case in GetData() as we have already > checked if bytes_size greater than zero. >> >> 136bool >> 137Scalar::GetData (DataExtractor &data, size_t limit_byte_size) >> const >> 138{ >>

Re: [Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-10 Thread Ed Maste via lldb-commits
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits wrote: > > Author: slthakur > Date: Fri Aug 7 01:39:38 2015 > New Revision: 244308 > > URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev > Log: > [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 > mode

Re: [Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-10 Thread Ed Maste via lldb-commits
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits wrote: > > Author: slthakur > Date: Fri Aug 7 01:39:38 2015 > New Revision: 244308 > > URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev > Log: > [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 > mode

Re: [Lldb-commits] [PATCH] D11987: Fix to handle AArch64 watchpoint exception before instruction being watched is executed

2015-08-12 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:186-187 @@ -186,1 +185,4 @@ +host_arch.GetMachine() == llvm::Triple::mips64el || +host_arch.GetMachine() == llvm::Triple::aarch64 || +ho

Re: [Lldb-commits] [lldb] r245141 - A messy bit of cleanup: Move towards more descriptive names

2015-08-18 Thread Ed Maste via lldb-commits
On 15 August 2015 at 01:21, Jason Molenda via lldb-commits wrote: > > Author: jmolenda > Date: Fri Aug 14 20:21:01 2015 > New Revision: 245141 > > URL: http://llvm.org/viewvc/llvm-project?rev=245141&view=rev > Log: > A messy bit of cleanup: Move towards more descriptive names > for eh_frame and st

Re: [Lldb-commits] [lldb] r245141 - A messy bit of cleanup: Move towards more descriptive names

2015-08-18 Thread Ed Maste via lldb-commits
On 18 August 2015 at 13:16, Ed Maste wrote: > On 15 August 2015 at 01:21, Jason Molenda via lldb-commits > wrote: >> >> Author: jmolenda >> Date: Fri Aug 14 20:21:01 2015 >> New Revision: 245141 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245141&view=rev >> Log: >> A messy bit of cleanup:

Re: [Lldb-commits] [PATCH] D5806: Compiler args patch resubmission

2015-08-30 Thread Ed Maste via lldb-commits
emaste resigned from this revision. emaste removed a reviewer: emaste. emaste added a comment. Please feel free to re-add me if there's a new patch to review; I'm trying to clear out my outstanding review list. http://reviews.llvm.org/D5806 ___ lld

Re: [Lldb-commits] [PATCH] D11099: [ClangASTType] Catch unhandled clang types at compile time

2015-08-30 Thread Ed Maste via lldb-commits
emaste added a comment. This seems fine to me - I agree that as long as we'll catch this e.g. through one compiler on the build bots it should be sufficient. http://reviews.llvm.org/D11099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

Re: [Lldb-commits] [PATCH] D6392: Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

2015-08-30 Thread Ed Maste via lldb-commits
emaste added a comment. What's the next step with this change? http://reviews.llvm.org/D6392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

2015-08-31 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. In http://reviews.llvm.org/D12485#236538, @sas wrote: > Looks like accept4(2) is linux-only. And FreeBSD -- from the man page `The accept4() system call appeared in FreeBSD 10.0.` Repository: rL LLVM http://reviews.llvm.org/D12485

[Lldb-commits] [lldb] r246490 - Remove expectedFailureFreeBSD for passing pexpect tests

2015-08-31 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Aug 31 16:37:15 2015 New Revision: 246490 URL: http://llvm.org/viewvc/llvm-project?rev=246490&view=rev Log: Remove expectedFailureFreeBSD for passing pexpect tests These tests work when run locally. They had been occasionally failing on the FreeBSD buildbot due to pexpect

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 1 September 2015 at 16:02, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Tue Sep 1 15:02:29 2015 > New Revision: 246578 > > URL: http://llvm.org/viewvc/llvm-project?rev=246578&view=rev > Log: > Have the Process hold a weak_ptr to the Target. Hi Zach, would you be able to ma

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 2 September 2015 at 10:55, Zachary Turner wrote: > I'll take a look today, thanks for letting me know Np. I need to get a FreeBSD buildbot back up again; the previous one was taken down because the machine was overloaded (and flaky). ___ lldb-commit

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 2 September 2015 at 12:49, Zachary Turner wrote: > I tried to fix this in r246672. I can't build on FreeBSD so I'm pretty much > just guessing. If this doesn't fix it then please update me with the new > build errors and I'll try again. Great, thanks -- I was able to build it now, and will c

[Lldb-commits] [lldb] r247009 - Exception registers aren't supported outside of Darwin

2015-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 8 08:05:15 2015 New Revision: 247009 URL: http://llvm.org/viewvc/llvm-project?rev=247009&view=rev Log: Exception registers aren't supported outside of Darwin Apply test update from r234992 to FreeBSD Modified: lldb/trunk/test/python_api/lldbutil/iter/TestRegiste

[Lldb-commits] [lldb] r247012 - Remove expectedFailureFreeBSD from passing PluginCommandTestCase::test_load_plugin

2015-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 8 08:27:27 2015 New Revision: 247012 URL: http://llvm.org/viewvc/llvm-project?rev=247012&view=rev Log: Remove expectedFailureFreeBSD from passing PluginCommandTestCase::test_load_plugin This test was failing due to a libc++ vs libsdc++ conflict which should be fixed

[Lldb-commits] [lldb] r247013 - Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD

2015-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 8 08:33:21 2015 New Revision: 247013 URL: http://llvm.org/viewvc/llvm-project?rev=247013&view=rev Log: Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD This test passes locally but was disabled due to pexpect issues o

[Lldb-commits] [lldb] r247024 - Revert "Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD"

2015-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 8 11:35:28 2015 New Revision: 247024 URL: http://llvm.org/viewvc/llvm-project?rev=247024&view=rev Log: Revert "Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD" And update the comment describing the reason this test i

Re: [Lldb-commits] [lldb] r247024 - Revert "Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD"

2015-09-08 Thread Ed Maste via lldb-commits
On 8 September 2015 at 12:35, Ed Maste via lldb-commits wrote: > Author: emaste > Date: Tue Sep 8 11:35:28 2015 > New Revision: 247024 > > URL: http://llvm.org/viewvc/llvm-project?rev=247024&view=rev > Log: > Revert "Enable > S

Re: [Lldb-commits] [PATCH] D12615: Teach utilsOsType about NetBSD

2015-09-08 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. Comment at: scripts/utilsOsType.py:33 @@ -32,2 +32,3 @@ "FreeBSD", +"NetBSD", "Linux", Please keep these in alpha order (other than Unknown at the top) Repository: rL LLVM h

[Lldb-commits] [lldb] r247141 - XFAIL TestFormatters on FreeBSD

2015-09-09 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 9 08:10:33 2015 New Revision: 247141 URL: http://llvm.org/viewvc/llvm-project?rev=247141&view=rev Log: XFAIL TestFormatters on FreeBSD The test is hitting an assertion in Clang. This is an extension of r246766. llvm.org/pr24691 Modified: lldb/trunk/test/expres

[Lldb-commits] [lldb] r247143 - Update expectedFailureFreeBSD to expectedFlakeyFreeBSD for intermittent tests

2015-09-09 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 9 08:15:14 2015 New Revision: 247143 URL: http://llvm.org/viewvc/llvm-project?rev=247143&view=rev Log: Update expectedFailureFreeBSD to expectedFlakeyFreeBSD for intermittent tests Due to LLDB or test race conditions these tests do not pass consistently. llvm.org/pr

Re: [Lldb-commits] [lldb] r247173 - Don't allow duplicate names for tests.

2015-09-09 Thread Ed Maste via lldb-commits
On 9 September 2015 at 14:25, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Wed Sep 9 13:25:13 2015 > New Revision: 247173 > > URL: http://llvm.org/viewvc/llvm-project?rev=247173&view=rev > Log: > Don't allow duplicate names for tests. > > We had 2 tests named TestCPPBreakpoint

[Lldb-commits] [lldb] r247190 - For now skip ThreadSpecificBreakTestCase on FreeBSD

2015-09-09 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 9 16:00:10 2015 New Revision: 247190 URL: http://llvm.org/viewvc/llvm-project?rev=247190&view=rev Log: For now skip ThreadSpecificBreakTestCase on FreeBSD It often hangs or times out, and obscures issues with other tests. Just skip it for now (until the FreeBSD test

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-10 Thread Ed Maste via lldb-commits
emaste added a comment. In http://reviews.llvm.org/D12659#243729, @krytarowski wrote: > In http://reviews.llvm.org/D12659#243415, @sas wrote: > > > > > > To something more generic: > > // Some platforms will occasionally send nonstandard spurious SI_KERNEL > codes. > // One way to get this i

Re: [Lldb-commits] [PATCH] D12762: Clean up building & linking of Process/elf-core.

2015-09-10 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. LGTM too http://reviews.llvm.org/D12762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

2015-09-10 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. Comment at: source/Host/posix/PipePosix.cpp:39 @@ -38,3 +38,3 @@ -// pipe2 is supported by Linux, FreeBSD v10 and higher. +// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer // TODO: Add more platforms that support pi

[Lldb-commits] [lldb] r247411 - Demote TestAttachResume back to @expectedFailureFreeBSD

2015-09-11 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Sep 11 08:43:07 2015 New Revision: 247411 URL: http://llvm.org/viewvc/llvm-project?rev=247411&view=rev Log: Demote TestAttachResume back to @expectedFailureFreeBSD It turns out it fails consistently for me. llvm.org/pr19310 Modified: lldb/trunk/test/functionalities/

[Lldb-commits] [PATCH] D12830: Limit scope of RegisterContextPOSIX.h header

2015-09-12 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added reviewers: tfiala, labath. emaste added a subscriber: lldb-commits. Herald added a subscriber: emaste. RegisterContextPOSIX.h is poorly named and contains only the declaration of POSIXBreakpointProtocol, which is used for in-process live kernel debugging

[Lldb-commits] [lldb] r247558 - Limit scope of RegisterContextPOSIX.h header

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 08:16:59 2015 New Revision: 247558 URL: http://llvm.org/viewvc/llvm-project?rev=247558&view=rev Log: Limit scope of RegisterContextPOSIX.h header RegisterContextPOSIX.h is poorly named and contains only the declaration of POSIXBreakpointProtocol, which is used for

Re: [Lldb-commits] [PATCH] D12830: Limit scope of RegisterContextPOSIX.h header

2015-09-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247558: Limit scope of RegisterContextPOSIX.h header (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D12830?vs=34631&id=34666#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r247561 - Move RegisterContextPOSIX.h to FreeBSD subdir

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:20:56 2015 New Revision: 247561 URL: http://llvm.org/viewvc/llvm-project?rev=247561&view=rev Log: Move RegisterContextPOSIX.h to FreeBSD subdir It is now used only by the FreeBSD in-process ptrace implementation. Added: lldb/trunk/source/Plugins/Process/Fre

[Lldb-commits] [lldb] r247562 - Remove expectedFailureFreeBSD from passing test_process_list

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:27:05 2015 New Revision: 247562 URL: http://llvm.org/viewvc/llvm-project?rev=247562&view=rev Log: Remove expectedFailureFreeBSD from passing test_process_list This test passes locally but was marked XFAIL due to failures on the FreeBSD buildbot. That buildbot ha

[Lldb-commits] [lldb] r247563 - Remove expectedFailureFreeBSD from passing test_with_dwarf_formatters_api

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:31:46 2015 New Revision: 247563 URL: http://llvm.org/viewvc/llvm-project?rev=247563&view=rev Log: Remove expectedFailureFreeBSD from passing test_with_dwarf_formatters_api llvm.org/pr24282 Modified: lldb/trunk/test/python_api/formatters/TestFormattersSBAPI.

[Lldb-commits] [lldb] r247564 - Remove expectedFailureFreeBSD from passing test_inferior_asserting_disassemble

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:40:22 2015 New Revision: 247564 URL: http://llvm.org/viewvc/llvm-project?rev=247564&view=rev Log: Remove expectedFailureFreeBSD from passing test_inferior_asserting_disassemble llvm.org/pr18533 Modified: lldb/trunk/test/functionalities/inferior-assert/TestI

[Lldb-commits] [lldb] r247565 - Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:41:58 2015 New Revision: 247565 URL: http://llvm.org/viewvc/llvm-project?rev=247565&view=rev Log: Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD This test passes locally but was disabled due to pexpect issues o

[Lldb-commits] [lldb] r247566 - Add expectedFlakeyFreeBSD to TestMultithreaded tests

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 09:42:22 2015 New Revision: 247566 URL: http://llvm.org/viewvc/llvm-project?rev=247566&view=rev Log: Add expectedFlakeyFreeBSD to TestMultithreaded tests One or more of these tests failed in 25 of 100 dotest.py runs. Modified: lldb/trunk/test/api/multithreaded

[Lldb-commits] Missing enum OMPArraySection case in ClangASTContext::GetEncoding

2015-09-14 Thread Ed Maste via lldb-commits
On 29 June 2015 at 11:17, Ed Maste wrote: > On 24 June 2015 at 19:13, Enrico Granata wrote: >> Author: enrico >> Date: Wed Jun 24 18:13:23 2015 >> New Revision: 240606 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=240606&view=rev >> Log: >> Handle (or at least don't crash) trying to get the

[Lldb-commits] [lldb] r247568 - The pipe2(2) call is supported on NetBSD

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 10:12:49 2015 New Revision: 247568 URL: http://llvm.org/viewvc/llvm-project?rev=247568&view=rev Log: The pipe2(2) call is supported on NetBSD Patch by Kamil Rytarowski. Differential Revision: http://reviews.llvm.org/D12746 Modified: lldb/trunk/source/Host/po

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

2015-09-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247568: The pipe2(2) call is supported on NetBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D12746?vs=34512&id=34674#toc Repository: rL LLVM http://reviews.llvm.org/D1274

Re: [Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

2015-09-14 Thread Ed Maste via lldb-commits
On 14 September 2015 at 12:25, Todd Fiala via lldb-commits wrote: > > Author: tfiala > Date: Mon Sep 14 11:25:34 2015 > New Revision: 247576 > > URL: http://llvm.org/viewvc/llvm-project?rev=247576&view=rev > Log: > Cleaned up a few unexpected successes on OS X > ... > -@expectedFailureClang('1

[Lldb-commits] [lldb] r247594 - Correct XFAIL OS list after r247576

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 13:40:52 2015 New Revision: 247594 URL: http://llvm.org/viewvc/llvm-project?rev=247594&view=rev Log: Correct XFAIL OS list after r247576 In ConstVariableTestCase::test_with_dwarf_and_run_command - the test fails with Clang (and presumably ICC) also on FreeBSD. Mod

[Lldb-commits] [lldb] r247596 - Remove expectedFailureFreeBSD from now-passing test

2015-09-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 14 13:50:23 2015 New Revision: 247596 URL: http://llvm.org/viewvc/llvm-project?rev=247596&view=rev Log: Remove expectedFailureFreeBSD from now-passing test ExprCommandCallUserDefinedFunction::test_with_dwarf llvm.org/pr20274 Modified: lldb/trunk/test/expression

[Lldb-commits] [lldb] r247799 - Remove expectedFailureFreeBSD from passing test

2015-09-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 16 08:55:15 2015 New Revision: 247799 URL: http://llvm.org/viewvc/llvm-project?rev=247799&view=rev Log: Remove expectedFailureFreeBSD from passing test ExprCommandWithTimeoutsTestCase::expectedFailureFreeBSD This test passes locally but was marked XFAIL due to failur

[Lldb-commits] [lldb] r247800 - Remove expectedFailureFreeBSD from passing test

2015-09-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 16 08:59:16 2015 New Revision: 247800 URL: http://llvm.org/viewvc/llvm-project?rev=247800&view=rev Log: Remove expectedFailureFreeBSD from passing test ExprCommandCallUserDefinedFunction::test_with_dwarf llvm.org/pr21142 Modified: lldb/trunk/test/functionalitie

[Lldb-commits] [lldb] r247801 - Remove expectedFailureFreeBSD from passing watchpoint tests

2015-09-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 16 09:05:20 2015 New Revision: 247801 URL: http://llvm.org/viewvc/llvm-project?rev=247801&view=rev Log: Remove expectedFailureFreeBSD from passing watchpoint tests llvm.org/pr18832 Modified: lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/TestWatc

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-16 Thread Ed Maste via lldb-commits
emaste added a comment. In http://reviews.llvm.org/D12899#246881, @tfiala wrote: > @emaste, I'm adding you because I have no idea what the state of the *BSD > world is with regards to lldb-server. It looks like you might still use the > process monitor bits so lldb-server might not be interest

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-16 Thread Ed Maste via lldb-commits
emaste added a comment. In http://reviews.llvm.org/D12899#247074, @zturner wrote: > They're not really dependencies in the normal sense. They're not build dependencies, but they are dependencies in the sense that lldb-server is required for lldb to be usable in the normal use case. In my opin

[Lldb-commits] [lldb] r247822 - Decorate flaky FreeBSD test

2015-09-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Sep 16 13:00:09 2015 New Revision: 247822 URL: http://llvm.org/viewvc/llvm-project?rev=247822&view=rev Log: Decorate flaky FreeBSD test ExprCommandWithTimeoutsTestCase::expectedFailureFreeBSD had an expectedFailureFreeBSD decorator, removed in r247799. It had been flakey

Re: [Lldb-commits] [lldb] r247764 - Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that we can read the global when specified with the global namespace and test that we can r

2015-09-16 Thread Ed Maste via lldb-commits
On 16 September 2015 at 00:42, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Tue Sep 15 19:42:50 2015 > New Revision: 247764 > > URL: http://llvm.org/viewvc/llvm-project?rev=247764&view=rev > Log: > Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that >

Re: [Lldb-commits] [PATCH] D12925: [cmake] Build lldb-server on Darwin, set dep on FreeBSD.

2015-09-17 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. I'm happy with the FreeBSD change. Minor nit, perhaps put in alpha order? http://reviews.llvm.org/D12925 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] r248155 - For now skip go tests that trigger assertion failures on FreeBSD

2015-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 21 08:32:21 2015 New Revision: 248155 URL: http://llvm.org/viewvc/llvm-project?rev=248155&view=rev Log: For now skip go tests that trigger assertion failures on FreeBSD llvm.org/pr24895 Modified: lldb/trunk/test/lang/go/goroutines/TestGoroutines.py lldb/trunk

[Lldb-commits] [lldb] r248157 - XFAIL TestConnectRemote.py on FreeBSD

2015-09-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Sep 21 08:44:57 2015 New Revision: 248157 URL: http://llvm.org/viewvc/llvm-project?rev=248157&view=rev Log: XFAIL TestConnectRemote.py on FreeBSD Test fails with: error: Process 1 was reported after connecting to 'connect://localhost:42922', but no stop reply pack

Re: [Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

2015-09-21 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. LGTM Although it ought to remain on the same line, no? http://reviews.llvm.org/D13022 __

Re: [Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

2015-09-21 Thread Ed Maste via lldb-commits
emaste added a comment. Yes, updated change LGTM. http://reviews.llvm.org/D13022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13028: [RFC] Merge dsym and dwarf test cases

2015-09-21 Thread Ed Maste via lldb-commits
emaste added a comment. Haven't reviewed in depth yet but in general I really like this idea. Comment at: test/lldbtest.py:524 @@ +523,3 @@ +def no_debug_info_test(func): +"""Decorate the item as a test what don't use any debug info. If this annotation is specified +

<    1   2   3   >