[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/18] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/15] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-03-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/132392 The build bot was failing when running remote test from windows to linux. >From 493a5798524361442ab19be4b0a8077910984ffc Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 21 Mar 2025 13:04:29 + Subject

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-20 Thread Ebuka Ezike via lldb-commits
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler { void operator()(const llvm::json::Object &request) const override; }; +class GoToRequestHandler : public RequestHandler { da-viper wrote: are the protocol types meant to follow

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-03-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/132392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Fix test settings JSON check to compare expected path list. (PR #132410)

2025-03-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/132410 Previously, the test compared the JSON output to `setting_value` which was incorrect. Updated the assertion to validate against the correct list of paths `[path1, path2]` to ensure accurate test behavior. Ran

[Lldb-commits] [lldb] [lldb][NFC] Fix test settings JSON check to compare expected path list. (PR #132410)

2025-03-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/132410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-03-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/132392 >From 493a5798524361442ab19be4b0a8077910984ffc Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 21 Mar 2025 13:04:29 + Subject: [PATCH 1/2] [lldb][NFC] use platform independent path separator. The bui

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-03-24 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Sent the commit https://github.com/llvm/llvm-project/pull/131683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-18 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/19] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/131544 The logging markers for incoming ("<--") and outgoing ("-->") messages were incorrectly reversed. from #7790d69 >From bdfcf3a3d15c2c8f72d6a553027287eb0f43a3d4 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date:

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130773 >From 1a70dca11783f11b267d0d144311994dfba79733 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Tue, 11 Mar 2025 13:15:16 + Subject: [PATCH] [lldb][lldb-dap] setVariable request should send the correct res

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-17 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/131544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/131683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 7bad765585b2ae96faf2d2558b099f4b965d2791 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/23] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/131683 >From 6d9b82be9fc681f25967a57a5c23148f3d023022 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 17 Mar 2025 23:54:30 + Subject: [PATCH 1/5] [lldb] Add JSON serialization for FileSpec and FileSpecList

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-06 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/134562 dap console does not recognise `expr` as a command because it is not explicitly set. It works fine in normal lldb because it is gotten from approximate match which is not available in the SBAPI >From be69e12

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-06 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134562 >From be69e129667cac2ab75597bb3ed02f7d6da39bce Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 6 Apr 2025 01:36:12 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] explicitly set the expr as an alias for expr

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 7bad765585b2ae96faf2d2558b099f4b965d2791 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/24] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 7bad765585b2ae96faf2d2558b099f4b965d2791 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/24] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,165 @@ +//===-- GoToTargetsRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,118 @@ +//===-- GoToRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From aa8ce4da16b9cf31974eb32ecefdeab403f3a497 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/25] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From aa8ce4da16b9cf31974eb32ecefdeab403f3a497 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/26] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-26 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper deleted https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-07 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Another solution I could think of is prioritising, the repl command type instead of the repl variable type. in https://github.com/llvm/llvm-project/blob/4607d39c7eded3ff6d425cbc502e30349078365c/lldb/tools/lldb-dap/DAP.cpp#L553-L558 or add the previously defined aliases in doc

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-09 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I think it should be. Most distributions are still on llvm 19 as llvm 20.1 was released last month. Maybe that's why there haven't been any reports. This only affects the 20 and 21 branches. https://github.com/llvm/llvm-project/pull/134626

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-09 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/135008 Fixes #131589 Add a new option to the RunCommands functions to control the echoing of commands >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-28 Thread Ebuka Ezike via lldb-commits
@@ -79,6 +79,27 @@ enum class PacketStatus { enum class ReplMode { Variable = 0, Command, Auto }; +class Gotos { +public: + /// \return the line_entry corresponding with \p id + /// + /// If \p id is invalid std::nullopt is returned. + std::optional GetLineEntry(uint64_t

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,120 @@ +//===-- GoToTargetsRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-07 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134626 >From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 10:24:02 +0100 Subject: [PATCH 1/3] [lldb] Fix SBTarget::ReadInstruction The disassemblyBytes par

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper milestoned https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: /cherry-pick 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e 4be5e33bf7b986e35808b83758e4a8d85b646a81 7417e79323c67ab478a0d41757ebb1679f4cb28c https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134626 >From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 10:24:02 +0100 Subject: [PATCH 1/3] [lldb] Fix SBTarget::ReadInstruction The disassemblyBytes par

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: separate it like this then it does not and it. ``` @skipIf(archs=no_match(["x86_64", "x86", "i386"])) @skipIfWindows ``` https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @DavidSpickett is there a way to run the merge build bot before merging to check if the test passes on other platforms ? https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Macos x86_64 also follows the systemV amd64 abi calling convention. So it should not fail or be skipped. In the linked build bot, I could not see the test (lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py) failing could you link it j

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-07 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/134626 When you call the `SBTarget::ReadInstructions` with flavor from lldb crashes. This is because the wrong order of the `DisassemblyBytes` constructor this fixes that >From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d1

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-07 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I was also wondering if this should be backported as it also affects llvm 20.x branch https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-07 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/134722 Ensure the disassembly respects the "target.x86-disassembly-flavor" setting for x86 and x86_64 targets. Depends on #134626 >From c3b28161884d44d1c0c0e45ef4025bea24bc3bc3 Mon Sep 17 00:00:00 2001 From: Ebuka E

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134562 >From be69e129667cac2ab75597bb3ed02f7d6da39bce Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 6 Apr 2025 01:36:12 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap] explicitly set the expr as an alias for expr

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-13 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > So we need a better solution to this DAP problem than just adding aliases. How about for aliases that are mentioned in the documentation, we explicitly set those as aliases. https://github.com/llvm/llvm-project/pull/134562 ___ lldb-

[Lldb-commits] [lldb] [llvm] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-04-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/135778 Fixes #45326 When you thread jump by calling `j +2` or `thread jump --by +2` the offset is not recognised. This commit fixes that. >From de43c70a26f5c6fb72f836804f2b3ed6851a0cc7 Mon Sep 17 00:00:00 2001 F

[Lldb-commits] [lldb] [llvm] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-04-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 >From de43c70a26f5c6fb72f836804f2b3ed6851a0cc7 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 15 Apr 2025 12:21:59 +0100 Subject: [PATCH 1/3] [Support] Recognise the '+' char for positive integers Fixes

[Lldb-commits] [lldb] [llvm] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-04-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 >From 73fc9565d973fd7e1ce92b005696f17c9a9acd5f Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 15 Apr 2025 12:21:59 +0100 Subject: [PATCH 1/3] [Support] Recognise the '+' char for positive integers Fixes

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-15 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > With this patch, is there anything that turns on echoing of commands? Yeah, the launch options InitCommands, PreCommands and ***Commands. https://github.com/llvm/llvm-project/pull/135008 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/135626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Complete ToJSON for OptionValues (PR #137375)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-23 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I think that may not apply to LLDB-dap. Since dap uses the SBAPI it sends the debugee output to the client here. https://github.com/llvm/llvm-project/blob/1b6cbaa7b64f54b127d139d653468e213bae007e/lldb/tools/lldb-dap/EventHelper.cpp#L205-L215 https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [NFC][lldb] Fix unresolved test in buildbot lldb-aarch64-windows (PR #137516)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Fix unresolved test in buildbot lldb-aarch64-windows (PR #137516)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/137516 object indexing causes key error. Initial commit #290ba2 >From f0279f88319ab70d0748d3fcde0cc0d279916e6e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 27 Apr 2025 15:03:19 +0100 Subject: [PATCH] [NFC][

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -102,3 +103,23 @@ def test_stackTrace(self): self.assertGreaterEqual( totalFrames, i, "total frames should include a pagination offset" ) + +@skipIfWindows da-viper wrote: should skip linux https://github.com/ll

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -217,3 +216,30 @@ def test_functionNameWithArgs(self): self.continue_to_next_stop() frame = self.get_stackFrames()[0] self.assertEqual(frame["name"], "recurse(x=1)") + +@skipIfWindows da-viper wrote: LGTM But I could not see why

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/137380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Make lldb-dap.executable-path machine specific (PR #137485)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/137485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Complete ToJSON for OptionValues (PR #137375)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/137375 >From a87d7be70ce0d82b159c163b1b319a349cb162ea Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 25 Apr 2025 18:20:24 +0100 Subject: [PATCH 1/4] [lldb] Add ToJson for OptionValueArch --- lldb/include/lldb

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/134722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/7] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ebuka Ezike via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value + lldb::SBCommandReturnObj

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/137002 Based on the DAP specification. The output categories stdout and stderr should only be used for the debuggee's stdout and stderr. ```jsonc /** * The output category. If not specified or if the category i

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-14 Thread Ebuka Ezike via lldb-commits
da-viper wrote: /cherrypick dda53bef35c5ab49967e8755e69ce893ecb525c4 5b384c3015100ad815f4d994d7ef35cc947db711 https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-14 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/135626 Fixes https://github.com/llvm/llvm-project/issues/22981 Do you think it is necessary for the`SetUseColor` to return a bool for the interface >From 0487d125beb27f87acc2c137b1554e08a52d195d Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-16 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I am using what is the default. which is automode. ![image](https://github.com/user-attachments/assets/66ee395e-f513-4ba8-bae3-f4651b2343c9) I am not sure if there is a way to change the mode from the user. https://github.com/llvm/llvm-project/pull/134562 ___

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/6] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/5] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-30 Thread Ebuka Ezike via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-30 Thread Ebuka Ezike via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/137803 >From ba68d13a307f7e7228de3e658b97743b153ba49b Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 29 Apr 2025 11:09:21 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] use the new protocol for set variable. ---

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-05-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-01 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/138116 None >From 437c69ffb1f86733649a82aa2a991360dd40fd7c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 29 Apr 2025 18:19:18 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] Migrate 'Scopes' to structured types.

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-01 Thread Ebuka Ezike via lldb-commits
@@ -105,6 +105,10 @@ class LLDB_API SBThreadPlan { SBThreadPlan QueueThreadPlanForStepOut(uint32_t frame_idx_to_step_to, bool first_insn, SBError &error); + SBThreadPlan QueueThreadPlanForStepSingleInstruction(bool step_over); --

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,10 @@ +#include +#include da-viper wrote: we could remove the includes as it is not really used in tests. as adding them increases the test times. https://github.com/llvm/llvm-project/pull/136494 ___ lld

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @labath this is what it looks like at the bottom right ![image](https://github.com/user-attachments/assets/750a38d0-7244-41ce-8140-1530d4eecece) https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Ebuka Ezike via lldb-commits
da-viper wrote: this does not catch https://github.com/llvm/llvm-project/blob/d775b911c90e631f5cc332c07474f7121564e25b/lldb/tools/lldb-dap/DAP.cpp#L215-L219 for example if you add the initcommand of `breakpoint set --file=main.c --line=2 --command "bogus"` it is not sent to the important categ

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Maybe we limit it to only Errors. as on linux if lldb is not built with lzma support it will spam warning messages like. ``` warning: 45F7FBFE-9455-A458-4A50-347C4A5BC883/libsync.so No LZMA support found for reading .gnu_debugdata section warning: 8E2F4272-9D82-2CEF-A46D-C69D

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/137007 >From 5ffbb9db5031e4f4146dce9736235421fbc5abca Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 21:07:34 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration This a

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,8 @@ +#include da-viper wrote: don't need the header ```suggestion ``` https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
da-viper wrote: LGTM https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/135008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

  1   2   3   4   5   >