https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/132410
Previously, the test compared the JSON output to `setting_value` which was
incorrect. Updated the assertion to validate against the correct list of paths
`[path1, path2]` to ensure accurate test behavior.
Ran the test on the local computer
>From 14d38f31871b4d3d11cdfdac660243643cfd0274 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimy...@gmail.com>
Date: Fri, 21 Mar 2025 15:12:04 +0000
Subject: [PATCH] [lldb][NFC] Fix settings JSON check to compare expected path
list.
Previously, the test compared the JSON output to `setting_value` which was
incorrect. Updated the assertion to validate against the correct list of paths
`[path1, path2]` to ensure accurate test behavior.
Signed-off-by: Ebuka Ezike <yerimy...@gmail.com>
---
lldb/test/API/commands/settings/TestSettings.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/test/API/commands/settings/TestSettings.py
b/lldb/test/API/commands/settings/TestSettings.py
index 2a7c852fc916d..b9b66ea953971 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1022,7 +1022,7 @@ def test_settings_api(self):
path2 = os.path.join(self.getSourceDir(), "tmp2")
self.runCmd("settings set %s '%s' '%s'" % (setting_path, path1, path2))
settings_json = self.get_setting_json(setting_path)
- self.assertEqual(settings_json, setting_value)
+ self.assertEqual(settings_json, [path1, path2])
# Test OptionValueFormatEntity
setting_value = """thread #${thread.index}{, name = \\'${thread.name}\\
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
