[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. By checking for cpu and toolchain features ahead of time we don't need the custom return

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, + lldb::addr_t addr2) const {

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp:36 + if (machine != llvm::Triple::aarch64 && machine != llvm::Triple::aarch64_be && + machine != llvm::Triple::aarch64_32) { +return nullptr; -

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > ptrace request is a success if number of tag

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:19 +@skipUnlessPlatform(["linux"]) +@skipUnlessAArch64MTELinuxCompiler +def test_qmemtags_pac

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > omjavaid wrote: > > ptrace request is a

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 329022. DavidSpickett added a comment. - Add RemoveNonAddressBits which will remove the entire top byte not just tags - Remove SetLogicalTag/RemoveLogicalTag/CopyLogicalTag which are now unused in the proceeding patches Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 329023. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 329024. DavidSpickett added a comment. - Use RemoveNonAddressBits instead of RemoveLogicalTag - Make the top byte of test buffer pointer non zero. As noted, setting the top byte doesn't prove much but it means if a future kernel gets more strict we're a

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > DavidSpickett wrote: > > omjavaid wrote

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 329027. DavidSpickett added a comment. - Comments for the MemoryTaggingDetails struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/H

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h:66 + virtual llvm::Expected + GetMemoryTaggingDetails(int32_t type) { +return llvm::createStringError( ---

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 329029. DavidSpickett added a comment. - Use RemoveNonAddressBits instead of RemoveLogicalTag Note that the tests don't have any changes because the client doesn't have any requirement to remove tags. Only the commands need to do that. The parts of thi

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett updated this revision to Diff 329030. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97284/new/ https://reviews.llvm.org/D97284 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index: ll

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 329031. DavidSpickett added a comment. - RemoveNonAddressBits over RemoveLogicalTag - Set bits 63-60 of test file pointers to check we remove the top byte now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:96 +if 'Scalable Vector Extension Registers' in registerSet.GetName(): +self.assertTrue(self.isAArch64SVE( +

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added a comment. Did you forget to add the changes? I don't see any diff for the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with that one thing fixed. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/main.c:4-10 +#ifndef HWCAP2_MTE +#define HWCAP2_MTE

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1345 + + tags.resize((range.GetByteSize() / details->manager->GetGranuleSize()) * + details->manager->GetBytesPerTag()); omjavaid wrote: > is t

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x000F; +} omjavaid wrote: > How did you come up with this 36bit mask for PC reg

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > DavidSpickett wrote: > > omjavaid wrote: > > > DavidSpickett wrote: > > > > DavidSpickett wr

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > DavidSpickett wrote: > > omjavaid wrote: > > > DavidSpickett wrote: > > > > omjavaid wrote:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 330684. DavidSpickett added a comment. Correctly handle the ptrace call by looping until we get all tags as an error. I've gone ahead and treated anything but all tags as an error as far as lldb-server is concerned. Tell me what you think of that. Re

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330685. DavidSpickett added a comment. Update after changing parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 330686. DavidSpickett added a comment. - Update after changing earlier revisions - Read page size only once in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:102 +# Here we read from 1/2 way through a granule, into the next. Expands to 2 granules +self.check_qmemtags_response("{:x},10:1".forma

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett added a comment. I still have one known (though rare) limitation to this command. That is, if you try to read across two neighbouring MTE regions it will fail because it thinks that the whole range isn't tagged. When it is, it's just split over two regions. This would require you

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330994. DavidSpickett added a comment. Account for a ranges being split across multiple mappings that are next to each other. (tested in the tag read command patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/Process.h:2749 + /// Check whether the remote supports memory tagging. + /// omjavaid wrote: > By remote you mean gdb-remote process? Thi

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330996. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Correct typo in function comment. "to read tags for" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https:/

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 330998. DavidSpickett added a comment. Expand test to check that we can read tags for a range that spans two mappings. This covers updated code in GetMemoryTagManager. Refactor the test file a bit to account for the extra mmap. I've tested the mmap seq

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 331003. DavidSpickett marked 3 inline comments as done. DavidSpickett added a comment. - Remove extra newline after test decorator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98770 Files: lldb/source/Commands/CommandObjectMemory.cpp Index: lldb/s

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

DavidSpickett added a comment. Thanks, I'll do that in future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98770/new/ https://reviews.llvm.org/D98770 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b513b2458d9: [lldb] Correct typo in memory read error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 331209. DavidSpickett added a comment. - Use PRIx64 to properly print 64 bit addresses in invalid range error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

DavidSpickett added a comment. TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register (EL1)` in the armarm) and covers EL0 and 1. Looking at the pseudocode access to this is undefined at EL0. So the OS would have to provide you some other way to read that, I know this is mis

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

DavidSpickett added a comment. > OK we may need to retain the manual setting when I upstream this, instead of > going with the pure Process-maintained value determined dynamically by gdb > packet or corefile metadata. If this is something you need for your own > FixCodeAddress prelim patch, I c

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett abandoned this revision. DavidSpickett added a comment. This is now redundant since Omair landed his changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97284/new/ https://reviews.llvm.org/D97284 __

[Lldb-commits] [PATCH] D99729: [lldb] Improve CPUInfo test predicate

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use a with block for reading the cpuinfo file. When loading the file fails (or we're not on Linux) return an empty string. Since all the cal

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. @omjavaid I get some new warnings when compiling this on x86: [732/1117] Building CXX object too.../RegisterContextDarwin_arm64.cpp.o In file included from /work/open_source/lldb-cross-compile/llvm-project/lldb/source/Pl

[Lldb-commits] [PATCH] D99847: [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM (we should have caught this on our WoA bots but they've been failing earlier in the builds) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D99729: [lldb] Improve CPUInfo test predicate

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8f4d8f87ba4: [lldb] Improve CPUInfo test predicate (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99729/new/ https://reviews.ll

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32 + if (pac_data.GetByteSize() > sizeof(uint64_t)) +opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth); + How is the `sizeof()`

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added a comment. @omjavaid Current status is that a partial read of memory tags is converted into an error by lldb-server. I think this is justifiable given that the GDB protocol as it stands doesn't describe how to really communicate a partial read (though we could make a reasona

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:6024 +llvm::Expected +Process::GetMemoryTagManager(lldb::addr_t addr, lldb::addr_t end_addr) { + Architecture *arch = GetTarget().GetArchitecturePlugin(); While writing "memory tag w

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added a comment. @labath Could you comment on the overall strategy that I'm going for? I'll summarise my intention, the rest of the review stack here implements that if you have time/want to dig into the details. - Tag managers provide utilities to handle tags without knowing the

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added a comment. @omjavaid Any more comments on this? Comment at: lldb/include/lldb/Core/Architecture.h:110 + virtual const MemoryTagManager *GetMemoryTagManager() const { +return nullptr; + } I also had the thought that we could just return

[Lldb-commits] [PATCH] D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64

DavidSpickett created this revision. Herald added subscribers: danielkiss, pengfei, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously the test would fail if you built on Arm/AArch64 but did not have the

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

DavidSpickett created this revision. Herald added subscribers: pengfei, arphaman. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All these tests use x86 target triples. Repository: rG LLVM Github Monorepo https://reviews

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett created this revision. Herald added a subscriber: pengfei. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests fail if you build without the x86 llvm backend. Either because they use an x86 triple or try

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett added reviewers: zturner, labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. (not adding a reviewer for each file type since most are pretty straightforward I think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett added inline comments. Comment at: lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test:45 # CHECK: frame #2: 0x000b1085 unwind-via-stack-win.exe`main + 5 # CHECK: frame #3: 0x77278494 kernel32.dll # CHECK-NOT: frame Same thing happens he

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

DavidSpickett created this revision. Herald added a subscriber: pengfei. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The core file used is built for i386 so we need the x86 backend to be able to load it. Repository: rG

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. (apologies for the review spam, you're the author of the test in this case) lldb in fact crashes when you try to load the core file. Would be nice to give a good failure message if we

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a64d80a959b: [lldb] Require x86 backend for a bunch of DWARF tests (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D100193?vs=336783&id=337068#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG96c82166b6e3: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64 (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1001

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f3187ca8a3: [lldb] Require x86 for unwind no-return test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100195/new/ https://re

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGf152472af576: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett updated this revision to Diff 337387. DavidSpickett added a comment. Pulling in compiler predicate from https://reviews.llvm.org/D95601 to get this landed before I attempt to fix the race condition in hasLinuxVmFlags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett added a comment. Going to commit this with the compiler predicate since this was accepted already and Omair has reviewed the test predicate in the other review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97684/new/ https://reviews

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdc2239dbab: [lldb][AArch64] Simplify MTE memory region test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97684/new/ https://

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 337452. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h l

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 337460. DavidSpickett added a comment. - Rebase onto main Same code just moved around since qSupported parsing was refactored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llv

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 337461. DavidSpickett added a comment. - Rebase onto main - skipUnlessAArch64MTELinuxCompiler was committed already so not added here, just used by the new tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 337467. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/in

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 337468. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/sour

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. AArch64 kernel builds default to having /smaps and the "VmFlags" line was added in 3.8.

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This fixes the underlying issue for the random failure of this test on the lldb bots. The only way we get bitten here is if someone runs this on a system with smaps disabled but giv

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1314 -for line in self.res.GetOutput().splitlines(): -if 'lldb-server' in line: -pid = line.split(' ')[0] When running on a buildb

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

DavidSpickett added a comment. > I don't feel strongly about the method name. Justin used > Process::GetPointerAuthenticationAddressMask which makes it sound specific to > ARM v8.3 ptrauth. The ARM v8.5 MTE tagging might be another use case (or TBI > as Omair has noted). I'd go with the generi

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a comment. Looks like buildkite had issues calling back to Phab yesterday so the builds didn't signal here. This test wouldn't get run in those anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100493/new/ https://reviews.l

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

DavidSpickett added inline comments. Comment at: lldb/docs/resources/test.rst:222 +``gmodules`` need to recompile external headers when they encounter +test-specific flags (including defines) which can be very expensive. + Does this mean only use the flag

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99941/new/ https://reviews.llvm.org/D99941 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

DavidSpickett added a comment. Did the changes in `GDBRemoteRegisterContext.cpp` (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to another diff? Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py:41 +

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 340774. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h ll

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 340776. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Target/Process.h lldb/source

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 340778. DavidSpickett added a comment. Rebase onto main. (switch to m_current_process) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 340779. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/inc

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 340780. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

DavidSpickett added a comment. In D99947#2719403 , @omjavaid wrote: > In D99947#2718954 , @DavidSpickett > wrote: > >> Did the changes in `GDBRemoteRegisterContext.cpp` >> (https://reviews.llvm.org/D99947?id=33548

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:888 + // consolidated data address mask after ignoring the top byte. + if (!ReadPAuthMask().Fail()) +mask |= m_pac_mask.data_mask; I'm g

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.h:77 +return hit_addr; + } }; This is going to be used by FreeBSD, have you checked if it enables top byte ignore at all? CHANGES SINCE

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a comment. @omjavaid ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100493/new/ https://reviews.llvm.org/D100493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett created this revision. Herald added a subscriber: mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Covering basic cases where you have 1 item on 1 line. Apart from eFormatCharArray, where using multiple l

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett updated this revision to Diff 341184. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. - Remove unused cfloat include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101453/new/ https://reviews.llvm.org/D101453

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett added reviewers: LLDB, zturner. DavidSpickett added a comment. I'm looking into printing memory tags and "memory read" uses this code a lot so I thought I'd add tests before I attempt to extend it. If this is useful then I'll add some more covering some other key bits like splitti

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341216. DavidSpickett added a comment. - Rebase onto new qSupported functions - Check AUXV for enabling feature, instead of enabling for all AArch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett added a subscriber: mgorny. DavidSpickett added a comment. @mgorny Can you take a quick look and see if I'm adding this new feature correctly? And thanks for working on qSupported. I skipped checking HWCAP in my first revision because the features were added in generic code, now I

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341232. DavidSpickett added a comment. - Add comment to explain reading auxv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/comm

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf31e390453d2: [lldb][AArch64] Don't check for VmFlags in smaps files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42 if self.process().GetState() == lldb.eStateExited: self.fail("Test program failed to run.") omjavaid wrot

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 341446. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h lldb/source/P

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341447. DavidSpickett added a comment. `asm/hwcap.h` is not available on x86 (riscv/arm/aarch64 have it at least) so #ifdef the includes and auxval call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 341448. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lld

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 341449. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/include/lldb/T

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 341450. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/source/Commands/

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

DavidSpickett added a comment. General question, is it possible to write a test for this? (I've not looked into this area of code before) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539 _

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett updated this revision to Diff 341811. DavidSpickett added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101453/new/ https://reviews.llvm.org/D101453 Files: lldb/unittests/Core/CMakeLists.txt ll

<    9   10   11   12   13   14   15   16   >