[Lldb-commits] [lldb] r346099 - Update framework-header-fix to force system sed

2018-11-04 Thread Dave Lee via lldb-commits
Author: kastiglione Date: Sun Nov 4 07:55:28 2018 New Revision: 346099 URL: http://llvm.org/viewvc/llvm-project?rev=346099&view=rev Log: Update framework-header-fix to force system sed Summary: There are 2 changes here: 1. Use system sed instead of the sed found in the user's path. This fi

[Lldb-commits] [lldb] r335709 - Fix a single typo in SBSymbolContext

2018-06-26 Thread Dave Lee via lldb-commits
Author: kastiglione Date: Tue Jun 26 23:46:09 2018 New Revision: 335709 URL: http://llvm.org/viewvc/llvm-project?rev=335709&view=rev Log: Fix a single typo in SBSymbolContext Summary: Fix a "Manay" in SBSymbolContext.i Reviewers: xiaobai Reviewed By: xiaobai Subscribers: lldb-commits Differen

[Lldb-commits] [lldb] r336287 - Fix and simplify lldb.command decorator

2018-07-04 Thread Dave Lee via lldb-commits
Author: kastiglione Date: Wed Jul 4 09:11:43 2018 New Revision: 336287 URL: http://llvm.org/viewvc/llvm-project?rev=336287&view=rev Log: Fix and simplify lldb.command decorator Summary: This change fixes one issue with `lldb.command`, and also reduces the implementation. The fix: a command fun

[Lldb-commits] [lldb] r355793 - Quiet command regex instructions during batch execution

2019-03-10 Thread Dave Lee via lldb-commits
Author: kastiglione Date: Sun Mar 10 16:15:48 2019 New Revision: 355793 URL: http://llvm.org/viewvc/llvm-project?rev=355793&view=rev Log: Quiet command regex instructions during batch execution Summary: Within .lldbinit, regex commands can be structured as a list of substitutions over multiple l

Re: [Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

2019-03-11 Thread Dave Lee via lldb-commits
Yeah given the evidence, maybe it's fine left as is. I worked around it locally so I am not blocked. Thanks! On Monday, March 11, 2019, Jonas Devlieghere wrote: > It's weird that this only occurs when building with Xcode, none of the > bots seem affected. Anyway, I'm updating the macros and veri

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread Dave Lee via lldb-commits
@@ -518,6 +518,15 @@ void CommandInterpreter::Initialize() { AddAlias("re", cmd_obj_sp); } + cmd_obj_sp = GetCommandSPExact("scripting execute"); + if (cmd_obj_sp) { +AddAlias("sc", cmd_obj_sp); +AddAlias("scr", cmd_obj_sp); +AddAlias("scri", cmd_obj_sp); +

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. In addition to the comment about unique prefixes, my only other comment is, have you considered `scripting run`? https://github.com/llvm/llvm-project/pull/97263 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-02 Thread Dave Lee via lldb-commits
kastiglione wrote: > The problem with this command is that it either executes a script given to it > on the command line, or it runs the embedded script interpreter... I don't see the problem. The original `script` does both of those things, and `run` works fits those two use case as well or b

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-02 Thread Dave Lee via lldb-commits
kastiglione wrote: @medismailben 👍 I saw, and also wanted to reply to Jim. https://github.com/llvm/llvm-project/pull/97263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/98190 None >From 24f2c8ee442b67bae4b78543f54cae4b026f3862 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 8 Jul 2024 11:19:55 -0700 Subject: [PATCH] [lldb] Improve summary string handling of dollar chars ---

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/98190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/98190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
kastiglione wrote: Note that this is essentially a few lines of concrete change, most of the change is whitespace only. Use `?w=1` to filter out whitespace only changes: https://github.com/llvm/llvm-project/pull/98190/files?w=1 https://github.com/llvm/llvm-project/pull/98190 __

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/98190 >From 24f2c8ee442b67bae4b78543f54cae4b026f3862 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 8 Jul 2024 11:19:55 -0700 Subject: [PATCH 1/2] [lldb] Improve summary string handling of dollar chars --- ll

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/98190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] baffaf0 - [lldb] Add required skipIfLLVMTargetMissing for X86 (NFC)

2024-05-11 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2024-05-11T11:48:31-07:00 New Revision: baffaf000fd4667f33b3756d0d3b645b1d926b44 URL: https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44 DIFF: https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44.diff LOG:

[Lldb-commits] [lldb] lldb Support custom LLVM formatting for variables (PR #91868)

2024-05-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/91868 - **[lldb] Support custom LLVM formatting for variables (#81196)** - **[lldb] Handle non-existent llvm_format** >From 30a36018b9c96d7ddd969815ef850987d781338e Mon Sep 17 00:00:00 2001 From: Dave Lee Date: T

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-15 Thread Dave Lee via lldb-commits
kastiglione wrote: @adrian-prantl updated the description: > Re-apply https://github.com/llvm/llvm-project/pull/81196, with a fix that > handles the absence of llvm formatting: > https://github.com/llvm/llvm-project/commit/3ba650e91eded3543764f37921dcce3bb47d425f https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/91868 >From 30a36018b9c96d7ddd969815ef850987d781338e Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 30 Apr 2024 10:45:10 -0700 Subject: [PATCH 1/3] [lldb] Support custom LLVM formatting for variables (#81196)

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

2024-05-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/91868 >From 30a36018b9c96d7ddd969815ef850987d781338e Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 30 Apr 2024 10:45:10 -0700 Subject: [PATCH 1/4] [lldb] Support custom LLVM formatting for variables (#81196)

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/92618 None >From 1564ae4ce3a56fc1f11e03e82e0da1e01f25f3ed Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 16 May 2024 14:01:22 -0700 Subject: [PATCH] [lldb] Add the word "backtrace" to bt help string --- lldb

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/92618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread Dave Lee via lldb-commits
kastiglione wrote: Open to alternative rewordings that include "backtrace". https://github.com/llvm/llvm-project/pull/92618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/92618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/93881 None >From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 30 May 2024 13:29:41 -0700 Subject: [PATCH] [lldb] Improve identification of Dlang mangled names --- l

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/93881 >From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 30 May 2024 13:29:41 -0700 Subject: [PATCH 1/2] [lldb] Improve identification of Dlang mangled names --- lld

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
kastiglione wrote: > This a little bit raises the question why we don't do the same checks for > `_R` and `_Z`. I asked myself the same. Turns out Rust doesn't have a number following the `_R` prefix, so it's not as simple. Given that C++ is much more load bearing, I didn't want to include ch

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/94046 None >From a783b4c189d3c5387418e58156667ecc8382b5ce Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 31 May 2024 13:47:24 -0700 Subject: [PATCH] [lldb] Fix Dlang symbol test breakage --- lldb/source/Core

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/94046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread Dave Lee via lldb-commits
kastiglione wrote: @gulfemsavrun apologies, fix is here: #94046 https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/94046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-06-03 Thread Dave Lee via lldb-commits
kastiglione wrote: @DavidSpickett thanks, is there a link to a log? I'm curious. https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/95146 None >From 1f4d61ed4e0ab42d5e5ac0937c0af0572f0f8f10 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 10 Jun 2024 10:46:08 -0700 Subject: [PATCH] [lldb] Fix declaration of thread argument in CommandObjectT

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/95146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/95146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/95146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DWIMPrint] Move the setting of the result status into dump_val_object (PR #96232)

2024-06-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. thanks https://github.com/llvm/llvm-project/pull/96232 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [GDBRemote] Handle 'heap' memory region info type (PR #105883)

2024-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/105883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [GDBRemote] Handle 'heap' memory region info type (PR #105883)

2024-08-23 Thread Dave Lee via lldb-commits
@@ -1635,6 +1635,8 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo( for (llvm::StringRef entry : llvm::split(value, ',')) { if (entry == "stack") region_info.SetIsStackMemory(MemoryRegionInfo::eYes); +if (entry == "hea

[Lldb-commits] [lldb] [lldb] In-progress — All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-19 Thread Dave Lee via lldb-commits
kastiglione wrote: > ### Goal > > Every `ValueObjectSP` will have an actual value and will never be equal to > `nullptr`. I would like to learn more about the goal. It seems like the existing code will result in widespread use of `optional>`. Is the plan to reduce these cases to a smaller amo

[Lldb-commits] [lldb] e19339f - [lldb] Identify Swift-implemented ObjC classes

2023-07-20 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2023-07-20T19:32:12-07:00 New Revision: e19339f5f8c15d4307aaed14309e38e3c87121ac URL: https://github.com/llvm/llvm-project/commit/e19339f5f8c15d4307aaed14309e38e3c87121ac DIFF: https://github.com/llvm/llvm-project/commit/e19339f5f8c15d4307aaed14309e38e3c87121ac.diff LOG:

[Lldb-commits] [lldb] a6ff60e - [lldb] Delete unused LibcxxOptionalSummaryProvider (NFC)

2023-07-20 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2023-07-20T19:32:58-07:00 New Revision: a6ff60ecdd061cc21383108ac092ae4a700f9143 URL: https://github.com/llvm/llvm-project/commit/a6ff60ecdd061cc21383108ac092ae4a700f9143 DIFF: https://github.com/llvm/llvm-project/commit/a6ff60ecdd061cc21383108ac092ae4a700f9143.diff LOG:

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Dave Lee via lldb-commits
kastiglione wrote: > You will need access to the debugger, target, process etc. Currently Editline > lives in Host, so we'd have to move that out into Core to avoid circular > dependencies. can we wire up the ansi color formatting without supporting all these other bits of data? if we're goi

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-19 Thread Dave Lee via lldb-commits
@@ -18,19 +18,45 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/66949 `std::basic_string` is not a regex, and treating it as such could unintentionally cause a formatter to substring match a template type parameter, for example: `std::vector>`. Differential Revision: https://r

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-02-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/83501 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract getter function for experimental target properties (NFC) (PR #83504)

2024-02-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/83504 None >From 969f441344e179c9167fe707cf8f01edae6dbfc5 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 29 Feb 2024 15:38:22 -0800 Subject: [PATCH] [lldb] Extract getter function for experimental target prop

[Lldb-commits] [lldb] [lldb] Extract getter function for experimental target properties (NFC) (PR #83504)

2024-02-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/83504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract getter function for experimental target properties (NFC) (PR #83504)

2024-02-29 Thread Dave Lee via lldb-commits
@@ -4227,28 +4228,21 @@ void TargetProperties::UpdateLaunchInfoFromProperties() { DisableSTDIOValueChangedCallback(); } -bool TargetProperties::GetInjectLocalVariables( -ExecutionContext *exe_ctx) const { +std::optional TargetProperties::GetExperimentalPropertyValue( +

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-06 Thread Dave Lee via lldb-commits
kastiglione wrote: We're going to need this logic in a couple from shell tests too. Should we: 1. Duplicate the logic into lit.cfg.py? 2. Import lldbplatformutil.py into lit.cfg.py? (are there any python structure/layout issues that would complicate this?) 3. Put the logic in an independent loc

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/84246 None >From 1fb13a2d034dbea1d1ba2ef87354199a815f3788 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 14:23:05 -0800 Subject: [PATCH] [lldb] Disable shell tests affected by ld64 bug --- lldb/te

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-06 Thread Dave Lee via lldb-commits
kastiglione wrote: To start with option #​1 I created https://github.com/llvm/llvm-project/pull/84246 https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Log module build remarks to types log too (PR #84260)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/84260 None >From c828091ab173a2c23e10649ad7b131a02ae4e6c1 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 15:55:38 -0800 Subject: [PATCH] [lldb] Log module build remarks to types log too --- .../Pl

[Lldb-commits] [lldb] [lldb] Remove unused #includes in ClangModulesDeclVendor.cpp (PR #84262)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/84262 None >From ba079bd1d130a460e481b6c10b33f1ddd58421a3 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 16:02:13 -0800 Subject: [PATCH] [lldb] Remove unused #includes in ClangModulesDeclVendor.cpp

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/84263 None >From e5bed6b190687cc31ecb69da006bc93d9284994a Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 16:03:22 -0800 Subject: [PATCH] [lldb] Minor cleanup in StoringDiagnosticConsumer --- .../E

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/84263 >From e5bed6b190687cc31ecb69da006bc93d9284994a Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 16:03:22 -0800 Subject: [PATCH 1/2] [lldb] Minor cleanup in StoringDiagnosticConsumer --- .../Exp

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused #includes in ClangModulesDeclVendor.cpp (PR #84262)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract getter function for experimental target properties (NFC) (PR #83504)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/83504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Log module build remarks to types log too (PR #84260)

2024-03-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + kastiglione wrote: my thinking is that the darwin check is baked into the invocation of xcrun. If you thin

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/84246 >From 1fb13a2d034dbea1d1ba2ef87354199a815f3788 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 14:23:05 -0800 Subject: [PATCH 1/2] [lldb] Disable shell tests affected by ld64 bug --- lldb/test

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
kastiglione wrote: Called it `ld_new-bug`. If it's not the TLS bug, I wonder if the version range is correct. https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
kastiglione wrote: I think this should be merged, and if either end of the version range proves to be too limited, we can increase the range. https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + +# Determine if a specific version of Xcode's linker contains a bug. We want to +# skip affected tests if they contain this b

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/84246 >From 1fb13a2d034dbea1d1ba2ef87354199a815f3788 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 14:23:05 -0800 Subject: [PATCH 1/3] [lldb] Disable shell tests affected by ld64 bug --- lldb/test

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. looks good https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85127 None >From 5d0a5c8721766544067ccd8e169a5e2effeba981 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 13:30:20 -0700 Subject: [PATCH] [lldb] XFAIL TestIndirectSymbols on darwin --- lldb/test/A

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/85127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85133 Correction to cb8f3837e2311c369ef24a077a0c34e4ff56c08f >From f5fb7236ad4df2fe9322ab00e4839e92ef29a8d3 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 14:09:20 -0700 Subject: [PATCH] [lldb] Sk

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/85133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85152 None >From 970cf82fa3d64c5a4e1b3929c110b42974ef13cd Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 14:49:23 -0700 Subject: [PATCH] [lldb] Fix dwim-print to not delete non-result persistent v

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-14 Thread Dave Lee via lldb-commits
@@ -170,6 +170,14 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, ExpressionResults expr_result = target.EvaluateExpression( expr, exe_scope, valobj_sp, eval_options, &fixed_expression); +auto persistent_name = valobj_sp->GetName(); +// Evaluat

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/85152 >From 970cf82fa3d64c5a4e1b3929c110b42974ef13cd Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 14:49:23 -0700 Subject: [PATCH 1/2] [lldb] Fix dwim-print to not delete non-result persistent var

  1   2   3   4   5   6   7   >