[Lldb-commits] [PATCH] D96655: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Correct `Thread::DiscardPlan` to call `DiscardPlan` instead of `PopPlan`. Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D96656: [lldb] Remove unused bool return type of ThreadPlan::WillStop (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The calls to `ThreadPlan::WillStop` do not use the return value. This changes `WillStop` to a `void` retu

[Lldb-commits] [PATCH] D96666: [lldb] Remove unused ThreadPlan tracer utilities (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Delete unused `EnableTracer()` and `SetTracer()` functions on `Thread`. By deleting these, their `ThreadP

[Lldb-commits] [PATCH] D96687: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `GetRealStopInfo` has only one call site, and in that call site a reference to the concrete thread plan i

[Lldb-commits] [PATCH] D96688: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Correct `RestoreThreadState` to a `void` return type. Also, update the signature of its callee, `Thread::

[Lldb-commits] [PATCH] D96689: [lldb] Remove ThreadPlan::ShouldAutoContinue (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove `ShouldAutoContinue`, implemented in only one subclass. In the `ShouldAutoContinue::ShouldAutoCont

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While learning the semantics of `IsMasterPlan` and `OkayToDiscard`, and guided by the FIXME comment in Th

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione updated this revision to Diff 323765. kastiglione added a comment. Herald added a subscriber: JDevlieghere. Restore a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96715/new/ https://reviews.llvm.org/D96715 Files: lldb/inclu

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp:72 +m_func_sp->SetIsMasterPlan(false); m_func_sp->SetOkayToDiscard(true); PushPlan(m_func_sp); Thi

[Lldb-commits] [PATCH] D96689: [lldb] Remove ThreadPlan::ShouldAutoContinue (NFC)

kastiglione abandoned this revision. kastiglione added a comment. Even though the tests pass, I see that my logic was flawed. In theory, if autocontinue is true, and `MischiefManaged` returns true, then previous (parent) plans will be asked whether to `ShouldStop`. So the semantics of `ShouldAu

[Lldb-commits] [PATCH] D96688: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65d91b40ae1d: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC) (authored by kastiglione). Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D96687: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2464eb7651: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D96666: [lldb] Remove unused ThreadPlan tracer utilities (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22f0aa0d9ebd: [lldb] Remove unused ThreadPlan tracer utilities (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. "Asynced" sounds funny to me, but I don't have suggestions other than "Async". Looks good to me. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:558 +

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Call `SetPrivate(true)` for subplans pushed via `PushPlan()`, as described in its docstring. Repository

[Lldb-commits] [PATCH] D96917: [lldb] Rename {stop, run}_vote to report_{stop, run}_vote

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rename `stop_vote` and `run_vote` to `report_stop_vote` and `report_run_vote` respectively. These variable

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adjust `ShouldAutoContinue` to be available to any thread plan previous to the plan that explains

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359 + /// Returns whether this thread plan overrides the `ShouldStop` of previous + /// plans. + /// + /// When processing the thread plan stack, this function gives plans the + /// abil

[Lldb-commits] [PATCH] D96917: [lldb] Rename {stop, run}_vote to report_{stop, run}_vote (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3b9e5799f6: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione added a comment. Good call on calling ShouldAutoContinue before Pop. Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359 + /// Returns whether this thread plan overrides the `ShouldStop` of previous + /// plans. + /// + /// When processing the thread plan

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0186c25c62e: [lldb] Refine ThreadPlan::ShouldAutoContinue (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D97076?vs=

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `frame variable` dereference suppport to libc++ `std::shared_ptr`. This chang

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:410-433 -if (!m_count_sp) { - ValueObjectSP shared_owners_sp(m_cntrl->GetChildMemberWithName( - ConstString("__shared_owners_"), true)); - if (!shared_owners_sp

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:11 + +class LibcxSharedPtrDataFormatterTestCase(TestBase): + teemperor wrote: > `Libcx` typo. FWI

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325527. kastiglione added a comment. Use expect_var_path and fix other issues with the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325529. kastiglione added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp lldb/sou

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325549. kastiglione added a comment. test for null using SBValue.unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlu

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:31 +) +self.assertRegex(valobj.children[0].value, "^0x0{8,}$") + jingham wrote: >

[Lldb-commits] [PATCH] D97235: [lldb] Reinstate support for LLDB_VERSION_STRING

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97235/new/ https://reviews.llvm.org/D97235 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325808. kastiglione added a comment. check ptr_sp before use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ac42fd26d73: [lldb] Add deref support and tests to shared_ptr synthetic (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D97524: [lldb] Add deref support to libc++ unique_ptr synthetic

kastiglione created this revision. kastiglione added reviewers: teemperor, jingham, JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add frame variable dereference suppport to libc++ `std::unique_ptr`. This change

[Lldb-commits] [PATCH] D97524: [lldb] Add deref support to libc++ unique_ptr synthetic

kastiglione added a comment. There's pretty much nothing new here compared D97165 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97524/new/ https://reviews.llvm.org/D97524

[Lldb-commits] [PATCH] D97524: [lldb] Add deref support to libc++ unique_ptr synthetic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a677b29a3b3: [lldb] Add deref support to libc++ unique_ptr synthetic (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D97985: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minor change for naming consistency. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97

[Lldb-commits] [PATCH] D97985: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7361c8eccb7: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

kastiglione added a comment. Jim previously approved this offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96916/new/ https://reviews.llvm.org/D96916 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG354d10530d26: [lldb] Fix PushPlan to set subplan to private (autho

[Lldb-commits] [PATCH] D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ignore `-Wreturn-type-c-linkage` diagnostics for `LLDBSwigPythonBreakpointCallbackFunction`. The fu

[Lldb-commits] [PATCH] D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf36998694f: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction… (authored by kastiglione). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D98653: [lldb] Refactor to support non-pointer instance variables (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor, jingham, JDevlieghere, labath. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `frame variable` contextually supports accessing ivars via a lang

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

kastiglione added inline comments. Comment at: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:609 if (!path_strings) { - result_ptr->image_ptr = dlopen(name, 2); + result_ptr->image_ptr = dlopen(name, )" DLOPEN_OPTIONS R"(); if (result_ptr->image_ptr)

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

kastiglione accepted this revision. kastiglione added a comment. 🚢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Debugging tests sometimes involves debugging the Python source. This adds a paragraph to the

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione added inline comments. Comment at: lldb/docs/resources/test.rst:387 + +alias lldb self.dbg.HandleCommand("%*") + JDevlieghere wrote: > This should be indented to show up as code. thanks for catching it Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione updated this revision to Diff 334733. kastiglione added a comment. Indent source block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99744/new/ https://reviews.llvm.org/D99744 Files: lldb/docs/resources/test.rst Index: lldb/docs/re

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione updated this revision to Diff 334734. kastiglione added a comment. s/lldb alias/pdb alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99744/new/ https://reviews.llvm.org/D99744 Files: lldb/docs/resources/test.rst Index: lldb/docs

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c653d4c3d14: [lldb] Update test.rst with a paragraph about pdb (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D99859: [lldb] Import ObjectiveC module instead of Foundation in test

kastiglione created this revision. kastiglione added a reviewer: teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use `@import ObjectiveC` instead of `@import Foundation`, as the former is all that's needed, and result

[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

kastiglione created this revision. kastiglione added a reviewer: teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When referencing `NSObject`, it's enough to import `objc/NSObject.h`. Importing `Foundation` is unneces

[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

kastiglione updated this revision to Diff 335187. kastiglione added a comment. fix lldb/test/API/commands/frame/recognizer/main.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99867/new/ https://reviews.llvm.org/D99867 Files: lldb/test/API/comma

[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

kastiglione added inline comments. Comment at: lldb/test/API/commands/frame/recognizer/main.m:1 -#import +#import teemperor wrote: > teemperor wrote: > > I guess this could also be just `stdio.h` (FWIW, the printfs in tests can > > also be removed as they ju

[Lldb-commits] [PATCH] D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG10ed479d7303: [lldb] Import ObjectiveC module instead of Foundation in test (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99859/ne

[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a1798e51a3: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione added a comment. friendly ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96715/new/ https://reviews.llvm.org/D96715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione created this revision. kastiglione added a reviewer: augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix cases that can crash `SBStructuredData::operator=`. This happened in a case where `rhs` had a nul

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione added a comment. I should expand this to fix other unchecked dereferences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione updated this revision to Diff 341721. kastiglione added a comment. Ensure m_impl_up is always non-null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 Files: lldb/source/API/SBStructuredData

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione added a comment. I changed direction, to ensure the impl pointer is always non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 ___ lldb-commit

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione added inline comments. Comment at: lldb/source/API/SBStructuredData.cpp:43 SBStructuredData::SBStructuredData(lldb_private::StructuredDataImpl *impl) -: m_impl_up(impl) { +: m_impl_up(impl ? impl : new StructuredDataImpl()) { LLDB_RECORD_CONSTRUCTOR(SBStru

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione updated this revision to Diff 343208. kastiglione added a comment. Herald added a subscriber: mgorny. Add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 Files: lldb/source/API/SBSt

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5cf4b8f11cd: [lldb] Handle missing SBStructuredData copy assignment cases (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, jasonmolenda. Herald added a subscriber: mgorny. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Enable `-Wmisleading-indentation` to balance

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. @dblaikie I have checked lldb, it builds cleanly. In the downstream swift branch of lldb there were a couple issues. I'll check llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione updated this revision to Diff 343773. kastiglione added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Enable for llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. Didn't mean to self-accept this, so I resigned as reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/D102092 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf44c6f20f5e9: [cmake] Enable -Wmisleading-indentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.l

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. Will keep an eye on buildbots, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/D102092 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Document how to complete command line suggestions provided by `show-autosuggestion`. Repository: rG L

[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

kastiglione updated this revision to Diff 345642. kastiglione added a comment. use "accepted" as the verb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102544/new/ https://reviews.llvm.org/D102544 Files: lldb/source/Core/CoreProperties.td Inde

[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

This revision was automatically updated to reflect the committed changes. Closed by commit rG02286d96dbb3: [lldb] Document ctrl-f for completing show-autosuggestion (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102544/new/

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. @thakis thanks for pointing that out. I had tried `-Wall` using the clang included with the latest version of Xcode, and that does not enable `-Wmisleading-indentation`. I see from the compiler explorer that recent clang versions do include misleading indentation di

[Lldb-commits] [PATCH] D86493: Remove unused/misnamed SetObjectModificationTime

kastiglione created this revision. kastiglione added reviewers: clayborg, friss, JDevlieghere, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Remove `SetObjectModificationTime` which is not currently used, and assigns

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; Is this lambda missing an assignment to `errors`? Repository:

[Lldb-commits] [PATCH] D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime

kastiglione added a comment. In D86493#2236454 , @aprantl wrote: > Sometimes these odd leaf APIs are used by custom downstream variants of LLDB I wondered about other consumers, how often is it the case that mainline lldb has code used only downstream?

[Lldb-commits] [PATCH] D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c48802918d: Remove unused/misnamed SetObjectModificationTime (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86493/new/ https://r

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

kastiglione added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:59 + +if (command_interpreter && command_interpreter[0]) { + full_command += command_interpreter; JDevlieghere wrote: > Given that this pattern repeats a few times in this stru

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:65 + + return CommandParsed(command); +} this is missing error handling for unsupported languages, such as `script -l swift` Comment at: lldb/test/She

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:50-51 + + std::tie(head, tail) = tail.split(' '); + if (head != "-l" && head != "--language") +return CommandParsed(command); generally, lldb supports more than spac

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:37 +"default", +"The default scripting language.", +}, is the default's name available in a `define`? If maybe it'd be good to include it here? I don'

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added a comment. > Given the `expr` status quo, I'd stick with that. I want to give a +1 to //not// copying `expr`. I think the tradeoff is not not worth it. My user perspective is that lldb could be improved by making more decisions with the user in mind, not lldb's engineers (to g

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Extract a function for turning `eLaunchFlavorDefau

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. Follow up to 8aeb212887024a615ca02437cd12fa055bd54b6f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione updated this revision to Diff 290581. kastiglione added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327 Files: lldb/tools/debugserver/source/debugserver.cpp Index: lld

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Fix references to LLDB_ENABLE_TESTS. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

This revision was automatically updated to reflect the committed changes. Closed by commit rG447ba60a224f: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87345/new/

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. @teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55dd731b291c: [debugserver] Extract function for default launch flavor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Since "generic type" has a precise meaning in some lang

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG757ac4ccfb8b: [lldb] Reword CompilerType docstring to not say "generic type" (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Update the some examples in the help string for `breakp

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint numbe

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint numbe

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3b9ba1c7d8: [lldb/Commands] Fix outdated `breakpoint command add

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

kastiglione added a comment. Should lldb avoid calling asan (or any other sanitizer's) `mmap`? If so, maybe this function can be sanitizer aware and ignore those symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87868/new/ https://reviews.llv

[Lldb-commits] [PATCH] D88119: [lldb] Remove lldb-perf remenant

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Delete a file remaining from the deletion of lldb-perf in D64362 .

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4625 + +def__init__(self, target, extra_args, dict): + missing space after `def` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D88119: [lldb] Remove lldb-perf remenant

This revision was automatically updated to reflect the committed changes. Closed by commit rG9abd1e8f4e5d: [lldb] Remove lldb-perf remenant (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88119/new/ https://reviews.llvm.org/

<    2   3   4   5   6   7   8   >