Author: cbieneman
Date: Sun Oct 30 23:48:10 2016
New Revision: 285541
URL: http://llvm.org/viewvc/llvm-project?rev=285541&view=rev
Log:
[Test Suite] Properly respect --framework option
Summary:
dotest.py has a framework option that is not respected. This patch makes the
framework path properly c
Author: cbieneman
Date: Mon Oct 31 17:06:52 2016
New Revision: 285646
URL: http://llvm.org/viewvc/llvm-project?rev=285646&view=rev
Log:
[Test-Suite] Speculative fix for darwin bots
When building with Xcode it looks like some of the logic in my test changes
went haywire. This should fix it.
Modi
Author: cbieneman
Date: Mon Oct 31 17:31:07 2016
New Revision: 285651
URL: http://llvm.org/viewvc/llvm-project?rev=285651&view=rev
Log:
[CMake] Populate the build directory's framework
This ensures that the Resources and clang headers are properly symlinked in
LLDB's framework. This should fix t
beanz created this revision.
beanz added reviewers: zturner, labath, spyffe, tfiala.
beanz added a subscriber: lldb-commits.
This patch allows the Darwin build to fall back to to Posix-style lookups for
the clang resource directory if the debugger library isn't inside a framework.
The patch also
I think the new mini-dump test case added here might be flaky.
See: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/381
The next build was successful.
-Chris
> On Oct 31, 2016, at 8:35 AM, Dimitar Vlahovski via lldb-commits
> wrote:
>
> Author: dvlahovski
> Date: Mon
Author: cbieneman
Date: Wed Nov 2 12:19:23 2016
New Revision: 285838
URL: http://llvm.org/viewvc/llvm-project?rev=285838&view=rev
Log:
Find clang resource directory via *nix-style lookup
Summary:
This patch allows the Darwin build to fall back to to Posix-style lookups for
the clang resource di
Author: cbieneman
Date: Wed Nov 2 12:19:26 2016
New Revision: 285839
URL: http://llvm.org/viewvc/llvm-project?rev=285839&view=rev
Log:
[CMake] Support LLDB_TEST_CLANG in check-lldb target(s)
This just hooks up the in-tree compiler to be optionally used when running the
test suite.
Modified:
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Author: cbieneman
Date: Tue Nov 8 11:53:18 2016
New Revision: 286254
URL: http://llvm.org/viewvc/llvm-project?rev=286254&view=rev
Log:
[Test Suite] Attempt to fix issue zturner reported to me
Not sure why this didn't explode more massively, but this should fix the issue
with the non-framework t
.
-Chris
> On Nov 8, 2016, at 7:37 AM, Zachary Turner wrote:
>
>
>
> On Sun, Oct 30, 2016 at 9:57 PM Chris Bieneman via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
> URL:
>
Author: cbieneman
Date: Tue Nov 8 12:14:42 2016
New Revision: 286258
URL: http://llvm.org/viewvc/llvm-project?rev=286258&view=rev
Log:
[Test Suite] Properly quote python string
Oops!
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbsu
ir own function scopes, which isn’t how they worked in py2.
In general we should probably look for ways to remove eval calls from the test
suite. They are widely discouraged in python code.
-Chris
> On Nov 8, 2016, at 10:05 AM, Chris Bieneman via lldb-commits
> wrote:
>
> I pushed a
beanz created this revision.
beanz added a reviewer: lldb-commits.
beanz added a subscriber: tfiala.
Herald added a subscriber: mgorny.
This change unifies and simplifies the code paths between the Darwin and
non-Darwin code to print the LLDB version information.
It also introduces a new variabl
Author: cbieneman
Date: Thu Nov 10 11:33:19 2016
New Revision: 286479
URL: http://llvm.org/viewvc/llvm-project?rev=286479&view=rev
Log:
Unify Darwin and Non-Darwin printing of version output
Summary:
This change unifies and simplifies the code paths between the Darwin and
non-Darwin code to prin
beanz created this revision.
beanz added a reviewer: lldb-commits.
beanz added subscribers: tfiala, kubabrecka.
This patch reworks all the @skip... lines for sanitizer libraries to be based
on whether or not the compiler actually works, rather than whether or not the
compiler-rt sources are pres
beanz added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23
@skipIfRemote
-@skipUnlessCompilerRt
@skipUnlessThreadSanitizer
def test(self):
tfiala wrote:
> Seems fine as long as @skipU
Author: cbieneman
Date: Thu Nov 10 13:16:17 2016
New Revision: 286490
URL: http://llvm.org/viewvc/llvm-project?rev=286490&view=rev
Log:
[Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities
Summary: This patch reworks all the @skip... lines for sanitizer libraries to
be b
Author: cbieneman
Date: Thu Nov 10 15:30:16 2016
New Revision: 286504
URL: http://llvm.org/viewvc/llvm-project?rev=286504&view=rev
Log:
Fixing the Xcode build that I broke in r286479
Since Xcode can't seem to handle quotes in preprocessor definitions, I've
changed the build to assume that the de
lldb.cpp:63:22:
> error: invalid suffix '.0' on floating constant
> In file included from :356:
> :4:40: note: expanded from here
> #define LLDB_VERSION_STRING lldb-360.99.0
> ^
> 2 errors generated.
>
>
> On Thu, Nov 10,
Author: cbieneman
Date: Thu Nov 10 15:43:24 2016
New Revision: 286505
URL: http://llvm.org/viewvc/llvm-project?rev=286505&view=rev
Log:
One more try to fix the Xcode project
This time I made sure it actually opened.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/ll
Author: cbieneman
Date: Thu Nov 10 17:56:32 2016
New Revision: 286528
URL: http://llvm.org/viewvc/llvm-project?rev=286528&view=rev
Log:
[CMake] Fixing CMake to append source properties instead of overwrite them.
This is a small fix to the version output.
Modified:
lldb/trunk/source/CMakeList
Thank you for fixing this! It was my bad.
-Chris
> On Nov 11, 2016, at 3:39 AM, Tamas Berghammer via lldb-commits
> wrote:
>
> Author: tberghammer
> Date: Fri Nov 11 05:39:23 2016
> New Revision: 286581
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286581&view=rev
> Log:
> Fix TestHelp on
Author: cbieneman
Date: Mon Nov 14 16:43:08 2016
New Revision: 286899
URL: http://llvm.org/viewvc/llvm-project?rev=286899&view=rev
Log:
One more cleanup to lldb version printing
With this patch LLDB_VERSION_STRING replaces "lldb version x.x.x" if it is set.
This allows builds to not display the
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
The big thing to be aware of about Twines is that they are designed so that
when you construct one the underlying string storage can vanish after the Twine
goes out of scope. Here it look
beanz added a comment.
The CMake all LGTM.
https://reviews.llvm.org/D26757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: cbieneman
Date: Fri Nov 18 17:31:53 2016
New Revision: 287408
URL: http://llvm.org/viewvc/llvm-project?rev=287408&view=rev
Log:
[CMake] NFC. Updating CMake dependency specifications
This patch updates a bunch of places where add_dependencies was being
explicitly called to add dependencie
Author: cbieneman
Date: Sun Dec 4 21:29:10 2016
New Revision: 288633
URL: http://llvm.org/viewvc/llvm-project?rev=288633&view=rev
Log:
[CMake] Use add_llvm_tool_symlink's OUTPUT_DIR option
This is updating to take r288632 into account.
Modified:
lldb/trunk/cmake/modules/AddLLDB.cmake
Modif
Author: cbieneman
Date: Mon Dec 5 13:40:34 2016
New Revision: 288691
URL: http://llvm.org/viewvc/llvm-project?rev=288691&view=rev
Log:
[CMake] Don't add gtest if it is already there
LLVM build trees export the gtest library through a special export set. If
you're building against a build tree y
Author: cbieneman
Date: Thu Dec 15 12:18:47 2016
New Revision: 289841
URL: http://llvm.org/viewvc/llvm-project?rev=289841&view=rev
Log:
[CMake] Only support LLDB_BUILD_FRAMEWORK on CMake 3.7 and later
CMake's framework target generation was unable to generate POST_BUILD steps
(see: https://gitla
Author: cbieneman
Date: Thu Dec 15 12:19:10 2016
New Revision: 289842
URL: http://llvm.org/viewvc/llvm-project?rev=289842&view=rev
Log:
[CMake] Ensure Python files are inside the LLDB framework bundle
When building the LLDB Framework we need to ensure that the Python files get
put into the Frame
Author: cbieneman
Date: Thu Dec 15 16:01:17 2016
New Revision: 289879
URL: http://llvm.org/viewvc/llvm-project?rev=289879&view=rev
Log:
[CMake] Refactor LLDB libraries and tools to be components
In LLVM's CMake we have a convention that components have both a build and an
install target. Making
Author: cbieneman
Date: Tue Dec 20 10:28:18 2016
New Revision: 290180
URL: http://llvm.org/viewvc/llvm-project?rev=290180&view=rev
Log:
[CMake] [PR31433] Fix LLDB tool installation
This resolves PR 31433.
Modified:
lldb/trunk/cmake/modules/AddLLDB.cmake
Modified: lldb/trunk/cmake/modules/Ad
Author: cbieneman
Date: Wed Dec 21 15:23:27 2016
New Revision: 290273
URL: http://llvm.org/viewvc/llvm-project?rev=290273&view=rev
Log:
[CMake] Support distribution install for LLDB.framework
This patch adds the last bit of support to get LLVM_DISTRIBUTION_COMPONENTS
working with libLLDB when bu
Author: cbieneman
Date: Tue Jan 3 21:36:35 2017
New Revision: 290934
URL: http://llvm.org/viewvc/llvm-project?rev=290934&view=rev
Log:
[CMake] Fix install rules for tools included in the framework
The logic for install rules was wrong for tools included in the framework if
the framework build i
Author: cbieneman
Date: Thu Jan 12 12:45:59 2017
New Revision: 291788
URL: http://llvm.org/viewvc/llvm-project?rev=291788&view=rev
Log:
[CMake] Fix finding LLDBWrapPython.cpp in Framework build
The framework build was constructing the path to LLDBWrapPython incorrectly. It
is apparently always i
Author: cbieneman
Date: Tue Jan 31 10:48:20 2017
New Revision: 293646
URL: http://llvm.org/viewvc/llvm-project?rev=293646&view=rev
Log:
NFC. Remove unused header include.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins
Author: cbieneman
Date: Tue Jan 31 10:59:46 2017
New Revision: 293647
URL: http://llvm.org/viewvc/llvm-project?rev=293647&view=rev
Log:
[CMake] Add LINK_LIBS and LINK_COMPONENTS options
This patch adds CMake options to add_lldb_library and add_lldb_executable for
specifying LLVM components and d
Author: cbieneman
Date: Tue Jan 31 14:43:05 2017
New Revision: 293686
URL: http://llvm.org/viewvc/llvm-project?rev=293686&view=rev
Log:
[CMake] Add accurate dependency specifications
Summary:
This patch adds accurate dependency specifications to the mail LLDB libraries
and tools.
In all cases e
Author: cbieneman
Date: Tue Jan 31 14:52:41 2017
New Revision: 293687
URL: http://llvm.org/viewvc/llvm-project?rev=293687&view=rev
Log:
[CMake] Fix broken NetBSD bots
http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd7/builds/4558/steps/cmake%20local/logs/stdio
Modified:
lldb/trunk/so
Author: cbieneman
Date: Tue Jan 31 15:12:52 2017
New Revision: 293690
URL: http://llvm.org/viewvc/llvm-project?rev=293690&view=rev
Log:
[CMake] Partial revert of r293686
This change reverts the lldb-server part of r293686, which is having trouble on
Linux bots. I'm not sure if I can make lldb-se
Author: cbieneman
Date: Tue Jan 31 16:12:59 2017
New Revision: 293696
URL: http://llvm.org/viewvc/llvm-project?rev=293696&view=rev
Log:
[CMake] Add explicit dependencies to plugins
Summary:
This patch does two things. First it updates all the ABI plugins with accurate
dependencies, and second it
Author: cbieneman
Date: Tue Jan 31 16:21:19 2017
New Revision: 293698
URL: http://llvm.org/viewvc/llvm-project?rev=293698&view=rev
Log:
[CMake] [1/4] Update a batch of plugins
This is extending the updates from r293696 to more LLDB plugins.
Modified:
lldb/trunk/source/Plugins/Disassembler/ll
Author: cbieneman
Date: Tue Jan 31 16:23:49 2017
New Revision: 293699
URL: http://llvm.org/viewvc/llvm-project?rev=293699&view=rev
Log:
[CMake] [2/4] Update a batch of plugins
This is extending the updates from r293696 to more LLDB plugins.
Modified:
lldb/trunk/source/Plugins/Language/CPlusP
Author: cbieneman
Date: Tue Jan 31 16:29:11 2017
New Revision: 293700
URL: http://llvm.org/viewvc/llvm-project?rev=293700&view=rev
Log:
[CMake] [3/4] Update a batch of plugins
This is extending the updates from r293696 to more LLDB plugins.
Modified:
lldb/trunk/source/Plugins/OperatingSystem
Author: cbieneman
Date: Tue Jan 31 16:31:38 2017
New Revision: 293701
URL: http://llvm.org/viewvc/llvm-project?rev=293701&view=rev
Log:
[CMake] [4/4] Update a batch of plugins
This is extending the updates from r293696 to more LLDB plugins.
Modified:
lldb/trunk/source/Plugins/ScriptInterpret
Author: cbieneman
Date: Wed Feb 1 16:17:00 2017
New Revision: 293821
URL: http://llvm.org/viewvc/llvm-project?rev=293821&view=rev
Log:
[CMake] Update unit tests with accurate dependencies
This is extending the updates from r293696 to the LLDB unit tests.
Modified:
lldb/trunk/unittests/Break
Author: cbieneman
Date: Tue Feb 7 17:33:58 2017
New Revision: 294372
URL: http://llvm.org/viewvc/llvm-project?rev=294372&view=rev
Log:
[CMake] Add explicit dependencies for ObjectFileELF tests
Modified:
lldb/trunk/unittests/ObjectFile/ELF/CMakeLists.txt
Modified: lldb/trunk/unittests/Object
Author: cbieneman
Date: Wed Feb 8 15:00:46 2017
New Revision: 294515
URL: http://llvm.org/viewvc/llvm-project?rev=294515&view=rev
Log:
[CMake] Final dependency cleanup patch!
Summary:
This patch removes the over-specified dependencies from LLDBDependencies and
instead relies on the dependencies
Author: cbieneman
Date: Wed Feb 8 15:24:51 2017
New Revision: 294521
URL: http://llvm.org/viewvc/llvm-project?rev=294521&view=rev
Log:
[CMake] Add dependency on Mips target if it is available
The Mips plugins conditionally link the Mips backend, so we need to
conditionally add the target as a d
Author: cbieneman
Date: Fri Feb 10 11:47:55 2017
New Revision: 294763
URL: http://llvm.org/viewvc/llvm-project?rev=294763&view=rev
Log:
Fix build issue with shared libraries reported via email
Modified:
lldb/trunk/source/Plugins/UnwindAssembly/x86/CMakeLists.txt
Modified: lldb/trunk/source/P
Author: cbieneman
Date: Fri Feb 10 12:37:02 2017
New Revision: 294767
URL: http://llvm.org/viewvc/llvm-project?rev=294767&view=rev
Log:
Fix another build issue with shared libraries on Linux
Modified:
lldb/trunk/source/Plugins/UnwindAssembly/x86/CMakeLists.txt
Modified: lldb/trunk/source/Plu
Author: cbieneman
Date: Fri Feb 10 12:39:26 2017
New Revision: 294768
URL: http://llvm.org/viewvc/llvm-project?rev=294768&view=rev
Log:
Fix another build issue with shared libraries on Linux
In r294767, I added these dependencies in the wrong place.
Modified:
lldb/trunk/source/Plugins/Disass
Author: cbieneman
Date: Mon Feb 13 15:16:01 2017
New Revision: 294986
URL: http://llvm.org/viewvc/llvm-project?rev=294986&view=rev
Log:
[CMake] Adding API dependency on Utility
Utility is directly referenced from API.
Modified:
lldb/trunk/source/API/CMakeLists.txt
Modified: lldb/trunk/sourc
Author: cbieneman
Date: Mon Feb 13 15:19:53 2017
New Revision: 294987
URL: http://llvm.org/viewvc/llvm-project?rev=294987&view=rev
Log:
[CMake] Adding API dependency on Utility
Utility is directly referenced from Breakpoint.
Modified:
lldb/trunk/source/Breakpoint/CMakeLists.txt
Modified: ll
Author: cbieneman
Date: Mon Mar 13 18:19:04 2017
New Revision: 297685
URL: http://llvm.org/viewvc/llvm-project?rev=297685&view=rev
Log:
[debugserver] This is a small cleanup patch to AVX support detection
Summary:
The first Sandybridge iMacs with AVX support shipped in Spring 2011 with Snow
Leop
Author: cbieneman
Date: Mon Mar 13 18:27:58 2017
New Revision: 297688
URL: http://llvm.org/viewvc/llvm-project?rev=297688&view=rev
Log:
[debugserver] NFC. Cleanup DNBArchImpl*::GetFPUState()
This patch consolidates the DEBUG_FPU_REGS code for i386 and x86_64 to take
advantage of the fact that th
Author: cbieneman
Date: Mon Mar 13 18:46:50 2017
New Revision: 297691
URL: http://llvm.org/viewvc/llvm-project?rev=297691&view=rev
Log:
[debugserver] NFC. Missed one bit of cleanup in r297688
I did this cleanup in the x86_64, but missed it in the i386 code. This just
simplifies the calls to thre
Author: cbieneman
Date: Tue Mar 14 15:01:24 2017
New Revision: 297774
URL: http://llvm.org/viewvc/llvm-project?rev=297774&view=rev
Log:
[debugserver] Fixing a small logic error from r297685
I had mixed up the logic during patch review. This resolves the test failure
reading YMM registers on Darw
Author: cbieneman
Date: Tue Mar 14 15:04:46 2017
New Revision: 297776
URL: http://llvm.org/viewvc/llvm-project?rev=297776&view=rev
Log:
[CMake] Override debugserver to use the build tree on Darwin
This patch adds support to the test suite for overriding the path to
debugserver, and uses the over
Author: cbieneman
Date: Tue Mar 14 17:24:36 2017
New Revision: 297787
URL: http://llvm.org/viewvc/llvm-project?rev=297787&view=rev
Log:
[debugserver] NFC. Cleanup Get/Set Register Value/Context
This patch modifies the Get/Set Register Value/Context functions for Intel to
not duplicate code for r
Author: cbieneman
Date: Wed Mar 15 14:52:57 2017
New Revision: 297880
URL: http://llvm.org/viewvc/llvm-project?rev=297880&view=rev
Log:
[debugserver] NFC. One more small cleanup to DNBArchImplX86_64::SetFPUState
This is another similar cleanup to other changes I've been making to simplify
the AV
beanz created this revision.
beanz added a subscriber: lldb-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20826
Files:
CMakeList
Author: cbieneman
Date: Tue May 31 15:21:44 2016
New Revision: 271328
URL: http://llvm.org/viewvc/llvm-project?rev=271328&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
beanz added a subscriber: beanz.
beanz added a comment.
@rengolin, thank you for putting this all together. It is very well thought
out, and I really like the shape it took. I have a few minor nitpick comments
inline.
Thanks,
-Chris
Comment at: docs/Proposals/GitHub.rst:58
@@
beanz created this revision.
beanz added reviewers: zturner, labath, jingham, tfiala.
beanz added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
This patch supplies basic infrastructure for LLDB to use LIT, and ports a few
basic test cases from the LLDB test suite into LIT.
beanz updated this revision to Diff 71452.
beanz added a comment.
Added lldb-server as a test dependency based on feedback from @tfiala.
https://reviews.llvm.org/D24591
Files:
lit/CMakeLists.txt
lit/Expr/Inputs/anonymous-struct.cpp
lit/Expr/Inputs/call-function.cpp
lit/Expr/TestCallStdS
beanz added a comment.
@zturner, on many of your comments I need to do some research and get back to
you. Particularly I need to understand how lit works on Windows better. I do
have one inline response.
@granata.enrico, we could migrate the existing tests into being executed by lit
even if th
beanz updated this revision to Diff 71460.
beanz added a comment.
- Use lit.util.which instead of constructing paths, which adds exe suffixes and
uses proper path seperators
- Fixed spelling error in list(APPEND ...) command
https://reviews.llvm.org/D24591
Files:
lit/CMakeLists.txt
lit/Exp
beanz added a comment.
@granata.enrico, it seems to me that this is a problem the people maintaining
the Xcode project should address. I know it is possible to create targets in
Xcode projects that call shell commands or makefiles (CMake does this). It is
therefore possible that the Xcode proje
beanz added inline comments.
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
+
Disallowing setting both seems reasonable to me. I'm not entirely sure how to
connect `LLDB_TEST_COMPILER` up i
beanz added a comment.
@zturner, we can absolutely add flags into the substitutions. Other projects do
that too.
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
+
zturner wrote:
> beanz wr
beanz updated this revision to Diff 71537.
beanz added a comment.
- Removed the XFAIL for icc
- Added support for LLDB_TEST__COMPILER options
Assuming there are no objections, since the patch has been approved by two
reviewers I'll commit it this afternoon.
Thanks,
-Chris
https://reviews.llvm
Author: cbieneman
Date: Thu Sep 15 15:13:55 2016
New Revision: 281651
URL: http://llvm.org/viewvc/llvm-project?rev=281651&view=rev
Log:
[LIT] First pass of LLDB LIT support
Summary:
This patch supplies basic infrastructure for LLDB to use LIT, and ports a few
basic test cases from the LLDB test
Author: cbieneman
Date: Thu Sep 15 15:23:31 2016
New Revision: 281652
URL: http://llvm.org/viewvc/llvm-project?rev=281652&view=rev
Log:
Fixing bot failures
Need to only add debugserver as a test dependency on Darwin.
Modified:
lldb/trunk/lit/CMakeLists.txt
Modified: lldb/trunk/lit/CMakeList
beanz created this revision.
beanz added reviewers: zturner, tfiala.
beanz added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
This patch adds a CMake option LLDB_BUILD_FRAMEWORK, which builds libLLDB as a
macOS framework instead of as a *nix shared library.
With this patc
beanz added a comment.
I've tested this on OS X with and without `LLDB_BUILD_FRAMEWORK` set, and
check-lldb works in both cases. I would expect it to also work on Linux and
Windows. The change should be NFC if `LLDB_BUILD_FRAMEWORK=Off`.
Comment at: scripts/Python/finishSwigPy
beanz updated this revision to Diff 72097.
beanz added a comment.
- Use INSTALL_RPATH and BUILD_WITH_INSTALL_RPATH instead of manually setting
the rpath linker flags
https://reviews.llvm.org/D24749
Files:
CMakeLists.txt
cmake/LLDBDependencies.cmake
cmake/modules/AddLLDB.cmake
cmake/mod
Author: cbieneman
Date: Wed Sep 21 16:02:16 2016
New Revision: 282110
URL: http://llvm.org/viewvc/llvm-project?rev=282110&view=rev
Log:
[CMake] Initial support for LLDB.framework
Summary:
This patch adds a CMake option LLDB_BUILD_FRAMEWORK, which builds libLLDB as a
macOS framework instead of as
Author: cbieneman
Date: Thu Sep 22 16:08:27 2016
New Revision: 282196
URL: http://llvm.org/viewvc/llvm-project?rev=282196&view=rev
Log:
[CMake] Fixing a small hack in add_lldb_library
This code was adding an explicit dependency on libclang because lldb needs
clang headers, changing this to inste
still doing this?
>
>
> On Thu, Sep 22, 2016 at 2:17 PM Chris Bieneman via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
> Author: cbieneman
> Date: Thu Sep 22 16:08:27 2016
> New Revision: 282196
>
> URL: http://llvm.org/viewvc/llvm-project?rev=28
w.
>
> -Chris
>
>> On Sep 22, 2016, at 2:21 PM, Zachary Turner > <mailto:ztur...@google.com>> wrote:
>>
>> At the end of the day though, lldb DOES need to link against libclang. Is
>> it still doing this?
>>
>>
>> On Thu, Sep 22, 2
beanz created this revision.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
This alters the generation of LLDB_REVISION to be heavily based on how clang
generates its version header. There are two benefits of this aproach.
beanz added a comment.
Putting this in LLVM would be ideal, but I think doing that requires a larger
refactoring of how LLVM and Clang handle SCM versions. I was kinda hoping to
land this and fix the lldb support, but if you'd prefer I can shelve this until
after fixing LLVM & Clang.
https://
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
Making static archives only have dependencies on other static archives has
serious implications and fundamentally breaks `LLVM_LINK_LLVM_DYLIB`. For
example:
libClangDriver.a depends
Author: cbieneman
Date: Fri Sep 23 18:33:52 2016
New Revision: 282314
URL: http://llvm.org/viewvc/llvm-project?rev=282314&view=rev
Log:
[CMake] Generate LLDB_REVISION at build time
Summary:
This alters the generation of LLDB_REVISION to be heavily based on how clang
generates its version header.
Author: cbieneman
Date: Thu Sep 29 17:55:09 2016
New Revision: 282803
URL: http://llvm.org/viewvc/llvm-project?rev=282803&view=rev
Log:
[CMake] LLDB/Expression needs to depend on intrinsics_gen
IRExecutionUnit.h includes Module.h, which through a long chain of includes
eventually includes Attrib
Author: cbieneman
Date: Sun Oct 2 19:03:43 2016
New Revision: 283081
URL: http://llvm.org/viewvc/llvm-project?rev=283081&view=rev
Log:
[CMake] Fixing a few missing dependencies on intrinsics_gen
These are missing dependencies that have been exposed in builds as a result of
my change to make lld
Author: Chris Bieneman
Date: 2022-03-29T14:46:24-05:00
New Revision: dfde354958ca49138349e1428bf2fc0414a73a43
URL:
https://github.com/llvm/llvm-project/commit/dfde354958ca49138349e1428bf2fc0414a73a43
DIFF:
https://github.com/llvm/llvm-project/commit/dfde354958ca49138349e1428bf2fc0414a73a43.diff
101 - 188 of 188 matches
Mail list logo
