[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

[Chris Bieneman via lldb-commits]

beanz added inline comments.


================
Comment at: 
packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23
     @skipIfRemote
-    @skipUnlessCompilerRt
     @skipUnlessThreadSanitizer
     def test(self):
----------------
tfiala wrote:
> Seems fine as long as @skipUnlessThreadSanitizer is doing the right type of 
> check like you added for @skipUnlessAddressSanitizer.
The implementation of `skipUnlessAddressSanitizer` is basically 
copy-paste-simplify-modify of `skipUnlessThreadSanitizer`. They should both 
have good coverage.


https://reviews.llvm.org/D26513



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits