Re: [Lldb-commits] [lldb] r316800 - [CMake] Build clang as dependency when using in-tree clang for tests.

2017-11-17 Thread Chris Bieneman via lldb-commits
A few notes on this change. > On Oct 27, 2017, at 2:22 PM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Fri Oct 27 14:22:57 2017 > New Revision: 316800 > > URL: http://llvm.org/viewvc/llvm-project?rev=316800&view=rev > Log: > [CMake] Build clang as dependency when using

Re: [Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

2017-03-30 Thread Chris Bieneman via lldb-commits
I had a talk with Lang about the ExecutionEngine library structuring, and it sounds like there are some problems there that need to be worked out. Luckily for this specific case, I think the solution is actually quite simple: ``` diff --git a/include/llvm/ExecutionEngine/ExecutionEngine.h b/inc

[Lldb-commits] [lldb] r300111 - Support Unit Testing debugserver

2017-04-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 12 16:56:29 2017 New Revision: 300111 URL: http://llvm.org/viewvc/llvm-project?rev=300111&view=rev Log: Support Unit Testing debugserver Summary: This patch refactors the CMake build system's support for building debugserver to allow us to build the majority of de

[Lldb-commits] [lldb] r300112 - [NFC] Adding a new wrapper for getaddrinfo

2017-04-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 12 16:56:33 2017 New Revision: 300112 URL: http://llvm.org/viewvc/llvm-project?rev=300112&view=rev Log: [NFC] Adding a new wrapper for getaddrinfo Summary: This patch adds a new wrapper for getaddrinfo which returns a std::vector of SocketAddresses. While this pat

[Lldb-commits] [lldb] r300372 - [CMake] Support generating Config.h

2017-04-14 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Apr 14 17:03:45 2017 New Revision: 300372 URL: http://llvm.org/viewvc/llvm-project?rev=300372&view=rev Log: [CMake] Support generating Config.h Summary: This patch removes the hand maintained config files in favor of auto-generating the config file. We will still need

[Lldb-commits] [lldb] r300374 - Fix bot breakage from r300372

2017-04-14 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Apr 14 17:20:36 2017 New Revision: 300374 URL: http://llvm.org/viewvc/llvm-project?rev=300374&view=rev Log: Fix bot breakage from r300372 Use #cmakedefine instead of #cmakedefine01 because the uses are ifndef instead of if. Modified: lldb/trunk/include/lldb/Host/

[Lldb-commits] [lldb] r300579 - Update LLDB Host to support IPv6 over TCP

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:01:52 2017 New Revision: 300579 URL: http://llvm.org/viewvc/llvm-project?rev=300579&view=rev Log: Update LLDB Host to support IPv6 over TCP Summary: This patch adds IPv6 support to LLDB/Host's TCP socket implementation. Supporting IPv6 involved a few signifi

[Lldb-commits] [lldb] r300580 - Update DebugServer to support IPv6 over TCP

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:01:59 2017 New Revision: 300580 URL: http://llvm.org/viewvc/llvm-project?rev=300580&view=rev Log: Update DebugServer to support IPv6 over TCP Summary: This patch adds IPv6 support to debugserver. It follows a similar pattern to the changes proposed for LLDB/

[Lldb-commits] [lldb] r300582 - Fixing bot failure caused by r300579

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:08:29 2017 New Revision: 300582 URL: http://llvm.org/viewvc/llvm-project?rev=300582&view=rev Log: Fixing bot failure caused by r300579 Modified: lldb/trunk/source/Host/common/Socket.cpp Modified: lldb/trunk/source/Host/common/Socket.cpp URL: http://llvm

[Lldb-commits] [lldb] r300587 - Fix broken windows build.

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:37:05 2017 New Revision: 300587 URL: http://llvm.org/viewvc/llvm-project?rev=300587&view=rev Log: Fix broken windows build. This is not ideal, but it should get the bot going again. I'll need to revisit this if we want to get signal handling working on Windo

[Lldb-commits] [lldb] r300589 - Writing multi-platform code is hard...

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:49:05 2017 New Revision: 300589 URL: http://llvm.org/viewvc/llvm-project?rev=300589&view=rev Log: Writing multi-platform code is hard... Fixing another error from r300579. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/

[Lldb-commits] [lldb] r300590 - [CMake] Adding configure-time check for sigaction

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 15:49:09 2017 New Revision: 300590 URL: http://llvm.org/viewvc/llvm-project?rev=300590&view=rev Log: [CMake] Adding configure-time check for sigaction Hopefully this will fix the netbsd bot that I broke... Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] r300605 - Removing unused include

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 16:23:55 2017 New Revision: 300605 URL: http://llvm.org/viewvc/llvm-project?rev=300605&view=rev Log: Removing unused include This is causing the Windows bot failures. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/Host/com

[Lldb-commits] [lldb] r300606 - Fixing error on Android build (-Werror)

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 16:35:26 2017 New Revision: 300606 URL: http://llvm.org/viewvc/llvm-project?rev=300606&view=rev Log: Fixing error on Android build (-Werror) This is fallout from r300579. Modified: lldb/trunk/source/Host/common/UDPSocket.cpp Modified: lldb/trunk/source/Hos

[Lldb-commits] [lldb] r300610 - Fix Windows bot failure

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 16:47:50 2017 New Revision: 300610 URL: http://llvm.org/viewvc/llvm-project?rev=300610&view=rev Log: Fix Windows bot failure timespec is not available on Windows, and we should use size_t instead of nfds_t. Modified: lldb/trunk/source/Host/common/MainLoop.

Re: [Lldb-commits] [lldb] r300610 - Fix Windows bot failure

2017-04-18 Thread Chris Bieneman via lldb-commits
t;https://msdn.microsoft.com/en-us/library/mt633792.aspx> > > I suspect somebody had suppressed it for some reason. > > On Tue, Apr 18, 2017 at 2:47 PM, Chris Bieneman via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: cbieneman > Date: Tue Apr 1

[Lldb-commits] [lldb] r300615 - Include time.h, and fix a Darwin warning

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 17:11:13 2017 New Revision: 300615 URL: http://llvm.org/viewvc/llvm-project?rev=300615&view=rev Log: Include time.h, and fix a Darwin warning This is a little more cleanup from r300579. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/tr

[Lldb-commits] [lldb] r300618 - Define HAVE_SIGACTION to 1 in Xcode build

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 17:37:00 2017 New Revision: 300618 URL: http://llvm.org/viewvc/llvm-project?rev=300618&view=rev Log: Define HAVE_SIGACTION to 1 in Xcode build This is needed to make the Xcode project build since it doesn't have auto-generated Config header. Modified: lldb

[Lldb-commits] [lldb] r300636 - ifdefing out the signal handling code on Windows

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 20:00:16 2017 New Revision: 300636 URL: http://llvm.org/viewvc/llvm-project?rev=300636&view=rev Log: ifdefing out the signal handling code on Windows *fingers crossed* This might fix the Window bots, but I really don't know... Modified: lldb/trunk/source/H

[Lldb-commits] [lldb] r300638 - Buildbot wack-a-mole!

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 20:15:17 2017 New Revision: 300638 URL: http://llvm.org/viewvc/llvm-project?rev=300638&view=rev Log: Buildbot wack-a-mole! This should fix the netbsd bot I just broke. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/Host/co

[Lldb-commits] [lldb] r300640 - Another netbsd build failure...

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 20:17:29 2017 New Revision: 300640 URL: http://llvm.org/viewvc/llvm-project?rev=300640&view=rev Log: Another netbsd build failure... Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/Host/common/MainLoop.cpp URL: http://llvm.

[Lldb-commits] [lldb] r300647 - One more attempt and Windows

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 20:32:08 2017 New Revision: 300647 URL: http://llvm.org/viewvc/llvm-project?rev=300647&view=rev Log: One more attempt and Windows This is the last Windows compile error, so... Hit me with your best shot. Modified: lldb/trunk/source/Host/common/MainLoop.cpp

[Lldb-commits] [lldb] r300654 - [CMake] Add configure check for sys/event.h

2017-04-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Apr 18 21:53:53 2017 New Revision: 300654 URL: http://llvm.org/viewvc/llvm-project?rev=300654&view=rev Log: [CMake] Add configure check for sys/event.h This enables the kqueue path in MainLoop for Darwin and BSD. Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] r301492 - Re-landing IPv6 support for LLDB Host

2017-04-26 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 26 18:17:20 2017 New Revision: 301492 URL: http://llvm.org/viewvc/llvm-project?rev=301492&view=rev Log: Re-landing IPv6 support for LLDB Host This support was landed in r300579, and reverted in r300669 due to failures on the bots. The failures were caused by sock

[Lldb-commits] [lldb] r301502 - Fix Windows bots broken by r301492

2017-04-26 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 26 19:03:27 2017 New Revision: 301502 URL: http://llvm.org/viewvc/llvm-project?rev=301502&view=rev Log: Fix Windows bots broken by r301492 http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015/builds/8644/ Modified: lldb/trunk/source/Host/common/TCPSocke

[Lldb-commits] [lldb] r301504 - One more attempt to fix the broken bots.

2017-04-26 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 26 19:23:41 2017 New Revision: 301504 URL: http://llvm.org/viewvc/llvm-project?rev=301504&view=rev Log: One more attempt to fix the broken bots. Modified: lldb/trunk/source/Host/common/TCPSocket.cpp Modified: lldb/trunk/source/Host/common/TCPSocket.cpp URL: h

[Lldb-commits] [lldb] r301506 - One more try at the whole compiling thing...

2017-04-26 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Apr 26 19:47:19 2017 New Revision: 301506 URL: http://llvm.org/viewvc/llvm-project?rev=301506&view=rev Log: One more try at the whole compiling thing... Need to actually use the right type in both parts of the cast. Modified: lldb/trunk/source/Host/common/TCPSocke

[Lldb-commits] [lldb] r301553 - [CMake] Abstract Config.h generation for Xcode

2017-04-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Apr 27 11:04:26 2017 New Revision: 301553 URL: http://llvm.org/viewvc/llvm-project?rev=301553&view=rev Log: [CMake] Abstract Config.h generation for Xcode This patch abstracts the generation of Config.h and creates a dummy project entry point to allow generation of LL

[Lldb-commits] [lldb] r301559 - Update GDB remote command regex for IPv6

2017-04-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Apr 27 11:13:58 2017 New Revision: 301559 URL: http://llvm.org/viewvc/llvm-project?rev=301559&view=rev Log: Update GDB remote command regex for IPv6 This updates the regular expression used to match host/port pairs for the gdb-remote command to also match IPv6 address

[Lldb-commits] [lldb] r301579 - Fix GreenDragon bots

2017-04-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Apr 27 14:45:13 2017 New Revision: 301579 URL: http://llvm.org/viewvc/llvm-project?rev=301579&view=rev Log: Fix GreenDragon bots We don't actually need to include Compiler.h here because it is only used on Windows and Windows/PosixAPI.h includes it. Modified: lld

[Lldb-commits] [lldb] r301580 - NFC. Add comment about debugserver usage

2017-04-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Apr 27 14:45:16 2017 New Revision: 301580 URL: http://llvm.org/viewvc/llvm-project?rev=301580&view=rev Log: NFC. Add comment about debugserver usage This just adds a comment to SocketAddress about it being used by debugserver and the implications of that. If we need

[Lldb-commits] [lldb] r301581 - Fixing Windows bot

2017-04-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Apr 27 14:56:54 2017 New Revision: 301581 URL: http://llvm.org/viewvc/llvm-project?rev=301581&view=rev Log: Fixing Windows bot URL: http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015/builds/8700 Modified: lldb/trunk/include/lldb/Host/PosixApi.h Modified:

[Lldb-commits] [lldb] r302282 - Fix UDP Socket connections

2017-05-05 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri May 5 15:35:50 2017 New Revision: 302282 URL: http://llvm.org/viewvc/llvm-project?rev=302282&view=rev Log: Fix UDP Socket connections Some of the refactoring in r301492 broke UDP socket connections. This is a partial revert of that refactoring. At some point I'll spe

[Lldb-commits] [lldb] r307957 - Fix debugserver accepting remote connections

2017-07-13 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Jul 13 13:58:13 2017 New Revision: 307957 URL: http://llvm.org/viewvc/llvm-project?rev=307957&view=rev Log: Fix debugserver accepting remote connections While adding IPv6 support to debugserver I broke handling wildcard addresses and fully qualified address filtering.

[Lldb-commits] [lldb] r308376 - [CMake] [NFC] Remove out of date and redundant version requirement

2017-07-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 18 14:15:14 2017 New Revision: 308376 URL: http://llvm.org/viewvc/llvm-project?rev=308376&view=rev Log: [CMake] [NFC] Remove out of date and redundant version requirement Since we set the minimum required version elsewhere to be higher this actually has meaningful

[Lldb-commits] [lldb] r308377 - [CMake] Refactor debugserver build system

2017-07-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 18 14:15:27 2017 New Revision: 308377 URL: http://llvm.org/viewvc/llvm-project?rev=308377&view=rev Log: [CMake] Refactor debugserver build system This refactoring changes two significant things about how the debugserver build system works: (1) debugserver will in

[Lldb-commits] [lldb] r308378 - [CMake] A few fixups to support building LLDB for iOS

2017-07-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 18 14:15:53 2017 New Revision: 308378 URL: http://llvm.org/viewvc/llvm-project?rev=308378&view=rev Log: [CMake] A few fixups to support building LLDB for iOS These changes enable proper configuration of LLDB targeting iOS. Modified: lldb/trunk/cmake/modules/LL

[Lldb-commits] [lldb] r308509 - Fix GreenDragon bots

2017-07-19 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Jul 19 11:57:16 2017 New Revision: 308509 URL: http://llvm.org/viewvc/llvm-project?rev=308509&view=rev Log: Fix GreenDragon bots This commit removes a very old deprecated API that was causing compile failures for LLDB on Darwin. Since the comment says we only needed t

[Lldb-commits] [lldb] r309020 - [CMake] Add debugserver entitlements

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:29:28 2017 New Revision: 309020 URL: http://llvm.org/viewvc/llvm-project?rev=309020&view=rev Log: [CMake] Add debugserver entitlements When consigning debugserver we should also include the entitlements file on the code sign command. Modified: lldb/trun

[Lldb-commits] [lldb] r309021 - [CMake] Cleanup unnecessary definition

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:29:45 2017 New Revision: 309021 URL: http://llvm.org/viewvc/llvm-project?rev=309021&view=rev Log: [CMake] Cleanup unnecessary definition This is only used in one file, and we already set it correctly on that file, so we don't need to set this everywhere. Mo

[Lldb-commits] [lldb] r309022 - [CMake] NFC. Cleanup unnecessary CMake policy

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:18 2017 New Revision: 309022 URL: http://llvm.org/viewvc/llvm-project?rev=309022&view=rev Log: [CMake] NFC. Cleanup unnecessary CMake policy This is just setting to the default behavior, so it does nothing. Modified: lldb/trunk/cmake/modules/LLDBStand

[Lldb-commits] [lldb] r309023 - [CMake] Fix framework build

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:35 2017 New Revision: 309023 URL: http://llvm.org/viewvc/llvm-project?rev=309023&view=rev Log: [CMake] Fix framework build The LLDB framework build looks for the swig-generated source in the wrong place. This should resolve that. Modified: lldb/trunk

[Lldb-commits] [lldb] r309024 - [CMake] Rework construction of framework bundle

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:30:58 2017 New Revision: 309024 URL: http://llvm.org/viewvc/llvm-project?rev=309024&view=rev Log: [CMake] Rework construction of framework bundle This adds an explicit step for processing the headers and restructures how the framework bundles are constructed

[Lldb-commits] [lldb] r309025 - [CMake] Update Framework construction for iOS

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:31:15 2017 New Revision: 309025 URL: http://llvm.org/viewvc/llvm-project?rev=309025&view=rev Log: [CMake] Update Framework construction for iOS On iOS frameworks don't have versions or resources, they are flatter bundles. This updates the LLDB framework buil

[Lldb-commits] [lldb] r309026 - [CMake] Build debugserver & debugserver_nonui

2017-07-25 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jul 25 13:31:53 2017 New Revision: 309026 URL: http://llvm.org/viewvc/llvm-project?rev=309026&view=rev Log: [CMake] Build debugserver & debugserver_nonui When building for iOS we build two variants of debugserver. One which supports UI functionality like Springboard f

[Lldb-commits] [lldb] r309392 - [CMake] Adapt to clang r309390

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:49 2017 New Revision: 309392 URL: http://llvm.org/viewvc/llvm-project?rev=309392&view=rev Log: [CMake] Adapt to clang r309390 This removes the configuration order dependence between LLDB and Clang. Modified: lldb/trunk/cmake/modules/AddLLDB.cmake Mod

[Lldb-commits] [lldb] r309393 - [CMake] Enable OS_LOG support on Darwin

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:50 2017 New Revision: 309393 URL: http://llvm.org/viewvc/llvm-project?rev=309393&view=rev Log: [CMake] Enable OS_LOG support on Darwin This gets CMake to match the Xcode project build Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeList

[Lldb-commits] [lldb] r309394 - [CMake] Cleanup of header fixup and installation

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:51 2017 New Revision: 309394 URL: http://llvm.org/viewvc/llvm-project?rev=309394&view=rev Log: [CMake] Cleanup of header fixup and installation This patch does the following: * Gets the header copy step to re-run whenever header change * Gets the header f

[Lldb-commits] [lldb] r309395 - [CMake] Add checks for libcompression

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:51 2017 New Revision: 309395 URL: http://llvm.org/viewvc/llvm-project?rev=309395&view=rev Log: [CMake] Add checks for libcompression This enables libcompression when available in the CMake build system. Modified: lldb/trunk/cmake/modules/LLDBGenerateC

[Lldb-commits] [lldb] r309396 - [CMake] libcompression is optional not required for debugserver

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:44:16 2017 New Revision: 309396 URL: http://llvm.org/viewvc/llvm-project?rev=309396&view=rev Log: [CMake] libcompression is optional not required for debugserver Fix a quick bug from r309395. Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt

[Lldb-commits] [lldb] r309428 - [CMake] debugserver-nonui doesn't go in the framework

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 13:27:37 2017 New Revision: 309428 URL: http://llvm.org/viewvc/llvm-project?rev=309428&view=rev Log: [CMake] debugserver-nonui doesn't go in the framework Small change to correct the install path of the nonui debugserver. Modified: lldb/trunk/tools/debugser

[Lldb-commits] [lldb] r309429 - [CMake] Add SharingPtr.h to the Framework header list

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 13:27:38 2017 New Revision: 309429 URL: http://llvm.org/viewvc/llvm-project?rev=309429&view=rev Log: [CMake] Add SharingPtr.h to the Framework header list lldb-forward.h which is a public header uses SharingPtr, so we need to include that header as well. Modif

[Lldb-commits] [lldb] r310936 - [CMake] Disable code sign entitlements when using lldb_codesign

2017-08-15 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Aug 15 10:42:20 2017 New Revision: 310936 URL: http://llvm.org/viewvc/llvm-project?rev=310936&view=rev Log: [CMake] Disable code sign entitlements when using lldb_codesign Turns out self-signed certificates and entitlements don't always play well together... Modified

[Lldb-commits] [lldb] r310955 - [CMake] Fixing an error in STREQUAL usage.

2017-08-15 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Aug 15 13:56:04 2017 New Revision: 310955 URL: http://llvm.org/viewvc/llvm-project?rev=310955&view=rev Log: [CMake] Fixing an error in STREQUAL usage. Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt Modified: lldb/trunk/tools/debugserver/source/CMakeL

[Lldb-commits] [lldb] r312008 - [IPv6] Fix a bug in the IPv6 listen behavior

2017-08-29 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Aug 29 09:13:41 2017 New Revision: 312008 URL: http://llvm.org/viewvc/llvm-project?rev=312008&view=rev Log: [IPv6] Fix a bug in the IPv6 listen behavior The socket bind address should either be localhost or anyaddress. This bug in the listen behavior was preventing ll

[Lldb-commits] [lldb] r312666 - [CMake] Need to set WITH_LOCKDOWN on debugserver target

2017-09-06 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Sep 6 13:15:43 2017 New Revision: 312666 URL: http://llvm.org/viewvc/llvm-project?rev=312666&view=rev Log: [CMake] Need to set WITH_LOCKDOWN on debugserver target Turns out WITH_LOCKDOWN define changes the struct layout and constructor implementation for RNBSocket wh

[Lldb-commits] [lldb] r315120 - [CMake] Add LLDB_INCLUDE_TESTS variable

2017-10-06 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Oct 6 15:21:36 2017 New Revision: 315120 URL: http://llvm.org/viewvc/llvm-project?rev=315120&view=rev Log: [CMake] Add LLDB_INCLUDE_TESTS variable This behaves like the other *_INCLUDE_TESTS variables in CMake and is tied to LLVM_INCLUDE_TESTS so that if you're build

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. The test suite calls realpath on the lldb executable then append "-mi" to it to find the path of the lldb-mi executable. This does not work when using CMake builds on *nix platforms. On *

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Default installations of OS X do not have system headers installed at /usr/include. This patch allows the LLDB test executables to properly compile when built on a system without headers

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works for the Xcode project builds, but fails for CMake builds regardless of wh

[Lldb-commits] [PATCH] D25489: Use LLDB_SRC for relative paths

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Going from LLDB_SRC instead of the file path is safer when looking for compiler-rt. Also need to add support for looking inside the LLVM runtimes subdirectory. Eventually we should just

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This patch adds the following fixes to the check-lldb targets: - Adds missing dependencies on lldb tools so they get built before tests execute - Adds Ni

[Lldb-commits] [lldb] r284041 - Fix lookup path for lldb-mi

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:15:46 2016 New Revision: 284041 URL: http://llvm.org/viewvc/llvm-project?rev=284041&view=rev Log: Fix lookup path for lldb-mi Summary: The test suite calls realpath on the lldb executable then append "-mi" to it to find the path of the lldb-mi executable. Th

[Lldb-commits] [lldb] r284042 - Fix building tests without system headers on Darwin

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:19:19 2016 New Revision: 284042 URL: http://llvm.org/viewvc/llvm-project?rev=284042&view=rev Log: Fix building tests without system headers on Darwin Summary: Default installations of OS X do not have system headers installed at /usr/include. This patch allo

[Lldb-commits] [lldb] r284043 - Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:22:02 2016 New Revision: 284043 URL: http://llvm.org/viewvc/llvm-project?rev=284043&view=rev Log: Fix test suite lookup path for LLDB.h Summary: When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added a comment. @labath I think having them running is useful. At the moment that is probably the only Darwin bot building LLDB using CMake. https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

[Lldb-commits] [lldb] r284045 - Use LLDB_SRC for relative paths

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:24:42 2016 New Revision: 284045 URL: http://llvm.org/viewvc/llvm-project?rev=284045&view=rev Log: Use LLDB_SRC for relative paths Summary: Going from LLDB_SRC instead of the file path is safer when looking for compiler-rt. Also need to add support for lookin

[Lldb-commits] [lldb] r284046 - [CMake] Cleanup check-lldb targets

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:26:13 2016 New Revision: 284046 URL: http://llvm.org/viewvc/llvm-project?rev=284046&view=rev Log: [CMake] Cleanup check-lldb targets Summary: This patch adds the following fixes to the check-lldb targets: * Adds missing dependencies on lldb tools so they get

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:676-677 # If not found, disable the lldb-mi tests -lldbMiExec = None -if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"): -lldbMiExec = lldbtest_config.lld

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

2016-10-13 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner, spyffe. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This patch adds support for installing public headers in LLDB.framework, and symlinking the headers into the build directory. While writing the

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

2016-10-13 Thread Chris Bieneman via lldb-commits
beanz added a comment. Worth noting, the CMake bug now has a fix in a pull request: https://gitlab.kitware.com/cmake/cmake/merge_requests/172 https://reviews.llvm.org/D25570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [lldb] r284250 - [CMake] Populate LLDB.framework's headers directory

2016-10-14 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Oct 14 12:09:55 2016 New Revision: 284250 URL: http://llvm.org/viewvc/llvm-project?rev=284250&view=rev Log: [CMake] Populate LLDB.framework's headers directory Summary: This patch adds support for installing public headers in LLDB.framework, and symlinking the headers

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: zturner, tfiala. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. Not everyone names their code sign identity "lldb_codesign", so it is nice to allow this to be overridden. https://reviews.llvm.org/D25714 Files: pa

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz added a comment. Maybe we should define `LLVM_CMAKE_PATH` in llvm's CMakeLists.txt so that we don't need a condition here or in clang where we do the same thing? https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz updated this revision to Diff 75057. beanz added a comment. Updating to use lldbtest_config. https://reviews.llvm.org/D25714 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/dotest_args.py packages/Python/lldbsuite/test/lldbtest.py test/CMakeLists.txt

[Lldb-commits] [PATCH] D25745: [CMake] Rename lldb-launcher to darwin-debug

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This tool is only built on Darwin, and the name darwin-debug matches the Xcode project. We should have this in sync unless there is a good reason not to.

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added a reviewer: tfiala. beanz added a subscriber: lldb-commits. If a user has their shell set to a non-POSIX conferment shell the TestTerminal.py tests fail because the shell blurb constructed here may not work in their shell. In my specific case fish-shell

[Lldb-commits] [PATCH] D25751: [CMake] Don't include LLDB_TEST_COMPILER in cached variable

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner, labath. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. CMake has no builtin mechanism for cache invalidation. As a general convention you want to not expand user-specified variables in other cached va

[Lldb-commits] [PATCH] D25753: Use clang --driver-mode instead of guessing c++ compiler path

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner, labath. beanz added a subscriber: lldb-commits. When building the LLDB test programs, if your CC is clang it actually isn't safe to make CXX a string replace of "clang -> clang++". This falls down on unix configurations if your

[Lldb-commits] [lldb] r284550 - Use clang --driver-mode instead of guessing c++ compiler path

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 18:53:24 2016 New Revision: 284550 URL: http://llvm.org/viewvc/llvm-project?rev=284550&view=rev Log: Use clang --driver-mode instead of guessing c++ compiler path Summary: When building the LLDB test programs, if your CC is clang it actually isn't safe to make

[Lldb-commits] [lldb] r284551 - [CMake] Don't include LLDB_TEST_COMPILER in cached variable

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 18:54:28 2016 New Revision: 284551 URL: http://llvm.org/viewvc/llvm-project?rev=284551&view=rev Log: [CMake] Don't include LLDB_TEST_COMPILER in cached variable Summary: CMake has no builtin mechanism for cache invalidation. As a general convention you want to

[Lldb-commits] [lldb] r284552 - When invoking Terminal, don't assume the default shell

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 18:55:34 2016 New Revision: 284552 URL: http://llvm.org/viewvc/llvm-project?rev=284552&view=rev Log: When invoking Terminal, don't assume the default shell Summary: If a user has their shell set to a non-POSIX conferment shell the TestTerminal.py tests fail bec

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

2016-10-18 Thread Chris Bieneman via lldb-commits
beanz added a comment. @joerg, it is OS X exclusive, and bash is the system default shell, so I think that makes sense. Repository: rL LLVM https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [lldb] r284555 - Fixing the linux bots I broke in r284550

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 19:13:56 2016 New Revision: 284555 URL: http://llvm.org/viewvc/llvm-project?rev=284555&view=rev Log: Fixing the linux bots I broke in r284550 Need to gate cxx linker adding driver-mode flag based on the linker being clang. Modified: lldb/trunk/packages/Pyth

[Lldb-commits] [lldb] r284564 - Trying to fix a few more missing LDFLAGS.

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 21:31:31 2016 New Revision: 284564 URL: http://llvm.org/viewvc/llvm-project?rev=284564&view=rev Log: Trying to fix a few more missing LDFLAGS. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r284565 - Revert back to the state before r284550

2016-10-18 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Oct 18 21:44:20 2016 New Revision: 284565 URL: http://llvm.org/viewvc/llvm-project?rev=284565&view=rev Log: Revert back to the state before r284550 This patch is causing a lot of issues on bots that I didn't see in local testing. I'm going to have to work on this. Rev

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

2016-10-20 Thread Chris Bieneman via lldb-commits
beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. `LLDB_PATH_TO_LLVM_BUILD` is a swift-ism that doesn't match LLVM's CMake conventions. In LLVM we don't pass in the path to build directories, instead we pass in `LLVM_CONFIG` to standa

[Lldb-commits] [lldb] r284756 - Re-landing a cleaned up implementation of r284550

2016-10-20 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Oct 20 13:01:19 2016 New Revision: 284756 URL: http://llvm.org/viewvc/llvm-project?rev=284756&view=rev Log: Re-landing a cleaned up implementation of r284550 This time it should actually work. The previous implementaiton was not getting the linker or compiler flag set

[Lldb-commits] [lldb] r284854 - [CMake] Fix standalone build

2016-10-21 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Oct 21 13:38:44 2016 New Revision: 284854 URL: http://llvm.org/viewvc/llvm-project?rev=284854&view=rev Log: [CMake] Fix standalone build not and FileCheck targets may not be defined in standalone builds. Modified: lldb/trunk/lit/CMakeLists.txt Modified: lldb/trun

[Lldb-commits] [lldb] r284893 - [Test Suite] Allow overriding codesign identity

2016-10-21 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Oct 21 17:13:55 2016 New Revision: 284893 URL: http://llvm.org/viewvc/llvm-project?rev=284893&view=rev Log: [Test Suite] Allow overriding codesign identity Summary: Not everyone names their code sign identity "lldb_codesign", so it is nice to allow this to be overridd

[Lldb-commits] [PATCH] D25886: [Test Suite] Properly respect --framework option

2016-10-21 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added a reviewer: tfiala. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. dotest.py has a framework option that is not respected. This patch makes the framework path properly configurable via the --framework option. This patch also ad

[Lldb-commits] [PATCH] D25887: [Test Suite] Pull generateSource into lldbtest

2016-10-21 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Convert tests using LLDB headers to use generateSource to put the right include paths in place regardless of whether or not you're building a framework. This also abstracted generateSourc

[Lldb-commits] [PATCH] D25745: [CMake] Rename lldb-launcher to darwin-debug

2016-10-21 Thread Chris Bieneman via lldb-commits
beanz updated this revision to Diff 75507. beanz added a comment. Cleaning up extra references to lldb-launcher https://reviews.llvm.org/D25745 Files: scripts/Python/finish-swig-Python-LLDB.sh scripts/Python/finishSwigPythonLLDB.py tools/darwin-debug/CMakeLists.txt Index: tools/darwin-d

[Lldb-commits] [lldb] r285356 - [CMake] Rename lldb-launcher to darwin-debug

2016-10-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Oct 27 17:51:41 2016 New Revision: 285356 URL: http://llvm.org/viewvc/llvm-project?rev=285356&view=rev Log: [CMake] Rename lldb-launcher to darwin-debug Summary: This tool is only built on Darwin, and the name darwin-debug matches the Xcode project. We should have thi

[Lldb-commits] [lldb] r285357 - [Test Suite] Pull generateSource into lldbtest

2016-10-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Oct 27 17:52:32 2016 New Revision: 285357 URL: http://llvm.org/viewvc/llvm-project?rev=285357&view=rev Log: [Test Suite] Pull generateSource into lldbtest Summary: Convert tests using LLDB headers to use generateSource to put the right include paths in place regardles

[Lldb-commits] [lldb] r285361 - Revert "[Test Suite] Pull generateSource into lldbtest"

2016-10-27 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Oct 27 18:18:52 2016 New Revision: 285361 URL: http://llvm.org/viewvc/llvm-project?rev=285361&view=rev Log: Revert "[Test Suite] Pull generateSource into lldbtest" This reverts commit r285357. I committed this patch accidentally out of order. Will recommit when the ch

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

2016-10-28 Thread Chris Bieneman via lldb-commits
beanz added a comment. This patch ends up hiding the problem, not fixing it. If it unblocks something it might be ok, but it doesn't actually fix the problem. The underlying problem is that liblldb and lldb-mi have their own copies of LLVM with their own copies of the GlobalParser static (llvm

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

2016-10-28 Thread Chris Bieneman via lldb-commits
beanz added a comment. In https://reviews.llvm.org/D26093#582618, @tfiala wrote: > The current usage of CommandLine via global static constructors in Debug.cpp > seems like a poor choice, as it forces all users of llvm with NDEBUG not > defined to get some command line behavior that they may ne

[Lldb-commits] [lldb] r285542 - [Test Suite] Pull generateSource into lldbtest

2016-10-30 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Sun Oct 30 23:48:19 2016 New Revision: 285542 URL: http://llvm.org/viewvc/llvm-project?rev=285542&view=rev Log: [Test Suite] Pull generateSource into lldbtest Summary: Convert tests using LLDB headers to use generateSource to put the right include paths in place regardles

  1   2   >