Author: cbieneman
Date: Thu Apr 27 14:45:16 2017
New Revision: 301580
URL: http://llvm.org/viewvc/llvm-project?rev=301580&view=rev
Log:
NFC. Add comment about debugserver usage
This just adds a comment to SocketAddress about it being used by debugserver
and the implications of that.
If we need to make changes to this class that make it unsuitable for
debugserver we can re-implement the minimal abstractions we need from this file
in debugserver. I would prefer not to do that because code duplication is bad.
Nuff said.
Modified:
lldb/trunk/source/Host/common/SocketAddress.cpp
Modified: lldb/trunk/source/Host/common/SocketAddress.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/SocketAddress.cpp?rev=301580&r1=301579&r2=301580&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/SocketAddress.cpp (original)
+++ lldb/trunk/source/Host/common/SocketAddress.cpp Thu Apr 27 14:45:16 2017
@@ -6,6 +6,12 @@
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
+//
+// Note: This file is used on Darwin by debugserver, so it needs to remain as
+// self contained as possible, and devoid of references to LLVM unless
+// there is compelling reason.
+//
+//===----------------------------------------------------------------------===//
#if defined(_MSC_VER)
#define _WINSOCK_DEPRECATED_NO_WARNINGS
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
