https://github.com/bulbazord commented:
Hmm, yeah testing this is probably tricky to do.
Nonetheless, I think your cleanup logic makes sense. It's also nice that you've
documented the intended behavior. 😄
https://github.com/llvm/llvm-project/pull/78652
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/78773
BroadcastEvent currently takes its EventData* param and shoves it into an Event
object, which takes ownership of the pointer and places it into a shared_ptr to
manage the lifetime.
Instead of relying on `new`
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/78773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79045
Instead of passing the data to BroadcastEventIfUnique to create an Event object
on the behalf of the caller, the caller can create the Event up-front.
>From 9cb80e3f334d3cf3dafed4bda6f87289ad330054 Mon Sep 17
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79064
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I thought about this more and talked with Jim offline. I think that it makes
sense for Broadcaster to create Events with the event_type and the EventDataSP.
I'm going to switch my approach and abandon this one.
https://github.com/llvm/llvm-project/pull/79064
__
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79189
This overload is completely unused.
>From c04b7a72444b167ab59604a7dce84bfadad0d45e Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 10:33:07 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79194
This was likely overlooked when SBFormat was added.
>From d96c07d55a76d333193a033cd0516243d01e2bf4 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 11:20:19 -0800
Subject: [PATCH] [lldb] Inc
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79194
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79189
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79215
None
>From 0e22f21875041f98e42b8573491bf8b9cfc1e01f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 13:54:00 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused method
BreakpointIDList::Find
https://github.com/bulbazord approved this pull request.
Thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/79385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/79389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79508
There are 3 ways to create an EventDataBytes object: (const char *),
(llvm::StringRef), and (const void *, size_t len). All of these cases can be
handled under `llvm::StringRef`. Additionally, this allows us t
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79517
`FindBreakpointID` take a BreakpointID and a pointer to a size_t (so you can
get position information). It returns a bool to indicate whether the id was
found in the list or not.
There are 2 callers of this c
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4281,25 +4281,31 @@ void
Process::CalculateExecutionContext(ExecutionContext &exe_ctx) {
//return Host::GetArchSpecForExistingProcess (process_name);
//}
+EventSP Process::CreateEventFromProcessState(uint32_t event_type) {
+ auto event_data_sp =
+ std::make_shar
@@ -0,0 +1,105 @@
+#include "Plugins/Platform/MacOSX/PlatformMacOSX.h"
bulbazord wrote:
Don't forget to include the license header in this file
https://github.com/llvm/llvm-project/pull/79533
___
lldb-commits mailing l
@@ -4281,25 +4281,31 @@ void
Process::CalculateExecutionContext(ExecutionContext &exe_ctx) {
//return Host::GetArchSpecForExistingProcess (process_name);
//}
+EventSP Process::CreateEventFromProcessState(uint32_t event_type) {
+ auto event_data_sp =
+ std::make_shar
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/79644
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/79649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
bulbazord wrote:
Suggestion: You can remove this and just return {} below.
https://github.com/llvm/llvm-project/pull/79662
__
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/79656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79716
The purpose of m_being_created in these classes was to prevent broadcasting an
event related to these Breakpoints during the creation of the breakpoint (i.e.
in the constructor). In Breakpoint and Watchpoint,
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
Sure
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits ma
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From fc0c5da871d32a7cf5a6c96ef7f36c49aeccd074 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
@jimingham how does this look to you?
https://github.com/llvm/llvm-project/pull/79716
__
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79901
I was refactoring something else but ran into this function. It was somewhat
confusing to read through and understand, but it boils down to two steps:
- First we try `OptionArgParser::ToBoolean`. If that works,
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 7ce769f1a5bde83e0ff7ae36852c7a742bbb990b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Minor refactor to
CommandObjectProcessHandle:
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From 1f81c3e01a12682ad514038d2e9f1baea80dcf03 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
bulbazord wrote:
> This version is still a little awkward because there's an ambiguity about
> what the incoming string being empty means. In the VerifyCommandOptionValue,
> it means "No Value" and the return is not distinguishable from "error" - but
> in a bunch of the places where you use Ve
@@ -1591,24 +1591,24 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
Options *GetOptions() override { return &m_options; }
- bool VerifyCommandOptionValue(const std::string &option, int &real_value) {
-bool okay = true;
+ std::optional VerifyComman
bulbazord wrote:
Okay, here's what I'll do then:
1. I will remove `VerifyCommandOptionValue` and replace uses of it with
`OptionArgParser::ToBoolean`.
2. Afterwards, I will change the interface of `OptionArgParser::ToBoolean`.
https://github.com/llvm/llvm-project/pull/79901
__
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 3cd6afa16fb8b282712b1d3cf103abbd3329fc17 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Minor refactor to
CommandObjectProcessHandle:
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord commented:
I haven't looked at the algorithm in great detail yet but a lot of the
surrounding stuff looks pretty reasonable I think.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commi
@@ -0,0 +1,38 @@
+//===-- WatchpointAlgorithms.h *- C++
bulbazord wrote:
The header needs adjustment
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lld
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,38 @@
+//===-- WatchpointAlgorithms.h *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
bulbazord wrote:
@clayborg how does this look to you?
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From f7bc2e013fb4a5cac93d2c5856983796459fb84b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/4] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/80602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> @bulbazord in the most recent commit I moved this internal-only enum from
> lldb-enumerations.h to lldb-private-enumerations.h, but I need to use the
> constexpr templatey thing that LLDB_MARK_AS_BITMASK_ENUM() defines for the
> enum so I can use bit-wise | & operations with
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
Haven't looked over everything yet but this has an ABI-breaking change. Please
revert the existing changes to SBTarget.
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commi
@@ -86,9 +86,13 @@ class LLDB_API SBTarget {
/// Returns a dump of the collected statistics.
///
+ /// \param[in] summary_only
+ /// If true, only report high level summary statistics without
+ /// targets/modules/breakpoints etc.. details.
+ ///
/// \return
@@ -186,6 +186,10 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
+ // Return total currently loaded debug info.
+ // For cases like
@@ -241,7 +241,7 @@ class DWARFUnit : public UserID {
FileSpec GetFile(size_t file_idx);
FileSpec::Style GetPathStyle();
- SymbolFileDWARFDwo *GetDwoSymbolFile();
+ SymbolFileDWARFDwo *GetDwoSymbolFile(bool load_if_needed = true);
bulbazord wrote:
Inste
bulbazord wrote:
I'm not sure I understand. Why do you need to get the path to the core file
through the SBAPI? Didn't you also load it through the SBAPI too?
https://github.com/llvm/llvm-project/pull/80767
___
lldb-commits mailing list
lldb-commits@l
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
https://github.com/bulbazord approved this pull request.
I'm happy w/ the name. Thanks!
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
@@ -608,11 +608,10 @@ static bool Evaluate_DW_OP_entry_value(std::vector
&stack,
StackFrameSP parent_frame = nullptr;
addr_t return_pc = LLDB_INVALID_ADDRESS;
uint32_t current_frame_idx = current_frame->GetFrameIndex();
- uint32_t num_frames = thread->GetStackFrameCount
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
https://github.com/bulbazord approved this pull request.
Makes sense to me. If the test suite is happy then I think this is fine.
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/bulbazord approved this pull request.
LGTM. I also noticed there's no tests for this functionality...
https://github.com/llvm/llvm-project/pull/81075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
https://github.com/bulbazord approved this pull request.
Ok, I think this is good to go in. There are things that can be improved but it
would be better to land this and change things in follow up PRs instead of
continually adjusting this one.
https://github.com/llvm/llvm-project/pull/70734
__
https://github.com/bulbazord approved this pull request.
LGTM but I'm not really an expert on FreeBSD. @emaste ?
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/81310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
This uses `DataExtractor::GetMaxU64` which already does this under the hood.
What does this do that isn't already being done? It may help if you add a test
case to show what you are trying to fix.
https://github.com/llvm/llvm
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/81565
None
>From a1bb825c34a951a0d99ecf03fe86545ed43bbe42 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 12 Feb 2024 19:05:55 -0800
Subject: [PATCH] [lldb][NFCI] Add header guard to PlatformRemoteAppleXR.h
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/81565
>From a1bb825c34a951a0d99ecf03fe86545ed43bbe42 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 12 Feb 2024 19:05:55 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Add header guard to PlatformRemoteAppleXR.h
-
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/81565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -825,6 +806,56 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
break;
}
- return StopInfoSP(new StopInfoMachException(thread, exc_type, exc_data_count,
- exc_code, exc_sub_code));
+ return StopInf
https://github.com/bulbazord commented:
Makes sense to me!
https://github.com/llvm/llvm-project/pull/81573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -79,6 +79,11 @@ class StopInfo : public
std::enable_shared_from_this {
virtual bool IsValidForOperatingSystemThread(Thread &thread) { return true; }
+ /// A Continue operation can result in a false stop event
+ /// before any execution has happened in certain cases on
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/81573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> > This uses `DataExtractor::GetMaxU64` which already does this under the
> > hood. What does this do that isn't already being done? It may help if you
> > add a test case to show what you are trying to fix.
>
> @clayborg @bulbazord The problem with GetMaxU64 is that it alway
bulbazord wrote:
ping @clayborg How does this look now?
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
// the user's options.
ProcessSP process_sp = target.GetProcessSP();
-int stop_action = -1; // -1 means leave the current setting alone
-int pass_action = -1; // -1 mea
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -224,6 +224,7 @@ llvm::json::Value DebuggerStats::ReportStatistics(
const lldb_private::StatisticsOptions &options) {
const bool summary_only = options.summary_only;
+ const bool force_laoding = options.force_loading;
bulbazord wrote:
typo in this o
https://github.com/bulbazord commented:
Idea looks ok, the naming could use a bit of work. Right now it feels a bit
generic and I'm not sure what "loading" means. I like Greg's suggestion here.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-
bulbazord wrote:
> @clayborg @bulbazord we have extension in lldb to support cobol code
> debugging, we require byteswapping there. upstream version of lldb does not
> do byteswapping on scalar so no problem seen.
Maybe not, but this should still be testable with a unit test. If somebody
modi
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
&request) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) {
+ size_t num_arg_entries = GetNumAr
@@ -243,7 +243,7 @@ static constexpr CommandObject::ArgumentTableEntry
g_argument_table[] = {
{ lldb::eArgTypeLogCategory, "log-category",
lldb::CompletionType::eNoCompletion, {}, { nullptr, false }, "The name of a
category within a log channel, e.g. all (try \"log list\"
@@ -1139,6 +1097,15 @@ class CommandObjectPlatformProcessLaunch : public
CommandObjectParsed {
m_arguments.push_back({run_arg_arg});
}
+ void
+ HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) ov
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/82095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> The downside of doing the initialization manually is that we do lose a bit of
> test coverage. For example, issue #70453 also manifested itself in the unit
> tests.
I think this is an acceptable tradeoff. The unit tests are for testing LLDB's
python internals, not for testi
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/82273
I have been looking to simplify parsing logic and improve the interfaces so
that they are both easier to use and harder to abuse. To be specific, I am
referring to functions such as `OptionArgParser::ToBoolean
https://github.com/bulbazord approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/82085
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2023-01-11T12:33:41-08:00
New Revision: f2f3b1a87ad294433986683864f75575c3a81779
URL:
https://github.com/llvm/llvm-project/commit/f2f3b1a87ad294433986683864f75575c3a81779
DIFF:
https://github.com/llvm/llvm-project/commit/f2f3b1a87ad294433986683864f75575c3a81779.diff
Author: Alex Langford
Date: 2023-01-11T13:37:16-08:00
New Revision: 58def623ca46f107d185d7f02b267ffa751aff97
URL:
https://github.com/llvm/llvm-project/commit/58def623ca46f107d185d7f02b267ffa751aff97
DIFF:
https://github.com/llvm/llvm-project/commit/58def623ca46f107d185d7f02b267ffa751aff97.diff
Author: Alex Langford
Date: 2023-01-31T12:58:37-08:00
New Revision: 8a16a069540a6c9662e53b64679b1f5ce8e51956
URL:
https://github.com/llvm/llvm-project/commit/8a16a069540a6c9662e53b64679b1f5ce8e51956
DIFF:
https://github.com/llvm/llvm-project/commit/8a16a069540a6c9662e53b64679b1f5ce8e51956.diff
Author: Alex Langford
Date: 2023-02-13T10:55:10-08:00
New Revision: f841c4af5f5ec88c33130ad744ee57ad672f
URL:
https://github.com/llvm/llvm-project/commit/f841c4af5f5ec88c33130ad744ee57ad672f
DIFF:
https://github.com/llvm/llvm-project/commit/f841c4af5f5ec88c33130ad744ee57ad672f.diff
Author: Alex Langford
Date: 2023-02-15T16:35:51-08:00
New Revision: dcf18e4757b2bc2410031e7b69082117d540a1d6
URL:
https://github.com/llvm/llvm-project/commit/dcf18e4757b2bc2410031e7b69082117d540a1d6
DIFF:
https://github.com/llvm/llvm-project/commit/dcf18e4757b2bc2410031e7b69082117d540a1d6.diff
Author: Alex Langford
Date: 2023-02-16T18:33:12-08:00
New Revision: ffe982f96bff77c1b326f5109e2dddfbcde4ca2a
URL:
https://github.com/llvm/llvm-project/commit/ffe982f96bff77c1b326f5109e2dddfbcde4ca2a
DIFF:
https://github.com/llvm/llvm-project/commit/ffe982f96bff77c1b326f5109e2dddfbcde4ca2a.diff
701 - 800 of 1590 matches
Mail list logo
