bulbazord wrote: > @bulbazord in the most recent commit I moved this internal-only enum from > lldb-enumerations.h to lldb-private-enumerations.h, but I need to use the > constexpr templatey thing that LLDB_MARK_AS_BITMASK_ENUM() defines for the > enum so I can use bit-wise | & operations without casting everywhere; that's > defined in lldb-enumerations.h so I included the public enums in the > lldb-private-enumerations.h. It seems like it's probably not a great choice, > but the other one is breaking out this and FLAGS_ENUM etc into a little > lldb-common-enumerations.h or something. What do you think?
Not the greatest thing in the world but it's not terrible either. We use the lldb public enumerations everywhere in private code, so as long as we're not going the other way this is ok to do. I will say, by moving the definitions from `lldb-enumerations.h` to `lldb-private-enumerations.h` you have removed these values from the python bindings. Technically that's an API break, but I'm not sure where anyone could have used these values otherwise. LGTM. https://github.com/llvm/llvm-project/pull/80376 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
