[Lldb-commits] [PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

This revision was automatically updated to reflect the committed changes. Closed by commit rL327162: [SymbolFilePDB] Keep searching until the file name is found for the pdb… (authored by asmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D44182?vs=137298&id=137798#toc Re

[Lldb-commits] [PATCH] D44455: [SymbolFilePDB] Remove a few null pointer checks by passing ref

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44455 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp source/Plug

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Replace SymbolFilePDB::GetSourceFileNameForPDBCompiland() with PDBSymbolCompiland::getSourceFileFullPath(). Repository: rL LLVM https://reviews.llvm.org/D44456 Files:

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

asmith added a comment. Has a dependence on https://reviews.llvm.org/D44458 Repository: rL LLVM https://reviews.llvm.org/D44456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327925: [SymbolFilePDB] Simplify getting the source file path (authored by asmith, committed by ). Changed prior to commi

[Lldb-commits] [PATCH] D45224: [SymbolFilePDB] Add support for resolving variable symbols

asmith created this revision. asmith added reviewers: rnk, zturner, lldb-commits. Herald added subscribers: llvm-commits, JDevlieghere, aprantl. Implement FindGlobalVariables and ParseVariableContext methods. Compile unit information is necessary for resolving variable context, however some PDB

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180939. asmith added a comment. Add lldb::pipe_t type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/Pi

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/PipeWindows.h include/lldb/lldb-types.h source

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 180992. asmith added a comment. Added lock suggested in review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 181377. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp ===

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

asmith marked an inline comment as done. asmith added a comment. @clayborg Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858 +Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool &is_loaded, + ll

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 182704. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: include/lldb/Utility/Args.h source/Host/windows/ProcessLauncherWindows.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp sou

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 184323. asmith retitled this revision from "Implement GetFileLoadAddress for the Windows process plugin" to "Implement GetLoadAddress for the Windows process plugin". asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 184325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Host/windows/ProcessLauncherWindows.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith added a comment. Thanks for the feedback and interesting discussion! If no more comments, let's go with this version for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 ___ lldb-commits

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185783. Herald added a reviewer: serge-sans-paille. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldb

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185784. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith added a comment. Any other comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 185817. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp source/Host/common/FileSystem.cpp source/Plugins/Proc

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186401. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: include/lldb/Host/Host.h source/Host/common/Host.cpp source/Host/windows/Host.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWi

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186580. Herald added subscribers: jdoerfert, emaste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source/Plugins/Platform/POSIX/PlatformPOSIX.h sou

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186796. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.h s

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186799. Herald added a subscriber: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354099: Implement GetLoadAddress for the Windows process plugin (authored by asmith, committed by ). Herald added a projec

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 5 inline comments as done. asmith added a comment. Committed a few NFC changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup

asmith created this revision. asmith added reviewers: zturner, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D60440 Files: include/lldb/Host/Socket.h source/Host/common/Socket.cpp source/Initialization/Syste

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 6 inline comments as done. asmith added inline comments. Comment at: tools/lldb-server/SystemInitializerLLGS.cpp:37-52 +#if defined(_WIN32) + if (g_ref_count++ == 0) { +// Require Windows Sockets version 2.2. +auto wVersion = MAKEWORD(2, 2); +WSADATA ws

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 4 inline comments as done. asmith added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:16 + +#include "IDebugDelegate.h" +#include "ProcessDebugger.h" labath wrote: > It looks like IDebugDelegate.h is missi

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 4 inline comments as done. asmith added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:294 + + lldb_private::UUID m_uuid; }; labath wrote: > Move UUID handling into a separate patch. The UUID change is being discu

[Lldb-commits] [PATCH] D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup

asmith updated this revision to Diff 194443. asmith added a comment. Addressed the review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60440/new/ https://reviews.llvm.org/D60440 Files: include/lldb/Host/Socket.h source/Host/common/Socket.cpp source/Initialization/System

[Lldb-commits] [PATCH] D60496: [lldb-server] Use std::thread/mutex for all platforms

asmith created this revision. asmith added reviewers: zturner, labath, jfb, Hui. Herald added subscribers: lldb-commits, dexonsmith. Herald added a project: LLDB. Some cleanup suggested when bringing up lldb-server on Windows. Thanks to Hui Huang for the patch. Repository: rLLDB LLDB https:/

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:1 //===-- main.cpp *- C++ -*-===// // labath wrote: > Could you (as a s

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith updated this revision to Diff 194751. asmith added a comment. Address reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60496/new/ https://reviews.llvm.org/D60496 Files: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp Index: packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:188-192 +g_print_mutex.lock(); printf("thread %d id: ", this_thread_index); print_thread_id(); printf("\n"); +g_prin

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78 +#if defined(_WIN32) + fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId()); +#else fprintf(stderr, "PID: %d\n", getpid()); +#en

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195282. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp sour

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195504. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PEC

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

asmith added a comment. Herald added a subscriber: JDevlieghere. Curious what the status of this is? Looks like its been ready for almost one year :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 __

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM. Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error" A little more description would be helpful for others. He

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I think this change has introduced a dependence on x64. I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp. This is because the version of _CONTEXT included by winnt.h is for x32 and not x6

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 11 inline comments as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:95 + +// Resume the debug loop. +ExceptionRecordSP active_exception = amccarth wrote: > This code appe

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub. You can reproduce the build failure from an x64 command prompt with this cmake command line: cmake path-to-llvm-project/llvm -Thost=x64 -DLLVM_ENABLE_PROJECTS="clang;lld;lld

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 2 inline comments as done. asmith added a comment. I don't see anything else to address in this review. Comments? Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { +

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked an inline comment as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { + // A WoW64 register info is the same as the i386's. + std

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though. CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. Do you need some help fixing the build? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. Any last comments before this is committed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. This is done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 214979. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 214985. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRe

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith added a comment. Any more comments on the tests for Windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368776: Update Python tests for lldb-server on Windows (authored by asmith, committed by ). Herald added a project: LLVM.

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith abandoned this revision. asmith added a comment. This was split into separate patches and committed. No longer need this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commit

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 196874. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 197239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

[Lldb-commits] [PATCH] D61686: Disable pty redirection on Windows and add a method to get the parent pid

asmith created this revision. asmith added reviewers: labath, rnk. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. More changes for lldb-server on Windows - Disable pty redirection for Windows since there is no pty support currently - Add a method to get the parent pid for

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith created this revision. asmith added reviewers: labath, rnk. Herald added a reviewer: jfb. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lld

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 198675. asmith retitled this revision from "Disable pty redirection on Windows and add a method to get the parent pid" to "Enable lldb-server on Windows". asmith edited the summary of this revision. Herald added subscribers: mgorny, srhines. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 199554. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py packages/Python/lldbsui

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 199555. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 200160. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py packages/Python/lldbsui

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith created this revision. asmith added reviewers: labath, Hui. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. asmith added reviewers: jfb, clayborg. Herald added a subscriber: dexonsmith. This change extracts functionalities from processwindows into a introduced

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith updated this revision to Diff 205178. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63166/new/ https://reviews.llvm.org/D63166 Files: source/Plugins/Process/Windows/Common/CMakeLists.txt source/Plugins/Process/Windows/Common/ProcessDebugger.cpp source/Plugins/Process/Windows

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp:31-36 + if (!data_sp) { +error.SetErrorStringWithFormat( +"failed to allocate DataBufferHeap instance of size %" PRIu64, +data_size); +r

<    1   2