asmith marked an inline comment as done.
asmith added inline comments.

================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78
+#if defined(_WIN32)
+  fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId());
+#else
   fprintf(stderr, "PID: %d\n", getpid());
+#endif
----------------
clayborg wrote:
> Is there no llvm host code we can use as the porting layer instead of this?
If the test harness was changed to link against the host support libraries and 
included the right header this could be factored out. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60496/new/

https://reviews.llvm.org/D60496



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to