[Lldb-commits] [PATCH] D52626: [lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when debugging a native x86 Windows process

asmith created this revision. asmith added reviewers: aleksandr.urakov, zturner, lldb-commits. Herald added a subscriber: erik.pilkington. A RichManglingContext constructed with an invalid demangled name or with a demangled function name without any context will have an empty context. This trigg

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

asmith created this revision. asmith added reviewers: zturner, aleksandr.urakov, lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D52627 Files: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp source/Plugins/ExpressionParser/Clang/ClangUserExpression.h source/Sy

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D52468 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

asmith updated this revision to Diff 167670. https://reviews.llvm.org/D52627 Files: source/Symbol/Symtab.cpp Index: source/Symbol/Symtab.cpp === --- source/Symbol/Symtab.cpp +++ source/Symbol/Symtab.cpp @@ -139,6 +139,8 @@

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL343497: [lldb] Start a new line for the next output if there are no symbols in the… (authored by asmith, committed by ). H

[Lldb-commits] [PATCH] D53090: [ProcessWindows] Fix a bug that causes lldb to freeze

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. If the process exits before any initial stop then notify the debugger of the error otherwise WaitForDebuggerConnection() will be blocked. An example of this issue is when

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D53092 Files: source/Utility/Status.cpp unittests/Utility/StatusTest.cpp Index: unittests/Utility/StatusTest.cpp

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov, lldb-commits. Herald added subscribers: teemperor, mgrang, mgorny. This parses entries in pecoff import tables for imported DLLs and is intended as the first step to allow LLDB to load a PE's shared modules when

[Lldb-commits] [PATCH] D53096: [lldb-test] Add a lit test for dependent modules in PECOFF

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. Add a new subcommand to lldb-test called 'dep-modules' to test dependent modules in PECOFF. Repository: rLLDB LLDB https://reviews.llvm.org/D53096 Files:

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

asmith added inline comments. Comment at: unittests/Utility/StatusTest.cpp:68-74 + EXPECT_STREQ("Access is denied. ", s.AsCString()); + + s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32); + EXPECT_STREQ("Negotiation timed out ", s.AsCString()); + + s.SetError

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344798: [lldb] Add support in Status::AsCString to retrieve win32 system error strings (authored by asmith, committed b

[Lldb-commits] [PATCH] D53375: [PDB] Improve performance of the PDB DIA plugin

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Thanks for adding the cache. We noticed the slowdown also and were discussing the same thing. This LGTM if the other reviewers done have any comments. Repository: rLLDB LLDB https://review

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith added a comment. I think this addresses all the previous comments. https://reviews.llvm.org/D53094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 170781. https://reviews.llvm.org/D53094 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h unittests/ObjectFile/CMakeLists.txt unittests/ObjectFile/PECOFF/CMakeLists.txt unittests/ObjectFi

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith added a comment. The ability to dump dependent modules is in another review that is waiting on this one. https://reviews.llvm.org/D53096 https://reviews.llvm.org/D53094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

asmith accepted this revision. asmith added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 176259. asmith added a comment. Add changes from D53096 as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modul

[Lldb-commits] [PATCH] D53096: [lldb-test] Add a lit test for dependent modules in PECOFF

asmith abandoned this revision. asmith added a comment. Changes from this CR were added to D53094 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53096/new/ https://reviews.llvm.org/D53096 _

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg source/Plugins/ObjectFile/PECOF

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg source/Plugins/ObjectFile/PECOF

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Provide an implementation of GetUUID() for remote debugging scenarios based on the md5 of the object's path. Include a simple lit test that checks the first 8 bytes of the UUID i

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D56230 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-remote/GDBRemote

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: lldb-commits, abidh. This commit contains the following changes: - Rewrite vfile close/read/write packet handlers with portable routines from lldb. This removes #if(s) and allows the handlers t

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Implement a few routines for Windows to support some basic process interaction and file system operations. Repository: rLLDB LLDB https://reviews.llvm.org/D56232 Files: so

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for building lldb-server on Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: lldb-commits, abidh, mgorny, srhines. This is intended as a first step to make lldb-server work on Windows. Follow-up changes to implement remote capabilities in PlatformWindows, launch gdbserve

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. This adds unnamed pipe support in PipeWindows to support communication between a debug server and child process. Modify PipeWindows::CreateNew to support the creation of an unname

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. When a process is loaded, update its sections with the load address to resolve any created breakpoints. For the remote debugging case, the debugged process is launched remotely s

[Lldb-commits] [PATCH] D45224: [SymbolFilePDB] Add support for resolving variable symbols

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333049: [SymbolFilePDB] Add support for resolving variable symbols (authored by asmith, committed by ). Changed prior to

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM - will commit for you https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. In https://reviews.llvm.org/D47708#1123286, @aleksandr.urakov wrote: > Thank you! > > But it looks like the binary files (*.pdb and *.exe) have not been committed > properly (they have zero size). I've seen that issue before. I think you have to specify --binary when g

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. In https://reviews.llvm.org/D47708#1123334, @labath wrote: > I have reverted this because of the broken tests. > > However, I have to also ask: isn't there better way to test this? (one that > does not depend on opaque checked-in binaries). On linux, I could check-in a >

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. Thanks! Much better without the binaries. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Except for minor formatting LGTM Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7 + + return; +} Please remove the return ==

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

asmith added a subscriber: aleksandr.urakov. asmith added a comment. Sure, I will do it Monday if someone hasn’t done it already. https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

asmith created this revision. asmith added reviewers: lldb-commits, aleksandr.urakov, rnk, zturner. Herald added a subscriber: llvm-commits. This is an alternative to https://reviews.llvm.org/D49368 Repository: rL LLVM https://reviews.llvm.org/D49410 Files: lit/SymbolFile/PDB/class-layout.

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

asmith updated this revision to Diff 155904. asmith added a comment. Adding missing inputs https://reviews.llvm.org/D49410 Files: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp lit/SymbolFile/PDB/Inputs/PointerTypeTest.cpp lit/SymbolFile/PDB/class-layout.test lit/SymbolFile/PDB/pointers.

[Lldb-commits] [PATCH] D51104: [PDB] Resolve a symbol context block info correctly

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D51104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith created this revision. Check that a regex is valid before searching by regex for a symbol in a pdb. This avoids throwing an exception on an invalid regex. Repository: rL LLVM https://reviews.llvm.org/D41086 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFil

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393 + bool is_regex = false; + if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { +// Trying to compile an invalid regex could throw an exception. The fin

[Lldb-commits] [PATCH] D41092: Enable more abilities in SymbolFilePDB

asmith created this revision. 1. Finding symbols through --symfile 2. More abilities: Functions, Blocks, GlobalVariables, LocalVariables, VariableTypes Repository: rL LLVM https://reviews.llvm.org/D41092 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFile/PDB/Sym

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:392-399 + bool is_regex = false; + if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { +// Trying to compile an invalid regex could throw an exception. +// Only search

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:392-399 + bool is_regex = false; + if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { +// Trying to compile an invalid regex could throw an exception. +// Only search

[Lldb-commits] [PATCH] D41092: Enable more abilities in SymbolFilePDB

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127 + } + lldbassert(m_session_up.get()); + if (auto enum_tables_up = m_session_up->getEnumTables()) { clayborg wrote: > I am assuming this assert won't fire if we give t

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith updated this revision to Diff 127255. asmith added a comment. This changes SymbolFilePDB::FindTypesByRegex () to take an lldb_private::RegularExpression as the argument and removes the use of the STL regex. Repository: rL LLVM https://reviews.llvm.org/D41086 Files: source/Plugins/

[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393 // try really hard not to use a regex match. - bool is_regex = false; - if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) { -// Trying to compile an invalid regex co

[Lldb-commits] [PATCH] D41427: [lldb] Fix crash when parsing the type of a function without any arguments

asmith created this revision. asmith added reviewers: zturner, lldb-commits. For `int main()`, the number of arguments is zero. Trying to access the element of a null array causes trouble. Repository: rL LLVM https://reviews.llvm.org/D41427 Files: source/Plugins/SymbolFile/PDB/PDBASTParse

[Lldb-commits] [PATCH] D41428: [lldb] This commit adds support to cache a PDB's global scope and fixes a bug in getting the source file name for a compiland

asmith created this revision. asmith added reviewers: zturner, lldb-commits. This commit is a combination of following changes: (1) Cache PDB's global scope(executable) in SymbolFilePDB (2) Change naming of `cu` to `compiland` which is PDB specific (3) Change ParseCompil

[Lldb-commits] [PATCH] D41092: Enable more abilities in SymbolFilePDB

asmith updated this revision to Diff 127658. asmith added a comment. If a `Symbols` table is present then lldb can retrieve symbols for the types listed in PDBSym_Type. In other words, if we want symbolic information for a function then checking for the `Symbols` table is sufficient. Repositor

[Lldb-commits] [PATCH] D41086: [lldb] Stop searching for a symbol in a pdb by regex

asmith updated this revision to Diff 127803. asmith retitled this revision from "[lldb] Check that a regex is valid before searching by regex for a symbol in a pdb." to "[lldb] Stop searching for a symbol in a pdb by regex". asmith edited the summary of this revision. Repository: rL LLVM http

[Lldb-commits] [PATCH] D41427: [lldb] Fix crash when parsing the type of a function without any arguments

asmith added a comment. This fix is part of a larger set of changes to retrieve the type for a function signature and I don't see how to test for this without those changes. With all the other changes, lldb-test fails without this fix and passes with it. So it's implicitly already tested. Rep

[Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex to use FindTypesByRegex instead of FindTypes

asmith created this revision. asmith added reviewers: zturner, lldb-commits, labath, clayborg. https://reviews.llvm.org/D41086 fixed an exception in FindTypes()/FindTypesByRegex() and caused two lldb unit test to fail. This change updates the unit tests to pass again. Related review: https://re

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments

asmith updated this revision to Diff 128069. asmith retitled this revision from "[lldb] Fix crash when parsing the type of a function without any arguments" to "Fix crash when parsing the type of a function without any arguments". asmith edited the summary of this revision. Repository: rL LLVM

[Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. From Zachary Turner [6:46 PM (3 hours ago)] Sorry I missed this, lgtm Repository: rL LLVM https://reviews.llvm.org/D41550 ___ lldb-commits ma

[Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex

asmith updated this revision to Diff 128258. asmith added a comment. Formatting; NFC Repository: rL LLVM https://reviews.llvm.org/D41550 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.h unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Index: unittests/SymbolFile/PDB/SymbolFilePDBTes

[Lldb-commits] [PATCH] D41428: [lldb] This commit adds support to cache a PDB's global scope and fixes a bug in getting the source file name for a compiland

asmith updated this revision to Diff 128312. asmith added a comment. These changes will fix this crash in the current mainline: lldb-test.exe symbols (path-to-your-lldb-exe) Repository: rL LLVM https://reviews.llvm.org/D41428 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp source/

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments

asmith added a comment. Do you prefer to drop the test changes and corresponding binaries? For an llvm-lit test, which directory do you recommend for the new file? Repository: rL LLVM https://reviews.llvm.org/D41427 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D41428: [lldb] This commit adds support to cache a PDB's global scope and fixes a bug in getting the source file name for a compiland

asmith updated this revision to Diff 129747. asmith added a comment. Herald added a subscriber: llvm-commits. Added a lit unit test Repository: rL LLVM https://reviews.llvm.org/D41428 Files: lit/SymbolFile/PDB/Inputs/CompilandsTest.cpp lit/SymbolFile/PDB/compilands.test lit/SymbolFile/

[Lldb-commits] [PATCH] D41428: [lldb] Add support to cache a PDB's global scope and fix a bug in getting the source file name for a compiland

asmith updated this revision to Diff 129750. asmith retitled this revision from "[lldb] This commit adds support to cache a PDB's global scope and fixes a bug in getting the source file name for a compiland" to "[lldb] Add support to cache a PDB's global scope and fix a bug in getting the source

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

asmith updated this revision to Diff 130088. asmith retitled this revision from "Fix crash when parsing the type of a function without any arguments" to "Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'". asmith edited the summary of this revision. Herald add

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

asmith added a comment. The test is added and this is ready to go. Let me know if there are any other changes. Thanks! Repository: rL LLVM https://reviews.llvm.org/D41427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

asmith updated this revision to Diff 130089. Repository: rL LLVM https://reviews.llvm.org/D41427 Files: lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFile/PDB/enums-layout.test lit/SymbolFile/PDB/typedefs.test source/Plugins/SymbolFile/PDB/PDBASTParser.cpp source/Plugins/Sy

[Lldb-commits] [PATCH] D41427: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL322995: [SymbolFilePDB] Fix null array access when parsing the type of a function… (authored by asmith, committed by ). C

[Lldb-commits] [PATCH] D41427: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

asmith accepted this revision. asmith added a comment. Revision was approved by zturner in the comments Repository: rL LLVM https://reviews.llvm.org/D41427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D42434: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. - Fix a null array access bug. This happens when creating the lldb type for a function that has no argument. - Implement SymbolFilePDB::ParseTypes method. Using `lldb-test symbols

[Lldb-commits] [PATCH] D42434: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

asmith added a comment. https://reviews.llvm.org/D41427 was reverted because the commit was missing some of the binary files for the tests. This is the same as https://reviews.llvm.org/D41427 without the binary files. I've dropped them since there are lit tests for the same functionality now.

[Lldb-commits] [PATCH] D42434: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

asmith updated this revision to Diff 131129. asmith added a comment. Fix BCD typo https://reviews.llvm.org/D42434 Files: lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFile/PDB/enums-layout.test lit/SymbolFile/PDB/typedefs.test source/Plugins/SymbolFile/PDB/PDBASTParser.cpp s

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. This is combination of following changes, - Resolve function symbols in PDB symbol file. `lldb-test symbols` will display information about function symbols. - Implement SymbolF

[Lldb-commits] [PATCH] D42620: [lldb] Silence signed <-> unsigned integer comparison warning

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Thanks for fixing that! https://reviews.llvm.org/D42620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

asmith updated this revision to Diff 132785. Repository: rL LLVM https://reviews.llvm.org/D42443 Files: lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp lit/SymbolFile/PDB/Inputs/FuncSymbolsTestMain.cpp lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFile/PDB/func-symbols.test sourc

[Lldb-commits] [PATCH] D42990: Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added subscribers: llvm-commits, hintonda, mgorny. This is a small change towards running the LLDB unit tests on Windows (still WIP). Systems that use make do not point to specific configurations. However, on sy

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. Update some unit tests that are passing -fPIC on Windows which is not a valid compiler option. This is another step in making the LLDB unit tests run on Windows. Repository:

[Lldb-commits] [PATCH] D42990: Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.

asmith added a comment. Thanks! Have updated the commit message to clarify. Repository: rL LLVM https://reviews.llvm.org/D42990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

asmith updated this revision to Diff 133354. asmith edited the summary of this revision. https://reviews.llvm.org/D42994 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefi

[Lldb-commits] [PATCH] D43059: Add implementation for MSCV in CPlusPlusLanguage::IsCPPMangledName

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43059 Files: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp Index: source/Plugins/Language/CPlusPlus/CPlusPlusLanguag

[Lldb-commits] [PATCH] D43061: [docs] Update docs for cmake options LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. LLDB_TEST_COMPILER is not a valid option for CMake for LLDB. There are instead two properties LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER. Update the documents accordingly to

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

asmith updated this revision to Diff 133362. asmith edited the summary of this revision. https://reviews.llvm.org/D42994 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefi

[Lldb-commits] [PATCH] D43061: [docs] Update docs for cmake options LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324564: [docs] Update docs for cmake options LLDB_TEST_C_COMPILER and… (authored by asmith, committed by ). Changed prior

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

asmith updated this revision to Diff 133467. Repository: rL LLVM https://reviews.llvm.org/D42994 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefile packages/Python/

[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

asmith added a comment. IsCPPMangledName() is a public method to determine if a symbol has a mangled name. This change is needed so that lldb can find symbols with MSVC style mangled names. Open to suggestions on a better way to deal with this... Here are all the places it is used: source/Co

[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

asmith added a comment. How about this? if (name == nullptr) return false; return ( (name[0] == '?') || (name[0] == '_' && name[1] == 'Z') ); Repository: rL LLVM https://reviews.llvm.org/D43059 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D43059: Recognize MSVC style mangling in CPlusPlusLanguage::IsCPPMangledName

asmith updated this revision to Diff 133489. asmith retitled this revision from "Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName" to "Recognize MSVC style mangling in CPlusPlusLanguage::IsCPPMangledName". https://reviews.llvm.org/D43059 Files: source/Plugins/Language/CPlusP

[Lldb-commits] [PATCH] D43059: Recognize MSVC style mangling in CPlusPlusLanguage::IsCPPMangledName

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324672: Recognize MSVC style mangling in CPlusPlusLanguage::IsCPPMangledName (authored by asmith, committed by ). Changed

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added subscribers: hintonda, mgorny. This is modeled after the clang and llvm lit tests. Several properties have CMAKE_CFG_INTDIR as part of the path - this works correctly when the cmake generator only supports

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

asmith updated this revision to Diff 133561. asmith added a comment. Minor cleanup before commit https://reviews.llvm.org/D42443 Files: lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp lit/SymbolFile/PDB/Inputs/FuncSymbolsTestMain.cpp lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFil

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL324707: [SymbolFilePDB] Add support for function symbols (authored by asmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D42443?vs=133561&id=133562#toc Repository: rL LLVM htt

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

asmith updated this revision to Diff 133770. https://reviews.llvm.org/D43096 Files: CMakeLists.txt lit/CMakeLists.txt lit/lit.site.cfg.in Index: lit/lit.site.cfg.in === --- lit/lit.site.cfg.in +++ lit/lit.site.cfg.in @@ -6,8

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

asmith updated this revision to Diff 133899. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43096 Files: CMakeLists.txt lit/CMakeLists.txt lit/lit.site.cfg.in Index: lit/lit.site.cfg.in

[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

asmith added a comment. That's a good question and I'm not sure. If all the tests pass you can make it return unconditionally. https://reviews.llvm.org/D43215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

asmith added a comment. Lgtm Repository: rL LLVM https://reviews.llvm.org/D43215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44164: [SymbolFilePDB] Get line number for PDBSymbolTypeEnum

asmith created this revision. asmith added reviewers: zturner, lldb-commits, rnk. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44164 Files: lit/SymbolFile/PDB/enums-layout.test source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Index: source/Plugins/

[Lldb-commits] [PATCH] D44165: [SymbolFilePDB] Minor cleanup

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. - Remove unused code - Adding `break` statement conditionally - Ignore empty strings in FindTypeByName Repository: rL LLVM https://reviews.llvm.org/D44165 Files: sou

[Lldb-commits] [PATCH] D44166: [SymbolFilePDB] Add missing Char16 and Char32 types in a few places

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44166 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Index: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp ===

[Lldb-commits] [PATCH] D44167: [SymbolFilePDB] Add support for CVR pointer type qualifier

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. - Complete element type of PDBSymbolTypeArray. - Add a test to check types of multi-dimensional array and pointers with CVR. Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44182 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp =

[Lldb-commits] [PATCH] D44165: [SymbolFilePDB] Minor cleanup

asmith marked an inline comment as done. asmith added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:499 auto type_list = GetTypeList(); -type_list->Insert(result); +if (type_list) + type_list->Insert(result); zturn

[Lldb-commits] [PATCH] D44166: [SymbolFilePDB] Add missing Char16 and Char32 types in a few places

asmith updated this revision to Diff 137324. asmith added a comment. Add test https://reviews.llvm.org/D44166 Files: lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFile/PDB/typedefs.test source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Index: source/Plugins/SymbolFile/PDB/PDBASTP

[Lldb-commits] [PATCH] D44166: [SymbolFilePDB] Add missing Char16 and Char32 types in a few places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL326875: [SymbolFilePDB] Add missing Char16 and Char32 types in a few places (authored by asmith, committed by ). Changed

[Lldb-commits] [PATCH] D44253: [SymbolFilePDB] Rewrite ParseTypes method

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. The types for the compiland's children are parsed when parsing types for a PDB compiland. Global types also need to be parsed but unfortunately PDBs do not have compiland in

[Lldb-commits] [PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

asmith added a comment. Any comment on this one? :) Repository: rL LLVM https://reviews.llvm.org/D44182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >