asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land.
Except for minor formatting LGTM ================ Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7 + + return; +} ---------------- Please remove the return ================ Comment at: source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h:26 +//------------------------------------------------------------------------------ +/// Converts a location information from a PDB symbol to a DWARF expression +/// ---------------- Are you sure about the /// ? Should these be // ? https://reviews.llvm.org/D49018 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
