[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 >From 8070e1a391d876ccbab25dac6d2a6d2d77f16069 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 15 Apr 2025 12:25:41 +0100 Subject: [PATCH 1/4] [lldb] Add test for jumping by offset Signed-off-by: Ebuka E

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Generate a dummy SB API file using lldb-rpc-gen. +# RUN: mkdir -p %t/server +# RUN: mkdir -p %t/lib chelcassanova wrote: > I don't see anything that would need job control, I'm wondering if a stray > character is causing the shell to think t

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/135778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread John Harrison via lldb-commits
@@ -62,6 +65,71 @@ def test(self): substrs=["error"], ) +def test_jump_offset(self): +"""Test Thread Jump by negative or positive offset""" +exe = self.getBuildArtifact("a.out") +file_name = "main.cpp" +self.runCmd(f"targ

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread John Harrison via lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public CommandObjectParsed { return Status::FromErrorStringWithFormat("invalid line number: '%s'.", option_arg.str().c_str()); break; - case 'b':

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/135778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti commented: I'm less familiar with this part of lldb, so I'd defer to others here. https://github.com/llvm/llvm-project/pull/135778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,18 @@ +// Copy lldb-rpc-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input + +// Run the convert script on it, then run the framework include fix on it. The framework version fix

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Generate a dummy SB API file using lldb-rpc-gen. +# RUN: mkdir -p %t/server +# RUN: mkdir -p %t/lib chelcassanova wrote: I just checked on macOS and got the same error. The error is a bit misleading, it's actually happening because I'm using

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From a00c76df4467c85a7436fc340c79d0a15ab6231a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb] Fix ForwardListFrontEnd::CalculateNumChildren (PR #139805)

2025-05-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/139805 Fixes the calculation of the number of children for `std::forward_list` to no longer be capped. The calculation was capped by the value of `target.max-children-count`. This resulted in at least the followin

[Lldb-commits] [lldb] [lldb] Fix ForwardListFrontEnd::CalculateNumChildren (PR #139805)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Fixes the calculation of the number of children for `std::forward_list` to no longer be capped. The calculation was capped by the value of `target.max-children-count`. This resulted in at least the following

[Lldb-commits] [lldb] 85bbf8c - [lldb] Use llvm::is_contained (NFC) (#139758)

2025-05-13 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-13T15:53:20-07:00 New Revision: 85bbf8c887615b6b2c70353761fad8139d6ecbe8 URL: https://github.com/llvm/llvm-project/commit/85bbf8c887615b6b2c70353761fad8139d6ecbe8 DIFF: https://github.com/llvm/llvm-project/commit/85bbf8c887615b6b2c70353761fad8139d6ecbe8.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #139758)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139758 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: @DavidSpickett I pushed here to address most of the outstanding changes I needed to make from your comments, and this change should also fix the CI issue on BuildKite. Could you give this patch another pass over? https://github.com/llvm/llvm-project/pull/138028 ___

[Lldb-commits] [lldb] cc2bedd - [lldb] Use std:::string::find with std::string_view (NFC) (#139679)

2025-05-13 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-13T15:48:50-07:00 New Revision: cc2beddaa44fb1f0e0ca9eb51c5feaca368c00b0 URL: https://github.com/llvm/llvm-project/commit/cc2beddaa44fb1f0e0ca9eb51c5feaca368c00b0 DIFF: https://github.com/llvm/llvm-project/commit/cc2beddaa44fb1f0e0ca9eb51c5feaca368c00b0.diff L

[Lldb-commits] [lldb] [lldb] Use std:::string::find with std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova reopened https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/138116 >From 559eb1a020e94c09ccfeda0e4cb5e16df145d4aa Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 29 Apr 2025 18:19:18 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] Migrate 'Scopes' to structured types. ---

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/138116 >From 559eb1a020e94c09ccfeda0e4cb5e16df145d4aa Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 29 Apr 2025 18:19:18 +0100 Subject: [PATCH 1/5] [lldb][lldb-dap] Migrate 'Scopes' to structured types. ---

[Lldb-commits] [lldb] Reapply "[lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)" (PR #138896)

2025-05-13 Thread Pavel Labath via lldb-commits
labath wrote: Thanks. I think I can fix that. Let me whip something up. https://github.com/llvm/llvm-project/pull/138896 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix compilation errors from #138896 (PR #139711)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes - s/size_t/SIZE_T to match the windows API - case HANDLE to int64_t to avoid cast-to-int-of-different-size errors/warnings --- Full diff: https://github.com/llvm/llvm-project/pull/139711.diff 3 Files Affected

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-13 Thread Ebuka Ezike via lldb-commits
da-viper wrote: This means also adding serialisation or de-serialisation for types that do not use it except for test. https://github.com/llvm/llvm-project/pull/138116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb] Fix compilation errors from #138896 (PR #139711)

2025-05-13 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/139711 - s/size_t/SIZE_T to match the windows API - case HANDLE to int64_t to avoid cast-to-int-of-different-size errors/warnings Rate limit · GitHub body { background-col

[Lldb-commits] [lldb] [lldb] Fix compilation errors from #138896 (PR #139711)

2025-05-13 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/139711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix compilation errors from #138896 (PR #139711)

2025-05-13 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo approved this pull request. LGTM, thanks! I can confirm that this fixes compilation on mingw targets, on both 32 and 64 bit. https://github.com/llvm/llvm-project/pull/139711 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb] Use std:::string::find with std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/139679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-13 Thread Pavel Labath via lldb-commits
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const MemberOfNode *node) { + Status error; + auto base_or_err = Evaluate(node->GetBase());

[Lldb-commits] [lldb] [lldb][test] Fix beginning/end of file test failed on Windows (PR #139278)

2025-05-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Seems fine, my only question is does the source actually need to be doing this much? Or in other words: the example should be as complex as it needs to be to show the bug. If that means just calling the same do-nothing function over and over to create more lines, that wou

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap event handling. (PR #139669)

2025-05-13 Thread Pavel Labath via lldb-commits
labath wrote: I also haven't looked at it in detail yet, but I think it makes sense overall. I'm not saying it has to be done -- it depends on where we want to take this. Doing everything on one thread makes it easy to avoid races and it's a strategy I generally like, but it also kind of goes

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-13 Thread Pavel Labath via lldb-commits
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const MemberOfNode *node) { + Status error; + auto base_or_err = Evaluate(node->GetBase());

[Lldb-commits] [lldb] [lldb] Use std:::string::find with a std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139679 std::string::find accepts anything that can be converted to std::string_view starting in C++17. Since StringRef can be converted to std::string_view, we do not need to create a temporary instance of std::

[Lldb-commits] [lldb] [lldb] Use std:::string::find with a std::string_view (NFC) (PR #139679)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes std::string::find accepts anything that can be converted to std::string_view starting in C++17. Since StringRef can be converted to std::string_view, we do not need to create a temporary instance of std:

[Lldb-commits] [lldb] Reapply "[lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)" (PR #138896)

2025-05-13 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: Hi Pavel! Unfortunately, it seems like this change has broken compilation of LLDB for mingw, on all architectures. With MSVC and clang-cl, it is broken for 32 bit platforms, while the issue only shows up as a warning for 64 bit architectures there. On 64 bit mingw: ``` llvm-p

[Lldb-commits] [lldb] [lldb][plugin] Use counter directly for number of readers (PR #139252)

2025-05-13 Thread Jacques Pienaar via lldb-commits
https://github.com/jpienaar closed https://github.com/llvm/llvm-project/pull/139252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c78e65c - [lldb][plugin] Use counter directly for number of readers (#139252)

2025-05-13 Thread via lldb-commits
Author: Jacques Pienaar Date: 2025-05-13T01:52:36-07:00 New Revision: c78e65cc980db9542b32049a5d96b00c64cbc47d URL: https://github.com/llvm/llvm-project/commit/c78e65cc980db9542b32049a5d96b00c64cbc47d DIFF: https://github.com/llvm/llvm-project/commit/c78e65cc980db9542b32049a5d96b00c64cbc47d.dif

[Lldb-commits] [lldb] 89826f0 - [lldb] Fix compilation errors from #138896 (#139711)

2025-05-13 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-13T15:05:53+02:00 New Revision: 89826f04589af9d309319b3651b609fdd8978631 URL: https://github.com/llvm/llvm-project/commit/89826f04589af9d309319b3651b609fdd8978631 DIFF: https://github.com/llvm/llvm-project/commit/89826f04589af9d309319b3651b609fdd8978631.diff

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-05-13 Thread Pavel Labath via lldb-commits
labath wrote: > To answer your last question: because the plugins (which is really a > misnomer), as I understand it, are there to provide abstraction: the caller > shouldn't have to know what concrete instance an `ObjectFile` is. The > no-plugins-dependency enforces that at compile/link time.

[Lldb-commits] [lldb] [lldb-dap] While handling events, grab the APIMutex for consistency. (PR #139596)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/139596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][plugin] Clear in same thread as set (PR #139252)

2025-05-13 Thread Jacques Pienaar via lldb-commits
https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/139252 >From c5ffbd84f8b68bae2112e8cec68803cefe571a72 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Fri, 9 May 2025 05:23:00 -0700 Subject: [PATCH 1/5] [lldb][plugin] Clear in same thread as set Here we were i

[Lldb-commits] [lldb] [lldb][plugin] Use counter directly for number of readers (PR #139252)

2025-05-13 Thread Jacques Pienaar via lldb-commits
https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/139252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][plugin] Clear in same thread as set (PR #139252)

2025-05-13 Thread Jacques Pienaar via lldb-commits
https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/139252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-13 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/139301 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-13 Thread via lldb-commits
jimingham wrote: I used `skipTest` which you can call midway through a test, and will show the skip reason. https://github.com/llvm/llvm-project/pull/139301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] 91ea494 - [lldb] Move lldb_enable_attach from test_common to a separate header (#139550)

2025-05-13 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-13T17:52:23+02:00 New Revision: 91ea49499325aeff8426135721b1bd432e5b7780 URL: https://github.com/llvm/llvm-project/commit/91ea49499325aeff8426135721b1bd432e5b7780 DIFF: https://github.com/llvm/llvm-project/commit/91ea49499325aeff8426135721b1bd432e5b7780.diff

[Lldb-commits] [lldb] [lldb] Move lldb_enable_attach from test_common to a separate header (PR #139550)

2025-05-13 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/139550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #139758)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139758 None >From dbe2a85661292455f0c6c141bb6d61d938212cc6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 13 May 2025 08:56:44 -0700 Subject: [PATCH] [lldb] Use llvm::is_contained (NFC) --- lldb/tools/

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #139758)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139758.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/DAP.cpp (+1-2) ``diff diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lld

[Lldb-commits] [lldb] [lldb] Move lldb_enable_attach from test_common to a separate header (PR #139550)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/139550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/138116 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [lldb-dap] Improving tests logging to understand CI failures. (PR #139311)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/139311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for breakpoint types (PR #139792)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/139792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for breakpoint types (PR #139792)

2025-05-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/139792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap event handling. (PR #139669)

2025-05-13 Thread Pavel Labath via lldb-commits
labath wrote: > I can split out some of the type fixes and some other changes I ended up > lumping in here. That would be great. Thanks. > This isn't really a NFC because this is forcing some things to be serial that > were previously not serial. We previously could trigger an event in the

[Lldb-commits] [lldb] 2d57b61 - [lldb-dap] Add unit test for breakpoint types (#139792)

2025-05-13 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-13T17:02:13-07:00 New Revision: 2d57b6132588cd1676d817d120c2f49916227414 URL: https://github.com/llvm/llvm-project/commit/2d57b6132588cd1676d817d120c2f49916227414 DIFF: https://github.com/llvm/llvm-project/commit/2d57b6132588cd1676d817d120c2f49916227414.d

[Lldb-commits] [lldb] [lldb-dap] Add unit test for breakpoint types (PR #139792)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/139792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap event handling. (PR #139669)

2025-05-13 Thread John Harrison via lldb-commits
ashgti wrote: > I believe you, but I don't understand. Since this restricts the set of > possible message orderings (does it?), I would naively expect that a test > which worked previously (with the wider set of orderings) would continue to > work afterwards. > > The only way I can imagine th

[Lldb-commits] [lldb] [lldb-dap] Add unit test for ColumnDescriptor, BreakpointMode and Breakpoint (PR #139627)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: low-priority ping (I'm doing this in the background and dealign with stacked PRs is a nuisance) https://github.com/llvm/llvm-project/pull/139627 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] 8193294 - [lldb-dap] Add unit test for ColumnDescriptor, BreakpointMode and Breakpoint (#139627)

2025-05-13 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-13T12:23:22-07:00 New Revision: 81932945d76a49a4dd222da39afbc18435e66fb0 URL: https://github.com/llvm/llvm-project/commit/81932945d76a49a4dd222da39afbc18435e66fb0 DIFF: https://github.com/llvm/llvm-project/commit/81932945d76a49a4dd222da39afbc18435e66fb0.d

[Lldb-commits] [lldb] [lldb-dap] Add unit test for ColumnDescriptor, BreakpointMode and Breakpoint (PR #139627)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/139627 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Add unit test for breakpoint types (PR #139792)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/139792 - Add unit test for breakpoint types for SourceBreakpoint, FunctionBreakpoint and DataBreakpoint. - Rename DataBreakpointInfo to DataBreakpoint. - Fix some mapOptions for optional fields. >From 653ea895

[Lldb-commits] [lldb] [lldb-dap] Add unit test for breakpoint types (PR #139792)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes - Add unit test for breakpoint types for SourceBreakpoint, FunctionBreakpoint and DataBreakpoint. - Rename DataBreakpointInfo to DataBreakpoint. - Fix some mapOptions for optional fields. --- Ful

[Lldb-commits] [lldb] [lldb-dap] Add unit test for ColumnDescriptor, BreakpointMode and Breakpoint (PR #139627)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/139627 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-13 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/139301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving tests logging to understand CI failures. (PR #139311)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/139311 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] 952b680 - Support stepping through Darwin "branch islands" (#139301)

2025-05-13 Thread via lldb-commits
Author: jimingham Date: 2025-05-13T13:32:53-07:00 New Revision: 952b680fd1a283883ee2075146a7b10ea9510e8a URL: https://github.com/llvm/llvm-project/commit/952b680fd1a283883ee2075146a7b10ea9510e8a DIFF: https://github.com/llvm/llvm-project/commit/952b680fd1a283883ee2075146a7b10ea9510e8a.diff LOG

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-13 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/139301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std:::string::find with std::string_view (NFC) (PR #139679)

2025-05-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/139679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b8ba963 - [lldb] don't run TestUnwindFramelessFaulted.py on Linux

2025-05-13 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-05-13T18:14:57-07:00 New Revision: b8ba9636f0f46a02ebe3ab369fe6b47703f45ba6 URL: https://github.com/llvm/llvm-project/commit/b8ba9636f0f46a02ebe3ab369fe6b47703f45ba6 DIFF: https://github.com/llvm/llvm-project/commit/b8ba9636f0f46a02ebe3ab369fe6b47703f45ba6.diff

[Lldb-commits] [lldb] [lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister (PR #139817)

2025-05-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: to be clear: The diff for the first half of the old SavedLocationForRegister is entirely pointless to look at. Reading RegisterContextUnwind::GetAbstractRegisterLocation in the "new" version of the file is the way to go, and I'm pretty comfortable with everything that I've

[Lldb-commits] [lldb] [lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister (PR #139817)

2025-05-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/139817 >From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 13 May 2025 17:11:08 -0700 Subject: [PATCH 1/4] [lldb][NFC] Split RegisterContextUnwind::SavedLocation

[Lldb-commits] [lldb] [lldb-dap] Add unit test for capabilities (PR #139835)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Add unit a test for the capabilities types. --- Full diff: https://github.com/llvm/llvm-project/pull/139835.diff 3 Files Affected: - (modified) lldb/tools/lldb-dap/Protocol/ProtocolTypes.cpp (+130

[Lldb-commits] [lldb] [lldb-dap] Add unit test for capabilities (PR #139835)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/139835 Add unit a test for the capabilities types. Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,B

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/139537 >From 05aef7d40097d9a554c648fa2be75530f23ca05c Mon Sep 17 00:00:00 2001 From: DhruvSrivastavaX Date: Mon, 12 May 2025 03:23:49 -0500 Subject: [PATCH 1/2] Added NativeThreadAIX --- .../source/Plugins/P

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for protocol enum types (PR #139848)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
@@ -105,7 +105,7 @@ bool fromJSON(const json::Value &Params, ColumnType &CT, json::Path P) { .Case("string", eColumnTypeString) .Case("number", eColumnTypeNumber) .Case("boolean", eColumnTypeBoolean) - .Case("unixTimestampUTC ", eColumnTy

[Lldb-commits] [lldb] [lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister (PR #139817)

2025-05-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/139817 >From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 13 May 2025 17:11:08 -0700 Subject: [PATCH 1/6] [lldb][NFC] Split RegisterContextUnwind::SavedLocation

[Lldb-commits] [lldb] [lldb] Fix typos in documentation (PR #139839)

2025-05-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/139839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,71 @@ +//===-- NativeThreadAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister (PR #139817)

2025-05-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/139817 >From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 13 May 2025 17:11:08 -0700 Subject: [PATCH 1/5] [lldb][NFC] Split RegisterContextUnwind::SavedLocation

[Lldb-commits] [lldb] [lldb-dap] Add unit test for capabilities (PR #139835)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Should we also have some tests for invalid enum cases? Sounds good, let me cover the enum cases in a separate PR. https://github.com/llvm/llvm-project/pull/139835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] ad2f703 - [lldb-dap] Add unit test for capabilities (#139835)

2025-05-13 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-13T22:51:03-07:00 New Revision: ad2f7034a2823f2366e55a5758c1c623b9348746 URL: https://github.com/llvm/llvm-project/commit/ad2f7034a2823f2366e55a5758c1c623b9348746 DIFF: https://github.com/llvm/llvm-project/commit/ad2f7034a2823f2366e55a5758c1c623b9348746.d

[Lldb-commits] [lldb] [lldb-dap] Add unit test for protocol enum types (PR #139848)

2025-05-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Add dedicated unit tests for the protocol enum types. --- Full diff: https://github.com/llvm/llvm-project/pull/139848.diff 3 Files Affected: - (modified) lldb/tools/lldb-dap/Protocol/ProtocolTypes

[Lldb-commits] [lldb] [lldb-dap] Add unit test for protocol enum types (PR #139848)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/139848 Add dedicated unit tests for the protocol enum types. Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -appl

[Lldb-commits] [lldb] [lldb-dap] Add unit test for capabilities (PR #139835)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/139835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for protocol enum types (PR #139848)

2025-05-13 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/139848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bdf8c99 - [lldb] Fix typos in documentation (#139839)

2025-05-13 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-13T23:34:28-07:00 New Revision: bdf8c9984ae325b9934ec6051a853a29830af9e2 URL: https://github.com/llvm/llvm-project/commit/bdf8c9984ae325b9934ec6051a853a29830af9e2 DIFF: https://github.com/llvm/llvm-project/commit/bdf8c9984ae325b9934ec6051a853a29830af9e2.diff L

[Lldb-commits] [lldb] [lldb] Fix typos in documentation (PR #139839)

2025-05-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/139839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typos in documentation (PR #139839)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits