jasonmolenda wrote: to be clear: The diff for the first half of the old SavedLocationForRegister is entirely pointless to look at. Reading RegisterContextUnwind::GetAbstractRegisterLocation in the "new" version of the file is the way to go, and I'm pretty comfortable with everything that I've kept in here, I think the behaviors are easy to reason as correct when I read it.
The diff for the second half -- taking an AbstractRegisterLocation and converting it into a ConcreteRegisterLocation -- involved very few changes and is readable. I've run it through our testsuite on macOS and it shows no issues, but I look forward to all the CI bots getting their hands on it & seeing that result confirmed. https://github.com/llvm/llvm-project/pull/139817 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
