[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-23 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/134354 >From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Fri, 4 Apr 2025 00:59:17 -0500 Subject: [PATCH 1/6] [lldb][AIX] get host info for AIX --- lldb/source/Hos

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Pavel Labath via lldb-commits
@@ -31,8 +31,11 @@ class DomainSocket : public Socket { std::vector GetListeningConnectionURI() const override; + static Socket *Create(NativeSocket sockfd, bool should_close, Status &error); labath wrote: I have a bit of a problem with this name because,

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Pavel Labath via lldb-commits
@@ -174,6 +175,9 @@ int main(int argc, char **argv) { //% self.expect("expr (new struct C[1]); side_effect", endstr=" = 4\n") //% self.expect("expr delete c2; side_effect", endstr=" = 1\n") //% self.expect("expr delete[] c3; side_effect", endstr=" = 2\n") + //% self.expe

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Dmitry Vasilyev via lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; slydiman wrote: There is a p

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Dmitry Vasilyev via lldb-commits
@@ -182,3 +191,22 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close, + Status &error) { +#ifdef _

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fb0000b - [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (#137007)

2025-04-23 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-04-24T07:38:35+01:00 New Revision: fbb6624a5f2df25d10e3667111e96dd1abd5 URL: https://github.com/llvm/llvm-project/commit/fbb6624a5f2df25d10e3667111e96dd1abd5 DIFF: https://github.com/llvm/llvm-project/commit/fbb6624a5f2df25d10e3667111e96dd1abd5.diff L

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Yingwei Zheng (dtcxzyw) Changes `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So I decided to change

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread Yingwei Zheng via lldb-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/137123 `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So I decided to change lldb to match

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Yingwei Zheng (dtcxzyw) Changes `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/6] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136777 >From e513345b74d5dac5b80fcddebcd52ff1aa2ea4dd Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 23 Apr 2025 00:06:28 +0200 Subject: [PATCH 1/2] [lldb-dap] handle stack frames without a module --- .../lldb-

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, getting some numbers would be nice. Maybe just repeating the benchmark in that diff. It might be a good idea to do it with and without the accelerator tables, just to rule out any effect from those. FWIW, I expect this to not matter these days. It looks like this change (h

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, // Line numbers are 1-based. object.try_emplace("line", inst_line + 1); object.try_emplace("column", 1); + } else { +// No valid line entry or symbol +llvm::json::Object source; +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/6] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/137041 This the actual PR to my [SEIZE RFC](https://discourse.llvm.org/t/rfc-ptrace-seize-when-attaching-to-dead-processes/85825/8). This is currently the bare bones on seizing a dead process, and being able to attac

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,166 @@ +//===-- DemangledNameInfo.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
@@ -209,6 +209,26 @@ def test_default_no_run(self): ) self.assertGreater(module_stats["symbolsLoaded"], 0) clayborg wrote: Same here, renamed "symbolTableSymbolCount" https://github.com/llvm/llvm-project/pull/136795 ___

[Lldb-commits] [lldb] [lldb-dap] Show load addresses in disassembly (PR #136755)

2025-04-23 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere I don't have write access, fee free to merge this PR if possible (I don't know how the procedures of LLVM work in order to merge) https://github.com/llvm/llvm-project/pull/136755 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/2] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb-dap] Show load addresses in disassembly (PR #136755)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1da856a - [lldb] Fix typo in ManualDWARFIndexSet.h

2025-04-23 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-04-23T18:22:26+02:00 New Revision: 1da856a685cf427ab1f5b810125c41e7859ed362 URL: https://github.com/llvm/llvm-project/commit/1da856a685cf427ab1f5b810125c41e7859ed362 DIFF: https://github.com/llvm/llvm-project/commit/1da856a685cf427ab1f5b810125c41e7859ed362.diff

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-23 Thread David Peixotto via lldb-commits
dmpots wrote: > > 1. Are we ok to start with a static table of plugin namespaces or do we > > want dynamic registration from the beginning? > >[Add commands to list/enable/disable pluginsĀ #134418 > > (comment)](https://github.com/llvm/llvm-project/pull/134418#discussion_r2029164327) > > I

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH 1/4] Fix connecting via abstract socket Commit 82ee31f an

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > What if a language plugin adds a command that conflicts with a top-level > command? @bulbazord the top-level command will be used. This is a fallback, for when no such top-level command exists. If a language plugin adds a subcommand that conflicts with a top-level command

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/5] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -37,6 +37,18 @@ void OptionValueEnumeration::DumpValue(const ExecutionContext *exe_ctx, } } +llvm::json::Value +OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) { + const size_t count = m_enumerations.GetSize(); + for (size_t i = 0; i < count; ++i) { +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -202,6 +202,10 @@ struct DAP { lldb::SBFormat frame_format; lldb::SBFormat thread_format; + + /// The value of stop-disassembly-display setting in LLDB. + std::string stop_disassembly_display; eronnen wrote: Agree, changed it https://github.com/llvm

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + lldb::SBStructuredData result = + debugger.GetSetting("stop-disassembly-display"); + const si

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > maybe you step into a frame you don't have debug info or symbols for @bulbazord one potential solution to this is to use the top-most stack frame for which a language is known. https://github.com/llvm/llvm-project/pull/136766 ___

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione ready_for_review https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-23 Thread Maksim Ivanov via lldb-commits
emaxx-google wrote: Hello, the minimized reproducer for the determinism issue is there: https://pastebin.com/6aL6rmBe . To build it, unpack it into separate files (via `split-file`), then run `CLANG=path/to/clang make`. The nondeterminism can be checked by looping `make clean` + `make` + `md5s

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
@@ -209,6 +209,26 @@ def test_default_no_run(self): ) self.assertGreater(module_stats["symbolsLoaded"], 0) +def test_default_no_run_no_preload_symbols(self): +"""Test "statistics dump" without running the target and without +preloadi

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/136795 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > Many of our users are opinionated about how commands should work ("This > breaks my python scripts!" @bulbazord I agree. I don't think this should break anything. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136486 >From 5cb1442b1df0befbc55806aee6c9dea4edd68816 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 14:27:53 +0200 Subject: [PATCH 1/2] fix wrong assembly line number when debugging assembly with di

[Lldb-commits] [lldb] [lldb] Minor improvements to AddNamesMatchingPartialString (NFC) (PR #136760)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/137041 >From a33b865302e0d489cc4426c038128d8dde47500e Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 22 Apr 2025 16:35:00 -0700 Subject: [PATCH 1/2] Create proc status reader --- .../Plugins/Process/Utility/

[Lldb-commits] [lldb] d72f1f9 - Bug fix in FindModuleUUID (#137075)

2025-04-23 Thread via lldb-commits
Author: GeorgeHuyubo Date: 2025-04-23T15:46:12-07:00 New Revision: d72f1f92f469a5d0ee28dc89f72977634d90d111 URL: https://github.com/llvm/llvm-project/commit/d72f1f92f469a5d0ee28dc89f72977634d90d111 DIFF: https://github.com/llvm/llvm-project/commit/d72f1f92f469a5d0ee28dc89f72977634d90d111.diff

[Lldb-commits] [lldb] Bug fix in FindModuleUUID (PR #137075)

2025-04-23 Thread via lldb-commits
GeorgeHuyubo wrote: > LGTM. Any chance you could artifically craft such a core file for a test? I think this file historically lack a good way of testing changes due to difficulties in hand craft a ELF core file using YAML. https://github.com/llvm/llvm-project/pull/137075 _

[Lldb-commits] [lldb] [lldb-dap] Migrate 'stepIn' request to well structured types. (PR #137071)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137071 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-23 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Thanks. Can this be merged now? https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/4] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] Bug fix in FindModuleUUID (PR #137075)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes In some core file, we are seeing that it's not always the case that the ELF header would exist in the first region in NT_FILES section. Therefore the FindModuleUUID is not able to find the module UUID by just re

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Quote module name in error message (PR #137083)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/137083.diff 1 Files Affected: - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp (+1-1) ``diff di

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136486 >From 5cb1442b1df0befbc55806aee6c9dea4edd68816 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 14:27:53 +0200 Subject: [PATCH 1/2] fix wrong assembly line number when debugging assembly with di

[Lldb-commits] [lldb] [lldb] Quote module name in error message (PR #137083)

2025-04-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/137083 None >From 05a5eb1eb5ac4ea32c98783cd1a241c7e147e30d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 23 Apr 2025 16:24:49 -0700 Subject: [PATCH] [lldb] Quote module name in error message --- .../

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere added a test that checks that `line` increments by exactly 1 each step https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,64 @@ +""" +Test lldb-dap stack trace containing x86 assembly +""" + +import lldbdap_testcase +from lldbsuite.test.decorators import skipUnlessArch, skipUnlessPlatform +from lldbsuite.test.lldbtest import line_number + + +class TestDAP_stacktrace_x86(lldbdap_testcase.DA

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,64 @@ +""" +Test lldb-dap stack trace containing x86 assembly +""" + +import lldbdap_testcase +from lldbsuite.test.decorators import skipUnlessArch, skipUnlessPlatform +from lldbsuite.test.lldbtest import line_number + + +class TestDAP_stacktrace_x86(lldbdap_testcase.DA

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136486 >From 5cb1442b1df0befbc55806aee6c9dea4edd68816 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 14:27:53 +0200 Subject: [PATCH 1/3] fix wrong assembly line number when debugging assembly with di

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-23 Thread Greg Clayton via lldb-commits
clayborg wrote: Can we renamed `"symbolsLoaded"` to `"symbolTableSymbolCount"` and `"totalSymbolsLoaded"` to `"totalSymbolTableSymbolCount"`? This would be more consistent with the other symbol table statistics https://github.com/llvm/llvm-project/pull/136226 __

[Lldb-commits] [lldb] [lldb-dap] Updating the 'next' request handler use well structured types (PR #136642)

2025-04-23 Thread John Harrison via lldb-commits
@@ -8,72 +8,37 @@ #include "DAP.h" #include "EventHelper.h" -#include "JSONUtils.h" +#include "Protocol/ProtocolTypes.h" #include "RequestHandler.h" +#include "llvm/Support/Error.h" + +using namespace llvm; +using namespace lldb_dap::protocol; namespace lldb_dap { -// "N

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-23 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @jimingham @DavidSpickett can one of you approve this please? https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Quote module name in error message (PR #137083)

2025-04-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/137083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136777 >From e513345b74d5dac5b80fcddebcd52ff1aa2ea4dd Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 23 Apr 2025 00:06:28 +0200 Subject: [PATCH] [lldb-dap] handle stack frames without a module --- .../lldb-dap/

[Lldb-commits] [lldb] 563ab56 - [lldb-dap] Show load addresses in disassembly (#136755)

2025-04-23 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-04-23T13:04:39-07:00 New Revision: 563ab56497104199b9fd57df9bd162f2b02cbe92 URL: https://github.com/llvm/llvm-project/commit/563ab56497104199b9fd57df9bd162f2b02cbe92 DIFF: https://github.com/llvm/llvm-project/commit/563ab56497104199b9fd57df9bd162f2b02cbe92.diff LO

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Fixes parsing of an ObjC type encoding such as `{?="a""b"}`. Parsing of such a type encoding would lead to an assert. This was observed when running `language objc class-table dump`. The function `ReadQuotedS

[Lldb-commits] [lldb] [lldb] Fix typo in tagged-pointer syntax string (NFC) (PR #137069)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/137069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM but I'd like to have a (x86) test that would have failed without this case. https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] cef9ed5 - [lldb] Fix typo in tagged-pointer syntax string (NFC) (#137069)

2025-04-23 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-23T14:59:27-07:00 New Revision: cef9ed56f8c19258f8805512e58627c5bc79bf98 URL: https://github.com/llvm/llvm-project/commit/cef9ed56f8c19258f8805512e58627c5bc79bf98 DIFF: https://github.com/llvm/llvm-project/commit/cef9ed56f8c19258f8805512e58627c5bc79bf98.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix typo in tagged-pointer syntax string (NFC) (PR #137069)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/137069.diff 1 Files Affected: - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (+1-1) ``di

[Lldb-commits] [lldb] [lldb] Fix typo in tagged-pointer syntax string (NFC) (PR #137069)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137069 None >From d4c5962b145e3d8c980159b0adca55d2bad55608 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 23 Apr 2025 14:59:03 -0700 Subject: [PATCH] [lldb] Fix typo in tagged-pointer syntax string (NFC) ---

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/135565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-23 Thread via lldb-commits
github-actions[bot] wrote: @eronnen Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,76 @@ +//===-- RegisterInfoPOSIX_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/115408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate 'stepIn' request to well structured types. (PR #137071)

2025-04-23 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/137071 >From f4f2fea5cebbce550de0e0c3facaac894b9f40b8 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 23 Apr 2025 15:01:53 -0700 Subject: [PATCH 1/2] [lldb-dap] Migrate 'stepIn' request to well structured types

[Lldb-commits] [lldb] [lldb-dap] Migrate 'stepIn' request to well structured types. (PR #137071)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Migrates the 'stepIn' request handler to have well structured types instead of raw json values. I also noticed in the 'next' request handler we were not passing the 'RunMode' flag. Updated the 'next' request

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/137072 When doing function lookup in an LLDB module by name, we may need to hand-parse C++ method names to determine properties of the function name such as its "basename". LLDB currently has two ways of parsing me

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks good to me, straightforward corefile impl of these registers. https://github.com/llvm/llvm-project/pull/115408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/137072 >From 91fc35b07ca2a282886b8c340d3dd37a6c881519 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 23 Apr 2025 22:48:12 +0100 Subject: [PATCH 1/2] [lldb][CPlusPlus] Remove TrySimplifiedParse when hand-par

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,185 @@ +//===-- RegisterInfos_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/115408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When doing function lookup in an LLDB module by name, we may need to hand-parse C++ method names to determine properties of the function name such as its "basename". LLDB currently has two ways of parsing

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH 1/3] Fix connecting via abstract socket Commit 82ee31f an

[Lldb-commits] [lldb] 6f5b98b - [lldb] returning command completions up to a maximum (#135565)

2025-04-23 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-04-23T15:01:03-07:00 New Revision: 6f5b98b3247969eb85135141bdae4a2d6aeb284a URL: https://github.com/llvm/llvm-project/commit/6f5b98b3247969eb85135141bdae4a2d6aeb284a DIFF: https://github.com/llvm/llvm-project/commit/6f5b98b3247969eb85135141bdae4a2d6aeb284a.diff LO

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -182,3 +191,22 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close, + Status &error) { +#ifdef _

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -182,3 +191,22 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close, + Status &error) { +#ifdef _

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; emrekultursay wrote: Done by

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; - + Log *log = GetLog(LLDBLog::Platform);

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay commented: PTAL. I added unit tests for the method, but I'm open to suggestions on how to improve that test. https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -182,3 +191,22 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close, + Status &error) { +#ifdef _

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
@@ -31,8 +31,11 @@ class DomainSocket : public Socket { std::vector GetListeningConnectionURI() const override; + static Socket *Create(NativeSocket sockfd, bool should_close, Status &error); emrekultursay wrote: Done. https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] 096ab51 - [lldb][MachO] MachO corefile support for riscv32 binaries (#137092)

2025-04-23 Thread via lldb-commits
Author: Jason Molenda Date: 2025-04-23T22:10:15-07:00 New Revision: 096ab51de03437e38f97a48b8f2d453fb903414a URL: https://github.com/llvm/llvm-project/commit/096ab51de03437e38f97a48b8f2d453fb903414a DIFF: https://github.com/llvm/llvm-project/commit/096ab51de03437e38f97a48b8f2d453fb903414a.diff

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/137092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/137007 >From 5ffbb9db5031e4f4146dce9736235421fbc5abca Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 21:07:34 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration This a

<    1   2   3   >