[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security edited https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security edited https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/131544 The logging markers for incoming ("<--") and outgoing ("-->") messages were incorrectly reversed. from #7790d69 >From bdfcf3a3d15c2c8f72d6a553027287eb0f43a3d4 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date:

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131519 >From 0af05f390616de8fa73fb975c4c202aac13d3745 Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Sun, 16 Mar 2025 14:08:57 + Subject: [PATCH] [lldb] Use correct path for lldb-server executab

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130773 >From 1a70dca11783f11b267d0d144311994dfba79733 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Tue, 11 Mar 2025 13:15:16 + Subject: [PATCH] [lldb][lldb-dap] setVariable request should send the correct res

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes The logging markers for incoming ("<--") and outgoing ("-->") messages were incorrectly reversed. from #7790d69 --- Full diff: https://github.com/llvm/llvm-project/pull/131544.diff 1 Files Affected: - (mod

[Lldb-commits] [lldb] 125c4db - [lldb][lldb-dap] setVariable request should send the correct response (#130773)

2025-03-16 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-03-16T23:28:25Z New Revision: 125c4db7301875cae928406043f02ed5b1133195 URL: https://github.com/llvm/llvm-project/commit/125c4db7301875cae928406043f02ed5b1133195 DIFF: https://github.com/llvm/llvm-project/commit/125c4db7301875cae928406043f02ed5b1133195.diff LOG: [

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131519 >From bbfae1028b2c47b6fe422f71516fb486d94f406b Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Sun, 16 Mar 2025 14:08:57 + Subject: [PATCH] [lldb] Use correct path for lldb-server executab

[Lldb-commits] [lldb] 8705e48 - [lldb] Remove use of comma operator (NFC) (#131233)

2025-03-16 Thread via lldb-commits
Author: Dave Lee Date: 2025-03-16T08:41:55-07:00 New Revision: 8705e489dc17eb7124aca5070201d2dd234f97c1 URL: https://github.com/llvm/llvm-project/commit/8705e489dc17eb7124aca5070201d2dd234f97c1 DIFF: https://github.com/llvm/llvm-project/commit/8705e489dc17eb7124aca5070201d2dd234f97c1.diff LOG:

[Lldb-commits] [lldb] [lldb] Remove use of comma operator (NFC) (PR #131233)

2025-03-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/131233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo comments https://github.com/llvm/llvm-project/pull/130090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Huh, you're right, the direction was changed, but I actually think the current direction is more intuitive. @ashgti did you change this on purpose? https://github.com/llvm/llvm-project/pull/131544 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
@@ -1,12 +1,12 @@ -//===-- Protocol.cpp --===// +//===-- ProtocolBase.cpp --===// JDevlieghere wrote: Why not just Protocol? Do you think that's to confusing wit

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
@@ -663,58 +671,64 @@ void DAP::SetTarget(const lldb::SBTarget target) { } bool DAP::HandleObject(const protocol::Message &M) { - // FIXME: Directly handle `Message` instead of serializing to JSON. - llvm::json::Value v = toJSON(M); - llvm::json::Object object = *v.getAsObj

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security created https://github.com/llvm/llvm-project/pull/131519 Hey, This solves an issue where running lldb-server-20 with a non-absolute path (for example, when it's installed into `/usr/bin` and the user runs it as `lldb-server-20 ...` and not `/usr/bin/ll

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Yuval Deutscher (yuvald-sweet-security) Changes Hey, This solves an issue where running lldb-server-20 with a non-absolute path (for example, when it's installed into `/usr/bin` and the user runs it as `lldb-server-20 ...` and not `/usr/b

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-16 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
@@ -0,0 +1,64 @@ +""" +Make sure 'frame var' using DIL parser/evaultor works for local variables. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + + +

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
@@ -0,0 +1,102 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
cmtice wrote: I think I have addressed all of the remaining review comments/questions. Please review this again when you have a few minutes. Thanks! https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
@@ -162,4 +162,13 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +llvm::Error takeError(const lldb::SBError &error) { JDevlieghere wrote: How about `ToError` to match `Status::ToError`? ```suggestion llvm::Error ToErr

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
cmtice wrote: > > > Didn't quite finish, but this is what I have so far. I am wondering about > > > the usefulness of the `IdentifierInfo`. It started out its existence in a > > > completely different world than what we have now -- where the operations > > > were mainly defined on types instea

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-16 Thread Jacob Lalonde via lldb-commits
@@ -392,9 +391,59 @@ struct DAP { void SetThreadFormat(llvm::StringRef format); - InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t bp_id); + template + BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) { +// Check to see if h

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
cmtice wrote: > The other advantage of the diagnostic manager with the details et al, is that > lldb can use the structure in the diagnostic messages to have the error > message include a pointer to the place of the error in the original message, > like: > > ``` > (lldb) expr edgeSet.not_ther

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
cmtice wrote: > NewFormatDiagnostics looks okay. It's longer than the old version, but it's > straight-forward linear code, so I don't have a problem with that. > > It's true that the system was designed to handle multiple errors, but it > doesn't mean you have to use it that way. For me, the

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-16 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread John Harrison via lldb-commits
ashgti wrote: > Huh, you're right, the direction was changed, but I actually think the > current direction is more intuitive. > > @ashgti did you change this on purpose? I didn’t mean to change it but I’m fine with either form. https://github.com/llvm/llvm-project/pull/131544 __

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/130090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap][NFC] Fix swapped logging directions for DAP messages. (PR #131544)

2025-03-16 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/131544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits