cmtice wrote:

> NewFormatDiagnostics looks okay. It's longer than the old version, but it's 
> straight-forward linear code, so I don't have a problem with that.
> 
> It's true that the system was designed to handle multiple errors, but it 
> doesn't mean you have to use it that way. For me, the main value in it is the 
> consistency of the error format wr.t. the expression parser (I don't 
> particularly care about the new fancy format, but I think it's good to use 
> the same one in both places).

Ok, I've updated the code to use the NewFormatDiagnostics (now just called 
FormatDiagnostics).

https://github.com/llvm/llvm-project/pull/120971
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to