[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,120 @@ +//===-- GoToTargetsRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
@@ -423,34 +493,66 @@ void DynamicLoaderPOSIXDYLD::RefreshModules() { E = m_rendezvous.end(); m_initial_modules_added = true; } -for (; I != E; ++I) { - // Don't load a duplicate copy of ld.so if we have already loaded it - // earlier in LoadInterp

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-03-15 Thread Mikhail Zakharov via lldb-commits
real-mikhail wrote: > I think something like that might work. Clarification: that will work only for cases if there are `VariableObject` for each variable and they are checked. If, for instance, non-persistent variable holds reference to persistent variable and only `MemoryCacheId` is bumped t

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/117500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 65e68a3 - [lldb] Update dwim-print to show expanded objc instances (#117500)

2025-03-15 Thread via lldb-commits
Author: Dave Lee Date: 2025-03-15T08:57:51-07:00 New Revision: 65e68a30787d7ce2bf5a9e695dd03944137c5287 URL: https://github.com/llvm/llvm-project/commit/65e68a30787d7ce2bf5a9e695dd03944137c5287 DIFF: https://github.com/llvm/llvm-project/commit/65e68a30787d7ce2bf5a9e695dd03944137c5287.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-15 Thread John Harrison via lldb-commits
@@ -0,0 +1,103 @@ +import * as vscode from "vscode"; +import * as child_process from "child_process"; +import * as util from "util"; +import { LLDBDapServer } from "./lldb-dap-server"; +import { createDebugAdapterExecutable } from "./debug-adapter-factory"; +import { ConfigureButt

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-15 Thread John Harrison via lldb-commits
@@ -90,117 +99,119 @@ async function getDAPExecutable( return foundPath; } - return undefined; + throw new ErrorWithNotification( +"Unable to find the path to the LLDB debug adapter executable.", +new OpenSettingsButton("lldb-dap.executable-path"), + ); } -

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/130912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Julius Alexandre via lldb-commits
wizardengineer wrote: Hey @adrian-prantl, if you can and when you have time. I was wondering if it'd be okay if you can review this and just so i can make sure it aligns with the standards for this PR. I was also curious to know if I'd have to change any test code too, I've tried to unit test

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From 88f1cf3469c9f24a768f5147c22cfe414aea014e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Sat, 8 Mar 2025 17:55:34 -0800 Subject: [PATCH 1/4] [lldb-dap] Adding logging helpers. Improving logging by defin

[Lldb-commits] [lldb] e9b2edd - [lldb] fix set SBLineEntryColumn (#130435)

2025-03-15 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-03-10T09:10:23-07:00 New Revision: e9b2eddd5be753e72010da8a4333df8195e1641c URL: https://github.com/llvm/llvm-project/commit/e9b2eddd5be753e72010da8a4333df8195e1641c DIFF: https://github.com/llvm/llvm-project/commit/e9b2eddd5be753e72010da8a4333df8195e1641c.diff L

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-15 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Overall looks great, a few questions / follow items https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Greg Clayton via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Greg Clayton via lldb-commits
@@ -969,12 +969,89 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } -static uint64_t -GetLargestRangeSize(const std::vector &ranges) { - uint64_t max_size = 0; - for (const auto &core_range : ranges) -max_size = std::max(max_size, core_range.ran

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,42 @@ +import * as path from "path"; +import * as vscode from "vscode"; +import { createProcessTree } from "../process-tree"; + +interface ProcessQuickPick extends vscode.QuickPickItem { + processId: number; +} + +/** + * Prompts the user to select a running process. +

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2025-03-15 Thread Dave Lee via lldb-commits
kastiglione wrote: @jimingham I agree that expanding the output of `v` while listing variables could be a regression. However note that this change is to `dwim-print`, not `v`, and so this change would not cause the problem you're describing. This is because `dwim-print` has neither a "print a

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Greg Clayton via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-15 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,330 @@ +//===-- NativeProcessAIX.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Jacob Lalonde via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131404 >From 5ea2ad6ecb388818b009fa89c4aebe1e0e4213df Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 14 Mar 2025 15:19:58 -0700 Subject: [PATCH 1/2] [lldb] Expose the Target API lock through the SB AP

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-15 Thread John Harrison via lldb-commits
@@ -0,0 +1,130 @@ +import * as child_process from "node:child_process"; +import * as vscode from "vscode"; + +function areArraysEqual(lhs: T[], rhs: T[]): boolean { + if (lhs.length !== rhs.length) { +return false; + } + for (let i = 0; i < lhs.length; i++) { +if (lhs[i

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/131404 Expose the target API lock through the SB API. This is motivated by `lldb-dap`, which is built on top of the SB API and needs a way to execute a series of SB API calls in an atomic manner (see #131242). We

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
@@ -240,6 +240,137 @@ using Message = std::variant; bool fromJSON(const llvm::json::Value &, Message &, llvm::json::Path); llvm::json::Value toJSON(const Message &); +// MARK: Types + +// "Source": { +// "type": "object", +// "description": "A `Source` is a descriptor for

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Please try to write a little summary of the problem in the commit description before you merge this. Something like: > The display value was incorrectly sent as "result" instead of "value". A good description is really helpful

[Lldb-commits] [lldb] 1d1b20a - [lldb] Avoid force loading symbol files in statistics collection (#129593)

2025-03-15 Thread via lldb-commits
Author: David Peixotto Date: 2025-03-10T10:54:11-07:00 New Revision: 1d1b20a19ecf51741f2946976ec5f44a0ed53710 URL: https://github.com/llvm/llvm-project/commit/1d1b20a19ecf51741f2946976ec5f44a0ed53710 DIFF: https://github.com/llvm/llvm-project/commit/1d1b20a19ecf51741f2946976ec5f44a0ed53710.diff

[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

2025-03-15 Thread John Harrison via lldb-commits
ashgti wrote: #130186 should fix the failure. https://github.com/llvm/llvm-project/pull/129964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/129593 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
https://github.com/satyajanga updated https://github.com/llvm/llvm-project/pull/130841 >From 55d3b7d0ecf103cc97942c1406926853c35356c1 Mon Sep 17 00:00:00 2001 From: satya janga Date: Tue, 11 Mar 2025 13:39:08 -0700 Subject: [PATCH 1/3] Make breakpoint stop reason more accurate --- .../test/to

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +struct APILock { + APILock(std::recursive_mutex &mutex) : lock(mutex) {} + std::lock_guard lock; +}; + +/// The private implementation used by

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
DanielCChen wrote: > > > Wouldn't it be more maintainable to just force the value to OFF for AIX > > > where the `option()` is defined? > > > > > > Unfortunately, the cmake command line option > > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the > > cmake file. > >

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/129307 >From 1cfd90c01dbd4358577c0bd62a88a1191848693a Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 28 Feb 2025 11:38:35 -0800 Subject: [PATCH 1/7] Update MinidumpFileBuilder to read and write in chunks ---

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Julius Alexandre via lldb-commits
@@ -483,19 +483,18 @@ class EntityVariableBase : public Materializer::Entity { } if (m_is_reference) { - DataExtractor valobj_extractor; - Status extract_error; - valobj_sp->GetData(valobj_extractor, extract_error); + auto valobj_extractor_or_err =

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer edited https://github.com/llvm/llvm-project/pull/130516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-03-15 Thread Mikhail Zakharov via lldb-commits
real-mikhail wrote: > If I make an instance of a collection class (most of which are comprehended > by synthetic child providers) and then call: > (lldb) expr $my_vector.append(1) > (lldb) expr $my_vector That will still work with my changes. Because function call (`.append()`) is JIT compiled

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/131475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 1/6] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 1/5] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 1/2] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON o

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/131475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 1/3] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 1/4] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Great, if that's the case let's turn it on by default, and go with the shared setting at the target level. We can migrate over the Darwin plugin in a follow-up PR. https://github.com/llvm/llvm-project/pull/130912 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-15 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,265 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From c340c38a82880114471938b19512670d7f94245e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 10:18:36 +0100 Subject: [PATCH 1/7] [lldb-dap] Refactoring IOStream into Transport handler. Inste

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread Pavel Labath via lldb-commits
@@ -315,23 +316,19 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, &dap_sessions_mutex, &dap_sessions, &clientCount](

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-15 Thread David Spickett via lldb-commits
@@ -185,6 +185,9 @@ def setUpServerLogging(self, is_llgs): ] def get_next_port(self): +available_ports = self.getPlatformAvailablePorts() +if available_ports: DavidSpickett wrote: We require Python >= 3.8 (https://lldb.llvm.or

[Lldb-commits] [lldb] [LLDB][Docstrings] Fix some poorly formatted Docstrings (PR #129605)

2025-03-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/129605 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-15 Thread Jacob Lalonde via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [clang] [lldb] [C++20][Modules] Do not update the declaration generation number if the redeclaration chain completion was delayed. (PR #129982)

2025-03-15 Thread Michael Park via lldb-commits
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested, if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility) return true; + // The external source may have additional definitions of this entity that are + // visi

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
@@ -210,12 +209,33 @@ struct DAP { // will contain that expression. std::string last_nonempty_var_expression; - DAP(llvm::StringRef client_name, llvm::StringRef path, std::ofstream *log, - lldb::IOObjectSP input, lldb::IOObjectSP output, ReplMode repl_mode, - st

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-15 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,265 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/5] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb] Objective-C runtime: Work around a bug in the shared cache builder (PR #130209)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Do you mind including the radar tracking the shared cache builder issue (rdar://146432183) in the comment? https://github.com/llvm/llvm-project/pull/130209 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] 4022d78 - [lldb] Fix compile error. (#130091)

2025-03-15 Thread via lldb-commits
Author: Adrian Kuegel Date: 2025-03-06T14:00:33+01:00 New Revision: 4022d78591d3ad417731fae2a16035126ff2ca7e URL: https://github.com/llvm/llvm-project/commit/4022d78591d3ad417731fae2a16035126ff2ca7e DIFF: https://github.com/llvm/llvm-project/commit/4022d78591d3ad417731fae2a16035126ff2ca7e.diff

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-03-15 Thread Tom Yang via lldb-commits
@@ -0,0 +1,8 @@ + +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "dynamicloaderposixdyld" in { + def ParallelModuleLoad: Property<"parallel-module-load", "Boolean">, zhyty wrote: I don't feel strongly about keeping it as a plugin-

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread John Harrison via lldb-commits
@@ -6,8 +6,9 @@ // //===--===// -#include "RequestHandler.h" +#include "Handler/RequestHandler.h" #include "DAP.h" +#include "Handler/ResponseHandler.h" ashgti wrote: `LogFailureResponseHan

[Lldb-commits] [lldb] [LLDB][NFC] Fix typo in docs (PR #131388)

2025-03-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kon (kon72) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/131388.diff 1 Files Affected: - (modified) lldb/docs/use/python-reference.rst (+1-1) ``diff diff --git a/lldb/docs/use/python-reference.rst b/lldb/

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-03-15 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Hi, @labath @DavidSpickett, Resuming the conversation on XCOFF support. I have added support for reading XCOFF sections using existing LLVM interfaces. I know there are gaps, so please let me know your thoughts. - Just FYI, I have only added implementation in CreateSe

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/18] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang commented: just a very cursory review. I will review this more closely as soon as the preparatory commits landed. Those "stacked PRs" are a bit hard to review https://github.com/llvm/llvm-project/pull/130169 ___ lldb-co

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -248,6 +246,7 @@ struct DAP { // Serialize the JSON value into a string and send the JSON packet to // the "out" stream. void SendJSON(const llvm::json::Value &json); + void Send(const protocol::Message &message); vogelsgesang wrote: ```suggestion

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -663,58 +671,65 @@ void DAP::SetTarget(const lldb::SBTarget target) { } bool DAP::HandleObject(const protocol::Message &M) { - // FIXME: Directly handle `Message` instead of serializing to JSON. - llvm::json::Value v = toJSON(M); - llvm::json::Object object = *v.getAsObj

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
@@ -565,8 +568,10 @@ int main(int argc, char *argv[]) { lldb::IOObjectSP output = std::make_shared( stdout_fd, File::eOpenOptionWriteOnly, false); - DAP dap = DAP("stdin/stdout", program_path, log.get(), std::move(input), -std::move(output), default_re

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
@@ -423,34 +493,66 @@ void DynamicLoaderPOSIXDYLD::RefreshModules() { E = m_rendezvous.end(); m_initial_modules_added = true; } -for (; I != E; ++I) { - // Don't load a duplicate copy of ld.so if we have already loaded it - // earlier in LoadInterp

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread Jacob Lalonde via lldb-commits
@@ -171,3 +171,35 @@ def test_functionality(self): self.continue_to_next_stop() x_val = self.dap_server.get_local_variable_value("x") self.assertEqual(x_val, "10") + +@skipIfWindows +def test_breakpoint_reason(self): +"""Tests setting dat

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -65,7 +66,7 @@ DAP::DAP(std::string name, llvm::StringRef path, std::ofstream *log, lldb::IOObjectSP input, lldb::IOObjectSP output, ReplMode repl_mode, std::vector pre_init_commands) : name(std::move(name)), debug_adapter_path(path), log(log), -

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
https://github.com/satyajanga updated https://github.com/llvm/llvm-project/pull/130841 >From e949d2ee19408c43d9067075d2436f8549132830 Mon Sep 17 00:00:00 2001 From: satya janga Date: Tue, 11 Mar 2025 13:39:08 -0700 Subject: [PATCH 1/4] Make breakpoint stop reason more accurate --- .../test/to

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
@@ -392,9 +391,59 @@ struct DAP { void SetThreadFormat(llvm::StringRef format); - InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t bp_id); + template + BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) { +// Check to see if h

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
https://github.com/satyajanga updated https://github.com/llvm/llvm-project/pull/130841 >From e949d2ee19408c43d9067075d2436f8549132830 Mon Sep 17 00:00:00 2001 From: satya janga Date: Tue, 11 Mar 2025 13:39:08 -0700 Subject: [PATCH 1/4] Make breakpoint stop reason more accurate --- .../test/to

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
@@ -962,28 +962,43 @@ llvm::json::Value CreateThreadStopped(DAP &dap, lldb::SBThread &thread, body.try_emplace("reason", "step"); break; case lldb::eStopReasonBreakpoint: { -ExceptionBreakpoint *exc_bp = dap.GetExceptionBPFromStopReason(thread); +ExceptionBre

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-15 Thread via lldb-commits
@@ -171,3 +171,35 @@ def test_functionality(self): self.continue_to_next_stop() x_val = self.dap_server.get_local_variable_value("x") self.assertEqual(x_val, "10") + +@skipIfWindows +def test_breakpoint_reason(self): +"""Tests setting dat

[Lldb-commits] [lldb] [lldb] Fix compile error. (PR #130091)

2025-03-15 Thread Adrian Kuegel via lldb-commits
https://github.com/akuegel closed https://github.com/llvm/llvm-project/pull/130091 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo nits. https://github.com/llvm/llvm-project/pull/130026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adapt llgs tests for RISC-V (PR #130034)

2025-03-15 Thread Georgiy Samoylov via lldb-commits
sga-sc wrote: Could you merge it, please? https://github.com/llvm/llvm-project/pull/130034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-15 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien edited https://github.com/llvm/llvm-project/pull/128943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Julius Alexandre via lldb-commits
@@ -46,19 +46,27 @@ bool TypeFormatImpl_Format::FormatObject(ValueObject *valobj, Value &value(valobj->GetValue()); const Value::ContextType context_type = value.GetContextType(); ExecutionContext exe_ctx(valobj->GetExecutionContextRef()); -DataExtractor data;

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Change `lldbtest.expect` to search the given `patterns` in order, if the `ordered` parameter is true. The `ordered` parameter is true by default, so this change also fixes tests by either tweaking the patter

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/131475 Change `lldbtest.expect` to search the given `patterns` in order, if the `ordered` parameter is true. The `ordered` parameter is true by default, so this change also fixes tests by either tweaking the patt

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/131475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/131475 >From dd2bf73c7118ba70dc0640f10cbdc25ef6886648 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Sat, 15 Mar 2025 11:20:36 -0700 Subject: [PATCH 1/2] [lldb] Support ordered patterns in lldbtest.expect Change `l

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-15 Thread John Harrison via lldb-commits
@@ -240,6 +240,137 @@ using Message = std::variant; bool fromJSON(const llvm::json::Value &, Message &, llvm::json::Path); llvm::json::Value toJSON(const Message &); +// MARK: Types + +// "Source": { +// "type": "object", +// "description": "A `Source` is a descriptor for

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/15] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-15 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/130026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniel Chen (DanielCChen) Changes We don't plan to support it on AIX. This change will make it as if it is set to OFF. --- Full diff: https://github.com/llvm/llvm-project/pull/131200.diff 9 Files Affected: - (modified) compiler-rt/cmake/

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

2025-03-15 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/12507 Here is the relevant piece of the build lo

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Adrian Prantl via lldb-commits
@@ -68,11 +68,9 @@ static bool CharStringSummaryProvider(ValueObject &valobj, Stream &stream) { template static bool CharSummaryProvider(ValueObject &valobj, Stream &stream) { - DataExtractor data; - Status error; - valobj.GetData(data, error); + auto data_or_err = valob

[Lldb-commits] [lldb] [lldb] Remove use of comma operator (NFC) (PR #131233)

2025-03-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/131233 >From 47bd3d18947f9d34472095f6064f00016c20bc4b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 13 Mar 2025 15:43:48 -0700 Subject: [PATCH 1/2] [lldb] Remove use of comma operator (NFC) --- lldb/source/V