@@ -0,0 +1,244 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,244 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
labath wrote:
I suppose an interesting practical question is whether a specific request needs
to "know" whether it has been (is being) cancelled (or whether the SBDebugger
flag suffices). If it does, then I think it would be natural to store this
state in the request object, but then really ou
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128505
Replace the by-ref return value with an actual result.
>From 31ce87a2aef9237862f0aa2f4b258d6abdf38b55 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 24 Feb 2025 13:40:03 +0100
Subject: [PATCH] [lldb] Mod
llvmbot wrote:
@llvm/pr-subscribers-backend-hexagon
Author: Pavel Labath (labath)
Changes
Replace the by-ref return value with an actual result.
---
Patch is 68.65 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/128505.diff
42 Files Affected:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Replace the by-ref return value with an actual result.
---
Patch is 68.65 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/128505.diff
42 Files Affected:
- (modifi
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128512
The test was failing because it was looking up the immediate value from the
call instruction as a load address, whereas in fact it was a file address. This
worked on darwin because (with ASLR disabled) the two a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The test was failing because it was looking up the immediate value from the
call instruction as a load address, whereas in fact it was a file address. This
worked on darwin because (with ASLR disabled) the two
@@ -10,7 +10,7 @@
class TestDiagnoseDereferenceFunctionReturn(TestBase):
-@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
+@expectedFailureAll(oslist=["windows"])
@skipIf(
archs=no_match(["x86_64"])
) # frame diagnose d
@@ -10,7 +10,7 @@
class TestDiagnoseDereferenceFunctionReturn(TestBase):
-@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
+@expectedFailureAll(oslist=["windows"])
@skipIf(
archs=no_match(["x86_64"])
) # frame diagnose d
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/128512
>From ed3003bd1ea04f4758fe91e0badaf203a60d80ec Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 24 Feb 2025 14:32:02 +0100
Subject: [PATCH 1/2] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux
The
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128515
The existing implementation would probably produce false positives for
discontinuous functions. I haven't tried reproducing it because setting up
discontinuous functions (and executing them, in particular) is pr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The existing implementation would probably produce false positives for
discontinuous functions. I haven't tried reproducing it because setting up
discontinuous functions (and executing them, in particular) is
@@ -1670,13 +1670,14 @@ lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame,
ConstString reg,
break;
case Instruction::Operand::Type::Immediate: {
DavidSpickett wrote:
What exactly is an immediate here? It's not a literal value, if it were we
w
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
SymbolFileCTF never creates discontinuous functions, so this is technically
NFC, but it takes us one step closer to removing the deprecated API.
---
Full diff: https://github.com/llvm/llvm-project/pull/128517.
@@ -1670,13 +1670,14 @@ lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame,
ConstString reg,
break;
case Instruction::Operand::Type::Immediate: {
labath wrote:
> What exactly is an immediate here? It's not a literal value, if it were we
> woul
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/128517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/128181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1670,13 +1670,14 @@ lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame,
ConstString reg,
break;
case Instruction::Operand::Type::Immediate: {
DavidSpickett wrote:
It makes enough sense yes :)
https://github.com/llvm/llvm-project/pull/12851
https://github.com/DavidSpickett approved this pull request.
LGTM.
As usual with Windows, I am a bit curious whether this works there, but not
enough to check myself or demand that you do :)
https://github.com/llvm/llvm-project/pull/128512
___
lldb-c
DavidSpickett wrote:
Also we have no Windows x86 bot right now so you'd never know if it was right
outside your own machine.
https://github.com/llvm/llvm-project/pull/128512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
@@ -1502,6 +1509,12 @@ enum DeclCode {
/// An ImplicitConceptSpecializationDecl record.
DECL_IMPLICIT_CONCEPT_SPECIALIZATION,
+ // A decls specilization record.
+ DECL_SPECIALIZATIONS,
+
+ // A decls specilization record.
+ DECL_PARTIAL_SPECIALIZATIONS,
+
-
@@ -1502,6 +1509,12 @@ enum DeclCode {
/// An ImplicitConceptSpecializationDecl record.
DECL_IMPLICIT_CONCEPT_SPECIALIZATION,
+ // A decls specilization record.
erichkeane wrote:
Note `specialization` is misspelled in this comment and the one below.
htt
@@ -41,17 +41,32 @@ static uint64_t ToNanosec(const SteadyTimePoint Point) {
return std::chrono::nanoseconds(Point.time_since_epoch()).count();
}
-static std::string MakeUUID(Debugger *debugger) {
+// Generate a unique string. This should be unique across different runs.
+//
JDevlieghere wrote:
That's a good question. The non-constness of the operator was an oversight, I
meant for the classes to be stateless and mimic the current implementation.
Adding he `const` is trivial and I can do that before migrating more requests,
but that's pointless if we want to make t
@@ -43,29 +77,79 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
serializer.write("end_time", ToNanosec(end_time.value()));
}
-[[maybe_unused]] static std::string MakeUUID(Debugger *debugger) {
- uint8_t random_bytes[16];
- if (auto ec = llvm::g
Michael137 wrote:
I looked at the memory footprint of LLDB while debugging LLDB and there wasn't
noticeable difference in resident memory usage between top-of-tree and this
patch. I made sure to evaluate expressions that open up large source files. I
do agree it feels a bit weird to be paying
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
return UUID(random_bytes).GetAsString();
}
+void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const {
+ serializer.write("entry_kind", getKind());
+ serializer.write("se
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
return UUID(random_bytes).GetAsString();
}
+void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const {
+ serializer.write("entry_kind", getKind());
+ serializer.write("se
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/128534
Details:
- Previously, we used the LLVM_BUILD_TELEMETRY flag to control whether any
Telemetry code will be built. This has proven to cause more nuisance to both
users of the Telemetry and any further extension
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Details:
- Previously, we used the LLVM_BUILD_TELEMETRY flag to control whether any
Telemetry code will be built. This has proven to cause more nuisance to both
users of the Telemetry and any further extension o
oontvoo wrote:
@JDevlieghere @labath : W.R.T the telemetry-build flag, I proposed
[PR](https://github.com/llvm/llvm-project/pull/128534). Please have a look
(ideally before continuing reviewing this patch since it'd simplify a few
things here).
Thanks!
https://github.com/llvm/llvm-project/p
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From c54157f43966c2d9d62134110026f3fed02de379 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/7] [lldb-dap] Add 'source' references to stack frames
without s
ashgti wrote:
> Could we make the test self contained (i.e. without the qsort reference)? If
> all you need is a function without debug info, then
> `__attribute__((nodebug))` should suffice.
Thanks for the suggestion! That works a lot more consistently than depending on
the implementation de
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From c54157f43966c2d9d62134110026f3fed02de379 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/8] [lldb-dap] Add 'source' references to stack frames
without s
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/128278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/128515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 139 of 139 matches
Mail list logo
