labath wrote:
> There's one small area that our desire to parse the widest range of
> identifiers comes into conflict with, namely the "persistent variable"
> namespace. For the C family of languages, we reserve the initial `$` for this
> purpose, for swift (where `$1` etc. were already taken)
labath wrote:
> > * The expression `foo["bar"]` tries:
> >
> > * `foo.GetChildWithName("bar")`
> > * `foo.GetChildWithName("[bar]")`
> > * The expression `foo[]` -- `expr` is evaluated and treated as
> > cases above. If the result of `expr` is not a number or a string -- produce
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From 41650cf89122dbc35285488ae4d7bd03034a751e Mon Sep 17 00:00:00 2001
From: Hu Jialun
Date: Sat, 28 Dec 2024 22:39:33 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
jmorse wrote:
Indeed, that's a pattern we've seen elsewhere in the instruction APIs -- you
can select whether you want an instruction inserted into a block or not by
whether you pass an instruction pointer or nullptr in. However, without a
common "no-such-location" instruction iterator (or by
@@ -0,0 +1,132 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
labath wrote:
I think this is better. As much as I like initializing things in the
constructor, I don't think it makes sense when the whole CommandReturnObject is
built around using it as a by-ref return value.
https://github.com/llvm/llvm-project/pull/125132
__
labath wrote:
/cherry-pick 13d0318a9848ec322ceea4f37fb6b421d70407b0
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath milestoned
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 1/2] Implement LLDB Telemetry (Part 1)
This contains only the concre
@@ -0,0 +1,163 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/labath commented:
I think this looks pretty good. The signal-safety of the code is very dubious
(it was dubious even before that, but now it's even more), but I don't think
that there's anything we can do about it from here. I think the only way we can
have a real signal-saf
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/121860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -73,6 +73,7 @@
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/Regex.h"
labath wrote:
?
https://github.com/llvm/llvm-project/pull/121860
___
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
@@ -280,7 +280,8 @@ std::optional
CxxModuleHandler::tryInstantiateStdTemplate(Decl *d) {
new_class_template->getDeclContext(),
new_class_template->getTemplatedDecl()->getLocation(),
new_class_template->getLocation(), new_class_template, imported_args,
-
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Matheus Izvekov (mizvekov)
Changes
Class templates might be only instantiated when they are required to be
complete, but checking the template args against the primary template is
immediate.
This result is cached so that later wh
oontvoo wrote:
@labath Hi, I've updated the patch to sync up with the changes from
llvm::Telemetry. (Aslo addressed all the open-questions.) Please have another
look when you can. Thanks!
https://github.com/llvm/llvm-project/pull/119716
___
lldb-comm
cor3ntin wrote:
Initially reverted by https://github.com/llvm/llvm-project/pull/125710
@mizvekov did you do a stage2 build of lldb?
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -111,8 +111,10 @@ Error
RunInTerminalLauncherCommChannel::WaitUntilDebugAdaptorAttaches(
return message.takeError();
}
-Error RunInTerminalLauncherCommChannel::NotifyPid() {
- return m_io.SendJSON(RunInTerminalMessagePid(getpid()).ToJSON());
+Error RunInTerminalLaunch
@@ -58,12 +57,13 @@ const char DEV_NULL[] = "/dev/null";
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, std::ofstream *log, ReplMode repl_mode,
- StreamDescriptor input, StreamDescriptor output)
-: debug_adaptor_path(path), log(log), input(std::move(input)),
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I think this looks good, modulo the question about (detached) threads. I'd be
nice to have an lldb-dap expert take a look as well.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -11,6 +11,8 @@
// IWYU pragma: begin_exports
+#include "lldb/lldb-forward.h"
labath wrote:
Probably revert this too?
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@l
@@ -0,0 +1,3 @@
+C_SOURCES := main.c
+
+include Makefile.rules
labath wrote:
I think this stop sign indicates a missing newline.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commi
@@ -243,25 +243,15 @@ bool Block::GetRangeContainingAddress(const Address &addr,
AddressRange &range) {
Function *function = CalculateSymbolContextFunction();
if (function) {
-const AddressRange &func_range = function->GetAddressRan
Author: Jonas Devlieghere
Date: 2025-02-04T08:55:30-08:00
New Revision: 906eeeda833b30fb7fdc3b7586de34b65d575b45
URL:
https://github.com/llvm/llvm-project/commit/906eeeda833b30fb7fdc3b7586de34b65d575b45
DIFF:
https://github.com/llvm/llvm-project/commit/906eeeda833b30fb7fdc3b7586de34b65d575b45.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
/pull-request llvm/llvm-project#125653
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/125682.diff
1 Files Affected:
- (modified) lldb/docs/resources/lldbgdbremote.md (+5)
``diff
diff --git a/lldb/docs/resources/lldbgdbremote
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/125682
None
>From cfe826019bb54bdb62cccbd8e8d3eba8f4d6f312 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 4 Feb 2025 14:11:03 +0100
Subject: [PATCH] Document lldb `x` packet deprecation.
---
lldb/docs/resourc
hvdijk wrote:
I'm taking a look, but I'm having some doubts about the change itself,
`DIBuilder::insertDbgValueIntrinsic`'s `BasicBlock *BB =
InsertBefore->getParent();` (where `InsertBefore` is an iterator) doesn't seem
safe, it seems like it should be valid to pass an at-the-end iterator the
Author: Jonas Devlieghere
Date: 2025-02-04T09:01:08-08:00
New Revision: 97f6e533865c66ea08840be78154099180293094
URL:
https://github.com/llvm/llvm-project/commit/97f6e533865c66ea08840be78154099180293094
DIFF:
https://github.com/llvm/llvm-project/commit/97f6e533865c66ea08840be78154099180293094.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,163 @@
+//===-- Statusline.cpp ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -73,6 +73,7 @@
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/Regex.h"
JDevlieghere wrote:
Remnant of trying to regex-away ANSI escape characters before I did #123430.
https://github.
JDevlieghere wrote:
> Definitely needs some tests though (I thought you had some -- what happened
> to those?)
Yup, I'm planning on adding dedicated PExpect tests. The ones you remember are
probably the ones from dependencies that have landed in separate PRs.
https://github.com/llvm/llvm-pro
jimingham wrote:
This is a little weird - why would the value of a ValueObject when interpreted
as its Dynamic Value ever be in host memory? That seems odd, made doubly so
because it's unused in the current sources. So I really worry about this
getting broken.
Would it be possible to cons u
JDevlieghere wrote:
@puremourning Please confirm whether this is ready to be merged and I can press
the ✅ button.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
To make sure I understand, you want me to write a unittest where I have a value
object, and make sure it's dynamic value object child uses the local buffer to
store the contents? What should I test? That it prints correctly?
https://github.com/llvm/llvm-project/pull/125143
_
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/125682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 1/2] Implement LLDB Telemetry (Part 1)
This contains only the concre
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From 88a8522f1b29b2ff392974322acdb722b7e00b70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH 1/2] [lldb-dap] Refactoring lldb-dap port listening mode to
allow
@@ -58,12 +57,13 @@ const char DEV_NULL[] = "/dev/null";
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, std::ofstream *log, ReplMode repl_mode,
- StreamDescriptor input, StreamDescriptor output)
-: debug_adaptor_path(path), log(log), input(std::move(input)),
@@ -11,6 +11,8 @@
// IWYU pragma: begin_exports
+#include "lldb/lldb-forward.h"
ashgti wrote:
Reverted
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
hvdijk wrote:
Thanks, I knew it was possible (it had to be: it would be possible to create a
dummy instruction, insert it at the specified point, and inspect its parent)
but had not yet found the best way of doing it, I was trying to get it working
with `IP.getNodePtr()->getParent()`. I'll upd
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -0,0 +1,3 @@
+C_SOURCES := main.c
+
+include Makefile.rules
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -0,0 +1,101 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -108,6 +108,9 @@ endfunction(add_lldb_test_dependency)
add_lldb_test_dependency(lldb)
add_lldb_test_dependency(lldb-test)
+# Enable Telemetry for testing.
+target_compile_definitions(lldb PRIVATE -DTEST_TELEMETRY)
+
oontvoo wrote:
done (removed the macro)
puremourning wrote:
Yep. Good to go.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ben Jackson
Date: 2025-02-04T16:03:13-08:00
New Revision: e8d437f827144061d051ecf199d4075bef317285
URL:
https://github.com/llvm/llvm-project/commit/e8d437f827144061d051ecf199d4075bef317285
DIFF:
https://github.com/llvm/llvm-project/commit/e8d437f827144061d051ecf199d4075bef317285.diff
L
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
On `clang-aarch64-quick` the test
`CompletionTest.ObjectiveCProtocolFromIndexSpeculation` from the `clangd` test
suite failed - unrelated to this commit
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing lis
62 matches
Mail list logo
