[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-27 Thread John Harrison via lldb-commits
ashgti wrote: > Were you able to reproduce the windows failure (and confirm the problem was > indeed in the pipe code), or is this an attempt at speculation? I was able to reproduce the issue on an x86_64 cloud host and I also verified after applying 3ea2b546a8d17014d3ecf05356ecfaadf26ed846 th

[Lldb-commits] [lldb] 873426b - [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (#122783)

2025-01-27 Thread via lldb-commits
Author: John Harrison Date: 2025-01-27T08:58:50-08:00 New Revision: 873426bea3dd67d80dd10650e64e91c69796614f URL: https://github.com/llvm/llvm-project/commit/873426bea3dd67d80dd10650e64e91c69796614f DIFF: https://github.com/llvm/llvm-project/commit/873426bea3dd67d80dd10650e64e91c69796614f.diff

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-27 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/122783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread Brad Smith via lldb-commits
@@ -29,6 +29,10 @@ #include #include +#ifdef __ANDROID__ +#include brad0 wrote: > what's the build failure you're seeing? this _should_ be included "for free" > by all of the #includes above (via , which they should all drag > in). > > of course, if you

[Lldb-commits] [lldb] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-01-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Yeah this should work for core files. > > ``` > (lldb) target create > "lldb/test/API/functionalities/postmortem/elf-core/linux-riscv64.gpr_only.out" > --core > "ldb/test/API/functionalities/postmortem/elf-core/linux-riscv64.gpr_only.core" > > Core file > 'lldb/test/AP

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl { void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED, TemplateSpecializationKind TSK); +public: kuilpd wrote: I left this in so that that I could simply do

[Lldb-commits] [lldb] [LLDB-DAP] Sbdebugger progress no title prefix (PR #124648)

2025-01-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/124648 In my last DAP patch (#123837), we piped the DAP update message into the update event. However, we had the title embedded into the update message. This makes sense for progress Start, but makes the update messa

[Lldb-commits] [lldb] [LLDB-DAP] Sbdebugger progress no title prefix (PR #124648)

2025-01-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In my last DAP patch (#123837), we piped the DAP update message into the update event. However, we had the title embedded into the update message. This makes sense for progress Start, but makes the update me

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/124648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-27 Thread via lldb-commits
jimingham wrote: > > I'd rather keep the flexibility, if you don't mind doing the work to add > > that. For now, it seems okay for the current libc++/libstdc++ ones to > > declare what they support (which is 1 pointer depth). If someone has a > > reason to come back and extend these ones in th

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Walter Erquinigo via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/124648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Jonas Devlieghere via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

<    1   2