@@ -128,30 +130,41 @@ bool StackFrameList::DecrementCurrentInlinedDepth() {
}
void StackFrameList::SetCurrentInlinedDepth(uint32_t new_depth) {
+ std::lock_guard guard(m_inlined_depth_mutex);
m_current_inlined_depth = new_depth;
if (new_depth == UINT32_MAX)
m_curre
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/117252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
This switching of lock types is making me very nervous. Every switch is an
opportunity to get preempted, which means you have to recheck any invariants
before you do that -- you can't just assume that conditions you tested earlier
in the function still hold
@@ -771,24 +809,38 @@ void StackFrameList::SelectMostRelevantFrame() {
LLDB_LOG(log, "No relevant frame!");
}
-uint32_t StackFrameList::GetSelectedFrameIndex(
-SelectMostRelevant select_most_relevant) {
- std::lock_guard guard(m_mutex);
+uint32_t
+StackFrameList::GetS
luporl wrote:
It looks like this broke lldb-aarch64-windows:
https://lab.llvm.org/buildbot/#/builders/141/builds/4061
```
FAIL: lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c (1581 of 2048)
TEST 'lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c'
FAILED
sylvestre wrote:
@Jlalond it breaks the build on i386 on:
https://github.com/llvm/llvm-project/issues/117327
https://github.com/llvm/llvm-project/pull/110065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
Reverts llvm/llvm-project#117336
---
Full diff: https://github.com/llvm/llvm-project/pull/117354.diff
1 Files Affected:
- (modified) lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c (+5-5)
``diff
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/117354
Reverts llvm/llvm-project#117336
>From 4348c4d658a56f45e939190aa1b2b6c698893999 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Fri, 22 Nov 2024 22:45:42 +0500
Subject: [PATCH] Revert "[lldb] Fix DW_OP_piece-O3
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/117354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ilia Kuklin
Date: 2024-11-22T23:16:08+05:00
New Revision: 4be09f06242be9349f05016fb50d3dbb378600bf
URL:
https://github.com/llvm/llvm-project/commit/4be09f06242be9349f05016fb50d3dbb378600bf
DIFF:
https://github.com/llvm/llvm-project/commit/4be09f06242be9349f05016fb50d3dbb378600bf.diff
L
Jlalond wrote:
@lukejriddle Can we add a test for this? We just want to have a test case that
iterates the regions.
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -7,7 +7,12 @@
def __iter__(self):
'''Iterate over all the memory regions in a lldb.SBMemoryRegionInfoList
object.'''
- return lldb_iter(self, 'GetSize', 'GetMemoryRegionAtIndex')
+ import lldb
+ size = self.GetSize()
+ region = lldb.SBMemoryRe
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
> Where those names go from "const string" to "const std::__1::string" (and
> from "string" to "std::__1::string")? or something like that.
Yes. In some cases, it's getting super verbose, e.g:
`std::__1::basic_string,
std::__1::allocator >::value_type`.
> Probably the most co
https://github.com/lukejriddle updated
https://github.com/llvm/llvm-project/pull/117358
>From c4a4b658daac89204d9e03ad5ef7a3cd7b474325 Mon Sep 17 00:00:00 2001
From: Luke Riddle
Date: Fri, 22 Nov 2024 10:23:43 -0800
Subject: [PATCH 1/2] Make SBMemeoryRegionInfoList iterable with Python SWIG
--
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Luke Riddle (lukejriddle)
Changes
This PR fixes a simple SWIG issue with SBMemoryRegionInfoList not being
iterable out-of-the-box. This is mostly because of limitations to the
`lldb_iter` function, which doesn't allow for specifying argume
https://github.com/lukejriddle ready_for_review
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -286,6 +286,22 @@ void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
}
}
+bool ProcessElfCore::GetModuleSpec(const FileSpec &module_file_spec,
+ const ArchSpec &arch,
+ ModuleSpec &module_spec) {
+ m
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/splhack updated
https://github.com/llvm/llvm-project/pull/117070
>From 8d9f061d7b5dfe5966f117f5b2740c8acbd87797 Mon Sep 17 00:00:00 2001
From: Kazuki Sakamoto
Date: Wed, 20 Nov 2024 13:49:26 -0800
Subject: [PATCH] [lldb] Fix ELF core debugging
DynamicLoader does not use Proc
@@ -286,6 +286,22 @@ void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
}
}
+bool ProcessElfCore::GetModuleSpec(const FileSpec &module_file_spec,
+ const ArchSpec &arch,
+ ModuleSpec &module_spec) {
+ m
https://github.com/splhack closed
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazuki Sakamoto
Date: 2024-11-22T13:55:55-08:00
New Revision: 1290e95849aaad2fbd813aa15da667b2103ecc64
URL:
https://github.com/llvm/llvm-project/commit/1290e95849aaad2fbd813aa15da667b2103ecc64
DIFF:
https://github.com/llvm/llvm-project/commit/1290e95849aaad2fbd813aa15da667b2103ecc64.dif
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/117266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5,9 +5,10 @@
// DW_AT_type (0x0032 "char[5]")
// DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0,
DW_OP_piece 0x1)
+// XFAIL: target=aarch64-pc-windows-{{.*}}
kuilpd wrote:
Ah, thank you, good to know!
https://
Author: Dave Lee
Date: 2024-11-22T10:30:44-08:00
New Revision: f170f5fa80f244ccac51e9867de3ad823512a2d4
URL:
https://github.com/llvm/llvm-project/commit/f170f5fa80f244ccac51e9867de3ad823512a2d4
DIFF:
https://github.com/llvm/llvm-project/commit/f170f5fa80f244ccac51e9867de3ad823512a2d4.diff
LOG:
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
Author: Ilia Kuklin (kuilpd)
Changes
Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch
changes the test so that a breakpoint can be made on a function name.
#117168
---
Full diff: https://github.com/llvm/l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch
changes the test so that a breakpoint can be made on a function name.
#117168
---
Full diff: https://github.com/llvm/llvm-project/
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/117336
Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch
changes the test so that a breakpoint can be made on a function name.
#117168
>From 8ab6044c2b1e54d0788eca39eb96cd64e30f372a Mon Se
https://github.com/lukejriddle created
https://github.com/llvm/llvm-project/pull/117358
This PR fixes a simple SWIG issue with SBMemoryRegionInfoList not being
iterable out-of-the-box. This is mostly because of limitations to the
`lldb_iter` function, which doesn't allow for specifying argumen
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
dwblaikie wrote:
> Just noticed that this breaks
> `llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-string.test` because
> for `DW_TAG_typedef`, llvm-dwarfdump will print the fully qualified name
> instead of the base name in DW_AT_type that refers to
> it([here](https://github.com/llvm/
lukejriddle wrote:
> @lukejriddle Can we add a test for this? We just want to have a test case
> that iterates the regions.
Done
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -250,6 +251,13 @@ def which(program):
return None
+def pickrandomport():
+"""Returns a random open port."""
+with socket.socket() as sock:
+sock.bind(("", 0))
+return sock.getsockname()[1]
ashgti wrote:
I have updated this to n
@@ -22,8 +22,17 @@ def port: S<"port">,
HelpText<"Communicate with the lldb-dap tool over the defined port.">;
def: Separate<["-"], "p">,
Alias,
+ MetaVarName<"">,
HelpText<"Alias for --port">;
+def unix_socket: S<"unix-socket">,
+ MetaVarName<"">,
+ HelpText<"Commu
@@ -22,8 +22,17 @@ def port: S<"port">,
HelpText<"Communicate with the lldb-dap tool over the defined port.">;
def: Separate<["-"], "p">,
Alias,
+ MetaVarName<"">,
HelpText<"Alias for --port">;
+def unix_socket: S<"unix-socket">,
+ MetaVarName<"">,
+ HelpText<"Commu
@@ -5028,36 +5218,52 @@ int main(int argc, char *argv[]) {
#endif
// Initialize LLDB first before we do anything.
- lldb::SBDebugger::Initialize();
+ lldb::SBError error = lldb::SBDebugger::InitializeWithErrorHandling();
+ if (error.Fail()) {
+llvm::errs() << "Failed
splhack wrote:
@clayborg most likely calling GetModuleSpec is the cause of these failures.
ProcessGDBRemote fetches modules from remote.
FindBuildId does not have the issue. What do you think?
> looks like these changes break `lldb-api::TestLoadUnload.py` test on the LLDB
> remote-linux builder
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/117401
Update the error returns in ValueObject::CastToBasicType and
ValueObject::CastToEnumType to create new errors and return a
ValueObjectConstResult with the error, rather tnan updating the error in (and
returni
@@ -2809,6 +2956,374 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP &type_sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ if (auto target_sp = GetTargetSP()) {
+const b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Update the error returns in ValueObject::CastToBasicType and
ValueObject::CastToEnumType to create new errors and return a
ValueObjectConstResult with the error, rather tnan updating the error in (and
returning) th
@@ -22,8 +22,17 @@ def port: S<"port">,
HelpText<"Communicate with the lldb-dap tool over the defined port.">;
def: Separate<["-"], "p">,
Alias,
+ MetaVarName<"">,
HelpText<"Alias for --port">;
+def unix_socket: S<"unix-socket">,
+ MetaVarName<"">,
+ HelpText<"Commu
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From acfdb2da30b7a49711c3d1ec3be3c9282d6c51b4 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 15 Nov 2024 09:56:43 -0500
Subject: [PATCH 1/3] [lldb-da] Refactoring lldb-dap port listening mode to
allow
@@ -116,6 +118,8 @@ enum LaunchMethod { Launch, Attach,
AttachForSuspendedLaunch };
/// Page size used for reporting addtional frames in the 'stackTrace' request.
constexpr int StackPageSize = 20;
+void RegisterRequestCallbacks(DAP &dap);
ashgti wrote:
Remov
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -1154,34 +1154,38 @@ class DebugAdaptorServer(DebugCommunication):
def __init__(
self,
executable=None,
+launch=True,
port=None,
+unix_socket=None,
init_commands=[],
log_file=None,
env=None,
):
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -1196,6 +1200,39 @@ def terminate(self):
self.process.wait()
self.process = None
+@classmethod
+def launch(
+cls, executable: str, /, port=None, unix_socket=None, log_file=None,
env=None
+) -> subprocess.Popen:
+adaptor_e
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -140,13 +137,16 @@ struct DAP {
llvm::StringRef debug_adaptor_path;
InputStream input;
OutputStream output;
+ lldb::SBFile in;
+ lldb::SBFile out;
+ lldb::SBFile err;
lldb::SBDebugger debugger;
lldb::SBTarget target;
Variables variables;
lldb::SBBroadcas
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t
variablesReference) {
}
}
-SOCKET AcceptConnection(DAP &dap, int portno) {
- // Accept a socket connection from any host on "portno".
- SOCKET newsockfd = -1;
- struct sockaddr_in serv_addr, cli
@@ -0,0 +1,6 @@
+#include
+
+int main(int argc, char const *argv[]) {
+ printf("hello world!\n"); // breakpoint 1
+ return 0;
+}
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits
@@ -22,8 +22,17 @@ def port: S<"port">,
HelpText<"Communicate with the lldb-dap tool over the defined port.">;
def: Separate<["-"], "p">,
Alias,
+ MetaVarName<"">,
HelpText<"Alias for --port">;
+def unix_socket: S<"unix-socket">,
+ MetaVarName<"">,
+ HelpText<"Commu
https://github.com/splhack created
https://github.com/llvm/llvm-project/pull/117416
ELF core debugging fix #117070 broke TestLoadUnload.py tests due to
GetModuleSpec call, ProcessGDBRemote fetches modules from remote. Revise the
original PR, renamed FindBuildId to FindModuleUUID.
>From 8fdc87
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazuki Sakamoto (splhack)
Changes
ELF core debugging fix #117070 broke TestLoadUnload.py tests due to
GetModuleSpec call, ProcessGDBRemote fetches modules from remote. Revise the
original PR, renamed FindBuildId to FindModuleUUID.
---
Ful
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4ab5e90c9c52fcf9b4ed297c887b31219e41f7d8
b6051edba2a1ecae144ead48712fb511c204131a --e
vvereschaka wrote:
Hi @splhack ,
looks like these changes break `lldb-api::TestLoadUnload.py` test on the LLDB
remote-linux builders:
* https://lab.llvm.org/buildbot/#/builders/195/builds/1435
* https://lab.llvm.org/staging/#/builders/197/builds/663
https://github.com/llvm/llvm-project/pull/11
splhack wrote:
@vvereschaka let me check
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From acfdb2da30b7a49711c3d1ec3be3c9282d6c51b4 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 15 Nov 2024 09:56:43 -0500
Subject: [PATCH 1/2] [lldb-da] Refactoring lldb-dap port listening mode to
allow
Author: Ilia Kuklin
Date: 2024-11-22T20:30:55+05:00
New Revision: 720a4c70edd0a9815f0e830d8ad4e1c322e404ae
URL:
https://github.com/llvm/llvm-project/commit/720a4c70edd0a9815f0e830d8ad4e1c322e404ae
DIFF:
https://github.com/llvm/llvm-project/commit/720a4c70edd0a9815f0e830d8ad4e1c322e404ae.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/117336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
metaflow wrote:
FYI I have temporary reverted f06c187799d910fd3ac3e9106397e5eecff9f265 to keep
things rolling
https://github.com/llvm/llvm-project/pull/117239
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
Author: Mikhail Goncharov
Date: 2024-11-22T13:49:37+01:00
New Revision: 11ee21671f7d4b0763eebfcb221c9598605e
URL:
https://github.com/llvm/llvm-project/commit/11ee21671f7d4b0763eebfcb221c9598605e
DIFF:
https://github.com/llvm/llvm-project/commit/11ee21671f7d4b0763eebfcb221c9598605e.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/117266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
@llvm/pr-subscribers-backend-aarch64
Author: Ilia Kuklin (kuilpd)
Changes
#117168
---
Full diff: https://github.com/llvm/llvm-project/pull/117355.diff
1 Files Affected:
- (modified) lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c (
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/117355
#117168
>From de297b66e1c87ed4856366f26c200bbbd172155c Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Fri, 22 Nov 2024 22:52:48 +0500
Subject: [PATCH] XFAIL DW_OP_piece-O3 test on AArch64 Windows
---
lldb/te
@@ -5,9 +5,10 @@
// DW_AT_type (0x0032 "char[5]")
// DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0,
DW_OP_piece 0x1)
+// XFAIL: target=aarch64-pc-windows-{{.*}}
luporl wrote:
It's better to just skip the test on w
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/117355
>From de297b66e1c87ed4856366f26c200bbbd172155c Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Fri, 22 Nov 2024 22:52:48 +0500
Subject: [PATCH 1/2] XFAIL DW_OP_piece-O3 test on AArch64 Windows
---
lldb/test/Sh
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/6
Here is the relevant piece of the build log
Author: Ilia Kuklin
Date: 2024-11-22T22:51:11+05:00
New Revision: dc637e940cb115fe72408ba96ad2e5e2396a3e94
URL:
https://github.com/llvm/llvm-project/commit/dc637e940cb115fe72408ba96ad2e5e2396a3e94
DIFF:
https://github.com/llvm/llvm-project/commit/dc637e940cb115fe72408ba96ad2e5e2396a3e94.diff
L
https://github.com/luporl edited
https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd edited
https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/luporl approved this pull request.
This fixes the failure for WoA, thanks.
https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
77 matches
Mail list logo
