[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-21 Thread Timm Baeder via lldb-commits
@@ -14690,6 +14690,14 @@ void Sema::FinalizeDeclaration(Decl *ThisDecl) { } } + // The result of __builtin_counted_by_ref cannot be assigned to a variable. + // It allows leaking and modification of bounds safety information. + if (const auto *CE = dyn_cast_if_present

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
ChuvakHome wrote: > BOLT changes look good, thank you for fixing those. If you split them out, I > can help land it sooner. https://github.com/llvm/llvm-project/pull/117156 https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-21 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/117168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #117079)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This was originally reviewed in #106791. LGTM. https://github.com/llvm/llvm-project/pull/117079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb] Fix inline function resolution for discontinuous functions (PR #116777)

2024-11-21 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/116777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d71fa33 - [lldb] Fix inline function resolution for discontinuous functions (#116777)

2024-11-21 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-22T08:32:47+01:00 New Revision: d71fa331df49450361a9e5cd4e48ae4a79b6126b URL: https://github.com/llvm/llvm-project/commit/d71fa331df49450361a9e5cd4e48ae4a79b6126b DIFF: https://github.com/llvm/llvm-project/commit/d71fa331df49450361a9e5cd4e48ae4a79b6126b.diff

[Lldb-commits] [lldb] [lldb] Fix inline function resolution for discontinuous functions (PR #116777)

2024-11-21 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, in my previous patches, the code was all in one section as it wasn't relevant for the test, but the way this really works is that every part of the function gets its own subsection (on MachO, I guess you'd use subsections for that). That way the linker doesn't need to do an

[Lldb-commits] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread David Spickett via lldb-commits
@@ -224,7 +224,7 @@ Status ProcessElfCore::DoLoadCore() { ArchSpec core_arch(m_core_module_sp->GetArchitecture()); target_arch.MergeFrom(core_arch); GetTarget().SetArchitecture(target_arch); - + DavidSpickett wrote: I would push these whitespace changes

[Lldb-commits] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I'm a bit confused as to how we have a core file but also things are moved in memory. Can you give an explanation of how this occurs? Please add it to the PR description. Also, tests? (which is partly why I ask how this occurs) https://github.com/l

[Lldb-commits] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/117028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-21 Thread via lldb-commits
https://github.com/Sirraide commented: I think this might honestly be fine the way it is now, but I’d like for e.g. @AaronBallman to take a look at this too before approving it since he’s more familiar w/ C than me. https://github.com/llvm/llvm-project/pull/116719 _

[Lldb-commits] [lldb] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/117028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/116989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread Kazuki Sakamoto via lldb-commits
@@ -224,7 +224,7 @@ Status ProcessElfCore::DoLoadCore() { ArchSpec core_arch(m_core_module_sp->GetArchitecture()); target_arch.MergeFrom(core_arch); GetTarget().SetArchitecture(target_arch); - + splhack wrote: This pull request will be rebased onto #117

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Pavel Labath via lldb-commits
@@ -2726,39 +2726,8 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { TypeQuery query_full(query); bool have_index_match = false; m_index->GetTypesWithQuery(query_full, [&](DWARFDIE die) { -// Check the language, but only if we have a

[Lldb-commits] [lldb] [lldb] Make sure completions don't end with newlines (PR #117054)

2024-11-21 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Okay, so you're saying that we could hit this if we're completing an expression (variable name) and a particularly evil compiler puts a newline into the name. Makes sense, sort of. https://github.com/llvm/llvm-project/pull/117054 __

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 edited https://github.com/llvm/llvm-project/pull/116989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
@@ -2790,7 +2759,7 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { // With -gsimple-template-names, a templated type's DW_AT_name will not // contain the template parameters. Try again stripping '<' and anything // after, filtering out

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
@@ -2726,39 +2726,8 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { TypeQuery query_full(query); bool have_index_match = false; m_index->GetTypesWithQuery(query_full, [&](DWARFDIE die) { -// Check the language, but only if we have a

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
https://github.com/ChuvakHome created https://github.com/llvm/llvm-project/pull/117151 Fix for some mistakes in source code found using PVS Studio. Inspired by: https://pvs-studio.com/en/blog/posts/cpp/1188/ >From 4bd798da2681d1648c19d10da1160b01e5445804 Mon Sep 17 00:00:00 2001 From: Feng Zou

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-libc Author: Chuvak (ChuvakHome) Changes Fix for some mistakes in source code found using PVS Studio. Inspired by: https://pvs-studio.com/en/blog/posts/cpp/1188/ --- Full diff: https://github.com/llvm/llvm-project/pull/117151.diff 11 Files Affected:

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Make sure completions don't end with newlines (PR #117054)

2024-11-21 Thread Pavel Labath via lldb-commits
labath wrote: I get the "description" part, but I'm somewhat confused about the "completion". How does a newline (trailing or not) get there? Like, you can't actually type something which includes a newline, right? I'm wondering if we should disallow these at a higher level... https://github.

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread David Spickett via lldb-commits
@@ -224,7 +224,7 @@ Status ProcessElfCore::DoLoadCore() { ArchSpec core_arch(m_core_module_sp->GetArchitecture()); target_arch.MergeFrom(core_arch); GetTarget().SetArchitecture(target_arch); - + DavidSpickett wrote: Keep formatting changes separate, pus

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 46f43b6d92e49b80df13e8a537a95767ffbaac9f ee6ab90efad3153cd5f49f1fd3589143291ae68b --e

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-21 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/117168 This commit fixes the test in so that the breakpoint is triggered correctly after `array` usage on Aarch64. Reapplies #116411 with a fix. >From b59a2114542999fa233e802cbc36500678132cb2 Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes This commit fixes the test in so that the breakpoint is triggered correctly after `array` usage on Aarch64. Reapplies #116411 with a fix. --- Full diff: https://github.com/llvm/llvm-project/pull/117168.diff

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2024-11-21 Thread via lldb-commits
https://github.com/anjenner updated https://github.com/llvm/llvm-project/pull/115331 >From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001 From: Andrew Jenner Date: Thu, 7 Nov 2024 10:47:42 -0500 Subject: [PATCH 1/2] Modify the localCache API to require an explicit commit on

[Lldb-commits] [lldb] 4b5a8d6 - [lldb] Make sure completions don't end with newlines (#117054)

2024-11-21 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-21T08:00:32-08:00 New Revision: 4b5a8d6835897477873242ef1ee529d00dedd9a1 URL: https://github.com/llvm/llvm-project/commit/4b5a8d6835897477873242ef1ee529d00dedd9a1 DIFF: https://github.com/llvm/llvm-project/commit/4b5a8d6835897477873242ef1ee529d00dedd9a1.d

[Lldb-commits] [lldb] [lldb] Make sure completions don't end with newlines (PR #117054)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/117054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread James Henderson via lldb-commits
https://github.com/jh7370 commented: I think these need to be split into individual PRs, as each will want reviewing on its own merits, and potentially they might indicate missing test coverage, warranting a test. https://github.com/llvm/llvm-project/pull/117151 ___

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
https://github.com/ChuvakHome edited https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov commented: BOLT changes look good, thank you for fixing those. If you split them out, I can help land it sooner. https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
https://github.com/ChuvakHome updated https://github.com/llvm/llvm-project/pull/117151 >From 882bcbafafe9b52014beaf44ffea206d2e03cc97 Mon Sep 17 00:00:00 2001 From: timurdemenev <311...@niuitmo.ru> Date: Thu, 21 Nov 2024 15:33:04 +0300 Subject: [PATCH] Fix bug with parenthesis, wrong names, inva

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
@@ -2790,7 +2759,7 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { // With -gsimple-template-names, a templated type's DW_AT_name will not // contain the template parameters. Try again stripping '<' and anything // after, filtering out

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread Simon Pilgrim via lldb-commits
https://github.com/RKSimon requested changes to this pull request. Thanks for the cleanups! Please can you close this and submit separate PRs for independent review https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-linalg @llvm/pr-subscribers-backend-x86 Author: Chuvak (ChuvakHome) Changes Fix for some mistakes in source code found using PVS Studio. Inspired by: https://pvs-studio.com/en/blog/posts/cpp/1188/ --- Full diff: https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

2024-11-21 Thread Augusto Noronha via lldb-commits
@@ -2726,39 +2726,8 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { TypeQuery query_full(query); bool have_index_match = false; m_index->GetTypesWithQuery(query_full, [&](DWARFDIE die) { -// Check the language, but only if we have a

[Lldb-commits] [lldb] 915d588 - Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (#117168)

2024-11-21 Thread via lldb-commits
Author: Ilia Kuklin Date: 2024-11-21T21:33:01+05:00 New Revision: 915d588b1a4762685b788020beadcd7aad5f50a0 URL: https://github.com/llvm/llvm-project/commit/915d588b1a4762685b788020beadcd7aad5f50a0 DIFF: https://github.com/llvm/llvm-project/commit/915d588b1a4762685b788020beadcd7aad5f50a0.diff L

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-21 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/117168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes Prior to this patch, the function returned an exit status, sometimes a ValueObject with an error and a Status object. This patch removes the Status object and ensures the error is consistently returned

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-21 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/117168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread via lldb-commits
@@ -3278,7 +3278,7 @@ bool AppleObjCRuntimeV2::NonPointerISACache::EvaluateNonPointerISA( } // If the index is still out of range then this isn't a pointer. - if (index > m_indexed_isa_cache.size()) + if (index >= m_indexed_isa_cache.size())

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
@@ -339,12 +339,9 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) { const char *expr_prefix = nullptr; lldb::ValueObjectSP result_valobj_sp; + lldb::ExpressionResults execution_results = UserExpression::Evaluate( + exe_

[Lldb-commits] [lldb] 0a72429 - [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (#110065)

2024-11-21 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-11-21T14:47:08-08:00 New Revision: 0a7242959f5d3f9ccf7b149009b9eebd45b785b0 URL: https://github.com/llvm/llvm-project/commit/0a7242959f5d3f9ccf7b149009b9eebd45b785b0 DIFF: https://github.com/llvm/llvm-project/commit/0a7242959f5d3f9ccf7b149009b9eebd45b785b0.diff

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-11-21 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/110065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Just noticed that this breaks `llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-string.test` because for `DW_TAG_typedef`, llvm-dwarfdump will print the fully qualified name instead of the base name in DW_AT_type that refers to it. Do you think we should keep the original

[Lldb-commits] [lldb] Convert the StackFrameList mutex to a shared mutex. (PR #117252)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/117252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack updated https://github.com/llvm/llvm-project/pull/117070 >From b93478345fbaa747b44d678207b768948db0a7d6 Mon Sep 17 00:00:00 2001 From: Kazuki Sakamoto Date: Wed, 20 Nov 2024 13:49:26 -0800 Subject: [PATCH] [lldb] Fix ELF core debugging DynamicLoader does not use Proc

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
@@ -144,9 +144,13 @@ lldb::ExpressionResults UserExpression::Evaluate(ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options, llvm::StringRef expr, llvm::StringRef prefix, - lldb::ValueObject

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/117186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a3e2f0a - [lldb] Fix a regression in Status::GetErrorType() (#117095)

2024-11-21 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-11-21T11:11:25-08:00 New Revision: a3e2f0acdf5ee452c8eb177b56f476b432539e08 URL: https://github.com/llvm/llvm-project/commit/a3e2f0acdf5ee452c8eb177b56f476b432539e08 DIFF: https://github.com/llvm/llvm-project/commit/a3e2f0acdf5ee452c8eb177b56f476b432539e08.diff

[Lldb-commits] [lldb] [lldb] Fix a regression in Status::GetErrorType() (PR #117095)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/117095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-21 Thread Bill Wendling via lldb-commits
bwendling wrote: > I think this might honestly be fine the way it is now Yeah. It's going kind of the opposite way from what you suggested with the placeholder, just instead of allowing for different uses at various places in Sema we disallow without using the placeholder. https://github.com/

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-21 Thread Bill Wendling via lldb-commits
@@ -14690,6 +14690,14 @@ void Sema::FinalizeDeclaration(Decl *ThisDecl) { } } + // The result of __builtin_counted_by_ref cannot be assigned to a variable. + // It allows leaking and modification of bounds safety information. + if (const auto *CE = dyn_cast_if_present

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-21 Thread Bill Wendling via lldb-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/116719 >From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 15 Nov 2024 15:41:48 -0800 Subject: [PATCH 1/8] [Clang] Improve Sema diagnostic performance for __builtin

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117242 >From dc8c3877594a513329a2b920b31f314684e6337c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 13:14:29 -0800 Subject: [PATCH] [lldb] Fix a regression in SBValue::GetObjectDescription()

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117242 >From e4a6563c21c251954b077a27b8375028134aa2f8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 13:14:29 -0800 Subject: [PATCH] [lldb] Fix a regression in SBValue::GetObjectDescription()

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread via lldb-commits
https://github.com/jimingham commented: It would be marginally nicer if there were some way to have "a shared pointer that can't be empty" to express the fact that we are always going to put something in the result_valobj_sp, so you didn't have to check it for null. That's the intent of Evalu

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Also push the Approve button... https://github.com/llvm/llvm-project/pull/117186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-11-21 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From c6d62d1b8612ddf052d5073a2845b1a44ae57a83 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Thu, 21 Nov 2024 22:42:39 +1300 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [lldb] Fix a regression in Status::GetErrorType() (PR #117095)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🚀 https://github.com/llvm/llvm-project/pull/117095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Alex Langford via lldb-commits
@@ -339,12 +339,9 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) { const char *expr_prefix = nullptr; lldb::ValueObjectSP result_valobj_sp; + lldb::ExpressionResults execution_results = UserExpression::Evaluate( + exe_

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread Dave Lee via lldb-commits
kastiglione wrote: for the lldb change: I'm not sure how you'd construct a test, but I think that's not a problem – the change looks obviously correct to me. https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes The old behavior was to return a null string in the error case,when refactoring the error handling I thought it would be a good idea to print the error in the description, but that breaks clients that

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread via lldb-commits
ChuvakHome wrote: I've made individual PRs: - https://github.com/llvm/llvm-project/pull/117156 - https://github.com/llvm/llvm-project/pull/117223 - https://github.com/llvm/llvm-project/pull/117226 - https://github.com/llvm/llvm-project/pull/117227 - https://github.com/llvm/llvm-project/pull/11722

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 29afbd5893fbf68a2b64321bee0c82233b8b852e...b01b2a158a3449904e210186b0cbfae3f51f6c7e lldb/

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/117242 The old behavior was to return a null string in the error case,when refactoring the error handling I thought it would be a good idea to print the error in the description, but that breaks clients that try

[Lldb-commits] [lldb] a62e1c8 - [lldb] Fix incorrect nullptr check in DumpAddressAndContent (#117219)

2024-11-21 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-21T13:23:55-08:00 New Revision: a62e1c8eddcda420abec57976dc48f97669277dc URL: https://github.com/llvm/llvm-project/commit/a62e1c8eddcda420abec57976dc48f97669277dc DIFF: https://github.com/llvm/llvm-project/commit/a62e1c8eddcda420abec57976dc48f97669277dc.d

[Lldb-commits] [lldb] [lldb] Fix incorrect nullptr check in DumpAddressAndContent (PR #117219)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/117219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9894cd5 - [lldb] Fix a warning

2024-11-21 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2024-11-21T16:00:42-08:00 New Revision: 9894cd5febbb89ad5b97c006179aaee77b824f91 URL: https://github.com/llvm/llvm-project/commit/9894cd5febbb89ad5b97c006179aaee77b824f91 DIFF: https://github.com/llvm/llvm-project/commit/9894cd5febbb89ad5b97c006179aaee77b824f91.diff L

[Lldb-commits] [lldb] [lldb] Add stop_reason_data property to SBThread python extensions (PR #117266)

2024-11-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/117266 None >From 07925dfe397a3cf0aa93f37bfc275cf0125c645d Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Sun, 10 Nov 2024 09:35:06 -0800 Subject: [PATCH] [lldb] Add stop_reason_data property to SBThread python ex

[Lldb-commits] [lldb] [lldb] Add stop_reason_data property to SBThread python extensions (PR #117266)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/117266.diff 2 Files Affected: - (modified) lldb/bindings/interface/SBThreadExtensions.i (+7) - (modified) lldb/test/API/lang/c/stepping/TestStepAnd

[Lldb-commits] [lldb] [lldb] Add stop_reason_data property to SBThread python extensions (PR #117266)

2024-11-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/117266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread David Blaikie via lldb-commits
dwblaikie wrote: Rather than a unit test, perhaps this could be tested with llvm-dwarfdump? (I think that's how I tested the DWARFTypePrinter during its initial development) It's a feature improvement to llvm-dwarfdump - being able to print out names better. I guess most of what I did was mor

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/117070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Convert the StackFrameList mutex to a shared mutex. (PR #117252)

2024-11-21 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/117252 >From b0d2179cf01cdd0b07bc43cef2a8c14d282e7ee7 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 19 Nov 2024 17:38:02 -0800 Subject: [PATCH 1/3] Convert the recursive StackFrameList mutex to a non-recursiv

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/117186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread Greg Clayton via lldb-commits
clayborg wrote: > I'm a bit confused as to how we have a core file but also things are moved in > memory. > > Can you give an explanation of how this occurs? Please add it to the PR > description. Will do. > Also, tests? (which is partly why I ask how this occurs) Tests are hard to create a

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/117186 Prior to this patch, the function returned an exit status, sometimes a ValueObject with an error and a Status object. This patch removes the Status object and ensures the error is consistently returned as

[Lldb-commits] [lldb] [lldb] Make sure completions don't end with newlines (PR #117054)

2024-11-21 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I get the "description" part, but I'm somewhat confused about the > "completion". How does a newline (trailing or not) get there? Like, you can't > actually type something which includes a newline, right? I'm wondering if we > should disallow these at a higher level... I

[Lldb-commits] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chuvak (ChuvakHome) Changes Fix for some mistakes in source code found using PVS Studio. Inspired by: https://pvs-studio.com/en/blog/posts/cpp/1188/ Fixed: - [Bug 8](https://pvs-studio.com/en/blog/posts/cpp/1188/#ID0EFA5EA398) - [Bug 10](h

[Lldb-commits] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread via lldb-commits
https://github.com/ChuvakHome created https://github.com/llvm/llvm-project/pull/117226 Fix for some mistakes in source code found using PVS Studio. Inspired by: https://pvs-studio.com/en/blog/posts/cpp/1188/ Fixed: - [Bug 8](https://pvs-studio.com/en/blog/posts/cpp/1188/#ID0EFA5EA398) - [Bug 1

[Lldb-commits] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] bcf654c - [lldb] Fix loading UUIDs from ELF headers. (#117028)

2024-11-21 Thread via lldb-commits
Author: Greg Clayton Date: 2024-11-21T14:15:26-08:00 New Revision: bcf654c7f5fb84dd7cff5fe112d96658853cd8f5 URL: https://github.com/llvm/llvm-project/commit/bcf654c7f5fb84dd7cff5fe112d96658853cd8f5 DIFF: https://github.com/llvm/llvm-project/commit/bcf654c7f5fb84dd7cff5fe112d96658853cd8f5.diff

[Lldb-commits] [lldb] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/117028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-21 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/117028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

2024-11-21 Thread Michael Jones via lldb-commits
michaelrj-google wrote: Same for libc, the change looks good but it's easier to land as an individual PR. Feel free to @ me or add me as a reviewer and I'll approve that PR. https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-11-21 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @jimingham I've implemented my proposal above. I added a test that `SBProcess::Continue()` preserves the reverse direction after stopping on a breakpoint. I also beefed up the conditional-breakpoint test to make a function call in the condition, which exercises the step-over-

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
@@ -144,9 +144,13 @@ lldb::ExpressionResults UserExpression::Evaluate(ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options, llvm::StringRef expr, llvm::StringRef prefix, - lldb::ValueObject

[Lldb-commits] [lldb] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread via lldb-commits
https://github.com/ChuvakHome edited https://github.com/llvm/llvm-project/pull/117226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/117239 Fix a bug introduced in https://github.com/llvm/llvm-project/pull/117071. Ideally the DWARTTypePrinter test should go to `llvm/unittests/DebugInfo/DWARF/DWARTTypePrinterTest.cpp`. >From 5ecdcda44c179d32e64fae

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Zequan Wu (ZequanWu) Changes Fix a bug introduced in https://github.com/llvm/llvm-project/pull/117071. Ideally the DWARTTypePrinter test should go to `llvm/unittests/DebugInfo/DWARF/DWARTTypePrinterTest.cpp`. --- Full diff: https://g

[Lldb-commits] [lldb] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread Alex Langford via lldb-commits
@@ -3278,7 +3278,7 @@ bool AppleObjCRuntimeV2::NonPointerISACache::EvaluateNonPointerISA( } // If the index is still out of range then this isn't a pointer. - if (index > m_indexed_isa_cache.size()) + if (index >= m_indexed_isa_cache.size())

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes Fix a bug introduced in https://github.com/llvm/llvm-project/pull/117071. Ideally the DWARTTypePrinter test should go to `llvm/unittests/DebugInfo/DWARF/DWARTTypePrinterTest.cpp`. --- Full diff: https://github

[Lldb-commits] [lldb] [lldb] Fix incorrect nullptr check in DumpAddressAndContent (PR #117219)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. makes sense https://github.com/llvm/llvm-project/pull/117219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117186 >From 208fa0afd563506c91afb320ff6cca4fa579c36a Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 08:32:06 -0800 Subject: [PATCH] [lldb] Refactor UserExpression::Evaluate to only have one

[Lldb-commits] [lldb] ba668eb - Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (#117079)

2024-11-21 Thread via lldb-commits
Author: Alex Langford Date: 2024-11-21T13:06:15-08:00 New Revision: ba668eb99c5dc37d3c5cf2775079562460fd7619 URL: https://github.com/llvm/llvm-project/commit/ba668eb99c5dc37d3c5cf2775079562460fd7619 DIFF: https://github.com/llvm/llvm-project/commit/ba668eb99c5dc37d3c5cf2775079562460fd7619.diff

[Lldb-commits] [lldb] Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #117079)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/117079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >