Author: Dmitry Vasilyev
Date: 2024-11-11T18:14:22+04:00
New Revision: 8941f898f1921857720034b9a0950e4ec32d5d87
URL:
https://github.com/llvm/llvm-project/commit/8941f898f1921857720034b9a0950e4ec32d5d87
DIFF:
https://github.com/llvm/llvm-project/commit/8941f898f1921857720034b9a0950e4ec32d5d87.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/115613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/115722
Test fails on https://lab.llvm.org/staging/#/builders/197/builds/76 because of
a little difference in format of output.
>From 3cf79d9bb129005fce07a9b7b5f651971e08579b Mon Sep 17 00:00:00 2001
From: Vladislav
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
Test fails on https://lab.llvm.org/staging/#/builders/197/builds/76 because of
a little difference in format of output.
---
Full diff: https://github.com/llvm/llvm-project/pull/115722.diff
1 File
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is the beginning of a different, more fundamental approach to handling.
This PR tries to tries to minimize functional changes. It only makes sure that
we store the true set of ranges inside the function o
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/115730
This is the beginning of a different, more fundamental approach to handling.
This PR tries to tries to minimize functional changes. It only makes sure that
we store the true set of ranges inside the function obj
DhruvSrivastavaX wrote:
Ok Sure, Got it. Will Proceed accordingly then.
Thanks!
https://github.com/llvm/llvm-project/pull/108000
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -264,34 +288,35 @@ PathMappingList::FindFile(const FileSpec &orig_spec)
const {
bool PathMappingList::Replace(llvm::StringRef path, llvm::StringRef new_path,
bool notify) {
- std::lock_guard lock(m_mutex);
- uint32_t idx = FindIndexForPath(p
jimingham wrote:
My notion was that when you push a plan that has an intention to run in a
direction, if the plan above it on the stack was going in the opposite
direction, it has to be popped. But plans that don't have an intention don't
change the stack above them.
https://github.com/llvm/
rocallahan wrote:
> My notion was that when you push a plan that has an intention to run in a
> direction, if the plan above it on the stack was going in the opposite
> direction, it has to be popped.
That's in the current code in this PR but I agree that was the wrong direction.
My experimen
jimingham wrote:
I also think in the long run we need a more flexible procedure. After all, you
might be doing a backwards direction next, but hit a breakpoint while doing
that. You then want to step FORWARDS from that breakpoint to check something
out. Then if stepping backwards and forward
jimingham wrote:
That would require that the thread wouldn't have a direction itself, but the
direction would be governed by whoever explained the stop and set up the next
phase of execution. Since all the threads need to work in lock step, that
probably means that `thread step-over --direct
https://github.com/ZequanWu approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/115177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Btw @weliveindetail , the `TestDAP_evaluate.py` test failure happens on other
PRs too. So I think this is safe to merge.
https://github.com/llvm/llvm-project/pull/115177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/115780
Support "true" and "false" (and "YES" and "NO" in Objective-C) in
ValueObject::SetValueFromCString.
Fixes #112597
>From 3450bca62abbc0e9595b61f663114cd67927ffaf Mon Sep 17 00:00:00 2001
From: Jonas Devlie
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Support "true" and "false" (and "YES" and "NO" in Objective-C) in
ValueObject::SetValueFromCString.
Fixes #112597
---
Full diff: https://github.com/llvm/llvm-project/pull/115780.diff
10 Files Aff
@@ -2,10 +2,15 @@
int main() {
NSDictionary* dic = @{@1 : @2};
+BOOL b = NO;
NSLog(@"hello world"); //% dic = self.frame().FindVariable("dic")
//% dic.SetPreferSyntheticValue(True)
//% dic.SetPreferDynamicValue(lldb.eDynamicCanRunTarget)
//% dic.Set
@@ -2,10 +2,15 @@
int main() {
NSDictionary* dic = @{@1 : @2};
+BOOL b = NO;
NSLog(@"hello world"); //% dic = self.frame().FindVariable("dic")
//% dic.SetPreferSyntheticValue(True)
//% dic.SetPreferDynamicValue(lldb.eDynamicCanRunTarget)
//% dic.Set
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/115780
>From 3450bca62abbc0e9595b61f663114cd67927ffaf Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 11 Nov 2024 14:17:17 -0800
Subject: [PATCH 1/2] [lldb] Support true/false in
ValueObject::SetValue
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/115780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> > My notion was that when you push a plan that has an intention to run in a
> > direction, if the plan above it on the stack was going in the opposite
> > direction, it has to be popped.
>
> That's in the current code in this PR but I agree that was the wrong
> direction. M
jimingham wrote:
IIUC, the goal is that In the end, DIL will win and there will only be one
VariableExpressionPath interface lldb. So it seems inefficient for the interim
stage to introduce another function and switch between them with UseDIL all
over the code. Why not leave GetValueForVaria
Author: Jonas Devlieghere
Date: 2024-11-11T16:27:15-08:00
New Revision: f109517d153609d4a8a3a3d3d3cc06da1b629364
URL:
https://github.com/llvm/llvm-project/commit/f109517d153609d4a8a3a3d3d3cc06da1b629364
DIFF:
https://github.com/llvm/llvm-project/commit/f109517d153609d4a8a3a3d3d3cc06da1b629364.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/115382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/115716
>From 306cf0dd5a6ccb80a1ec530b1753f6fa8d538715 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Thu, 29 Aug 2024 16:27:25 +
Subject: [PATCH 1/3] [lldb][test] Fix remote Shell tests failures on Wi
https://github.com/anatawa12 edited
https://github.com/llvm/llvm-project/pull/115712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-11-11T13:30:06Z
New Revision: bc368e4b578730bf0b10acd5412e476ccf7a5807
URL:
https://github.com/llvm/llvm-project/commit/bc368e4b578730bf0b10acd5412e476ccf7a5807
DIFF:
https://github.com/llvm/llvm-project/commit/bc368e4b578730bf0b10acd5412e476ccf7a5807.diff
LOG:
rocallahan wrote:
Giving ThreadPlans a direction gets complicated when there are multiple
runnable threads, because the topmost plans for different runnable threads
could disagree about the execution direction, which is obviously unworkable. In
my experimental branch I linked above, I resolve
rocallahan wrote:
The approach I implemented fails when evaluating a breakpoint condition
requires running a function in the target process, e.g. evaluating a breakpoint
condition that's a function call, or calling `mmap()` to allocate memory for
JITted code. That pushes a `ThreadPlanCallFunct
slydiman wrote:
Reduced the list of environment variables to SystemDrive only.
We can easily add necessary variables later.
It must fix `cmake-configure` step here
https://lab.llvm.org/staging/#/builders/197/builds/77
https://github.com/llvm/llvm-project/pull/115613
___
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/115613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,10 +6,10 @@ tbx z0.b, z1.b, z2.b
// CHECK: error: instruction requires: sve2 or sme
// CHECK-NEXT: tbx z0.b, z1.b, z2.b
-.arch_extension sve2-aes
-.arch_extension nosve2-aes
+.arch_extension sve-aes
+.arch_extension nosve-aes
SpencerAbson wrote:
I see,
@@ -6,10 +6,10 @@ tbx z0.b, z1.b, z2.b
// CHECK: error: instruction requires: sve2 or sme
// CHECK-NEXT: tbx z0.b, z1.b, z2.b
-.arch_extension sve2-aes
-.arch_extension nosve2-aes
+.arch_extension sve-aes
+.arch_extension nosve-aes
labrinea wrote:
You may fin
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/111814
>From 08c9d5ae66ca857d165dc878ebd1b2e0de364a24 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Thu, 10 Oct 2024 02:24:42 -0500
Subject: [PATCH 1/9] Taking base file structure from ELF as reference
DhruvSrivastavaX wrote:
> Are XCOFF files always big endian? If so, then all you need is to add a
> `DataExtractor::SetByteOrder()`. If not (and you want to support both
> endiannesses), then it would be better to add both cases to
> `XCOFFHeaderSizeFromMagic`.
Yes, AIX XCOFF does not support
@@ -0,0 +1,193 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/anatawa12 created
https://github.com/llvm/llvm-project/pull/115712
I hope this fixes #67825
Fixes
[RIDER-99436](https://youtrack.jetbrains.com/issue/RIDER-99436/Unity-Editor-will-be-crashed-when-detaching-LLDB-debugger-in-Rider),
which is upstream issue of #67825.
This PR c
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: anatawa12 (anatawa12)
Changes
I hope this fixes #67825
Fixes
[RIDER-99436](https://youtrack.jetbrains.com/issue/RIDER-99436/Unity-Editor-will-be-crashed-when-detaching-LLDB-debugger-in-Rider),
which is upstream issue of #67825.
This PR ch
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (Lakshmi-Surekha)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/1016
https://github.com/Lakshmi-Surekha created
https://github.com/llvm/llvm-project/pull/115714
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issue
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
Since the remote Shell test execution feature was added, these tests should now
be disabled on Windows target instead of Windows host.
It should fix failures on https://lab.llvm.org/staging/#/build
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/115716
Since the remote Shell test execution feature was added, these tests should now
be disabled on Windows target instead of Windows host.
It should fix failures on https://lab.llvm.org/staging/#/builders/197/bu
https://github.com/Lakshmi-Surekha edited
https://github.com/llvm/llvm-project/pull/115714
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/115619
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-11-11T12:40:01+04:00
New Revision: 1277bea4311692d3bd3d1a6566ec1011d3e72f65
URL:
https://github.com/llvm/llvm-project/commit/1277bea4311692d3bd3d1a6566ec1011d3e72f65
DIFF:
https://github.com/llvm/llvm-project/commit/1277bea4311692d3bd3d1a6566ec1011d3e72f65.dif
labath wrote:
I don't think we should submit this, because I believe this file exists only as
a consequence of shoehorning NativeProcessAIX into the NativeProcessLinux
mould. I think this needs to be reviewed in conjunction with the rest of the
process code using it. If you want to start revie
slydiman wrote:
@labath
> The problem might have something to do with the fact that this somehow ends
> up in the windows platform code:
This callstack has no problem. It is the callstack on local Windows just for
the comparison. I will remove this callstack from the issue description to
avoi
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/115613
>From 17b3338decd050612d0b804ef6d9966912b0950b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sat, 9 Nov 2024 21:11:16 +0400
Subject: [PATCH 1/2] [lldb] Transfer some environment variables into the tests
Author: Kazu Hirata
Date: 2024-11-11T00:00:20-08:00
New Revision: ebcdc700d68582a44dd059c40f382583126f29a6
URL:
https://github.com/llvm/llvm-project/commit/ebcdc700d68582a44dd059c40f382583126f29a6
DIFF:
https://github.com/llvm/llvm-project/commit/ebcdc700d68582a44dd059c40f382583126f29a6.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/115684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,10 +6,10 @@ tbx z0.b, z1.b, z2.b
// CHECK: error: instruction requires: sve2 or sme
// CHECK-NEXT: tbx z0.b, z1.b, z2.b
-.arch_extension sve2-aes
-.arch_extension nosve2-aes
+.arch_extension sve-aes
+.arch_extension nosve-aes
labrinea wrote:
> all sve2-
Author: Michael Buch
Date: 2024-11-11T10:05:54Z
New Revision: 04b295e8938778251821f8a39903fdad0501112c
URL:
https://github.com/llvm/llvm-project/commit/04b295e8938778251821f8a39903fdad0501112c
DIFF:
https://github.com/llvm/llvm-project/commit/04b295e8938778251821f8a39903fdad0501112c.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/115571
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
Thanks, that sounds OK but I don't see how it would help with my main question
right now:
> So what would be a good way to pop `ThreadPlanReverseContinue`?
Put it another way: if we change the plan stack state to request reverse
execution (push a `ThreadPlanReverseContinue`,
chelcassanova wrote:
I agree that those who want to change their colours in LLDB shouldn't have to
touch the ANSI suffix setting in order to do this. We do use settings for
changing the suffix in other places in LLDB, so if we were change how this
setting works then I think it's outside of the
chelcassanova wrote:
I also agree with how I was misusing the `pexpect` module here, I was way
overcomplicating things there by trying to model my test after the one that
drives the `expect` program instead of lldb itself 😅
https://github.com/llvm/llvm-project/pull/91404
_
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/115500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-11T08:11:03-08:00
New Revision: e19d74016971faed321e5cca20da7016047eb029
URL:
https://github.com/llvm/llvm-project/commit/e19d74016971faed321e5cca20da7016047eb029
DIFF:
https://github.com/llvm/llvm-project/commit/e19d74016971faed321e5cca20da7016047eb029.d
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/115730
>From 39a29e37cfcd3d581c488605959c9a7c9ada5d69 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 11 Nov 2024 16:49:38 +0100
Subject: [PATCH 1/3] [lldb] (Begin to) support discontinuous
lldb_private::Functio
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 00a1f1ab71302d190f8059d86a53ec62485fbce9
39a29e37cfcd3d581c488605959c9a7c9ada5d69 --e
jimingham wrote:
We have another negotiation among the threads that want to run with other
threads suspended. We let all the threads that want to run with others
suspended go in a round robin and only when there are none of those left do we
let the "run all threads" plans do their thing.
May
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,26 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test im
labath wrote:
It's very hard to review this without seeing the related code as well (who
calls On(Un)loadModule and why?), and I don't think it's a high priority for
review/upstreaming. You should be able to go quite a long way without a dynamic
loader plugin. The first thing you need to do it
https://github.com/labath approved this pull request.
Looks good. Thanks. Do you need someone to push the merge button?
https://github.com/llvm/llvm-project/pull/111814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
DhruvSrivastavaX wrote:
> Looks good. Thanks. Do you need someone to push the merge button?
Ok, great. Yes, please merge it, I don't have the permission to do that yet.
https://github.com/llvm/llvm-project/pull/111814
___
lldb-commits mailing list
lld
labath wrote:
How can you run a PDB test on a linux machine?
https://github.com/llvm/llvm-project/pull/115722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
So, it sounds like this is fixing
test/API/commands/process/detach-resumes/TestDetachResumes.py (which is linked
to #89077, which may be a dupe of the bug you're referencing), so the first
step would be to figure out whether this test actually passes with your patch.
Note that t
@@ -0,0 +1,26 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test im
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/115730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -254,12 +254,32 @@ Function *IndirectCallEdge::GetCallee(ModuleList &images,
/// @}
+AddressRange CollapseRanges(llvm::ArrayRef ranges) {
+ if (ranges.empty())
+return AddressRange();
+ if (ranges.size() == 1)
+return ranges[0];
+
+ Address lowest_addr = ranges[
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1062,6 +1063,16 @@ void request_breakpointLocations(const
llvm::json::Object &request) {
continue;
if (line == end_line && column > end_column)
continue;
+
+ // Make sure we are in the right file.
+ // We might have a match on line & column
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/113787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
82 matches
Mail list logo
