jimingham wrote:

IIUC, the goal is that In the end, DIL will win and there will only be one 
VariableExpressionPath interface lldb.  So it seems inefficient for the interim 
stage to introduce another function and switch between them with UseDIL all 
over the code.  Why not leave GetValueForVariableExpressionPath for now, and 
move the `if (UseDIL())` into that function.  They have the same signature, and 
you'll always be able to find the target from the ValueObject when you are in 
GetValueForVariableExpressionPath, so that should be possible.

That will make the diff much smaller, and in the end mean that pulling the 
switch to use only the DIL will be less disruptive.

https://github.com/llvm/llvm-project/pull/115666
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to