[Lldb-commits] [lldb] [lldb][test] Add libcxx-simulators test for std::optional (PR #111133)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 19c6958d24acf5beaba1946ad3e1e5fc538e3a2d...d4e8921f4e00351c2906b08d2c2a1e9a4191c40e lldb

[Lldb-commits] [lldb] [lldb][test] Add libcxx-simulators test for std::optional (PR #111133)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Follow-up to the LLDB std::optional data-formatter test failure caused by https://github.com/llvm/llvm-project/pull/110355. Two formats are supported: 1. `__val_` has type `value_type` 2. `__val_`'s type i

[Lldb-commits] [lldb] [lldb][test] Add libcxx-simulators test for std::optional (PR #111133)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/33 Follow-up to the LLDB std::optional data-formatter test failure caused by https://github.com/llvm/llvm-project/pull/110355. Two formats are supported: 1. `__val_` has type `value_type` 2. `__val_`'s type is

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/23 >From 453d33171be0550737e2f6e5d7e182ef43c71c51 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 4 Oct 2024 10:16:18 +0100 Subject: [PATCH] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

Michael137 wrote: Didn't manage to build LLDB on my Windows machine (and AFAICT we don't have Windows PR testing). So hoping this will fix it. https://github.com/llvm/llvm-project/pull/23 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/23 >From 453d33171be0550737e2f6e5d7e182ef43c71c51 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 4 Oct 2024 10:16:18 +0100 Subject: [PATCH] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py

[Lldb-commits] [lldb] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Relands https://github.com/llvm/llvm-project/pull/108375 which had to be reverted because it was failing on the Windows buildbot. Trying to reland this with `msvc::no_unique_address` on Windows. --- Full

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/23 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/23 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/23 >From 27ff173e19c5391fe175a144f5bb6909a98289f9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 4 Oct 2024 10:16:18 +0100 Subject: [PATCH 1/3] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulato

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/110065 >From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 24 Sep 2024 17:42:49 -0700 Subject: [PATCH 1/9] Add the addr info when appropriate for NIX' crash signals -

[Lldb-commits] [libcxx] [lldb] [lldb][CMake] Add single target that runs libc++ tests (PR #110856)

Michael137 wrote: Hmm getting ``` Exit Code: 255 Command Output (stderr): -- ERROR:root:"/home/runner/_work/llvm-project/llvm-project/build/bootstrapping-build/./bin/clang" is not a valid compiler executable; aborting... ``` In the `[stage3 (bootstrapping-build, libcxx-runners-8-set)](https://

[Lldb-commits] [lldb] [lldb][test] Add libcxx-simulators test for std::optional (PR #111133)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/33 >From d4e8921f4e00351c2906b08d2c2a1e9a4191c40e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Oct 2024 13:31:07 +0100 Subject: [PATCH 1/2] [lldb][test] Add libcxx-simulators test for std::optional

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

https://github.com/Michael137 approved this pull request. Given the discussion so far this seems like a good enough perf. improvement without having to revamp the `FindFunctions` API. So lgtm, thanks for the patience. Please give it a couple of days before merging in case Greg (or someone else

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: @JDevlieghere @cyndyishida @topperc gentle ping. It's mostly mechanical. https://github.com/llvm/llvm-project/pull/110692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [libcxx] [lldb] [lldb][CMake] Add single target that runs libc++ tests (PR #110856)

Michael137 wrote: Yea i think we need to run make sure the `check-lldb-api-deps` target gets run. https://github.com/llvm/llvm-project/pull/110856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [libcxx] [lldb] [lldb][CMake] Add single target that runs libc++ tests (PR #110856)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110856 >From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Oct 2024 15:44:28 +0100 Subject: [PATCH 1/7] [lldb][CMake] Add single target that runs libc++ tests ---

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From 5eff438dfba2a1f31bd51a84ca3516bae7fc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

@@ -26,6 +27,35 @@ class raw_ostream; namespace lldb_private { +/// A compiler-independent representation of a Diagnostic. Expression +/// evaluation failures often have more than one diagnostic that a UI +/// layer might want to render differently, for example to colorize +/

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From 97b3812fe74feef8ea4e263cbb487bde5b3fe28b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

@@ -3180,15 +3180,24 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, if ((result.Succeeded() && io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { -// Display a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

adrian-prantl wrote: @jimingham I changed the API to just record the offset of the expression in the command instead of the expression itself, which should make this all look a bit more logical. https://github.com/llvm/llvm-project/pull/110901 ___ ll

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: more of a hypothetical concern at this point. It's also making file names under Option consistent, in the sense that we have `Option.h` and `Option.cpp` but `OptTable.h` `OptSpecifier.h` and `OptTable.cpp` https://github.com/llvm/llvm-project/pull/110692 ___

[Lldb-commits] [lldb] Add SBDebugger::AddCreateCallback API (PR #111206)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/111206 This PR adds new SBDebugger::AddCreateCallback()/RemoveCreateCallback() APIs. This API enables any lldb client to subscribe to debugger creation and perform action on it. For example, we have telemetry cod

[Lldb-commits] [lldb] Add SBDebugger::AddCreateCallback API (PR #111206)

https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/111206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add SBDebugger::AddCreateCallback API (PR #111206)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This PR adds new SBDebugger::AddCreateCallback()/RemoveCreateCallback() APIs. This API enables any lldb client to subscribe to debugger creation and perform action on it. For example, we have telemetry code that

[Lldb-commits] [lldb] Add SBDebugger::AddCreateCallback API (PR #111206)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 828783177f71d95522763fba92ef1e42dc6101c7...4f119961f3ae2d7bc40a2c00e18ee5774254c773 lldb/

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From bfb74e76dbfa548d821e6b3891fb1e6e6c9a80a3 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

JDevlieghere wrote: The change itself seems fine but I'm not super convinced that the motivation is worth the churn. All these files live under the "Option" library and therefore it's (IMHO) clear that Opt is short for Option. Is this addressing code review feedback or a real issue where the

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111237 The decorators caused the main test, i.e. `test_set_use_source_cache_true()`, to be skipped in most scenarios. It was only run on a Windows host targeting a non-Windows remote platform, and it failed in this

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes The decorators caused the main test, i.e. `test_set_use_source_cache_true()`, to be skipped in most scenarios. It was only run on a Windows host targeting a non-Windows remote platform, and it failed in thi

[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)

https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111231 This fixes a build error with msvc for code introduced in #106442: ``` ...\lldb\source\Expression\DiagnosticManager.cpp(37): error C2668: 'llvm::ErrorInfo::ErrorInfo': ambiguous call to overloaded function

[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes This fixes a build error with msvc for code introduced in #106442: ``` ...\lldb\source\Expression\DiagnosticManager.cpp(37): error C2668: 'llvm::ErrorInfo

[Lldb-commits] [libcxx] [lldb] [lldb][CMake] Add single target that runs libc++ tests (PR #110856)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110856 >From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Oct 2024 15:44:28 +0100 Subject: [PATCH 1/8] [lldb][CMake] Add single target that runs libc++ tests ---

[Lldb-commits] [lldb] [WIP] Reland "[lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout" (PR #111123)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/23 Relands https://github.com/llvm/llvm-project/pull/108375 which had to be reverted because it was failing on the Windows buildbot. Trying to reland this with `msvc::no_unique_address` on Windows. >From 27ff1

[Lldb-commits] [lldb] [lldb] Add isConstant mode for FA locations (PR #110726)

https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/110726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6294679 - [lldb] Add isConstant mode for FA locations (#110726)

Author: Felipe de Azevedo Piovezan Date: 2024-10-04T05:01:52-07:00 New Revision: 6294679faa8ae57873b7fcdc00a4deb522d31c38 URL: https://github.com/llvm/llvm-project/commit/6294679faa8ae57873b7fcdc00a4deb522d31c38 DIFF: https://github.com/llvm/llvm-project/commit/6294679faa8ae57873b7fcdc00a4deb52

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 99f527d2807b5a14dc7ee64d15405f09e95ee9f2 f59f186d66c96a4aefbebd58776f99dd294f47e8 --e

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) { } void CommandReturnObject::SetError(llvm::Error error) { - if (error) + // Retrieve any diagnostics. + error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error) { a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

@@ -3180,15 +3180,24 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, if ((result.Succeeded() && io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { -// Display a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From f59f186d66c96a4aefbebd58776f99dd294f47e8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] [lldb][test] Mark test() in TestBSDArchives.py as passing remotely (PR #111199)

https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/99 It was xfail'ed in de2ddc8f3146b. However, it passes on a buildbot https://lab.llvm.org/staging/#/builders/195/builds/3988. >From 092c1abb8de5e0bf3eaaa7758cc3dc3614c02b60 Mon Sep 17 00:00:00 2001 From: Vladi

[Lldb-commits] [lldb] [lldb][test] Mark test() in TestBSDArchives.py as passing remotely (PR #111199)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes It was xfail'ed in de2ddc8f3146b. However, it passes on a buildbot https://lab.llvm.org/staging/#/builders/195/builds/3988. --- Full diff: https://github.com/llvm/llvm-project/pull/99.diff 1

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -556,6 +559,24 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch) { si_signo = data.GetU32(&offset); si_errno = data.GetU32(&offset); si_code = data.GetU32(&offset); + // 64b ELF have a 4 byte pad. + if (data.GetAddressByteSize() == 8)

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -76,14 +76,19 @@ static_assert(sizeof(ELFLinuxPrStatus) == 112, "sizeof ELFLinuxPrStatus is not correct!"); struct ELFLinuxSigInfo { - int32_t si_signo; - int32_t si_code; + int32_t si_signo; // Order matters for the first 3. int32_t si_errno; + int32_t

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -76,14 +76,19 @@ static_assert(sizeof(ELFLinuxPrStatus) == 112, "sizeof ELFLinuxPrStatus is not correct!"); struct ELFLinuxSigInfo { - int32_t si_signo; - int32_t si_code; + int32_t si_signo; // Order matters for the first 3. int32_t si_errno; + int32_t

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) { } void CommandReturnObject::SetError(llvm::Error error) { - if (error) + // Retrieve any diagnostics. + error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error) { +SetStatus(eRe