Author: Pavel Labath
Date: 2024-09-06T09:00:00+02:00
New Revision: ddf40e0132cdfb9443e8dce9ca18d4f5595fb73c
URL:
https://github.com/llvm/llvm-project/commit/ddf40e0132cdfb9443e8dce9ca18d4f5595fb73c
DIFF:
https://github.com/llvm/llvm-project/commit/ddf40e0132cdfb9443e8dce9ca18d4f5595fb73c.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/107240
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
@@ -181,29 +241,61 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -943,8 +935,20 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
}
}
}
+ return debugserver_file_spec;
+}
- if (debugserver_exists) {
+Status GDBRemoteCommunication::StartDebugserverProcess(
+const char *url, Platform *platform, ProcessLaunchInfo
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/107388
>From 9f1612513d5feffe7c0b5b5e5b743d932d233934 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 5 Sep 2024 16:04:44 +0400
Subject: [PATCH 1/2] [lldb][NFC] Separated
GDBRemoteCommunication::GetDebugser
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Rahul Joshi (jurahul)
Changes
Migrate LLDB TableGen backend to use const RecordKeeper.
---
Full diff: https://github.com/llvm/llvm-project/pull/107536.diff
6 Files Affected:
- (modified) lldb/utils/TableGen/LLDBOptionDefEmitter.cpp (+6-7
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
DavidSpickett wrote:
Is this part of a larger effort, do you have a link to an RFC or previous PRs?
I assume the motivation is const correctness?
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/107553
Replaced `int connection_fd = -1` with `shared_fd_t connection_fd =
SharedSocket::kInvalidFD`.
This is prerequisite for #104238.
>From 77be482bff5a68f2357bb7e0499e5a67cfbece22 Mon Sep 17 00:00:00 2001
From: D
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Replaced `int connection_fd = -1` with `shared_fd_t connection_fd =
SharedSocket::kInvalidFD`.
This is prerequisite for #104238.
---
Full diff: https://github.com/llvm/llvm-project/pull/107553.diff
7 F
Author: Christian Sigg
Date: 2024-09-06T11:55:24+02:00
New Revision: d4e320e6f4dd78929cec44b342b6035a6bbd6323
URL:
https://github.com/llvm/llvm-project/commit/d4e320e6f4dd78929cec44b342b6035a6bbd6323
DIFF:
https://github.com/llvm/llvm-project/commit/d4e320e6f4dd78929cec44b342b6035a6bbd6323.diff
slydiman wrote:
Oops, I copied `shared_fd_t` from #104238 by mistake
```
Status GDBRemoteCommunication::StartDebugserverProcess(... , shared_fd_t
pass_comm_fd) {
```
It will break the Windows build.
I can replace it with `int` or we can apply #107553.
Please advise.
https://github.com/llvm/ll
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/107553
>From 23df9469749dbe73d86ef8d0fe2db4fc9a769836 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 13:38:09 +0400
Subject: [PATCH] [lldb][NFC] Used shared_fd_t
Replaced `int connection_fd = -1
mstorsjo wrote:
> Oops, I copied `shared_fd_t` from #104238 by mistake
>
> ```
> Status GDBRemoteCommunication::StartDebugserverProcess(... , shared_fd_t
> pass_comm_fd) {
> ```
>
> It will break the Windows build. I can replace it with `int` or we can apply
> #107553. Please advise.
As some
Author: Dmitry Vasilyev
Date: 2024-09-06T14:42:28+04:00
New Revision: b11a70392c6ef3c481421f9f0a6651030333ebdc
URL:
https://github.com/llvm/llvm-project/commit/b11a70392c6ef3c481421f9f0a6651030333ebdc
DIFF:
https://github.com/llvm/llvm-project/commit/b11a70392c6ef3c481421f9f0a6651030333ebdc.dif
slydiman wrote:
[Updated](https://github.com/llvm/llvm-project/commit/b11a70392c6ef3c481421f9f0a6651030333ebdc).
Thanks.
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
mstorsjo wrote:
Thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/107553
>From c5d5515a71690ef795912219b99408effb5031d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 13:38:09 +0400
Subject: [PATCH] [lldb][NFC] Used shared_fd_t
Replaced `int connection_fd = -1
slydiman wrote:
I have separated changes `int connection_fd = -1` -> `shared_fd_t connection_fd
= SharedSocket::kInvalidFD` to #107553 (NFC).
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/107553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From fc72ca63e886b0a364bb33972581f05fd663eb29 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 15:50:40 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen to
slydiman wrote:
Sorry for the spam. Something went wrong during the rebase.
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 92b6c2c8ab9c98d48fb5bef72bbd072f68ceff7b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 15:50:40 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen to
Author: Dmitry Vasilyev
Date: 2024-09-06T16:03:11+04:00
New Revision: 5d2b3378758b42391e90b1adf936537a66b038b6
URL:
https://github.com/llvm/llvm-project/commit/5d2b3378758b42391e90b1adf936537a66b038b6
DIFF:
https://github.com/llvm/llvm-project/commit/5d2b3378758b42391e90b1adf936537a66b038b6.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/107553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From f0b91561e4ee1caf55c60bd1d06e517dab1f63eb Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 16:12:50 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen to
labath wrote:
> > That bug shows we're not able to create a test for a very simple thing (an
> > unaligned stack pointer) that works reliably for everyone.
>
> Honestly, based on [#101710
> (comment)](https://github.com/llvm/llvm-project/issues/101710#issuecomment-2291180977),
> I'd say that
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
jurahul wrote:
Yes, the motivation is const correctness. Please see the discourse thread here:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefinitions-api-potential-downstream-breakages/81089
https://github.com/llvm/llvm-project/pull/107536
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
https://github.com/dfukalov updated
https://github.com/llvm/llvm-project/pull/106810
>From 8232271806ea605fb4f7212d842a328307070003 Mon Sep 17 00:00:00 2001
From: dfukalov
Date: Sat, 31 Aug 2024 01:45:27 +0200
Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its
macros are
https://github.com/dfukalov created
https://github.com/llvm/llvm-project/pull/107603
(this is lldb part)
Without these explicit includes, removing other headers, who implicitly include
llvm-config.h, may have non-trivial side effects. For example, `clangd` may
report even `llvm-config.h` as "
Author: Jacob Lalonde
Date: 2024-09-06T09:04:33-07:00
New Revision: d4d4e77918118f1444dc5ca230d4fdf82bb05b74
URL:
https://github.com/llvm/llvm-project/commit/d4d4e77918118f1444dc5ca230d4fdf82bb05b74
DIFF:
https://github.com/llvm/llvm-project/commit/d4d4e77918118f1444dc5ca230d4fdf82bb05b74.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/107159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/2] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -1363,6 +1363,14 @@ void request_evaluate(const llvm::json::Object &request)
{
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ static
https://github.com/dfukalov ready_for_review
https://github.com/llvm/llvm-project/pull/107603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Daniil Fukalov (dfukalov)
Changes
(this is lldb part)
Without these explicit includes, removing other headers, who implicitly include
llvm-config.h, may have non-trivial side effects. For example, `clangd` may
report even `llvm-config.h`
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/3] MSquash merge lldb changes and drop llvm changes
---
.../Pro
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c014db47ca298ad7a0f52a57c3bfc2a9914371b2
bfb8f4f2f9becfd3156aefbcf1d34673abbcd8bd --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Sep 2024 13:09:27 -0700
Subject: [PATCH 1/4] MSquash merge lldb changes and drop llvm changes
---
.../Pro
Author: Tom Stellard
Date: 2024-09-06T17:05:32-07:00
New Revision: adf44d5c3ea03569f019740e1140c3205810b3fa
URL:
https://github.com/llvm/llvm-project/commit/adf44d5c3ea03569f019740e1140c3205810b3fa
DIFF:
https://github.com/llvm/llvm-project/commit/adf44d5c3ea03569f019740e1140c3205810b3fa.diff
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/106885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
I think I have addressed all of the review comments now, except for the
dependency on the Clang lexer. If it's ok with the reviewers, I would rather
not put that change into this PR, but instead I will make that the next PR that
I submit in the DIL (Data Inspection Language) ser
52 matches
Mail list logo
