mstorsjo wrote:
> Oops, I copied `shared_fd_t` from #104238 by mistake
>
> ```
> Status GDBRemoteCommunication::StartDebugserverProcess(... , shared_fd_t
> pass_comm_fd) {
> ```
>
> It will break the Windows build. I can replace it with `int` or we can apply
> #107553. Please advise.
As someone who just ran into this build failure - I would prefer to first push
a minimal fixup commit to change it to `int`, to unbreak the build, and then
rebase #107553 on top of that. Even if #107553 is meant to be NFC, it's a much
larger change.
https://github.com/llvm/llvm-project/pull/107388
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
