[Lldb-commits] [lldb] 3d06de5 - [lldb] Remove Phabricator usernames from Code Owners file (#102590)

2024-08-15 Thread via lldb-commits
Author: David Spickett Date: 2024-08-15T09:07:02+01:00 New Revision: 3d06de544b8397a6b93a4fdb52650579237b77fa URL: https://github.com/llvm/llvm-project/commit/3d06de544b8397a6b93a4fdb52650579237b77fa DIFF: https://github.com/llvm/llvm-project/commit/3d06de544b8397a6b93a4fdb52650579237b77fa.diff

[Lldb-commits] [lldb] [lldb] Remove Phabricator usernames from Code Owners file (PR #102590)

2024-08-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/102590 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for putting so much work into this. I will test this out with my VM setup. > Parameters --min-gdbserver-port and --max-gdbserver-port are deprecated now. Are they just consumed but the port number is not used because it can use the first port for everything? (I do

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: @medismailben how might we reduce the path length? Maybe `/interfaces/` content could be moved into the parent folder, or `Python` dropped from some of the cpp file names (as they're in a python subfolder anyway)? Headers are better left verbose so we can see what they are

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104317 >From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 14 Aug 2024 11:52:40 + Subject: [PATCH 1/2] [lldb-dap] Support inspecting memory Adds suppor

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object &request) { response.try_emplace("body", std::move(body)); g_dap.SendJSON(llvm::json::Value(std::move(response))); } + +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" },

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object &request) { response.try_emplace("body", std::move(body)); g_dap.SendJSON(llvm::json::Value(std::move(response))); } + +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" },

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104317 >From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 14 Aug 2024 11:52:40 + Subject: [PATCH 1/4] [lldb-dap] Support inspecting memory Adds suppor

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object &request) { response.try_emplace("body", std::move(body)); g_dap.SendJSON(llvm::json::Value(std::move(response))); } + +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" },

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104317 >From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 14 Aug 2024 11:52:40 + Subject: [PATCH 1/5] [lldb-dap] Support inspecting memory Adds suppor

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104317 >From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 14 Aug 2024 11:52:40 + Subject: [PATCH 1/5] [lldb-dap] Support inspecting memory Adds suppor

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -1085,6 +1085,19 @@ std::string VariableDescription::GetResult(llvm::StringRef context) { return description.trim().str(); } +lldb::addr_t GetMemoryReference(lldb::SBValue v) { + if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType()) { +return LLDB_INVALID_

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks for the super-fast review, @clayborg! I addressed all the straightforward issues and replied to the non-straightforward ones https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7898866 - [lldb-dap] Expose log path in extension settings (#103482)

2024-08-15 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-15T13:19:32+02:00 New Revision: 7898866065f6c9b72b5fa3e45e565baf8a5e7609 URL: https://github.com/llvm/llvm-project/commit/7898866065f6c9b72b5fa3e45e565baf8a5e7609 DIFF: https://github.com/llvm/llvm-project/commit/7898866065f6c9b72b5fa3e45e565baf8a5e7609

[Lldb-commits] [lldb] [lldb-dap] Expose log path in extension settings (PR #103482)

2024-08-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/103482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. This indeed fixes the race condition. I can confirm that the test no longer hangs after with this patch. I'm glad we were able to figure this out. *However*, this doesn't appear to be the only problem here. With the hang out of the way, I c

[Lldb-commits] [lldb] Reapply "[lldb] Tolerate multiple compile units with the same DWO ID (#100577)" (PR #104041)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/104041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 57a19ac - Reapply "[lldb] Tolerate multiple compile units with the same DWO ID (#100577)" (#104041)

2024-08-15 Thread via lldb-commits
Author: Pavel Labath Date: 2024-08-15T13:34:03+02:00 New Revision: 57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9 URL: https://github.com/llvm/llvm-project/commit/57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9 DIFF: https://github.com/llvm/llvm-project/commit/57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9.diff

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: The termination part definitely needs to be done differently, but overall, I think this is a pretty good start. (PSA: I will be OOO all of next week.) https://github.com/llvm/llvm-project/pull/104238 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -20,6 +20,10 @@ #include #include +#ifdef SendMessage +#undef SendMessage +#endif + labath wrote: I guess that means we're including a windows header somewhere. Any chance to avoid that? Llvm is pretty strict about that. Lldb is not, though I think it's

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -40,83 +40,20 @@ #include "lldb/Utility/StringExtractorGDBRemote.h" +#include "../tools/lldb-server/Acceptor.h" labath wrote: We will need to move this someplace else (probably `Host`) https://github.com/llvm/llvm-project/pull/104238

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -601,15 +570,24 @@ int main_platform(int argc, char *argv[]) { // If not running as a server, this process will not accept // connections while a connection is active. acceptor_up.reset(); - - // When not running in server mode, use all available ports

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -666,7 +756,23 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFD(llvm::StringRef s, socket_id_callback_type socket_id_callback, Status *error_ptr) { -#if LLDB_ENABLE_POSIX +#ifdef _WIN32 + int64_t

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -879,20 +879,12 @@ lldb::thread_result_t GDBRemoteCommunication::ListenThread() { return {}; } -Status GDBRemoteCommunication::StartDebugserverProcess( -const char *url, Platform *platform, ProcessLaunchInfo &launch_info, -uint16_t *port, const Args *inferior_arg

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
@@ -47,111 +48,10 @@ using namespace llvm; // option descriptors for getopt_long_only() -#ifdef _WIN32 -typedef pipe_t shared_fd_t; -const shared_fd_t kInvalidSharedFD = LLDB_INVALID_PIPE; -#else -typedef NativeSocket shared_fd_t; -const shared_fd_t kInvalidSharedFD = Socket:

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-15 Thread Pavel Labath via lldb-commits
labath wrote: `lldbPluginScriptInterpreterPythonScriptedThreadPlanPythonInterface` quite a mouthful for just a single cpp file. Maybe all of the interfaces could be a part of a single library? That would end up with something like: ``` D:\build-lldb\tools\lldb\source\Plugins\ScriptInterpreter\

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: The deps seem fine. I like the approach you've chosen. I'll leave the rest to other reviewers. https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -879,20 +879,12 @@ lldb::thread_result_t GDBRemoteCommunication::ListenThread() { return {}; } -Status GDBRemoteCommunication::StartDebugserverProcess( -const char *url, Platform *platform, ProcessLaunchInfo &launch_info, -uint16_t *port, const Args *inferior_arg

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -40,83 +40,20 @@ #include "lldb/Utility/StringExtractorGDBRemote.h" +#include "../tools/lldb-server/Acceptor.h" slydiman wrote: SocketProtocol is defined in lldb/include/lldb/Host/Socket.h I will move FindSchemeByProtocol(const Socket::SocketProtocol prot

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -47,111 +48,10 @@ using namespace llvm; // option descriptors for getopt_long_only() -#ifdef _WIN32 -typedef pipe_t shared_fd_t; -const shared_fd_t kInvalidSharedFD = LLDB_INVALID_PIPE; -#else -typedef NativeSocket shared_fd_t; -const shared_fd_t kInvalidSharedFD = Socket:

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -601,15 +570,24 @@ int main_platform(int argc, char *argv[]) { // If not running as a server, this process will not accept // connections while a connection is active. acceptor_up.reset(); - - // When not running in server mode, use all available ports

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-15 Thread Pavel Labath via lldb-commits
labath wrote: Thanks for chiming in Jason. I'm glad this is getting attention, as I think that our memory reading APIs are in need of an overhaul -- and it gives me a chance to share my idea. ;) I don't think that we need to change all of the APIs to return their memory. Sometimes reading the

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -20,6 +20,10 @@ #include #include +#ifdef SendMessage +#undef SendMessage +#endif + slydiman wrote: Note TestClient.cpp and LLGSTest.cpp already contain this code. Windows headers are necessary for socket definitions. It is impossible to separate them.

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -666,7 +756,23 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFD(llvm::StringRef s, socket_id_callback_type socket_id_callback, Status *error_ptr) { -#if LLDB_ENABLE_POSIX +#ifdef _WIN32 + int64_t

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Are they just consumed but the port number is not used because it can use the > first port for everything? > > (I do see the logic of leaving the options in at first, so we can tell > whether any problems are from the changes in this PR or purely from removing > the options)

[Lldb-commits] [lldb] [WIP] memory find speedup+bugfix (PR #104193)

2024-08-15 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/104193 >From a537a48c444e9dec3a85241d9726d6f3187a43cf Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Aug 2024 19:58:27 +0200 Subject: [PATCH] [WIP] memory find speedup+bugfix --- lldb/source/Target/Process.

[Lldb-commits] [lldb] [WIP] memory find speedup+bugfix (PR #104193)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 20b2c9f10fe09f2c5cbd3da7f0af8df24f62e899...a537a48c444e9dec3a85241d9726d6f3187a43cf lldb/

[Lldb-commits] [lldb] [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (PR #104439)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/104439 This is the prerequisite for #104238. >From e4dce57456f354c30e8a9f896354aeb12075d58b Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 15 Aug 2024 17:59:55 +0400 Subject: [PATCH] [lldb][NFC] Moved Find

[Lldb-commits] [lldb] [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (PR #104439)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is the prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104439.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+4) - (modified) lldb/source/H

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][WIP] memory find speedup+bugfix (PR #104193)

2024-08-15 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/104193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (PR #104439)

2024-08-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: So to test https://github.com/llvm/llvm-project/pull/104238 I should apply this first, or is it included in that? https://github.com/llvm/llvm-project/pull/104439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [lldb] [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (PR #104439)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > So to test #104238 I should apply this first, or is it included in that? Don't include that. I will rebase #104238 after merging this patch. https://github.com/llvm/llvm-project/pull/104439 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
@@ -20,6 +20,10 @@ #include #include +#ifdef SendMessage +#undef SendMessage +#endif + slydiman wrote: I will retest it after #104439. Probably we won't need it. https://github.com/llvm/llvm-project/pull/104238 _

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread Vlad Serebrennikov via lldb-commits
Endilll wrote: FYI there was a Linux pre-commit CI build recently that timed out on `functionalities/single-thread-step/TestSingleThreadStepTimeout.py`: https://buildkite.com/llvm-project/github-pull-requests/builds/91810 Relevant part of the log: https://gist.github.com/Endilll/a15335f75f2aa4

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/104238 >From 5732bda3558a0d55f2f7b9d1a3722d11458a2360 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 14 Aug 2024 22:36:52 +0400 Subject: [PATCH 1/2] [lldb] Removed gdbserver ports map from lldb-server List

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread via lldb-commits
jeffreytan81 wrote: @labath, thanks. I am able to reproduce the failure after adding the sleep and running tests in a loop for 4 iterations. I will take a look after landing this race condition fix. https://github.com/llvm/llvm-project/pull/104195 __

[Lldb-commits] [lldb] 54154f9 - Fix single thread stepping timeout race condition (#104195)

2024-08-15 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-08-15T09:57:01-07:00 New Revision: 54154f9f06e08b7ab3c7294352601ca4c6e5e160 URL: https://github.com/llvm/llvm-project/commit/54154f9f06e08b7ab3c7294352601ca4c6e5e160 DIFF: https://github.com/llvm/llvm-project/commit/54154f9f06e08b7ab3c7294352601ca4c6e5e160.diff

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/104195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/104109 >From 8f2f84294ea3875c88ce36a4980fd3a3afce01de Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Tue, 18 Jun 2024 10:38:09 -0700 Subject: [PATCH 1/3] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrS

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -0,0 +1,162 @@ +//===-- ThreadElfCoreTest.cpp *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/102708 >From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 Aug 2024 08:58:52 -0700 Subject: [PATCH 01/11] Initial attempt at new classes Summary statistics in Summa

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -318,6 +318,32 @@ Status ELFLinuxPrStatus::Parse(const DataExtractor &data, return error; } +static struct compat_timeval +copy_timespecs(const ProcessInstanceInfo::timespec &oth) { + using sec_t = decltype(compat_timeval::tv_sec); + using usec_t = decltype(compat_timev

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/104109 >From 8f2f84294ea3875c88ce36a4980fd3a3afce01de Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Tue, 18 Jun 2024 10:38:09 -0700 Subject: [PATCH 1/4] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrS

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -318,6 +318,32 @@ Status ELFLinuxPrStatus::Parse(const DataExtractor &data, return error; } +static struct compat_timeval +copy_timespecs(const ProcessInstanceInfo::timespec &oth) { + using sec_t = decltype(compat_timeval::tv_sec); + using usec_t = decltype(compat_timev

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/104109 >From 8f2f84294ea3875c88ce36a4980fd3a3afce01de Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Tue, 18 Jun 2024 10:38:09 -0700 Subject: [PATCH 1/5] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrS

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
@@ -394,6 +420,107 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data, return error; } +std::optional +ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) { + ELFLinuxPrPsInfo prpsinfo{}; + prpsinfo.pr_pid = process_sp->GetID(); + ProcessInstanceInfo in

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Miro Bucko via lldb-commits
https://github.com/mbucko approved this pull request. Just a couple of small things https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Miro Bucko via lldb-commits
https://github.com/mbucko edited https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Miro Bucko via lldb-commits
@@ -174,6 +177,83 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Miro Bucko via lldb-commits
@@ -174,6 +177,83 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Jacob Lalonde via lldb-commits
@@ -174,6 +177,84 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(lldb_private::ConstString name, +

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/102708 >From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 Aug 2024 08:58:52 -0700 Subject: [PATCH 01/11] Initial attempt at new classes Summary statistics in Summa

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/102708 >From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 Aug 2024 08:58:52 -0700 Subject: [PATCH 01/12] Initial attempt at new classes Summary statistics in Summa

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-15 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Could you please explain to me why we use different rules in symbol > > lookups? Namely: > > > > * > > [ClangExpressionDeclMap::GetSymbolAddress](https://github.com/llvm/llvm-project/pull/102835/files#diff-5d2da8306a4f4991885836925979f188658789adc8041c37811c243f2cdca24c)

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Michael Buch via lldb-commits
@@ -174,6 +177,86 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Michael Buch via lldb-commits
@@ -174,6 +177,86 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Michael Buch via lldb-commits
@@ -174,6 +176,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] 47721d4 - [lldb] Realpath symlinks for breakpoints (#102223)

2024-08-15 Thread via lldb-commits
Author: royitaqi Date: 2024-08-15T11:26:24-07:00 New Revision: 47721d46187f89c12a13d07b5857496301cf5d6e URL: https://github.com/llvm/llvm-project/commit/47721d46187f89c12a13d07b5857496301cf5d6e DIFF: https://github.com/llvm/llvm-project/commit/47721d46187f89c12a13d07b5857496301cf5d6e.diff LOG:

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-15 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/104109 >From 8f2f84294ea3875c88ce36a4980fd3a3afce01de Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Tue, 18 Jun 2024 10:38:09 -0700 Subject: [PATCH 1/6] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrS

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/1591 Here is the relevant piece of t

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-15 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From b21f63e4376dd9c390abea72a1ebd5594652e681 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH] [lldb][test] Improve toolchain detection in Makefile.r

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-15 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From 5130b2af8c2a274d73a9d90a4a71d77d85ac0973 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH] [lldb][test] Improve toolchain detection in Makefile.r

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-15 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-15 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Umm... could we move this logic to python, and then just pass the final tool > paths (or whatever) into the makefile, like we did with the other patches > (for `(HOST_)OS`, etc.) ? Moved logic to Python, updated commit description. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I'm looking at this build break with `PATH_MAX`. Trying to figure out what to use instead. If anyone knows what to use, please LMK. https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/104493 Fix build break for Windows, caused by a [previous patch](https://github.com/llvm/llvm-project/pull/102223) using `PATH_MAX` which is undefined in Windows. The fix is to `#include "lldb/Host/PosixApi.h"` in t

[Lldb-commits] [lldb] Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes Fix build break for Windows, caused by a [previous patch](https://github.com/llvm/llvm-project/pull/102223) using `PATH_MAX` which is undefined in Windows. The fix is to `#include "lldb/Host/PosixApi.h"` in the sou

[Lldb-commits] [lldb] (lldb) Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I don't have a Windows machine to test this build on. So I'm merging this blindfolded, in the hope of fixing the build break so that less folks who are working on Windows will get affected by the break. https://github.com/llvm/llvm-project/pull/104493 __

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I'm waiting for the "buildkite/github-pull-requests" job to finish (so that this "fix" won't break more things). LMK if I don't need to wait for it. https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] f377edb - (lldb) Fix PATH_MAX for Windows (#104493)

2024-08-15 Thread via lldb-commits
Author: royitaqi Date: 2024-08-15T13:14:26-07:00 New Revision: f377edb96abe9fd6fa458415f07b0f411e59cf24 URL: https://github.com/llvm/llvm-project/commit/f377edb96abe9fd6fa458415f07b0f411e59cf24 DIFF: https://github.com/llvm/llvm-project/commit/f377edb96abe9fd6fa458415f07b0f411e59cf24.diff LOG:

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply #100443 SBSaveCore Thread list (PR #104497)

2024-08-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/104497 Reapply #100443 and #101770. These were originally reverted due to a test failure and an MSAN failure. I changed the test attribute to restrict to x86 (following the other existing tests). I could not reproduce

  1   2   >